Thanks for looking into this. I agree per case (c) that I should add my
S-o-b. I will plan to add both mine and Sean's S-o-b in v2 of the series.
Thanks,
Michael
On 4/9/2020 6:18 AM, Laszlo Ersek wrote:
On 04/09/20 11:23, Leif Lindholm wrote:
On Thu, Apr 09, 2020 at 11:17:31 +0200, Laszlo
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
duplicated across several drivers. These macros have proven useful and
established a commonly used pattern for linked list iteration.
This change
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
duplicated across several drivers such as:
* EhciPei
* EhciDxe
* HddPasswordDxe
* RamDiskDxe
* UfsPassThruDxe
* XhciDxe
These macros have proven
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in Ehci.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed-off
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1562
The current SnpDxe implementation registers its ExitBootServices event
notification function (SnpNotifyExitBootServices ()) at TPL_NOTIFY. This
function calls PxeShutdown() which issues an UNDI shutdown operation
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in UfsPassThru.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in RamDiskImpl.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in
HddPasswordDxe.h with the common definition in BaseLib.h.
Cc: Chao Zhang
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Sean Brogan
Signed-off
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in EhcPeim.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed-off
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
Update pytools configuration to enable EmulatorPkg, ArmVirtPkg,
and OvmfPkg.
Update documentation for the status of those packages.
Remove future work items that are now complete.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc:
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
Add new Azure Pipeline definitions to build and run EmulatorPkg with:
* Ubuntu GCC5
* Windows VS2019
Add PyTool based build of EmulatorPkg
Add EmulatorPkg.ci.yaml for Core CI
Add README-pytools for details and
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
Add new Azure Pipeline definitions to build and run OvmfPkg with:
* Ubuntu GCC5
* Windows VS2019
Add PyTool based build of OvmfPkg
Add extdep for managing the iasl dependency
Add OvmfPkg.ci.yaml for Core CI
Add
From: Michael Kubacki
The following 6 patches adds support for "Platform CI" for ArmVirtPkg,
OvmfPkg, and EmulatorPkg.
Each readme has live status and links to the builds as well as details
of how to build and run the same way the CI server will.
ArmVirtPkg:
https://github.com/spb
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
Add ArmVirtPkg to Core CI matrix
Add EmulatorPkg to Core CI matrix
Add OvmfPkg to Core CI matrix
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Sean Brogan
---
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
Add new Azure Pipeline definitions to build and run ArmVirtPkg with:
* Ubuntu GCC5
Add PyTool based build of ArmVirtPkg
Add extdep for managing the iasl dependency
Add ArmVirtPkg.ci.yaml for Core CI
Add README-pytools
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
Add template for Platform CI steps for a Pytools based build.
Add README to describe the template and how to use it.
Add helpful information for working with azurepipelines, templates, and
lessons learned.
Cc: Sean
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2593
Increases the maximum number of failures in the SpellCheck plugin so
that more issues can be caught in a single pass.
Cc: Bob Feng
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off
[mailto:michael.kuba...@outlook.com]
Sent: Friday, April 10, 2020 4:05 AM
To: devel@edk2.groups.io
Cc: Zhang, Chao B; Bi, Dandan; Wu, Hao A; Wang, Jian J; Gao, Liming; Kinney,
Michael D; Ni, Ray; Sean Brogan
Subject: [PATCH v1 0/7] Add linked list iteration macros to BaseLib.h
From: Michael Kubacki
REF:https
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1969
ReportDispatcher() may be invoked with a NULL Data argument. When TPL is
less than TPL_HIGH_LEVEL and Data is NULL, the EFI_STATUS_CODE_DATA
structure inside RscData should be cleared so listeners will not receive
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2669
Updates ReportDispatcher() to take the size in the HeaderSize field in
a EFI_STATUS_CODE_DATA element into account when walking the data buffer.
This size will cause the header size to differ from the compiled sizeof
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2670
The RSC router data buffer may be reallocated when the buffer is nearing
exhaustion (7/8 portion of the buffer used).
While several pointers are updated to point to the newly allocated buffer,
the RscData
Reviewed-by: Michael Kubacki
On 4/6/2020 11:47 PM, Zhang, Shenglei wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2617
Update edk2 build and test ci to use Python 3.8.x
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1563
SnpDxe initializes values for MemoryBarIndex and IoBarIndex to 0 and 1
respectively even if calls to PciIo->GetBarAttributes never return
success.
Later, if the BAR is used to perform IO/Mem reads/wri
Reviewed-by: Michael Kubacki
On 4/6/2020 11:47 PM, Zhang, Shenglei wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2616
Pytool extensions are locked on 0.12.x but extensions has
moved to 0.13.x. So update the pip-requirements.txt.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2513
Remove Windows only scopes in the CISettngs file
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
---
.pytool/CISettings.py | 3 ---
1
-by: Michael Kubacki
---
BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
| 58 ++--
BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner_plug_in.yaml
| 4 +-
2 files changed, 31 insertions(+), 31 deletions(-)
diff --git
a/BaseTools/Plugin
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2513
The following 2 patches remove the Core CI limitation of running and
reporting results of host based unit tests only for Core CI on Windows.
Branch can be reviewed here:
https://github.com/spbrogan/edk2/commits
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2273
Ip6ConfigReadConfigData() reads configuration data from a UEFI variable
and copies the data to another buffer. This change checks that the length
of the data record being copied does not exceed the size of the source
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2416
The software SMI Command IO Port is currently used in SecurityPkg to
support the Physical Presence Interface. The IO port is hardcoded as 0xB2
in Tpm.asl.
This patch series adds a PCD to SecurityPkg with the default
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2416
Replaces the hardcoded value of 0xB2 with a PCD for the SMI port access
operation region. This allows platforms to customize the IO port value if
necessary.
Cc: Kun Qin
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Chao
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2416
Adds a PCD to SecurityPkg used to specify the SW SMI Command port. This
value may vary across platforms and is current hardcoded to 0xB2 in
package code.
Cc: Kun Qin
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Chao Zhang
, Liming
Subject: [PATCH v1 0/9] Add the VariablePolicy feature
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522
The 9 patches in this series add the VariablePolicy feature to the core,
deprecate Edk2VarLock (while adding a compatibility layer to reduce code
churn
for status, details, and instructions
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 103
ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 89
: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
---
.pytool/CISettings.py | 7 +--
.pytool/Plugin/SpellCheck/cspell.base.yaml | 14 ++
.pytool/Readme.md | 10 --
3 files changed, 23
From: Michael Kubacki
The following 6 patches adds support for "Platform CI" for ArmVirtPkg,
OvmfPkg, and EmulatorPkg.
Each readme has live status and links to the builds as well as details
of how to build and run the same way the CI server will.
ArmVirtPkg:
https://github.com/spb
-by: Michael Kubacki
---
.azurepipelines/templates/pr-gate-build-job.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
index 61868554d43c..a9f89aa68451 100644
--- a/.azurepipelines/templates/pr-gate
and instructions
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
---
EmulatorPkg/EmulatorPkg.ci.yaml | 85 ++
EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml| 95 +++
EmulatorPkg/PlatformCI
Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
---
.azurepipelines/ReadMe.md | 50
.azurepipelines/templates/ReadMe.md| 59 +
.azurepipelines/templates
README.rst for status, details and instructions
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
---
OvmfPkg/OvmfPkg.ci.yaml | 83 +++
OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml| 133
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2665
ReportDispatcher() is called by a software module to report a status code.
The interface is generic and can be called frequently throughout the boot
under various conditions. A certain set of conditions can cause
into the VariablePolicyLib business logic.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Bret Barkelew
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c | 51 +++
MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c| 445
From: Bret Barkelew
https://bugzilla.tianocore.org/show_bug.cgi?id=2522
These were previously using VarLock, which is
being deprecated.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Bret Barkelew
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Universal/Variable/RuntimeDxe
-by: Bret Barkelew
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Universal/Variable/RuntimeDxe/VarCheck.c | 49
+-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequstToLock.c | 71
MdeModulePkg/Universal/Variable/RuntimeDxe
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
V2 changes:
* Add explicit dependency to EhciPei on BaseLib
The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
duplicated across several drivers such as:
* EhciPei
* EhciDxe
* HddPasswordDxe
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in
HddPasswordDxe.h with the common definition in BaseLib.h.
Cc: Chao Zhang
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Sean Brogan
Signed-off
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in UfsPassThru.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
duplicated across several drivers. These macros have proven useful and
established a commonly used pattern for linked list iteration.
This change
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in RamDiskImpl.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in Xhci.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed-off
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in Ehci.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed-off
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
Replaces usage of the linked list iteration macros defined in EhcPeim.h
with the common definition in BaseLib.h.
Cc: Dandan Bi
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Ray Ni
Cc: Sean Brogan
Signed-off
and packed
VariablePolicy entry.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Bret Barkelew
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c | 396
MdeModulePkg/Include/Library
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522
The 9 patches in this series add the VariablePolicy feature to the core,
deprecate Edk2VarLock (while adding a compatibility layer to reduce code
churn), and integrate the VariablePolicy libraries and protocols
For the series:
Reviewed-by: Michael Kubacki
On 3/26/2020 12:49 AM, Wang, Jian J wrote:
v5: change VariableRootKey to VariableKey
v4: remove CounterId which should not be exposed
v3: update retval description in RpmcLib.h and RpmcLibNull.c
v2: change CounterIndex to CounterId
From: Michael Kubacki
This patch series updates the GetVariable() implementation
to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned.
* [PATCH v3 1/3] Makes the functional change in the DXE/MM variable driver.
* [PATCH v3 2/3] Makes the functional change in the PEI variable driver
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
The UEFI specification v2.8 Errata A Section 8.2 "GetVariable()"
"Attributes" parameter description states:
"If not NULL, a pointer to the memory location to return the
attributes bitm
From: Michael Kubacki
This reverts commit 6896efdec2709e530b23c688cf0f31706709a0c5.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
GetVariable() now returns attributes when it fails with
EFI_BUFFER_TOO_SMALL. Therefore, commit 6896efdec270 is
reverted since it is no longer relevant
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
This commit makes the behavior for PeiGetVariable() match the following
specification-defined behavior. It is now consistent with the DXE/SMM
variable driver implementation.
The UEFI specification v2.8 Errata
, Michael D
; Wang, Jian J ;
Wu, Hao A
Subject: [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable()
attr if EFI_BUFFER_TOO_SMALL
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
The UEFI specification v2.8 Errata A Section 8.2 "GetVariable()"
&
20200327215536.9556-1-michael.kuba...@outlook.com>
References: <20200327215536.9556-1-michael.kuba...@outlook.com>
Please let me know if you have suggestions. I'll look into it more.
Thanks,
Michael
On 3/31/2020 4:55 PM, Laszlo Ersek wrote:
Hi Michael,
On 03/27/20 22:55, Michael Kubacki
confusion. I
suggest
to make similar change to PEI variable driver.
Regards,
Jian
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael
Kubacki
Sent: Wednesday, March 25, 2020 11:00 AM
To: devel@edk2.groups.io
Cc: Bret Barkelew ; Gao, Liming
; Kinney, Michael D ;
Wang, Jian J
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2640
Azure Pipelines agents have 2 threads. This commit has been shown to
reduce the build time in half on those agents.
Cc: Bob C Feng
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
BaseTools/Edk2ToolsBuild.py | 16
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
The UEFI specification v2.8 Errata A Section 8.2 "GetVariable()"
"Attributes" parameter description states:
"If not NULL, a pointer to the memory location to return the
attributes bitm
From: Michael Kubacki
This reverts commit 6896efdec2709e530b23c688cf0f31706709a0c5.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
GetVariable() now returns attributes when it fails with
EFI_BUFFER_TOO_SMALL. Therefore, commit 6896efdec270 is
reverted since it is no longer relevant
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
This is a two-part patch series to update the GetVariable() implementation
to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned.
* [PATCH v2 1/2] Makes the actual functional change in the variable
Hi Laszlo,
I sent a v2 patch series with that commit reverted as patch 2/2.
Thanks,
Michael
On 3/24/2020 6:57 PM, Laszlo Ersek wrote:
Hello Michael,
On 03/24/20 23:04, Michael Kubacki wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
The UEFI
Given no remaining opens and the approvals given, I went ahead and
merged the series through patch #6.
Thanks,
Michael
On 4/28/2020 5:59 AM, Laszlo Ersek wrote:
On 04/24/20 23:31, michael.kuba...@outlook.com wrote:
From: Michael Kubacki
Attention: Reviewed-by is still needed from some
Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
The contributor attests the compliance of the submission with
https://developercertificate.org/ at the point of contribution by
using Signed-off-by.
Statements by others (including original
, michael.kuba...@outlook.com wrote:
From: Michael Kubacki
Attention: Reviewed-by is still needed from some package maintainers.
* 0002-ArmVirtPkg-Add-Platform-CI-and-configuration-for-Cor.patch
* Laszlo Ersek
* Ard Biesheuvel
* Leif Lindholm
* 0003-EmulatorPkg-Add-Platform-CI-and-configuration
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2612
Removes the FrameworkHandle parameter from SaveFrameworkState() in the
UnitTestLib library instance and updates callers of the function in the
library to use the new function signature.
Cc: Bret Barkelew
Cc: Sean
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2612
Simplifies the SaveFrameworkState() interface by removing the
FrameworkHandle parameter. The expectation is that this API is called
from within a test suite prior to test case completion such as a reboot.
The active
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2612
The framework handle can be retrieved from GetActiveFrameworkHandle()
internal to SaveFrameworkState() so this change removes the parameter
from the function signature.
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Michael
Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
Reviewed-by: Shenglei Zhang
Reviewed-by: Bret Barkelew
---
.azurepipelines/ReadMe.md | 50
.azurepipelines/templates/ReadMe.md
ReadMe.md for details and instructions
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
Acked-by: Laszlo Ersek
Acked-by: Ard Biesheuvel
Reviewed-by: Shenglei Zhang
Reviewed-by: Bret Barkelew
---
OvmfPkg/OvmfPkg.ci.yaml
: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
Reviewed-by: Shenglei Zhang
Reviewed-by: Bret Barkelew
---
.pytool/CISettings.py | 7 +--
.pytool/Plugin/SpellCheck/cspell.base.yaml | 14 ++
.pytool/Readme.md
: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
Reviewed-by: Laszlo Ersek
Reviewed-by: Bret Barkelew
---
ReadMe.rst | 354
Readme.md | 235 -
2 files changed, 354 insertions(+), 235 deletions
-by: Michael Kubacki
Reviewed-by: Shenglei Zhang
Reviewed-by: Bret Barkelew
---
.azurepipelines/templates/pr-gate-build-job.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
index 61868554d43c
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
Reviewed-by: Shenglei Zhang
Reviewed-by: Bret Barkelew
---
EmulatorPkg/EmulatorPkg.ci.yaml | 85 ++
EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
From: Michael Kubacki
Attention: Reviewed-by is still needed from some package maintainers.
* 0002-ArmVirtPkg-Add-Platform-CI-and-configuration-for-Cor.patch
* Laszlo Ersek
* Ard Biesheuvel
* Leif Lindholm
* 0003-EmulatorPkg-Add-Platform-CI-and-configuration-for-Co.patch
* Jordan
for details and instructions
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Sean Brogan
Signed-off-by: Michael Kubacki
Reviewed-by: Shenglei Zhang
Acked-by: Laszlo Ersek
Acked-by: Ard Biesheuvel
Reviewed-by: Bret Barkelew
---
ArmVirtPkg/ArmVirtPkg.ci.yaml
Reviewed-by: Michael Kubacki
On 4/21/2020 1:40 PM, Nate DeSimone wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events
What was done
Reviewed-by: Michael Kubacki
On 4/21/2020 1:40 PM, Nate DeSimone wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events
What was done
Reviewed-by: Michael Kubacki
On 4/23/2020 1:42 AM, Heng Luo wrote:
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688
Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of
AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc
Cc: Michael Kubacki
Cc
I think the series cover letter should have been filled out but this
seems reasonable to me for removal of the temporary workaround.
Reviewed-by: Michael Kubacki
On 4/23/2020 1:42 AM, Heng Luo wrote:
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688
Remove Features/Intel
Thanks,
Maciej
On 09-Apr-20 20:16, michael.kuba...@outlook.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1562
The current SnpDxe implementation registers its ExitBootServices event
notification function (SnpNotifyExitBootServices ()) at TPL_NOTIFY. This
function c
I saw Bret gave an R-b to the v2 series since it was sent. In addition
to the R-bs already captured from v1, is there anything else needed for
the series to be pushed?
Thanks,
Michael
On 4/10/2020 1:02 PM, michael.kuba...@outlook.com wrote:
From: Michael Kubacki
REF:https
cases for the lib.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Library/VariablePolicyLib/VariablePolicyExtraInitNull.c
| 46 +
MdeModulePkg/Library/VariablePolicyLib/VariablePolicyExtraInitRuntimeDxe.c
| 85
-by: Michael Kubacki
---
MdeModulePkg/Universal/Variable/RuntimeDxe/VarCheck.c | 49
+-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableLockRequstToLock.c | 71
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf | 1
From: Bret Barkelew
https://bugzilla.tianocore.org/show_bug.cgi?id=2522
These were previously using VarLock, which is
being deprecated.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockDxe.c | 52
-off-by: Michael Kubacki
---
MdeModulePkg/Include/Protocol/VariablePolicy.h | 157
MdeModulePkg/MdeModulePkg.dec | 14 +-
2 files changed, 170 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Include/Protocol/VariablePolicy.h
b/MdeModulePkg/Include
with PcdAllowVariablePolicyEnforcementDisable set to
TRUE.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Test/ShellTest/VariablePolicyFuncTestApp/VariablePolicyFuncTestApp.c
| 1942
MdeModulePkg/MdeModulePkg.ci.yaml
and packed
VariablePolicy entry.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c | 396
MdeModulePkg/Include/Library/VariablePolicyHelperLib.h | 164
into the VariablePolicyLib business logic.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c | 53 ++
MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c| 653
MdeModulePkg
From: Bret Barkelew
https://bugzilla.tianocore.org/show_bug.cgi?id=2522
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Michael Kubacki
---
OvmfPkg/OvmfPkgIa32.dsc| 8
OvmfPkg/OvmfPkgIa32X64.dsc | 8
OvmfPkg/OvmfPkgX64.dsc | 8
3
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522
The 12 patches in this series add the VariablePolicy feature to the core,
deprecate Edk2VarLock (while adding a compatibility layer to reduce code
churn), and integrate the VariablePolicy libraries and protocols
From: Bret Barkelew
https://bugzilla.tianocore.org/show_bug.cgi?id=2522
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael Kubacki
---
EmulatorPkg/EmulatorPkg.dsc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg
for messages from the DXE protocol.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c | 318
MdeModulePkg/Include/Guid/VarCheckPolicyMmi.h| 54
MdeModulePkg/Library
, not modification.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockSmm.c | 10
++
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf | 2 ++
2 files changed, 12 insertions(+)
diff
Cc: Chao Zhang
Signed-off-by: Michael Kubacki
---
SecurityPkg/Library/AuthVariableLib/AuthService.c | 22
SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf | 2 ++
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/Library
, Michael Kubacki wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522
The 12 patches in this series add the VariablePolicy feature to the
core, deprecate Edk2VarLock (while adding a compatibility layer to
reduce code churn), and integrate the VariablePolicy libraries
1 - 100 of 1410 matches
Mail list logo
