Re: [edk2-devel] [PATCH] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent

2023-09-08 Thread levi.yun
> Signed-off-by: Tuan Phan > --- > .../Drivers/StandaloneMmCpu/EventHandle.c | 25 +++ > .../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42 +- > .../StandaloneMmCpu/StandaloneMmCpu.inf | 9 ++-- > .../Library/Arm/StandaloneMmCoreEntryPoint.h | 17 ++-- >

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix assert in CmObject parser

2023-11-01 Thread levi.yun
Reviewed-by: levi.yun (yeoreum@arm.com) From: Sami Mujawar Sent: 01 November 2023 10:28 To: devel@edk2.groups.io Cc: Sami Mujawar; Pierre Gondois; Yeo Reum Yun; quic_llind...@quicinc.com; Akanksha Jain; Sibel Allinson; nd Subject: [PATCH v1 1/1

Re: [edk2-devel] [PATCH v2 2/2] StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver

2023-09-27 Thread levi.yun
Look good to me. Thanks! Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Tuan Phan via groups.io Sent: 15 September 2023 00:10 To: devel@edk2.groups.io Cc: ardb+tianoc...@kernel.org; Sami Mujawar; ray...@intel.com; huangm

Re: [edk2-devel] [PATCH v2 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent

2023-09-27 Thread levi.yun
Look good to me. Thanks! Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Tuan Phan via groups.io Sent: 15 September 2023 00:10 To: devel@edk2.groups.io Cc: ardb+tianoc...@kernel.org; Sami Mujawar; ray...@intel.com; huangm

[edk2-devel] [PATCH] Basetools: Include PCD declarations from Library Instance

2023-10-12 Thread levi.yun
an be seen on https://github.com/LeviYeoReum/edk2/tree/levi/2848_dec_check_on_library Signed-off-by: levi.yun --- BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py b/BaseTo

[edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

2023-07-12 Thread levi.yun
: 0 Virtual timer GSIV : 0x1B Virtual timer FLAGS: 0x2 Signed-off-by: levi.yun --- The changes can be seen at https://github.com/LeviYeoReum/edk2/compare/master...LeviYeoReum:edk2:refs.geads/2711_gtdt_flags_v1 ShellPkg/Library/UefiShellAcpiViewComm

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/BaseCryptoLib: Remove unnecessary key generation.

2023-07-18 Thread levi.yun
Hi Li! On 18/07/2023 07:03, Li, Yi1 wrote: Hi, This function has a special use case: when the input PublicKey array is NULL and size is 0, the function will generate EC keypair and update context, and fill PublicKeySize with non-zero keysize to indicate success. (CryptEc.c L492) if

[edk2-devel] [PATCH v2 1/1] CryptoPkg/BaseCryptoLib: Remove unnecessary key generation.

2023-07-18 Thread levi.yun
check before generating the key. Therefore, optimise to avoid unnecessary key generation. Signed-off-by: levi.yun --- Notes: v2: - Fix missing spceial case when (PublicKey == NULL && PublicKeySize == 0) This changes can be seen at https://github.com/LeviYeoReum/e

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

2023-07-14 Thread levi.yun
+/** >> >> + This function prints Polarity information in timer flags. > polarity (lowercase) Thanks. Many Thanks..! From: Pedro Falcato Sent: 13 July 2023 15:24 To: devel@edk2.groups.io; Yeo Reum Yun Cc: zhichao@intel.com; Sami Mu

[edk2-devel] [PATCH v2 1/1] ShellPkg: Acpiview/GTDT: Print timer flags information.

2023-07-17 Thread levi.yun
: 0 Virtual timer GSIV : 0x1B Virtual timer FLAGS: 0x2 Signed-off-by: levi.yun Tested-by: Pierre Gondois --- The changes can be seen at https://github.com/LeviYeoReum/edk2/tree/2711_gtdt_flags_v2 Notes: v2: - Fix typos. -

[edk2-devel] [PATCH v1 1/1] CryptoPkg/BaseCryptoLib: Remove unnecessary key generation.

2023-07-17 Thread levi.yun
check before generating the key. Therefore, optimise to avoid unnecessary key generation. Signed-off-by: levi.yun --- This changes can be seen at https://github.com/LeviYeoReum/edk2/tree/levi/2716_not_generate_key_on_fail_size_v1 CryptoPkg/Library/BaseCryptLib/Pk/CryptEc.c | 10 +- 1 file

[edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: SgiPkg: Add serial debug port mapping.

2024-01-19 Thread levi.yun
tables to add the address range covering the serial debug port. Signed-off-by: levi.yun --- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 1 + Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH RESEND edk2-platforms v1 2/3] Platform/Arm: Enable UEFI Secure Variable support for FVP

2024-01-19 Thread levi.yun
tion of the StandaloneMm memory map from normal world, so we have no real need for MmUnblockMemoryLib. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 49 +++- Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 9 2 files changed, 57 insertions(+

[edk2-devel] [PATCH RESEND edk2-platforms v1 3/3] Platform/Arm: Add Standalone MM support for FVP

2024-01-19 Thread levi.yun
Add Standalone MM support for FVP model. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 208 Platform/ARM/VExpressPkg/PlatformStandaloneMm.fdf | 106 ++ 2 files changed, 314 insertions(+) diff --git a/Platform/ARM/VExpressPkg

[edk2-devel] [PATCH RESEND edk2-platforms v1 1/3] Platform/Arm: FVP: Add a NorFlashLib instance for StandaloneMm

2024-01-19 Thread levi.yun
from the Normal world NorFlashLib instance when Standalone MM is enabled using the ENABLE_STMM build flag. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c | 34 ++-- Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib

[edk2-devel] [PATCH RESEND edk2-platforms v1 0/3] Platform/Arm: StandloneMm support for FVP.

2024-01-19 Thread levi.yun
This patch adds StandloneMm feature on FVP RevC & AEMvA. StandaloneMm will be used for UEFI secure Variable support on these models. levi.yun (3): Platform/Arm: FVP: Add a NorFlashLib instance for StandaloneMm Platform/Arm: Enable UEFI Secure Variable support for FVP Platform/Arm:

Re: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp

2023-12-12 Thread levi.yun
Hi Sahil! On 16/11/2023 11:45, sahil via groups.io wrote: Add NOR flash DXE driver, this brings up NV storage on QSPI's flash device using FVB protocol. Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dec |5 +-

[edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-05 Thread levi.yun
port early on in the entry point. Signed-off-by: levi.yun --- These changes can be seen at https://github.com/LeviYeoReum/edk2/tree/levi/2956_init_serial too. StandaloneMmPkg/StandaloneMmPkg.dsc | 1 + StandaloneMmPkg/Library

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-05 Thread levi.yun
+ ardb+tianoc...@kernel.org From: levi.yun Sent: 05 January 2024 11:49 To: devel@edk2.groups.io Cc: Yeo Reum Yun; ard.biesheu...@linaro.org; Sami Mujawar; ray...@intel.com; Pierre Gondois; nd Subject: [PATCH v1 1/1] StandaloneMmPkg: Initialise serial

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-05 Thread levi.yun
Hi Ard :) So now we will always initialize the serial port in the entrypoint only because DebugLib might use it later with doing the initialization. That doesn't sound quite correct to me. Could you explain why we cannot rely on DebugLib to call the initializer / constructor at the right

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-10 Thread levi.yun
My personal conclusion in that thread was [1], and correspondingly, commit 5087a0773645 ("ArmVirtPkg/FdtPL011SerialPortLib: initialize implicitly", 2023-10-07). In the end, the only tractable solution was to initialize the serial port (hardware, and library instance) exactly once, in (a) the

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-10 Thread levi.yun
Hi, Laszlo. This will keep initing the serial port upon every API call until the global variable becomes writeable, and then the next API call will init the serial port for one last time, and also prevent further page table checks. The CheckWritable() function is an implementation detail. In

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-11 Thread levi.yun
Hi Brian. > Ard didn't want a SerialPortInitialize() call directly in the > all-platform StandaloneMmCore _ModuleEntryPoint() function, which is > understandable. So perhaps you could either: Thanks to corret me :) > 1. Propose a platform-specific callout at that point and a library class >

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-18 Thread levi.yun
Hi, Ard Could I process with this way? Many thanks! On 11/01/2024 09:05, levi.yun via groups.io wrote: Hi Brian. Ard didn't want a SerialPortInitialize() call directly in the all-platform StandaloneMmCore _ModuleEntryPoint() function, which is understandable. So perhaps you could

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds

2024-01-08 Thread levi.yun
Hi. Parabin On 05/01/2024 15:38, Prabin CA via groups.io wrote: Add the no-stack-protector compiler flag to allow StandaloneMM builds on both AArch64 and x86 host. Without this flag, the link stage fails with the following errors on multiple files when built with gcc (Ubuntu

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use

Re: [edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/Sgi: Define RD-V2 platform id values

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu Signed-off

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/7] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/7] Platform/Sgi: Add a PCD to specify platform variant

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Platform/Sgi: remove +nofp gcc option flag

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating

Re: [edk2-devel] [edk2-platforms][PATCH v2 7/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-01-08 Thread levi.yun
Reviewed-by: levi.yun On 05/01/2024 15:38, Prabin CA via groups.io wrote: From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform

[edk2-devel] [PATCH edk2-platforms v2 1/1] Platform/ARM: Fix the build failure DxeCore

2023-11-30 Thread levi.yun
The edk2 commit 7284c44951cffd52f1a08367d91b5c63c7bb9c16 introduces a new library ImagePropertiesRecordLib to consolidate the logic for manipulating the image properties used to track runtime images and to remove duplicate code. This library is further linked with DxeCore. Therefore, add an

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread levi.yun
Except, 8bit transfer encoding. Tested-by: levi.yun Reviewed-by: levi.yun On 19/01/2024 10:39, Ard Biesheuvel via groups.io wrote: On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io wrote: From: Laszlo Ersek The current dependency evaluator violates the memory access permission when

[edk2-devel] [PATCH 1/1] BaseTool/Ecc: Fix incorrect parsing of variable initialisation

2024-04-15 Thread levi.yun
n as below: "ERROR - *The variable name [0)] does not follow the rules" This patch fixes the parsing logic so that scenarios with macro initialisations are handled correctly. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Sami Mujawar Cc: Pierre Gondois Sig

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 08/14] Platform/ARM: Add HostRegisterBaseAddress variable

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 07/14] Platform/ARM/NorFlashDxe: Switch from NorFlash.c to NorFlashDeviceLib

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 05/14] Platform/ARM: Create NorFlashDeviceLib library interface for flash specific functions

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 10/14] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 11/14] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 06/14] Platform/ARM: Add P30NorFlashDeviceLib Library

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 03/14] Platform/ARM/NorFlashDxe: Add NorFlashCommon.h header file

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 04/14] Platform/ARM/NorFlashDxe: Move flash specific functions to NorFlash.c

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 01/14] Platform/ARM/NorFlashDxe: Move DiskIo related functions out of NorFlash.c

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 13/14] Platform/ARM/N1Sdp: Persistent storage for N1Sdp

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 12/14] Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFlashDxe

2024-04-24 Thread levi.yun
> +EFI_STATUS > +NorFlashWriteSingleBlock ( > + INNOR_FLASH_INSTANCE *Instance, > + INEFI_LBA Lba, > + INUINTN Offset, > + IN OUTUINTN *NumBytes, > + INUINT8 *Buffer > + ) > +{ > + EFI_STATUS

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 09/14] Platform/ARM: Add optional provision to fetch and print NOR Flash info

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 14/14] Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp

2024-04-24 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Sahil Kaushal via groups.io Sent: 23 April 2024 06:56 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm ; Sami Mujawar; Sahil Kaushal Subject: [edk2-devel] [PATCH RESEND edk2

[edk2-devel] [PATCH v1 3/4] MdePkg/Include/IndustryStandard: Update EINJ information according to ACPI 6.5

2024-05-10 Thread levi.yun
Cc: Liming Gao Cc: Zhichao Gao Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: levi.yun --- MdePkg/Include/IndustryStandard/Acpi65.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h b/MdePkg/Include/IndustryStandard/Acpi65

[edk2-devel] [PATCH v1 4/4] ShellPkg/Acpiview: Add EINJ Parser

2024-05-10 Thread levi.yun
Gondois Signed-off-by: levi.yun --- ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 1 + ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h| 21 ++ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Einj/EinjParser.c | 358

[edk2-devel] [PATCH v1 2/4] MdePkg/Include/IndustryStandard: Update GET_EXECUTE_OPERATION_TIMINGS Error Injection Actions

2024-05-10 Thread levi.yun
GET_EXECUTE_OPERATION_TIMINGS Error Injection Actions was added from ACPI 6.1 specification. Update Error Injection Action with the ACPI spec. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Liming Gao Cc: Zhichao Gao Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: levi.yun --- MdePkg/Include

[edk2-devel] [PATCH v1 0/4] Add EINJ table parser.

2024-05-10 Thread levi.yun
Add Error Injection Table (EINJ) parser for AcpiView and add some missing Error Injection Action definitions in each Acpi* headers. The changes can be seen at: https://github.com/LeviYeoReum/edk2/tree/levi/3075_einj_table_v1 levi.yun (4): MdePkg/Include/IndustryStandard: Update

[edk2-devel] [PATCH v1 1/4] MdePkg/Include/IndustryStandard: Update SET_ERROR_TYPE_WITH_ADDRESS Error Injection Actions

2024-05-10 Thread levi.yun
SET_ERROR_TYPE_WITH_ADDRESS Error Injection Actions was added from ACPI 5.1 specification. Update Error Injection Action with the ACPI spec. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Liming Gao Cc: Zhichao Gao Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: levi.yun --- MdePkg/Include

Re: [edk2-devel] [edk2-platforms][PATCH v5 3/6] Platform/Sgi: Add a PCD to specify platform variant

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116508): https://edk2.groups.io/g/devel/message/116508 Mute This Topic: https://groups.io/mt/104668452/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https

Re: [edk2-devel] [edk2-platforms][PATCH v5 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116507): https://edk2.groups.io/g/devel/message/116507 Mute This Topic: https://groups.io/mt/104668449/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https

Re: [edk2-devel] [edk2-platforms][PATCH v5 1/6] Platform/Sgi: remove +nofp gcc option flag

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116506): https://edk2.groups.io/g/devel/message/116506 Mute This Topic: https://groups.io/mt/104668448/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/8] Platform/Sgi: Refactor system memory base and size definitions

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 2/8

Re: [edk2-devel] [edk2-platforms][PATCH v4 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 3/8

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 1/8

Re: [edk2-devel] [edk2-platforms][PATCH v4 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-03-08 Thread levi.yun
Hi. Prabin! > +[Sources] > + Dbg2.aslc > + Fadt.aslc > + Gtdt.aslc > + RdFremont/Dsdt.asl > + RdFremont/Madt.aslc > + RdFremont/Pptt.aslc > + Spcr.aslc > + SsdtEvents.asl > + SsdtRos.asl > + SsdtRosVirtioP9.asl > + With the RdN2Cfg3 and RdV2 too, When would you support PCIE & IORT in

Re: [edk2-devel] [edk2-platforms][PATCH v5 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:29 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 6/6

Re: [edk2-devel] [edk2-platforms][PATCH v4 5/8] Platform/Sgi: Add initial support for RD-Fremont platform

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 5/8

Re: [edk2-devel] [edk2-platforms][PATCH v4 6/8] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 6/8

Re: [edk2-devel] [edk2-platforms][PATCH v4 7/8] Platform/Sgi: Low Power Idle States for RD-Fremont

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 7/8

Re: [edk2-devel] [edk2-platforms][PATCH v5 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116509): https://edk2.groups.io/g/devel/message/116509 Mute This Topic: https://groups.io/mt/104668453/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https

Re: [edk2-devel] [edk2-platforms][PATCH v5 5/6] Platform/Sgi: Define RD-V2 platform id values

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116510): https://edk2.groups.io/g/devel/message/116510 Mute This Topic: https://groups.io/mt/104668455/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https

Re: [edk2-devel] [edk2-platforms][PATCH v4 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform

2024-03-08 Thread levi.yun
> + CPPC_PACKAGE_INIT (0x200293000, 0x200293004, 20, 160, 160, 85, 85, > 5) In the FFH spec [1], section 'B.2.2 Performance Controls', the 'Performance Ltd Register' is set to a certain memory location. The ACPI spec. describes the following fields in the CPPC object 'Performance

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-18 Thread levi.yun
licit-function-declaration") Otherwise, Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116837): https://edk2.groups.io/g/devel/message/116837 Mute This Topic: https://groups.io/mt/104997022/21656 Group Owner

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 2/3] Platform/Arm: Enable UEFI Secure Variable support for FVP

2024-03-15 Thread levi.yun
Platform/Arm: Enable UEFI Secure Variable support for FVP Hi Levi, On Fri, Jan 19, 2024 at 01:33 AM, levi.yun wrote: +!if $(ENABLE_UEFI_SECURE_VARIABLE) == TRUE + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf +!endif Considering that Arm implementation does not

[edk2-devel] [PATCH edk2-platform v2 0/3] StandloneMm support for FVP.

2024-03-15 Thread levi.yun
This patch adds StandloneMm feature on FVP RevC & AEMvA. StandaloneMm will be used for UEFI secure Variable support on these models. v1->v2: - Rebase to master - Use MmunblockLibNull when ENABLE_STMM == TRUE. levi.yun (3): Platform/Arm: FVP: Add a NorFlashLib instance for Stand

[edk2-devel] [PATCH edk2-platform v2 2/3] Platform/Arm: Enable UEFI Secure Variable support for FVP

2024-03-15 Thread levi.yun
tion of the StandaloneMm memory map from normal world, so we have no real need for MmUnblockMemoryLib. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 49 +++- Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 9 2 files changed, 57 insertions(+

[edk2-devel] [PATCH edk2-platform v2 3/3] Platform/Arm: Add Standalone MM support for FVP

2024-03-15 Thread levi.yun
Add Standalone MM support for FVP model. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 208 Platform/ARM/VExpressPkg/PlatformStandaloneMm.fdf | 106 ++ 2 files changed, 314 insertions(+) diff --git a/Platform/ARM/VExpressPkg

[edk2-devel] [PATCH edk2-platform v2 1/3] Platform/Arm: FVP: Add a NorFlashLib instance for StandaloneMm

2024-03-15 Thread levi.yun
for that has the NOR Flash1 definitions for Standalone MM. Also, disable the NOR Flash1 definitions from the Normal world NorFlashLib instance when Standalone MM is enabled using the ENABLE_STMM build flag. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 0/3] Platform/Arm: StandloneMm support for FVP.

2024-03-15 Thread levi.yun
Hi. Sami! > I am not able to apply these patches. Can you share a branch with your > patches, please? Okay, I'll send with v2 with rebase to recent master. Thanks! From: Sami Mujawar via Groups.Io Sent: 15 March 2024 10:10 To: Yeo Reum Yun;

Re: [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 3/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 1/9] Platform/Sgi: Correct typo in defining CPPC performance limited register

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 1/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 2/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 8/9] Platform/Sgi: Low Power Idle States for RD-Fremont

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 8/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 9/9] Platform/Sgi: Add CPPC support for RD-Fremont platform

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 9/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 7/9] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 7/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 6/9] Platform/Sgi: Add initial support for RD-Fremont platform

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 6/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 5/9] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 5/9

Re: [edk2-devel] [edk2-platforms][PATCH v5 4/9] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-03-11 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 11 March 2024 13:14 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 4/9

[edk2-devel] [Question] using Flexible Array Member in Structure.

2024-04-03 Thread levi.yun
Hello all! while I see the code. I have one question related using Flexible Array Member. For example) /// /// Socket Type Data. /// typedef struct {   EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE CommonMemoryDeviceHeader;   UINT16 SocketIdentifier;   UINT16 Reserved;   //

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/5] Platform/Sgi: Use PCD value for L2 cache size in PPTT table

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 2/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 4/5] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 4/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/5] Platform/Sgi: Add a new PCD for L2 cache size

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 5/5] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 5/5

Re: [edk2-devel] [edk2-platforms][PATCH v1 3/5] Platform/Sgi: Define RD-V2 platform id values

2024-04-04 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 03 April 2024 18:33 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/5

Re: [edk2-devel] [Question] using Flexible Array Member in Structure.

2024-04-05 Thread levi.yun
ray members were supported by all the compilers. Converting these to a flexible array member would not be a backwards compatible change. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of > levi.yun > Sent: Wednesday, April 3, 2024 2:27 AM > To: devel@edk2

Re: [edk2-devel] [PATCH v1 0/4] Add EINJ table parser.

2024-05-23 Thread levi.yun
Gentle ping for this patchset. ;) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119136): https://edk2.groups.io/g/devel/message/119136 Mute This Topic: https://groups.io/mt/106019470/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH v1 0/4] Add EINJ table parser.

2024-06-03 Thread levi.yun
Hi ShellPkg and Acpi Header maintainers. Would you confirm patcheset EINJ table parser please? Thanks. From: levi.yun Sent: 10 May 2024 13:22 To: devel@edk2.groups.io Cc: Yeo Reum Yun; Sami Mujawar; Pierre Gondois; zhiguang@intel.com; dandan