t;
> Thanks,
> Michael
>
> On 5/17/2024 7:20 PM, Michael Kubacki wrote:
> > To ensure CI is unblocked, I am going to add the push tag now.
> >
> > On 5/17/2024 6:31 PM, Michael Kubacki wrote:
> >> Thanks Mike. Are you okay with me completing
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Friday, May 17, 2024 2:09 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Joey Vagedes
> ; Liming Gao ; Kinney,
> Michael D ; Rebecca Cran ;
> Sean Brogan ; Chen
apple.com)
> >>> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> >>> Review from email to GitHub Pull Requests on 5-24-2024
> >>>
> >>> On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io
> >>>
: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
mailto:devel@edk2.groups.io>> 代表 gaoliming via groups.io
发送时间: 2024年5月7日 9:25
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>;
annou...@edk2.groups.io<mailto:annou...@edk2.groups.io>
抄送: 'Michael D Kinney'
mailto:mi
I agree it should catch edk2-stable202405
Mike
> -Original Message-
> From: gaoliming
> Sent: Thursday, May 9, 2024 12:24 AM
> To: devel@edk2.groups.io; Pakkirisamy, ShanmugavelX
>
> Cc: Liu, Zhiguang ; Bi, Dandan ;
> 'Leif Lindholm' ; 'Andrew Fish' ;
> Kinney, Michael D
> Subject:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, May 6, 2024 9:55 PM
> To: Zhang, Hongbin1 ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Ni, Ray
> ; Liming Gao ; Liu, Zhiguang
> ; Xie, Yuanhao
> Subject: RE
Hi Ard,
Thais is an attribute of Mergify. I do not see a way to change that
behavior.
I do not know if using the GitHub merge capability or other merge services
provides different behavior here or not.
This specific request is not related to the change to GitHub PRs
for code review. There is
That information is in GitHub in the PR conversation.
If you follow the link from the commit to the PR, the PR conversation shows
who set the 'push' label.
Mike
> -Original Message-
> From: r...@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Monday, May 6, 2024 3:01 AM
> To:
l D
> >
> > > > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew
> > Fish
> > > > (af...@apple.com)
> > > > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore
> > Code
> > > > Review from email to GitHub Pull Requests
> Sent: Thursday, May 2, 2024 10:51 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D
>
> > > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew
> Fish
> > > (af...@apple.com)
> > > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore
>
ocess changes needed?
>
> For example, could we start with CODEOWNERS manually synced to
> Maintainers.txt, Maintainers.txt dropped, and then add REVIEWERS in the
> future with additional actions to verify file coverage, etc.?
>
> Thanks,
> Michael
>
> On 5/2/2024 12:24
[edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
>
> On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io
> wrote:
> >
> > Hello,
> >
> > I would like to propose that TianoCore move all code review
zone).
>
> Thanks,
> Oliver
>
> On 5/1/2024 9:45 AM, Michael D Kinney wrote:
> > Please let me know if you have any topics for the TianoCore Community
> > Meeting this month.
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> >
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Wednesday, April 24, 2024 11:14 AM
> To: devel@edk2.groups.io; Jayaprakash, N ;
> Kinney, Michael D
> Cc: Rebecca Cran
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] e
> -Original Message-
> From: Leif Lindholm
> Sent: Thursday, May 2, 2024 3:57 AM
> To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael
> D ; r...@edk2.groups.io
> Cc: Andrew Fish (af...@apple.com)
> Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review
ew Fish (af...@apple.com)
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
>
> On 5/1/24 18:19, Dionna Glaze via groups.io wrote:
> > On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io
> >
anoCore Code Review from
> email to GitHub Pull Requests on 5-24-2024
>
> On 5/2/2024 6:34 AM, Leif Lindholm wrote:
> > On 2024-05-02 07:33, Marcin Juszkiewicz wrote:
> >> W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze:
> >>> I would like to propose
Hello,
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately after the next stable
tag which is currently scheduled for May 24, 2024.
Updates to the following Wiki
Please let me know if you have any topics for the TianoCore Community
Meeting this month.
Thanks,
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118467): https://edk2.groups.io/g/devel/message/118467
Mute This Topic:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Anthony
> PERARD via groups.io
> Sent: Monday, April 29, 2024 9:06 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Anthony PERARD
> Subject:
No objections.
For all patches related to adding libspdm submodule:
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Sunday, April 28, 2024 5:33 PM
> To: Hou, Wenxing ; devel@edk2.groups.io; Andrew
> Fish ; Leif Lindholm ;
>
Hi Jiewen,
Michael Kubacki has been working on a CI issue and a change is being merged now.
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, April 24, 2024 3:57 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> ; Sean Brogan
> Cc: Gerd Hoffmann ; Ard Biesheuvel ;
>
t; > For changes between the previous version (2.14.5) and 2.16.1 see:
> >
> > https://github.com/github/codeql-cli-
> binaries/compare/v2.14.5...v2.16.1
> >
> > Cc: Bob Feng
> > Cc: Joey Vagedes
> > Cc: Liming Gao
> > Cc: Michael D Kinney
&
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, April 23, 2024 7:40 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Marcin Juszkiewicz
>
> Subject: [PATCH edk2-non-osi 1/1] Maintain
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, April 24, 2024 10:37 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Joey Vagedes
> ; Liming Gao ; Kinney,
> Michael D ; Rebecca Cran
> ; Sean Br
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jayaprakash, N
> Sent: Friday, April 19, 2024 2:01 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function avai
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Friday, April 19, 2024 12:40 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Andrew Fish
> ; Leif Lindholm ; Attar,
> A
> bits
> its value will be set to 0. Because of this the higher 32 bits of the
> MSR
> are always set to 0. This has been fixed by this commit.
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
> Cc: Jayaprakash N
> Signed-off-by: Jayaprakash N
> ---
> .../Python/Pyt
read/write cpu specific msrs
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
> >
> > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> > APIs supported in edk2 module. These extension APIs makes it
> possible
> > to read /
t; The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> APIs supported in edk2 module. These extension APIs makes it possible
> to read / write MSRs from specific processors and fills an existing
> gap in this area.
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
64)vedx) << 32) | veax;
> Verified the function by making this change and could see that the
> wrmsr is working as expected.
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
> Cc: Jayaprakash N
> Signed-off-by: Jayaprakash N
> ---
> .../Python/Python-3.6.8/PyMod-3.6.8/Modul
POLUDOV, FELIX ; Liu, Liqi
> ; Kinney, Michael D
> Subject: RE: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe:
> Update UI according to UEFI spec
>
> Acked-by: Michael D Kinney
>
>
> > -Original Message-
> > From: devel@edk2.groups.io
Acked-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Clark-
> williams, Zachary
> Sent: Wednesday, April 10, 2024 9:03 AM
> To: Tan, Ming ; devel@edk2.groups.io
> Cc: Kasbekar, Saloni ; Bi, Dandan
> ; POLUDOV, FELIX ; Liu,
tps://trustedcomputinggroup.org/resource/pc-client-specific-
> platform-firmware-profile-specification/
>
> The POC branch:
> https://github.com/tianocore/edk2-staging/tree/DeviceSecurity
>
> And the PATCH set has passed the EDKII CI:
> https://github.com/tianocore/edk2/pull/550
]
Mike
> -Original Message-
> From: Oliver Smith-Denny
> Sent: Wednesday, April 3, 2024 3:02 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> ; Ard Biesheuvel
> Subject: Re: [edk2-devel] Call or topics for April TianoCore Community
> Meeting
>
> On 4/3/202
uld be PRs and lack of maintainer response, the proper
> process there, etc.
>
> Thanks,
> Oliver
>
> On 4/2/2024 5:12 PM, Michael D Kinney wrote:
> > Please let me know if you have any topics for the TianoCore
> Co
No topics received. Meeting canceled this month.
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, April 2, 2024 5:12 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject: Call or topics for April TianoCore Community Meeting
>
> Please let me know if you
Yes. Use of flexible array members is supported and encouraged.
There are challenges with existing structure definitions that declare
arrays of size [1] when a flexible array is really intended. Those
were defined before flexible array members were supported by all the
compilers. Converting
Please let me know if you have any topics for the TianoCore Community
Meeting this month.
Thanks,
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117339): https://edk2.groups.io/g/devel/message/117339
Mute This Topic:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, April 2, 2024 8:40 AM
> To: devel@edk2.groups.io
> Cc: Marcin Wojtas ; Narinder Dhillon
> ; Kinney, Michael D
> Subject: [PATCH edk2-platforms 1/1] Maintainers.tx
There are also utilities to partition and format.
https://www.intel.com/content/www/us/en/download/714351/uefi-shell-disk-utilities.html
Mike
From: devel@edk2.groups.io On Behalf Of Andrew Fish via
groups.io
Sent: Friday, March 29, 2024 3:11 PM
To: devel@edk2.groups.io;
Merged: https://github.com/tianocore/edk2/pull/5505
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Oliver
> Smith-Denny
> Sent: Friday, March 29, 2024 1:21 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Leif Lindholm
> ; Ard Biesheuvel ;
> Sami Mujawar ; Taylor Beebe
>
y, Michael D ;
> Ard Biesheuvel
> Cc: Liming Gao ; Ni, Ray ; Leif
> Lindholm ; Sami Mujawar ;
> Taylor Beebe
> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
> ImagePropertiesRecordLib Fixes
>
> Thanks Mike!
>
> Oliver
>
> On 3/29/2024 10:12 AM, Michael D K
Hi Ard,
I have reviewed the discussion on the V1 and V2 versions of the series.
For the V2 Series:
Acked-by: Michael D Kinney
I will add the Rb/Ab tags and get this merged.
Mike
> -Original Message-
> From: Ard Biesheuvel
> Sent: Friday, March 29, 2024 1:03 AM
> To
ing given the Pci vendor ID
> values.
>
> Signed-off-by: Simon Wang
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> ---
> MdePkg/Include/Library/PciVenNameLib.h| 27 +
> MdePkg/Library/PciVenNameLib/PciVenNameLib.c | 2394
> +
&
Merged: https://github.com/tianocore/edk2/pull/5463
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Qingyu
> Sent: Sunday, February 25, 2024 7:06 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData
> function description
>
wed-by. So for now, for the series:
> Acked-by: Leif Lindholm
>
> > [1] https://edk2.groups.io/g/devel/message/111566
> >
> > Cc: Ard Biesheuvel
> > Cc: Gerd Hoffmann
> > Cc: Jiewen Yao
> > Cc: Leif Lindholm
> > Cc: Liming Gao
> > Cc: Micha
This issue appears to be resolved
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Sunday, March 10, 2024 12:16 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject: [edk2-devel] EDK II CI issues installi
I am seeing some EDK II CI failures installing choco
dependencies on windows CI agents.
Here is an example:
https://github.com/tianocore/edk2/pull/5454
der to
> determine the size of the buffer needed".
>
> Modify the description of "EFI_INVALID_PARAMETER" return code as "The
> ImageInfoSize is not too small and Image is NULL." and add new
> descriptions for "EFI_INVALID_PARAMETER" return code.
>
and add new
> descriptions for "EFI_INVALID_PARAMETER" return code.
>
> REF: UEFI spec v2.10 23.1.2
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4660
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Yi Li
> Cc: GuoX Xu
>
b81-aea3-d574ed7b6a91
Please update patches to address all these failures and resend to mailing list.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Friday, March 8, 2024 1:12 PM
> To: Kasbekar, Saloni ; Santhosh Kuma
Acked-by: Michael D Kinney
> -Original Message-
> From: Kasbekar, Saloni
> Sent: Wednesday, February 7, 2024 2:58 PM
> To: Santhosh Kumar V ; devel@edk2.groups.io
> Cc: Sivaraman Nainar ; Raj V Akilan
> ; Kinney, Michael D ;
> Mathews, John ; Clark-williams, Zac
Meeting canceled this month.
No agenda topics received.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Tuesday, March 5, 2024 11:08 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject: [edk2-devel] Topic
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, March 6, 2024 1:10 PM
> To: edk2-devel-groups-io
> Cc: Andrew Fish ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, March 6, 2024 1:10 PM
> To: edk2-devel-groups-io
> Cc: Desimone, Nathaniel L ; Chaganty,
> Rangasai V
> Subject: Re: [edk2-devel] [e
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, March 6, 2024 1:06 PM
> To: edk2-devel-groups-io
> Cc: Andrew Fish ; Ard Biesheuvel
> ; Gerd Hoffmann ; Yao,
> Jiewen ; Leif Lindho
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, March 6, 2024 1:09 PM
> To: edk2-devel-groups-io
> Cc: Feng, Bob C ; Joey Vagedes
> ; Liming Gao ;
> Kinney, Michael D ; Rebecca Cran
> ; Sean Brogan ; Chen,
> Chri
Please let me know if you have any topics for the TianoCore Community Meeting
this month.
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116424): https://edk2.groups.io/g/devel/message/116424
Mute This Topic:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Friday, March 1, 2024 3:33 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Joey Vagedes
> ; Kinney, Michael D
>
> Subject: [PATCH v2 1/1] .github/workflows/co
I think one advantage of this new proposal is to prevent
an extra level of nesting and use of stack resources in
that extra level.
The nesting depth is then both predictable and minimized
for a given set of supported TPL levels.
Mike
> -Original Message-
> From: Michael Brown
> Sent:
> -Original Message-
> From: Paolo Bonzini
> Sent: Thursday, February 29, 2024 11:04 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Liming Gao
> ; Laszlo Ersek ; Michael
> Brown
> Subject: Re: [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack overflow issue
> due to nested
> -Original Message-
> From: Michael Brown
> Sent: Thursday, February 29, 2024 9:39 AM
> To: Kinney, Michael D ;
> devel@edk2.groups.io; Ni, Ray
> Cc: Liming Gao ; Laszlo Ersek
> ; Paolo Bonzini
> Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack
> overflow issue due
Hi Paolo,
The proposed change does not disable interrupts at TPL below TPL_HIGH_LEVEL
when processing event handlers.
It only prevents interrupts being enabled in the window from the last event
processed in a timer interrupt and the return from the timer interrupt handler.
This is a window
Hi Michael,
Can you provide a pointer to the UEFI Spec statement this breaks?
Thanks,
Mike
> -Original Message-
> From: Michael Brown
> Sent: Thursday, February 29, 2024 5:23 AM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Kinney, Michael D ; Liming Gao
> ; Laszlo Ersek ; Paolo
>
higuang
> ; Oliver Smith-Denny
> ; Pop, Aaron
> Subject: Re: [edk2-devel] [Patch v2 1/3]
> MdePkg/Include/IndustryStandard: Add Operator and Xor field names
>
> On Tue, Feb 27, 2024 at 11:46 PM Michael D Kinney
> wrote:
> >
> > Hi Pedro,
> >
> > L
e-
> > > > From: Pedro Falcato
> > > > Sent: Wednesday, May 31, 2023 11:17 AM
> > > > To: Kinney, Michael D
> > > > Cc: devel@edk2.groups.io; Gao, Liming ;
> Liu,
> > > > Zhiguang ; Oliver Smith-Denny
> > > &g
> referring to the codeql-action/upload-sarif action which is at v2.
>
> This change updates all of the actions to the latest releases to
> prevent deprecated versions from continuing to be used.
>
> Cc: Sean Brogan
> Cc: Joey Vagedes
> Cc: Michael D Kinney
> Signed-o
Since this is not a standard PCI visible to PCI Bus Driver, did you consider
using MdeModulePkg\Universal\SerialDxe that
produces a Serial I/O Protocol from a SerialPortLib instance? That was
SerialPortLib can be used for DEBUG() logging
and the Serial I/O Protocol produced by SerialDxe can be
DXE env is not UEFI conformant. UEFI Drivers can not be executed
until the UEFI env is fully established which is at end of DXE
after all DXE Arch Protocols are produced and DXE Core supports the
full set of requires UEFI services. Running a UEFI Driver or UEFI
Application before all DXE Arch
Thanks for the reminder. "Require Linear History" was not set
in edk2-non-osi. It is now.
Mike
> -Original Message-
> From: Marcin Juszkiewicz
> Sent: Wednesday, February 21, 2024 12:58 AM
> To: devel@edk2.groups.io; Desimone, Nathaniel L
>
> Cc: Kinney, Michael D
> Subject: Re:
Hi Ard,
I disagree. We have never allowed a force push to the main
branch of TianoCore repos. This has happened before and
was discussed and the policy is to not fix. Even the edk2
repo has some merge commits in its history that were discussed
and not fixed.
We can never know how many
move the cc lines listing people that have
> reviewed/acked/tested the patch, as those tags already convey that the
> person is aware of it cc'ed or not.
>
> So perhaps it would be better to make this check part of the
> contributor workflow but not the GitHub PR/CI workflow?
>
>
This is a UEFI Driver that depends on the Driver Binding Protocol
and use of ConnectController(). These drivers cannot be used
until the BDS phase when the active consoles and boot devices
are evaluated and the smallest set of drivers required to boot
are connected.
It does not make sense to have
sel Chiu
> M: Sai Chaganty
> @@ -88,6 +93,11 @@ Silicon/Intel/WhitleySiliconBinPkg
> M: Nate DeSimone
> M: Isaac W Oram
>
> +Silicon/Intel/EaglestreamSiliconBinPkg
> +M: Nate DeSimone
> +M: Chasel Chiu
> +M: Nathaniel Haller
> +
> Silicon/Intel/QuarkSocBin
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Nathaniel Haller
> Sent: Friday, February 16, 2024 5:48 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Chiu,
> Chasel
> Subject: [edk2-devel] [PATCH
volatile means do not optimize into a register. The compiler must perform the
actual memory access every time.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Sunday, February 18, 2024 7:06 PM
> To: Zhou, Jianfeng ; devel@edk2.groups.io
> Cc: Laszlo
Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Michael Kubacki
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/PatchCheck.py | 77 -
1 file changed, 76 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts
Cc tags are present to make sure
all patches Cc the required maintainers/reviewers.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Michael Kubacki
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Michael D Kinney (4):
BaseTools/Scripts/PatchCheck:
o use all lower case.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Michael D Kinney
Reviewed-by: Rebecca Cran
Reviewed-by: Ard Biesheuvel
---
BaseTools/Scripts/PatchCheck.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scr
and reviewers are documented in
Maintainers.txt and can be retrieved using the script
BaseTools/Scripts/GetMaintainer.py.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/PatchCheck.py | 6 --
1 file changed, 4
in CommitMessageCheck class to return errors
detected in commit message signatures.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/PatchCheck.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
ewing each patch.
>
> Best regards,
>
> Mike
>
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Wednesday, February 14, 2024 3:48 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> >
> > Cc: Leif Lindholm ; Reb
-Wregister (C++ and Objective-C++ only)
Warn on uses of the register storage class specifier, except when it is part of
the GNU Variables in Specified Registers extension. The use of the register
keyword as storage class specifier has been deprecated in C++11 and removed in
C++17. Enabled by
The other option is update build to ignore -Werror=register
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro
> Falcato
> Sent: Friday, February 16, 2024 12:06 PM
> To: devel@edk2.groups.io; pawel.karczew...@solidigm.com
> Subject: Re: [edk2-devel] Using
I think adding a #define to define register to nothings makes sense.
If this is something that is tied to a specific C++ version, then it could be
further qualified with a version value.
Mike
From: devel@edk2.groups.io On Behalf Of pawel.karczewski
via groups.io
Sent: Friday, February 16,
Hi Rebecca,
This approach makes a lot of sense. Thank you for the updated. I have
approved.
Can we open some new Issues to re-enable flake8/ruf and codecov so
those tasks are not forgotten.
Thanks,
Mike
> -Original Message-
> From: Rebecca Cran
> Sent: Thursday, February 15, 2024
gt;> ; Michael Roth ; Xu,
> >> Min M ; Desimone, Nathaniel L
> >> ; Paul Grimes ;
> >> Kumar, Rahul R ; Ni, Ray
> ;
> >> Rebecca Cran ; Chaganty, Rangasai V
> >> ; Sami Mujawar
> ;
> >> Rhodes, Sean ; Zeng, Star
> ;
> >>
; ; caiyuqing379 ; dahogn
> ; meng-cz
> Subject: Re: [edk2-devel] BaseTools/AutoGen: declare
> ProcessLibraryConstructorList() for SEC modules
>
> On 2/8/24 17:40, Michael D Kinney wrote:
> > Hi Laszlo,
> >
> > I need to review the proposed BaseTools/AutoGen change to see
atch 1/1] MdePkg/Library/BaseCpuLibNull: Add missing
> X86 specific services
>
> Reviewed-by: Liming Gao
>
> > -邮件原件-
> > 发件人: Laszlo Ersek
> > 发送时间: 2024年1月24日 21:00
> > 收件人: Michael D Kinney ;
> > devel@edk2.groups.io
> > 抄送: Liming Gao
the DXE
Core internal time to run faster than expected.
Cc: Ray Ni
Signed-off-by: Michael D Kinney
---
PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c
b/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c
index
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Douglas Flick [MSFT]
> Sent: Thursday, January 25, 2024 1:55 PM
> To: devel@edk2.groups.io
> Cc: Douglas Flick [MSFT] ; Kinney, Michael D
> ; Liming Gao ;
> Liu, Zhiguang
> Subject: [PATCH v2
Please make sure this change is also applied to the edk2-basetools repo.
Mike
From: devel@edk2.groups.io On Behalf Of Sami Mujawar
Sent: Friday, January 26, 2024 2:13 AM
To: devel@edk2.groups.io; Sami Mujawar ; Rebecca Cran
; nd
Subject: Re: [edk2-devel] [PATCH] Basetools: Include PCD
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Thursday, January 25, 2024 12:23 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Laszlo Ersek
> ; Aktas, Erdem ; Michael Roth
> ; Xu, Min M ; Gerd Hoffmann
> ; Yao, Jiewen ; Tom Lendacky
> ;
new way to describe the memory range, should
> we
> > > > suggest the rule to still
> > > > use the top memory resource hob for the memory type bin range?
> > >
> > > How would that work, technically? If the platform specifies a
> concrete
> >
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Douglas Flick [MSFT]
> Sent: Tuesday, January 23, 2024 7:34 PM
> To: devel@edk2.groups.io
> Cc: Douglas Flick [MSFT] ; Kinney, Michael D
> ; Liming Gao ;
> Liu, Zhiguang
> Subject: [PATCH 11/14] MdePk
they should point their new HOB to the top of RAM?
>
> Thanks
> Laszlo
>
> >
> > Thanks
> > Liming
> >> -邮件原件-
> >> 发件人: Michael D Kinney
> >> 发送时间: 2024年1月24日 4:24
> >> 收件人: devel@edk2.groups.io
> >> 抄送:
, Aaron
> ; Liu, Yun Y ; Andrew Fish
>
> Subject: Re: [edk2-devel] [Patch v2 1/1] MdeModulePkg/Core/Dxe: Set
> MemoryTypeInfo bin range from HOB
>
> On 1/23/24 21:24, Michael D Kinney wrote:
> > Provide an optional method for PEI to declare a specific address
> > rang
tch v2 1/1] MdeModulePkg/Core/Dxe: Set
> MemoryTypeInfo bin range from HOB
>
> On 1/23/24 21:24, Michael D Kinney wrote:
> > Provide an optional method for PEI to declare a specific address
> > range to use for the Memory Type Information bins. The current
> > algorithm
ject: RE: [edk2-devel] [PATCH v3 1/1] MdePkg: Add FdtLib gmock
> support
>
> Reviewed-by: Michael D Kinney
>
> I also see you opened a PR to run EDK II CI and it passed.
>
> I will merge V3
>
> Thanks,
>
> Mike
>
> > -Original Message-
> > F
1 - 100 of 2528 matches
Mail list logo
