Re: [edk2-devel] [PATCH] Add SHA3/SM3 functions with openssl for Mbedtls

2024-04-24 Thread Wenxing Hou
Hi Yi, Thanks for your feedback. I have changed the code and sent the PATCH v2. Please review the PATCH v2. Thanks, Wenxing -Original Message- From: Li, Yi1 Sent: Monday, April 22, 2024 3:43 PM To: Hou, Wenxing ; devel@edk2.groups.io Cc: Yao, Jiewen Subject: RE: [PATCH] Add

Re: [edk2-devel] [PATCH] Add SHA3/SM3 functions with openssl for Mbedtls

2024-04-22 Thread Li, Yi
Adding a copy of BaseCryptLib/Sm3/Sha3 seems like a workaround to me. I prefer to use files directly from BaseCryptLib, such like: DEFINE BASE_CRYPT_PATH= ../BaseCryptLib [Sources] $(BASE_CRYPT_PATH)/Hash/CryptDispatchApDxe.c ... Then I think DummyOpensslSupport.c should not be

[edk2-devel] [PATCH] Add SHA3/SM3 functions with openssl for Mbedtls

2024-04-21 Thread Wenxing Hou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177 Because the Mbedlts 3.3.0 doesn't have SHA3 and Sm3, the SHA3 and Sm3 implementaion based on Openssl. Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou --- CryptoPkg/CryptoPkg.ci.yaml | 1 +