Re: [PATCH] SMPP trivial
On Thu, Feb 20, 2003 at 06:55:21PM +0100, Alexander Malysh wrote: here is trivial SMPP generic_nack fix. generic_nack command id is 0x8000 instead of 0x Please apply ... Thanks, you are right. I checked the SMPP spec and I've committed that patch to CVS. Cheers, Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 :: The biggest crime of all that [Microsoft] commits is getting people accustomed to huge, slow, unstable software as the norm. -- Jay Maynard
Re: [PATCH] Re: RE : SMPP 3.3 trouble
On Fri, Feb 21, 2003 at 02:06:12PM +0100, Alexander Malysh wrote: For all: SMPP v3.4 spec allow sequence number in the range from 0x0001 to 0x7FFF And we send 0x0 , that is wrong and SMSC do right job! Looks plausible to me... +1 I guess most other SMSC's are lax about accepting a zero sequence number or this problem would have been fixed by now. Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 :: Disney does mediated experiences better than anyone. If they understood what OSes are ... they could crush Microsoft in a year or two. -- NS
Re: [PATCH] Re: RE : SMPP 3.3 trouble
On Fri, Feb 21, 2003 at 04:45:53PM +0100, Angel Fradejas wrote: It seems someone rolled it back :-( Oops. I think Stipe took it out in revision 1.12... Stipe, was that deliberate? Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 ::
[PATCH] allow setting service-type for SMPP SMSC
Please find below a patch to allow an SMPP SMSC group to contain a
service-type definition. Previously Kannel would always send NULL, i.e.
use default service-type. I've tested this patch and it works against
Xwireless/Mblox SMPP server. If no-one objects I'll commit it to CVS and
update the userguide.
Many thanks to Nick Clarey for writing this when I realised what the
missing functionality was.
Dave
--
:: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 ::
Standards ought to be less whimsical than, say, Microsoft APIs.
-- Graham Nelson
Index: gw/smsc/smsc_smpp.c
===
RCS file: /home/cvs/gateway/gw/smsc/smsc_smpp.c,v
retrieving revision 1.23
diff -u -r1.23 smsc_smpp.c
--- gw/smsc/smsc_smpp.c 14 Feb 2003 10:44:39 - 1.23
+++ gw/smsc/smsc_smpp.c 18 Feb 2003 13:34:11 -
@@ -89,6 +89,7 @@
Octstr *address_range;
Octstr *our_host;
Octstr *my_number;
+Octstr *service_type;
int source_addr_ton;
int source_addr_npi;
int dest_addr_ton;
@@ -120,7 +121,7 @@
int max_pending_submits, int reconnect_delay,
int version, int priority, Octstr *my_number,
int smpp_msg_id_type, int autodetect_addr,
- Octstr *alt_charset)
+ Octstr *alt_charset, Octstr *service_type)
{
SMPP *smpp;
@@ -144,6 +145,7 @@
smpp-alt_dcs = alt_dcs;
smpp-our_host = octstr_duplicate(our_host);
smpp-my_number = octstr_duplicate(my_number);
+smpp-service_type = octstr_duplicate(service_type);
smpp-transmit_port = transmit_port;
smpp-receive_port = receive_port;
smpp-enquire_link_interval = enquire_link_interval;
@@ -173,6 +175,7 @@
octstr_destroy(smpp-username);
octstr_destroy(smpp-password);
octstr_destroy(smpp-system_type);
+octstr_destroy(smpp-service_type);
octstr_destroy(smpp-address_range);
octstr_destroy(smpp-our_host);
octstr_destroy(smpp-my_number);
@@ -326,6 +329,9 @@
pdu-u.submit_sm.source_addr = octstr_duplicate(msg-sms.sender);
pdu-u.submit_sm.destination_addr = octstr_duplicate(msg-sms.receiver);
+
+/* Set the service type of the outgoing message */
+pdu-u.submit_sm.service_type = octstr_duplicate(smpp-service_type);
/* Check for manual override of source ton and npi values */
if(smpp-source_addr_ton -1 smpp-source_addr_npi -1) {
@@ -1252,6 +1258,7 @@
long dest_addr_npi;
Octstr *our_host;
Octstr *my_number;
+Octstr *service_type;
SMPP *smpp;
int ok;
int transceiver_mode;
@@ -1284,6 +1291,7 @@
address_range = cfg_get(grp, octstr_imm(address-range));
our_host = cfg_get(grp, octstr_imm(our-host));
my_number = cfg_get(grp, octstr_imm(my-number));
+service_type = cfg_get(grp, octstr_imm(service-type));
system_id = cfg_get(grp, octstr_imm(system-id));
if (system_id != NULL) {
@@ -1328,6 +1336,11 @@
error(0, SMPP: Configuration file doesn't specify system-type.);
ok = 0;
}
+if (octstr_len(service_type) 6) {
+error(0, SMPP: Service type must be 6 characters or less.);
+ok = 0;
+}
+
if (!ok)
return -1;
@@ -1379,7 +1392,7 @@
dest_addr_npi, alt_dcs, enquire_link_interval,
max_pending_submits, reconnect_delay,
version, priority, my_number, smpp_msg_id_type,
- autodetect_addr, alt_charset);
+ autodetect_addr, alt_charset, service_type);
conn-data = smpp;
conn-name = octstr_format(SMPP:%S:%d/%d:%S:%S,
@@ -1401,6 +1414,7 @@
octstr_destroy(my_number);
octstr_destroy(smsc_id);
octstr_destroy(alt_charset);
+octstr_destroy(service_type);
conn-status = SMSCCONN_CONNECTING;
Index: gwlib/cfg.def
===
RCS file: /home/cvs/gateway/gwlib/cfg.def,v
retrieving revision 1.81
diff -u -r1.81 cfg.def
--- gwlib/cfg.def 14 Feb 2003 10:55:37 - 1.81
+++ gwlib/cfg.def 18 Feb 2003 13:34:11 -
@@ -232,6 +232,7 @@
OCTSTR(source-addr-npi)
OCTSTR(dest-addr-ton)
OCTSTR(dest-addr-npi)
+OCTSTR(service-type)
OCTSTR(source-addr-autodetect)
OCTSTR(enquire-link-interval)
OCTSTR(max-pending-submits)
Re: [PATCH] allow setting service-type for SMPP SMSC
On Tue, Feb 18, 2003 at 02:58:12PM +0100, Stipe Tolj wrote: One thing only: what's the default of the value if *no* config directive is given?! NULL. (and I have tested that -- it appears correctly in the PDU dump) It looks you don't initialize the variable and hence you will pass garbage, or does cfg_get() return NULL in case the value is not given?! Yes, that's what happens. Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 :: Even if you are on the right track, you'll get run over if you just sit there.
Re: [PATCH] allow setting service-type for SMPP SMSC
On Tue, Feb 18, 2003 at 03:34:24PM +0100, Stipe Tolj wrote: so why didn't you post it ;)) Too late, I've committed it now :-) Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 :: Fare evasion also adds a much needed element of excitement to the otherwise dull trek to work. -- Ronald Seegers
Re: SMPP driver default autodetect should be 1
On Tue, Feb 11, 2003 at 04:03:13PM -, Alex Judd wrote: By default we are disabling the auto switching of TON and NPI in the SMPP driver. I think we should enable this by default and then allow to explicitly turn it off. I agree. (it would have saved me half an hour of head-scratching last week ;-) ) Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 :: The more complex the system and the more expert the users, the more their technical conversation sounds like the plot of a soap opera. -- Pinker
Re: (no subject)
On Tue, Jan 21, 2003 at 01:26:02PM +0100, Andrea Viscovich wrote: You have the wrong link to download kannel, http://www.kannel.3glab.org is the right one. actually www.kannel.org points to the same place as www.kannel.3glab.org these days, thanks to the guys at Wapme. Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 ::
mailing list downtime
Hi, just a heads-up: I'll be upgrading the software (Mailman) on the list server later today. There'll be a short period when messages don't immediately get sent out to the list; they'll get queued and sent later. Cheers, Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 ::
Re: mailing list downtime
I wrote: just a heads-up: I'll be upgrading the software (Mailman) on the list server later today. If this message makes it out to the list, then the upgrade went OK. :-) Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 ::
Re: daily snapshot is not up to date
On Thu, Aug 01, 2002 at 02:58:14PM +0300, Kaido Karner wrote: daily snapshot (tried only tarball) on http://www.kannel.org/ is not up to date with cvs .. [dholland@geodude download]$ cat snapshot-timestamp.txt Snapshot build starts: Thu Aug 1 06:00:00 BST 2002 Snapshot build ends: Thu Aug 1 06:04:22 BST 2002 What do you think is missing? Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: doc building bug
On Fri, May 31, 2002 at 11:10:20AM +0200, Andreas Fink wrote: jade:doc/userguide/userguide.tmp:5551:7:E: end tag for SECT3 omitted, but OMITTAG NO was specified Odd, it builds without errors on my Debian Woody machine. I checked in a new version. Can you try it again, please? Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901 My Installation Crashes Randomly Or Some Operations Fail Totally.
lists/website downtime
Apologies for the downtime on the lists/website. The machine had crashed with a kernel oops. I just rebooted it and all seems well now. I'll keep an eye on it. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: [FYI] Post-XML
Bruno David Simões Rodrigues wrote: I guess snapshots aren't beeing built again. (Last build: Apr 26) Does the script stop with warnings ? Yeah, simply a missing /appendix in userguide.xml. It got broken in 1.166. I just checked in a fix and ran the snapshot script. I've changed the daily nag on failed build script to also check that the documentation can be successfully built. Then you can all see when it goes wrong! Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*=3G Lab, UK =*= fax: +44 01223 478901
Re: [Fwd: Daily patch: gateway]
On Thu, Apr 18, 2002 at 05:34:16PM +0100, Bruno Rodrigues wrote: I was thinking in just splitting it, but I don't know where to. doc/old/changelog.*.*.* ? Good idea. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: Snapshots aren't being built (Was: Re: smsc_at2.c at+cmms=2)
On Fri, Apr 19, 2002 at 05:14:44PM +0100, Bruno David Simões Rodrigues wrote: Shouldn't the scripts detect the error and send us an email to devel-reports ? ;) Yes :-( Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901 Ogden's Law: The sooner you fall behind, the more time you have to catch up.
Re: [Fwd: Daily patch: gateway]
On Thu, Apr 18, 2002 at 03:29:42PM +0100, Bruno David Simões Rodrigues wrote: Hei, what happened to changelog ?!?!?! Good question. I noticed the big diff, but the new Changelog looked intact, so I didn't go further. Maybe the whitespace got reformatted or something? Stipe, I think you were the only person to check in changes between 1.1781 and 1.1786? Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: Kannel Installation Error
On Tue, Mar 12, 2002 at 07:32:31PM +0200, Avner Sternheim wrote: cd `dirname doc/alligata/alligata.xml` : `basename doc/alligata/alligata`.tex /dev/null || true Those lines look as though you don't have jadetex installed. /bin/sh: dvips: command not found And that means you don't have dvips installed. Assuming this is Red Hat or similar, installing the tetex-dvips package should help. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: Kannel Development
On Thu, Feb 21, 2002 at 08:25:37AM +0100, Andreas Fink wrote: To the group: Any objections to declare CVS as stable 1.2.0 and development 1.3.0. No objections here. Should we elect/delegate/co-opt a release manager who will be responsible for this? Anyway, please liaise with me or Nick (or both) before doing a tag/branch/release/whatever, so we can be sure to have a backup of the repository in case we need to go back. And have a look at gateway/doc/release.txt for the actual process. Thanks, Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901 What happened to the innocent and trusting child that I used to be? Oh, yeah, I got involved with computers. -- Seymour J. Metz
Re: I don't want to run bearerbox as root
On Fri, Feb 15, 2002 at 01:24:43PM +0100, Miroslav Vrankic wrote: When we tried to run bearerbox as user kannel other boxes could not connect to it. You didn't attach your config file (or log file), but from this line: CONF=/usr/local/bin/m20.conf it looks like you're using a Siemens M20. Check the permissions on the serial port device (e.g. /dev/ttyS0) to make sure the kannel user can access it. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901 If you lie to the compiler, it will get its revenge. -- Henry Spencer
Re: Deligates to 3GSM world congress?
On Thu, Jan 24, 2002 at 05:43:34PM -, Paul Keogh wrote: Are there going to be any of us at 3GSM World Congress, 19-22. We (ANAM) will be there on the Enterprise Ireland stand. Drop by and say hello ! 3G Lab will have a stand... and a yacht. How come I never get to go on fun trips like this? :-) Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: problems compiling kannel with mySQL.
On Tue, Jan 08, 2002 at 03:40:54PM +0200, Oded Arbel wrote: Yaouch ! this will still not work - it doesn't matter where mySQL include files are, as long as mysql.h and mysql_version.h are on the same directory, kannel will not compile successful. Really? It works fine for me with them both in /usr/include/mysql: [dholland@geodude dholland]$ locate mysql.h /usr/include/mysql/mysql.h [dholland@geodude dholland]$ locate mysql_version.h /usr/include/mysql/mysql_version.h [dholland@geodude dholland]$ [dholland@geodude gateway]$ ./configure --with-mysql=/usr . checking for MySQL client support in... /usr checking for /usr/include/mysql/mysql.h... yes checking for mysql/mysql.h... yes checking for mysql/mysql_com.h... yes checking for mysql/mysql_version.h... yes . and the build succeeds. This is on Red Hat 7.1 with the mysql-devel-3.23.36-1 rpm. I am interested to know what the difference in file layouts is between the Red Hat packaged version and the default MySQL install. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: cvs mail post-process
On Wed, Jan 02, 2002 at 04:24:29PM +0100, Bernino Lind wrote: Could you setup cvs to make a post-process rule on commit, that all interested parties gets a mail that states the commit comment, the file changed etc. Look for the daily messages to the devel-reports list with the subject Daily patch: gateway. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: Proposed Improvement for Kannel SMS Gateway - File
On Sat, Dec 22, 2001 at 09:38:15PM -0800, Choong Hong Cheng wrote: I managed to prepared the patches for the changes but it is currently held at the Administrator devel mailing list ... awaiting for approval ... Sorry, the list admin doesn't work weekends. :-) The patch was held due to a size limit on the list. I've upped that to 100KB/message. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901 I must admit that I do hate Windows because it has so shamefully lowered our expectations of what quality software should be. -- Nicholas Petreley
Re: [RFC] adding features to kannel.3glab.org
On Thu, Oct 18, 2001 at 06:15:16PM +0200, Stipe Tolj wrote: * mailing list for CVS commits This should now be working, with a daily email to the devel-reports list. The first message will go out around 6:30am GMT tomorrow. As always, please let me know if it doesn't work... Thanks, Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: aa
On Sun, Nov 18, 2001 at 05:17:25PM +0100, Roberto Biancardi wrote: subscribe Just a reminder; all your mailing list needs are catered for at: http://kannel.3glab.org/mailman/listinfo/ Please don't send subscribe/unsubscribe requests to the list. Thanks, Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: doc/PNG Files
On Tue, Nov 13, 2001 at 02:06:41PM +0100, Jörg Pommnitz wrote: [jpo@jpo wtls]$ file *.png fig10o.png: PNG image data, CORRUPTED, fig1o.png:PNG image data, CORRUPTED, I see rev 1.2 was checked in on 2001-10-31, that version appears to be the problem, because the 1.1 files are OK. At least, fig1o.png v1.1 is fine, I didn't check them all. 1.2 was checked in by Paul Keogh. Paul, what did you do? Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: GSM modem
On Wed, Oct 31, 2001 at 08:26:47PM +0100, Fernando Primo wrote: Finaly I bought the GSM modem and I have got to send/recive menssage, but now I have a little problem, and I don´t know if you will be able to solve it. When I send special character, like ñ, ú, ó, á, é, í, ü , I don´t get to recive them correctly. Is a configuration problem of GSM modem? or Is a kannel problem? I have seen a file alt_charsets.h in source files, but I don´t know if i have to modify this file to solve this problem and how to do it. ??? Sorry, no idea. (I am not a programmer, etc.) I've cc'ed the devel list; someone there should know. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: Documentation updates?
On Wed, Oct 24, 2001 at 12:51:21PM +0200, Steve Rapaport wrote: Examples: - Many people know about the mail list archive search URL I posted last week, but it's not linked to the docs. I just added a link to those archives to the page at http://www.kannel.3glab.org/lists.shtml So, are the docs also on CVS? Can I contribute? Who has taken on the job of updating them? I'd like to add some bits The docs are indeed in CVS. See the gateway/doc directory. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: [RFC] adding features to kannel.3glab.org
On Thu, Oct 18, 2001 at 06:15:16PM +0200, Stipe Tolj wrote: * ViewCVS (http://viewcvs.sourceforge.net/) I like the look of that. Try: http://www.kannel.3glab.org/cgi-bin/viewcvs.cgi (and tell me how I broke the installation, please) * automatic nightly snapshots (tarballs) of CVS checkout Do you mean, different from http://www.kannel.3glab.org/download/kannel-snapshot.tar.gz (and snapshot.zip, doc-snapshot.tar.gz, doc-snapshot.zip) They are created nightly and are linked from the downloads page. * automatic compile and build test for major supported OS (was running at kannel.org) Can do, for Linux/RedHat 7.1 at least. The script is already there for this, it's just not enabled. I think the devel-reports list is/was the intended recipient. * mailing list for CVS commits Sounds like a good idea. I don't know how to tie that into CVS (but I'm willing to learn...). There is an existing script to send each day's ChangeLog diff to the devel list; is that something that would be useful instead or as well as a CVS commit list? Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: CVS patches
On Mon, Oct 15, 2001 at 07:06:18PM +1000, Matt Flax wrote: IF YOU DO NOT WANT TO GIVE ME ACCESS THEN FINE, HOWEVER THIS PATCH IS NECESSARY. I suggest you patch the CVS tree and give me access WHEN YOU DEEM MY KNOWLEDGE, EXPERIENCE AND EFFORT WITH KANNEL SIGNIFICANT. OK ? Matt, Please don't post in all-caps. It's hard to read. It appears you've been actively working on kannel for less than a month. I think it probably takes longer than that to get to know the other people who are working on the project, which might be one reason why people are reluctant to commit your code. Also while we are without a project technical architect, I can understand the community's reluctance to make large-scale changes to what is by-and-large working code (the at driver). I think your best way forward is to produce a patch against cvs to implement your at3 driver. Thanks, Dave (mailing list/web site/cvs maintainer) -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901
Re: cvs
On Thu, Aug 02, 2001 at 11:10:44AM +0200, Frederik Ammitzbøll wrote: Are these daily snapshots not generated anymore (snapshot-timestamp says June 22), or do you need cvs access to get them (in that case could somebody be so kind as to send the patch to me please?) The daily snapshots are being generated as before, but the build process has been failing in the make docs stage. I have commented out the make docs in the snapshot script and generated a snapshot manually. I'll leave it that way until I have time to work out why the docs won't build properly. Dave -- David Holland =*= Systems Manager =*= tel: +44 01223 478900 http://www.3glab.com/ =*= 3G Lab, UK =*= fax: +44 01223 478901 Please help me out. ... Certainly. Which way did you come in?
