Le 10/10/2012 11:41, Vincent CHAVANIS a écrit :
Hi all,
As some SMPP Servers requires this feature,
here is the patch.
Comments please ?
regards
Any comments ? votes ?
FI,
Acision, leader in SMS gateways can require this on their server config.
(A Vodafone company requires
Le 10/10/2012 11:41, Vincent CHAVANIS a écrit :
Hi all,
As some SMPP Servers requires this feature,
here is the patch.
Comments please ?
regards
Any comments ?
FI,
Acision, leader in SMS gateways can require this on their config file.
sorry for posting twice,
Vincent.
Le 23/10/2012 12:38, Vincent CHAVANIS a écrit :
Le 10/10/2012 11:41, Vincent CHAVANIS a écrit :
Hi all,
As some SMPP Servers requires this feature,
here is the patch.
Comments please ?
regards
Hi all,
As some SMPP Servers requires this feature,
here is the patch.
Comments please ?
regards
--- gateway.orig/gw/smsc/smsc_smpp.c2012-09-27 11:17:34.588403041 +0200
+++ gateway/gw/smsc/smsc_smpp.c 2012-10-10 11:27:16.195102206 +0200
@@ -149,6 +149,8 @@
int source_addr_npi;
thanks,
Le 22/08/2012 10:04, Alexander Malysh a écrit :
Hi,
I just commited hash from Robert Sedgewick as replacement for the old one. I
think that would be default for now?
Alex
Am 09.08.2012 um 13:42 schrieb Stipe Tolj st...@kannel.org:
Am 07.08.2012 22:40, schrieb Rene Kluwen:
Is this cert valid ? Got an ssl error when trying to access
https://redmine.kannel.org
Informations
- hostname : redmine.kannel.org
- valid from Sun, 12 Dec 2010 17:48:13 GMT to Wed, 14 Dec 2011
01:40:34 GMT
- signedfrom : Secure Digital Certificate Signing, StartCom Ltd., IL
-
Sorry for the delay, i've just pushed it on SVN
Vincent
Le 21/06/2011 13:50, Alexander Malysh a écrit :
hi,
still not tested but +1. Please commit it.
Alex
Am 21.06.2011 um 11:14 schrieb Vincent CHAVANIS:
any objections, comments on this patch ?
Le 15/06/2011 14:27, Vincent CHAVANIS
any objections, comments on this patch ?
Le 15/06/2011 14:27, Vincent CHAVANIS a écrit :
here is the corrected patch.
Vincent.
Le 15/06/2011 13:42, Alexander Malysh a écrit :
Hi Vincent,
patch doesn't apply:
fatal: corrupt patch at line 59
and this change is not what you want
you don't receive any MOs
b) if you have something to send, this thread will be waked up any time and
therefore there is no throughput garantee
if you use load_XXX then all these issues can be avoided.
Alex
Am 19.05.2011 um 13:04 schrieb Vincent CHAVANIS:
Hi Alex,
AT commands are synchronous
);
+gwthread_sleep(1);
you want to sleep 1 second because modem needs this. if you use gwthread_sleep
other threads
could wake up this thread.
Thanks,
Alex
P.S. Otherwise patch looks good.
Am 15.06.2011 um 13:00 schrieb Vincent CHAVANIS:
Hi,
Sorry for the delay,
here is the new patch with alex
Also i want to wish an Happy new year to everyone!
Le 03/01/2011 10:21, Alexander Malysh a écrit :
and best wishes for 2011!
Alexnder Malysh
commited!
Le 11/10/2010 20:43, Nikos Balkanas a écrit :
Hi,
Good eye! That's a typo that got away.
+1
BR,
Nikos - Original Message - From: Vincent CHAVANIS
v.chava...@telemaque.fr
To: devel@kannel.org
Sent: Monday, October 11, 2010 7:38 PM
Subject: [FIX] BROKEN DLR with Mysql
Fix compiler warnings on test_list.c
fa fb should be defined as const.
comments ?
Vincent.
--- /gateway-cvs/test/test_list.c 2010-10-07 16:26:09.971141724 +0200
+++ /gateway/test/test_list.c 2010-10-12 13:06:43.732612247 +0200
@@ -68,8 +68,8 @@
static int my_sort_cmp(const void *a,
commited!
thanks
Le 12/10/2010 14:23, Alexander Malysh a écrit :
+1
Thanks,
Alexander Malysh
Am 12.10.2010 um 13:22 schrieb Vincent CHAVANIS:
Fix compiler warnings on test_list.c
fa fb should be defined as const.
comments ?
Vincent.
test_list_warnings.txt
Dear all,
Here is a small patch that fixes intermediate DLR state
for all SMSCs using MySQL.
Vincent.
--
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Direction du Developpement xMS+
http://www.telemaque.fr/
v.chava...@telemaque.fr
Tel : +33 4 92 90 99 84 (fax
Hi nikos,
'alias' is an crypted MSISDN done by the operator-side
to protect the customer (avoid spamming, and any abuses)
This actually exists here in fr but i assume,
this also exists on other countries
I just want to be sure this will not
break any existing installations.
Vincent.
Le
be to calculate the encryption and
implement it when used. Is there a way to predict it? How can I get more info
about it?
BR,
Nikos
- Original Message - From: Vincent CHAVANIS v.chava...@telemaque.fr
To: devel@kannel.org
Sent: Wednesday, July 21, 2010 1:45 PM
Subject: Re: Patch: EMI UUCP DLRs (final
think? It seems I need to make that parameter
configurable. I will have to resubmit. Please do not commit yet.
BR,
Nikos
- Original Message - From: Vincent CHAVANIS
v.chava...@telemaque.fr
To: Nikos Balkanas nbalka...@gmail.com
Cc: devel@kannel.org
Sent: Wednesday, July 21, 2010 3:12 PM
I'm +0 for this patch
because i really dislike the LIKE '%searches', they are *extremely* slow
but this is at least the most advanced patch that partially fixes the
EMI's dlr issue.
*but* you still have an issue if 2 MTs are send in the same second (same
ts) to the same destination.
which DLR
Hi Olivier,
So, you will loop 100 times (in most cases for nothing) to find any unacked msg
?
This is useless CPU usage don't you think ?
Vincent
Le 08/07/2010 10:52, Olivier Dormond a écrit :
Hello,
Here is a patch against 1.4.3 to fix the detection of non-acked
messages sent through
Hi Nikos,
This patch will be rejected as we need a global resolution
of the problem. I've already posted this patch a couple of years ago.
(http://www.mail-archive.com/devel@kannel.org/msg05349.html)
Also your patch does not fully-fixes this issue.
If 2 MT are sended on the same second.
Which
Hi,
Also your patch does not fully-fixes this issue.
If 2 MT are sended on the same second.
Which DLR will you get ? (probably the first one inserted on your db)
Nope. That was what this patch was created for. If dst is known, then
dst (along with ts and smsc-id) are used for the query.
commit a patch with those fixes and also a couple color changes
Vincent also suggested.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 26/11/2009, at 11:00, Andreas Fink wrote:
php version = 6.0??
thats not existing yet.
On 25.11.2009, at 14:37, Vincent CHAVANIS wrote:
Hi
+2009-12-07 Stipe Tolj stolj at kannel.org
+* gw/smsc/smsc_emi.c: fix segmentation fault in case we jump via goto
+ error in smsc_emi2_create(), but have yet no privdata created.
nice catch!
Vincent.
Hi,
You have short_open_tag ? on index.php xmltoarray.php
And *shouldn't* be like this as described in the php guidelines
for further php releases (eg. = php 6.0)
Could you please fix this asap?
Then, i think we have to make a default working config
for people who just want to quickly test
no objections for this patch ?
Vincent
Stipe Tolj a écrit :
Damián Viano schrieb:
On Sun, Nov 15, 2009 at 03:43:01PM +0100, Alexander Malysh wrote:
Hi,
any objections from anybody to apply this patch? AFAIK nobody should depend on
case sensitivity for table names...
IMO it's worth to note
eheh right!
new file attached.
Vincent.
Alexander Malysh a écrit :
Hi Vincent,
seems you sent reverse patch?
Thanks,
Alexander Malysh
Am 13.11.2009 um 18:45 schrieb Vincent CHAVANIS:
Here is the PostgreSQL patch.
Vincent.
refs:
http://www.postgresql.org/docs/8.0/static/sql-syntax.html
Also, just a warning,
before this patch tables/column names were NOT case sensitives.
Now they are!.
Quoting an identifier also makes it case-sensitive, whereas unquoted names are
always folded to lower case.
Vincent.
Vincent CHAVANIS a écrit :
eheh right!
new file attached.
Vincent.
tested and work as expected.
++1
Vincent.
Alejandro Guerrieri a écrit :
This patch adds separate dlr counters on the status page. This is much
clearer than now imho, where we have dlr's and mo's mixed on the same
counter.
For example:
...
SMS: inbound (0.00,0.00,0.00) msg/sec, *dlr
tested,
++1 also for this patch
Alejandro Guerrieri a écrit :
Please see attached.
It adds the new dlr fields, and also:
1. Adds the admin-id field on the SMSC list.
2. It replaces $HTTP_GET_VARS (very outdated) with $_REQUEST.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
Ok, attached the new patch here.
Vincent.
Alexander Malysh a écrit :
Am 13.10.2009 um 00:09 schrieb Vincent CHAVANIS:
I'm sure we will find other specific cases that will be processed into
this function ;)
Let it as it.
Vincent, sorry but I don't see reason and case that we will add
your patch? I think as optional callback function ?
Thanks,
Alex
Am 09.10.2009 um 16:27 schrieb Vincent CHAVANIS:
this is Mysql specs (cf
http://dev.mysql.com/doc/refman/5.0/en/identifiers.html)
eg. : A reserved word that follows a period in a qualified name must
be an identifier, so it need
done.
Vincent
Alexander Malysh a écrit :
Hi again,
I don't see reason to use macro because macro contains only one line...
Could you please drop macro and use plain function call?
Thanks,
Alex
Am 12.10.2009 um 12:39 schrieb Vincent CHAVANIS:
Damn! you're right ;-)
For this issue, i
with only one line?
Thanks,
Alex
Am 12.10.2009 um 13:45 schrieb Vincent CHAVANIS:
done.
Vincent
Alexander Malysh a écrit :
Hi again,
I don't see reason to use macro because macro contains only one line...
Could you please drop macro and use plain function call?
Thanks,
Alex
Am 12.10.2009 um
Hi all,
Here is a patch that escape table names from mysql specs.
This will fix the SQL syntax error.
Simple POC (set your mysql conf as this)
group = dlr-db
id = mydlr
table = SELECT
You will get : ERROR 1064 (42000): You have an error in your SQL syntax;
Vincent
--
Telemaque - 06560
: Vincent CHAVANIS
v.chava...@telemaque.fr
To: devel@kannel.org
Sent: Friday, October 09, 2009 4:21 PM
Subject: [PATCH] dlr_mysql.c - Table name fix
Hi all,
Here is a patch that escape table names from mysql specs.
This will fix the SQL syntax error.
Simple POC (set your mysql conf as this)
group
I'm +0 for this patch as it.
There will be a compatibility breaker with Mysql 4
as the mysql_real_escape_string as been implemented in mysql 4.
We already had this discussion 4 years back with the stipe's patch.
(http://www.mail-archive.com/devel@kannel.org/msg05072.html)
This was mainly
- optimizing detection process on CME/CMS Errors
(avoid to check if CMS when CME was detected.)
- renaming param value code - errcode to make it more clean
Vincent.
--- /gateway-cvs/gw/smsc/smsc_at.c 2009-06-22 10:26:10.0 +0200
+++ /gateway/gw/smsc/smsc_at.c 2009-06-26
No this is currently uppon approval to be on CVS.
You can freely give your opignon though ;)
Vincent.
Alvaro Cornejo a écrit :
Hi Vincent
Is that in the latest CVS?
I got this as error string:
cat /var/log/kannel/x1p7_movimx2.log |grep -i error |more
2009-06-18 06:08:41 [29762] [14]
.
Vincent CHAVANIS a écrit :
No this is currently uppon approval to be on CVS.
You can freely give your opignon though ;)
Vincent.
Alvaro Cornejo a écrit :
Hi Vincent
Is that in the latest CVS?
I got this as error string:
cat /var/log/kannel/x1p7_movimx2.log |grep -i error |more
2009-06
Here is the revision of the latest patch i've submited.
- Now handling +CME ERRORS
- Added more detailled descriptions from +CME ERRORS
- Added specs sources
Vincent.
Alexander Malysh a écrit :
commited to cvs.
Thanks,
Alex
Am 17.06.2009 um 14:26 schrieb Vincent CHAVANIS:
This one should
This is already as it.
error(0, AT2[%s]: +CMS ERROR: %s (%d), octstr_get_cstr(privdata-name),
at2_error_string(errcode), errcode);
Vincent.
Alvaro Cornejo a écrit :
Hi Vincent
Might it be possible to show the message error number/code in the
error message text? This way it will be easyer
From an old thread (http://www.mail-archive.com/us...@kannel.org/msg07693.html)
Alex moved the at2_error_string into smsc_at.c
2004-09-18 Alexander Malysh amalysh at kannel.org
* gw/smsc/smsc_at.c: added new function 'at2_error_string' and teached
smsc_at to use it.
But some error
, privdata-max_error_count);
this is not very informative for kannel user. Please write out something
like Init failed errors X from max errors X.
please kill comments like this:
+ /*
+ */
please fix indentation, we use 4 spaces...
Thanks,
Alex
Am 17.06.2009 um 12:56 schrieb Vincent
ERROR but no error code - possibly
unsupported or invalid command?;
indents are 4 spaces instead of 2.
Thanks,
Alex
Am 17.06.2009 um 13:24 schrieb Vincent CHAVANIS:
yep, you're right.
new file attached.
without blank comments, and text cleaned.
Vincent.
Alexander Malysh a écrit :
Hi Vincent
ok +1 for me too,
But why limiting to 1024 ?
Should be better to check if defined NR_OPEN ?
Vincent.
Alejandro Guerrieri a écrit :
Ok, fair enough. +1 then :)
--
Alejandro Guerrieri
aguerri...@kannel.org
On 17/06/2009, at 12:48, Alexander Malysh wrote:
Am 17.06.2009 um 12:38 schrieb
Hi,
I'm currently benchmarking kannel/cvs-20090615 with 40 http smsc type generic
with a host 127.0.0.1 and 40 differents ports.
The thing is that the 30 firsts smsc are working and responding normaly
like this exemple:
#) telnet 127.0.0.1 7188
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape
try attached patch. The mtbatch freeze because in main we try to
join all threads (gwthread_join_all) but
in read_messages_from_bearerbox we blocked infinite waiting for acks
from bearerbox.
Thanks,
Alex
Am 17.04.2009 um 11:35 schrieb Vincent CHAVANIS:
I've experiences somes troubles when
of
‘octstr_create_real’ differ in signedness
Thanks,
Alex
Am 16.04.2009 um 14:52 schrieb Vincent CHAVANIS:
This fixes:
1/
gwlib/charset.c: In function 'charset_convert':
gwlib/charset.c:635: attention : format '%d' expects type 'int', but
argument 3 has type 'long int'
gwlib/charset.c:669
Alexander Malysh a écrit :
Hi,
I don't get it, why this patch is needed? Could you please describe in
detail?
Thanks,
Alex
Am 16.04.2009 um 12:36 schrieb Vincent CHAVANIS:
- When main thread is sleeping and receiving data by bearerbox,
we will be into an infinite loop.
This patch fix
- When main thread is sleeping and receiving data by bearerbox,
we will be into an infinite loop.
This patch fix this by waking-up the main thread.
Vincent.
--
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Direction du Developpement xMS+
http://www.telemaque.fr/
This fixes:
1/
gwlib/charset.c: In function 'charset_convert':
gwlib/charset.c:635: attention : format '%d' expects type 'int', but argument 3
has type 'long int'
gwlib/charset.c:669: attention : format '%d' expects type 'int', but argument 4
has type 'long int'
2/
/* now make it const -
to apply your patches cleanly:
alex:gateway$ patch -p2 --dry-run mtbatch_r2.txt
(Stripping trailing CRs from patch.)
patching file utils/mtbatch.c
patch: malformed patch at line 75: @@ -389,6 +407,9 @@
Thanks,
Alex
Am 09.04.2009 um 17:09 schrieb Vincent CHAVANIS:
yep you're right.
also fix
This *minor* patch :
- just moves the file from /test/ to the /utils/ folder which is IMO more
appropriate.
- add a new feature: now prints ot (operation type) on ack/nack responses
+printf(E%d_ACK \t%s\n, emimsg-ot,
+octstr_get_cstr(emimsg-fields[E50_ADC]));
already checked that if dlr-mask supplied that dlr_url is
also supplied.
Thanks,
Alex
Am 09.04.2009 um 12:34 schrieb Vincent CHAVANIS:
here is a revised version
Vincent.
Alexander Malysh a écrit :
Hi Vincent,
some comments to your patch:
+
+if (dlr_mask 0 dlr_url
)
--- /gateway-cvs/utils/mtbatch.c2009-04-03 14:51:29.0 +0200
+++ /gateway/utils/mtbatch.c2009-04-07 12:49:08.0 +0200
@@ -63,8 +63,10 @@
* to bearerbox.
*
* Stipe Tolj st...@wapme.de
+ * Vincent Chavanis v.chava...@telemaque.fr
*
- * XXX add udh (etc.) capabilities
Did this patch has been tested ?
In file included from ./gwlib/gwlib.h:83,
from gw/msg.h:69,
from gw/sms.h:89,
from gw/sms.c:65:
./gwlib/gwmem.h:188:1: warning: strdup redefined
In file included from /usr/include/string.h:423,
is a really trivial one.
please try attached patch that should fix this warning.
btw. I don't have such warning ;)
Thanks,
Alex
Am 06.04.2009 um 12:44 schrieb Vincent CHAVANIS:
Did this patch has been tested ?
In file included from ./gwlib/gwlib.h:83,
from gw/msg.h:69
Hi,
i'm also as +0
Calloc is malloc+memset
The only *unsignificant* case where we could use calloc is
to prevent redundant code on when allocating multiples elements
by passing the 2 args.
Vincent
Alexander Malysh a écrit :
Hi,
2009/4/3 Nikos Balkanas nbalka...@gmail.com
Here is a new version of the mtbach program.
- Introducing a Counter type
- Now handling correclty ack from bearerbox.
- typo fixes.
Vincent
Vincent CHAVANIS a écrit :
The issue is located on the mtbatch program that exit before receiving
all ack/nack from bearerbox.
(btw, Thanks
We should in that case also patch *http_header_value()
Vincent.
Alexander Malysh a écrit :
hi,
yes, you are right here. it doesn't crash only due to the octstr_copy
length adjust.
Patch applied to cvs.
Thanks,
Alex
Am 27.03.2009 um 18:30 schrieb Nikos Balkanas:
Hi,
A small patch
The issue is located on the mtbatch program that exit before receiving all
ack/nack from bearerbox.
(btw, Thanks to alex pointing me this)
The result is an TCP broken pipe System error 104: Connection reset by peer
This patch fixes this.
Vincent.
--
Telemaque - 06560 SOPHIA-ANTIPOLIS -
Hi nikos,
I could not understand this patch !?
If `from+len' is after the end of `ostr', `len' is reduced appropriately.
So what's wrong here ?
Vincent.
Nikos Balkanas a écrit :
Hi,
A small patch that left as it is should lead to memory corruption. I
have not tested the broken code but
Not yet!
I was a bit busy from the last days.
Vincent.
Hillel a écrit :
Hi Vincent,
You mention in the email below that a new patch is needed.
Out of interest, did you create a patch with the speed variable?
thanks
Date: Tue, 17 Feb 2009 12:05:43 +0100
From: Vincent CHAVANIS v.chava
Hi all,
Did someone tried to make the mtbatch working ?
This seems to be broken.
Maybe the UUID stuff in the msg structure ?
./mtbatch -v0 -p 13013 -f12345 content receivers10
gives:
2009-03-19 17:17:19.568 [28096] [0] INFO: SMS-Text: Test
2009-03-19 17:17:19.568 [28096] [0] INFO: Loading
ok got it worked
was a port problem
i said nothing... :-)
Vincent CHAVANIS a écrit :
Hi all,
Did someone tried to make the mtbatch working ?
This seems to be broken.
Maybe the UUID stuff in the msg structure ?
./mtbatch -v0 -p 13013 -f12345 content receivers10
gives:
2009-03-19 17:17
bps the
user provided. As I said, this seems reasonable for systems such as
Linux where the B is never equal to , and for others such as Mac
OS X where they are always equal.
P.
On Feb 16, 2009, at 21:53, Vincent CHAVANIS wrote:
The function do not *set* any bps.
And i don't see any
Adapted paul's patch for EMI_X25 SMSC
Vincent.
P. A. Bagyenda a écrit :
Thanks.
On the issue of non-standard speeds, I've tested this on Mac OS X
(which uses bps value as actual speed value) with a 460800 (i.e.
non-standard) modem, and it works just fine. Said modem also works well
update?
BR,
Nikos
- Original Message - From: Vincent CHAVANIS
v.chava...@telemaque.fr
To: devel@kannel.org
Sent: Monday, February 16, 2009 12:31 PM
Subject: [PATCH] EMI_X25 smsc module support for high speed modems
This patch fixes segfaults.
--
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Direction du Developpement xMS+
http://www.telemaque.fr/
v.chava...@telemaque.fr
Tel : +33 4 92 90 99 84 (fax 9142)
diff -rauw /gateway-cvs/test/test_hmac.c /gateway/test/test_hmac.c
---
Thanks,
I Will try soon to provide a patch in order to
fix all segfaults of all /test/ applications
I Will also use in the future the panic() function
for args checks.
Vincent.
Alexander Malysh a écrit :
commited to cvs, thanks!
Am 06.02.2009 um 14:45 schrieb Vincent CHAVANIS:
This patch
Hi Alejandro,
I spent a lot of time to understand how this works.
this seems to work like this:
- .xml file is (if i remember well) the XML format of your
content you will answer generally successResponse
- .spec are the logical path to grab the infos
from the XML you receive with this
15:22)
Vincent CHAVANIS a écrit :
After a long proccess of investigation, i finaly found that this SMSC
have some serious issues
- XML specs files are really bad interpreted (fields are read with char
* and then converted into octstr)
- Lots of segfaults
- SMSC driver cannot support multi
yep i'm also in favour ++1 of using
gsoap in the future releases of this driver.
Vince.
Stipe Tolj a écrit :
Alejandro Guerrieri schrieb:
Ouch! ;)
Ok, I'd rather think about developing new code than trying to fix this.
Thanks for your insights, they've been very useful.
gSOAP! gSOAP! :)
happy birthday stipe :-)
00 - command 'multipart'
03 - length of 'multipart' data
AD - reference number to group of the messages
(cf http://www.mail-archive.com/[EMAIL PROTECTED]/msg00633.html)
Guillaume Godart a écrit :
Could anybody tell me what means those 6 digit ?
UDH = 0B 05 04 0B84 23F0 0003AD 08 04
0B : 11
/smsbox.c
Hunk #2 FAILED at 2142.
1 out of 2 hunks FAILED -- saving rejects to file gw/smsbox.c.rej
Please rebase your patch and resend...
Thanks,
Alex
Vincent CHAVANIS schrieb:
yep, i omit the ; after the returnerror line
due to a copy/paste error
Fixed on this version.
Vincent.
Alexander
definitively ++1
Vincent.
Stipe Tolj a écrit :
Hi list,
we have a possible bug situation in the gw/dlr_mysql.c module,
especially for the dlr_mysql_add() function:
We perform an INSERT into the table space with the values provided in
dlr_entry struct. The field entry-source is the source
Hi andreas,
Andreas Fink a écrit :
On 05.08.2008, at 12:17, Vincent CHAVANIS wrote:
\
- (time(NULL) (PRIVDATA(conn)-last_activity_time +
PRIVDATA(conn)-keepalive)))
+ (time(NULL) = (PRIVDATA(conn)-last_activity_time +
PRIVDATA(conn
Hi all,
A bug still exists on the UCP/EMI driver.
-Keepalive was wrong because the sender thread was awaken keepalive + 1
When you set keepalive=5 you will in reality have keepalive=6
-Then, the patch also fixes the UCP31 at login.
We don't need to send it beacause UCP60 already make an
Andreas Fink a écrit :
On 05.08.2008, at 12:57, Vincent CHAVANIS wrote:
} else if (emimsg-ot == 31) {
+PRIVDATA(conn)-last_activity_time = time
(NULL); /* XXX Process error codes here
if (octstr_get_char(emimsg
Hi all
Any other comments for this (needed) patch ?
Vincent CHAVANIS a écrit :
++1.
X.25 protocol is quite old, that means system will also be old.
And that means we need to support most of these.
FYI, POSIX.1 define at least B57600.
Vincent
Bostock James a écrit :
From: Vincent
++1.
X.25 protocol is quite old, that means system will also be old.
And that means we need to support most of these.
FYI, POSIX.1 define at least B57600.
Vincent
Bostock James a écrit :
From: Vincent CHAVANIS
Sent: 10 July 2008 18:06
I'm +0 as it.
The fact is that we need to choose
Yeah, i'm also suprised !!!
(X25 is dead, long live TCP/IP ! )=)
The EMI patch looks good but, we need to check if everything goes fine
in changing speed.
!--
ret = tcsetattr(fd, TCSANOW, tios);
if (ret == -1) {
error(errno, EMI[X25]: at_dial: fail to set termios
Stipe Tolj a écrit :
Vincent: so a +1 for committing to CVS?
yes +1 for me.
Vincent.
--
Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
Service Technique/Reseau - NOC
Direction du Developpement xMS+
http://www.telemaque.fr/
[EMAIL PROTECTED]
Tel : +33 4 92 90 99 84 (fax 9142)
As no objections here,
Thanks to commit it.
Vincent CHAVANIS a écrit :
done.
- Original Message - From: Stipe Tolj [EMAIL PROTECTED]
Cc: devel@kannel.org; Vincent CHAVANIS [EMAIL PROTECTED]
Sent: Thursday, May 22, 2008 1:40 PM
Subject: Re: [PATCH] Minor Issue when alt-host is set
done.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
Cc: devel@kannel.org; Vincent CHAVANIS [EMAIL PROTECTED]
Sent: Thursday, May 22, 2008 1:40 PM
Subject: Re: [PATCH] Minor Issue when alt-host is set on EMI/UCP
Alexander Malysh schrieb:
hi,
++1, sorry unable to commit
Hi all,
Here is a minor fix to get the real name of the connection
when alt-host is set. (especially for the web status)
Without this patch, we will get the primary hostname
even if we are connected to the alt-host
Vincent.
diff -rauw /gateway-cvs/gw/smsc/smsc_emi.c
(null));
mutex_unlock(conn-flow_mutex);
bb_smscconn_connected(conn);
return server;
- Original Message -
From: Vincent CHAVANIS [EMAIL PROTECTED]
To: devel@kannel.org
Sent: Tuesday, May 06, 2008 4:33 PM
Subject: [PATCH] Minor Issue when alt-host is set on EMI/UCP
you're right...
It's not very clear in the code though :-)
I did not see it at the fist time.
Vincent.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
To: Vincent CHAVANIS [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Friday, April 11, 2008 3:16 PM
Subject: Re: [PATCH] wapbox
Hi all,
Is there any reasons why we load ssl config
into wapbox without checking if we HAVE_LIBSSL ?
We do not want to load unused variables.
here is a patch that fix this.
any comments ?
Vincent.
diff -rauw /gateway-cvs/gw/wapbox.c /gateway/gw/wapbox.c
--- /gateway-cvs/gw/wapbox.c
+1 for me!
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
To: devel@kannel.org
Sent: Friday, March 14, 2008 2:42 AM
Subject: [REQ] CVS write permission for Alejandro (for his 'membox' project)
Hi core group,
I'd like to advocate for CVS permission for Alejandro Guerrieri
yep,
ok for me.
Vincent.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
To: Andreas Fink [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Tuesday, February 05, 2008 1:27 PM
Subject: Re: [PATCH] empty msg-sms.sender support
Andreas Fink schrieb:
how about using empty string
Yep,
But UCP 01 is stated as legacy operation.
And should be remove in the future version of the UCP protocol.
This has been keeped for backward compatibility.
Vincent.
- Original Message -
From: Andreas Fink [EMAIL PROTECTED]
To: Stipe Tolj [EMAIL PROTECTED]; devel Devel
Specs 4.6 says that these fileds (oadc, adc) are only mendatory.
IMO, NULL or empty will result in writing the same way the request.
Vincent.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Friday, February 01, 2008 2:19 PM
Subject: Re: [PATCH]
/CD
And will probably result as an SMSC error as Andreas said as OADC and ADC is
mandatory.
Vincent.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Friday, February 01, 2008 3:01 PM
Subject: Re: [PATCH] empty msg-sms.sender support
Vincent
ok,
will try to provide something soon.
Vincent.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
To: Vincent CHAVANIS [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Saturday, January 12, 2008 8:00 PM
Subject: Re: [PATCH] Include milliseconds in logging
Vincent CHAVANIS
Why do we need this ?
As we don't need to change it at start as we are not/are using localtime at
start
Vincent.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
To: Vincent CHAVANIS [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Thursday, January 10, 2008 5:23 PM
Subject: Re
.
- Original Message -
From: Stipe Tolj [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Friday, January 11, 2008 4:37 PM
Subject: Re: [PATCH] Include milliseconds in logging
Vincent CHAVANIS schrieb:
Why do we need this ?
As we don't need to change it at start as we are not/are using localtime
]
To: Vincent CHAVANIS [EMAIL PROTECTED]
Cc: devel@kannel.org
Sent: Thursday, November 29, 2007 10:50 PM
Subject: Re: Include miliseconds in logging
Vincent CHAVANIS schrieb:
I thought about a macro :-)
a pre-processdor macro is resolved at compile time, so this is same as at
configure time
1 - 100 of 221 matches
Mail list logo