: [PATCH] custom MO Parameters for smsc-http
ups fixed :D
http://www.blogalex.com/wp-content/uploads/2009/06/kannel-http
-mo-params2.patch
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 15:40, Alejandro Guerrieri wrote:
Oh, yes, sorry :D
I'd rather
Hi,
do I understand right that Claro use GET for MO and XML Post for DLR?
Thanks,
Alex
Am 23.06.2009 um 17:59 schrieb Franck LAMASUTA:
Hi all,
I'm still trying to use the generic code for our Claro HTTP
connection...
The attached table describes how it works currently with all
-
From: Alexander Malysh [mailto:malys...@googlemail.com] On
Behalf Of Alexander Malysh
Sent: Wednesday, June 24, 2009 11:20 AM
To: f.lamas...@cobratelematics.com
Cc: devel@kannel.org
Subject: Re: [PATCH] custom MO Parameters for smsc-http
Hi,
do I understand right that Claro use GET
:53:10 +0200
From: Alejandro Guerrieri aguerri...@kannel.org
Subject: Re: [PATCH] custom MO Parameters for smsc-http
To: f.lamas...@cobratelematics.com
Cc: devel@kannel.org devel@kannel.org
Message-ID: 20ea24af-3ed4-4957-bf45-3f7f9eac1...@kannel.org
Content-Type: text/plain; charset=us-ascii; Format
Hi all,
I'm still trying to use the generic code for our Claro HTTP connection...
The attached table describes how it works currently with all protocols. It
highlights some issues.
a) Clickatell variables
This protocol uses some variables which are not available in the generic part:
charge,
] custom MO Parameters for smsc-http
Me too, second one is far more flexible and clean.
--
Alejandro Guerrieri
aguerri...@kannel.org
On 10/06/2009, at 14:31, Alexander Malysh wrote:
Hi,
I'm for the second idea, regex rocks ;)
Thanks,
Alex
Am 10.06.2009 um 12:37 schrieb Franck LAMASUTA:
It's
@kannel.org
Subject: Re: [PATCH] custom MO Parameters for smsc-http
+1 with the changes Alex proposed. I'd rename
ack_foreign_id_regex as
well, for clarity's sake.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 22/06/2009, at 12:26, Alexander Malysh wrote:
Hi,
patch looks
Here is the new version...
-Original Message-
From: devel-boun...@kannel.org
[mailto:devel-boun...@kannel.org] On Behalf Of Franck LAMASUTA
Sent: Monday, June 22, 2009 4:53 PM
To: devel@kannel.org
Subject: RE: [PATCH] custom MO Parameters for smsc-http
Thanks for your comments
-boun...@kannel.org] On Behalf Of Franck LAMASUTA
Sent: Monday, June 22, 2009 4:53 PM
To: devel@kannel.org
Subject: RE: [PATCH] custom MO Parameters for smsc-http
Thanks for your comments.
First comment regarding the variable name:
The new variable is closely related to status-success-regex
which
-
From: Alejandro Guerrieri [mailto:aguerri...@kannel.org]
Sent: Wednesday, June 10, 2009 3:08 PM
To: Alexander Malysh
Cc: f.lamas...@cobratelematics.com;devel@kannel.org
Subject: Re: [PATCH] custom MO Parameters for smsc-http
Me too, second one is far more flexible and clean
FYI, I've also commited the fix for kannel_receive_sms (removed the
dlrurl condition).
I've also added test/test_date and utils/decode_emimsg to .cvsignore.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 19:05, Alejandro Guerrieri wrote:
Commited to CVS.
It's not so urgent but I could try, it could be interesting...
I have 2 ideas so far...
First idea
==
I could add 2 new config parameters to define 2 regex:
- the first one, to find the start of the foreign id.
- the second one, to find the end of the foreign id.
For Claro, they could
Hi,
I'm for the second idea, regex rocks ;)
Thanks,
Alex
Am 10.06.2009 um 12:37 schrieb Franck LAMASUTA:
It's not so urgent but I could try, it could be interesting...
I have 2 ideas so far...
First idea
==
I could add 2 new config parameters to define 2 regex:
- the first one,
Me too, second one is far more flexible and clean.
--
Alejandro Guerrieri
aguerri...@kannel.org
On 10/06/2009, at 14:31, Alexander Malysh wrote:
Hi,
I'm for the second idea, regex rocks ;)
Thanks,
Alex
Am 10.06.2009 um 12:37 schrieb Franck LAMASUTA:
It's not so urgent but I could try,
Ok, here's a new version of my patch to add support for custom MO
parameters on the generic http-smsc.
New features:
1. Support for setting the numeric response code for successful and
failed requests (as it is now, it always returns 202 HTTP_ACCEPTED).
2. Support for setting the text
Hi,
Seems you don't handle charset at all. Do you assume to receive UTF-8
in any case? I don't think it's
applicable to generic interface. At least alt-charset should be taken
in account...
some comments to patch below...
why is dlrurl required for DLR? We have dlrurl stored in DLR
Alex,
Commenting inline below.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 10:44, Alexander Malysh wrote:
Hi,
Seems you don't handle charset at all. Do you assume to receive
UTF-8 in any case? I don't think it's
applicable to generic interface. At least
Am 09.06.2009 um 11:05 schrieb Alejandro Guerrieri:
Alex,
Commenting inline below.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 10:44, Alexander Malysh wrote:
Hi,
Seems you don't handle charset at all. Do you assume to receive
UTF-8 in any case? I don't
Alex,
Regarding the charsets, I agree it's better to tackle it now that
leave it for later (aka, never ;) ).
I'm fixing the charset issue and the dlr bugs and resending later.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 11:17, Alexander Malysh wrote:
Am
Am 09.06.2009 um 11:23 schrieb Alejandro Guerrieri:
Alex,
Regarding the charsets, I agree it's better to tackle it now that
leave it for later (aka, never ;) ).
I'm fixing the charset issue and the dlr bugs and resending later.
thanks alex!
Regards,
--
Alejandro Guerrieri
Ok, done!
http://www.blogalex.com/wp-content/uploads/2009/06/kannel-http-mo-params1.patch
I've fixed the dlr-url bug _only_ on the generic part. If no
objections, I'm doing a second patch to fix it on the kannel smsc
(since it's in fact a separate issue).
I've also fixed a small glitch on
only one last thing:
+msg-sms.account = octstr_duplicate(account);
+msg-sms.binfo = octstr_duplicate(binfo);
+if (ret == -1) {
+retmsg = octstr_create(Not accepted);
+retstatus = fm-status_error;
+} else {
+retmsg =
Yes, I have to move that afterwards, otherwise the
urltrans_fill_escape_codes call would panic:
2009-06-09 12:46:13 [15580] [6] PANIC: gwlib/octstr.c:2488:
seems_valid_real: Assertion `ostr-len = 0' failed. (Called from
gwlib/octstr.c:1552:octstr_split_words.)
...
2009-06-09 12:46:13
Oh, yes, sorry :D
I'd rather duplicate the msg...
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 15:38, Alejandro Guerrieri wrote:
Yes, I have to move that afterwards, otherwise the
urltrans_fill_escape_codes call would panic:
2009-06-09 12:46:13 [15580] [6] PANIC:
ups fixed :D
http://www.blogalex.com/wp-content/uploads/2009/06/kannel-http-mo-params2.patch
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 15:40, Alejandro Guerrieri wrote:
Oh, yes, sorry :D
I'd rather duplicate the msg...
--
Alejandro Guerrieri
now it's perfect ;)
would you like to commit or should I commit it?
Thanks,
Alex
Am 09.06.2009 um 16:06 schrieb Alejandro Guerrieri:
ups fixed :D
http://www.blogalex.com/wp-content/uploads/2009/06/kannel-http-mo-params2.patch
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On
I'll do it, no problem.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 16:30, Alexander Malysh wrote:
now it's perfect ;)
would you like to commit or should I commit it?
Thanks,
Alex
Am 09.06.2009 um 16:06 schrieb Alejandro Guerrieri:
ups fixed :D
Hi Alejandro ,
I work with Hervé who posted to this list the 25th of May (Claro http
communication).
It seems the patch you've done on the generic part could be very useful for us
to manage our communications with Claro. It could be better than a specific
implementation for Claro.
However, I
Franck,
The dlr part is inherited from the kannel smsc format. In the actual
implementation there's no way to grab the remote message id from a
request, and it'd make a lot of sense to be able to do it.
I can try adding it, but don't refrain to do it so yourself if you
feel the urge
Am 09.06.2009 um 17:55 schrieb Alejandro Guerrieri:
Franck,
The dlr part is inherited from the kannel smsc format. In the
actual implementation there's no way to grab the remote message id
from a request, and it'd make a lot of sense to be able to do it.
I can try adding it, but don't
Commited to CVS.
Regards,
--
Alejandro Guerrieri
aguerri...@kannel.org
On 09/06/2009, at 16:30, Alexander Malysh wrote:
now it's perfect ;)
would you like to commit or should I commit it?
Thanks,
Alex
Am 09.06.2009 um 16:06 schrieb Alejandro Guerrieri:
ups fixed :D
Hi,
here some comments...
in generic_receive_sms you first receive all values than converts it
and only
after this done check authorization. Make no sense... first check auth
then convert anything.
+else if (from == NULL || to == NULL || text == NULL) {
+
+error(0, HTTP[%s]:
Ok, makes sense, I'll do the mods and resend.
PS: I usually wait until there's some acceptance for the patch to
write the userguide part, my next version will definitely come with
his userguide patch bundled ;)
--
Alejandro Guerrieri
aguerri...@kannel.org
On 01/06/2009, at 22:50,
HI,
I've finished my patch to configure the parameter names for MO on the
generic http-smsc.
To use it you just add a few entries on the smsc definition, only with
the parameters you want to rename.
e.g:
generic-param-from = phoneNumber
generic-param-to = shortCode
generic-param-text =
34 matches
Mail list logo
