Re: [PATCH 2/2] staging/tidspbridge: use module_platform_driver

2012-07-24 Thread Ramirez Luna, Omar
On Sat, Jul 21, 2012 at 3:56 AM, Devendra Naga develkernel412...@gmail.com wrote: the code under _init and _exit does platform_driver_register and platform_driver_unregister respectively only, so its better to use the module_platform_driver than just replicating the module_platform_driver's

Re: [PATCH NEXT]staging tidspbridge Fix typos.

2012-07-23 Thread Ramirez Luna, Omar
Hi Justin, On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock justinmatt...@gmail.com wrote: diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c index f9609ce..2c82d5a 100644 --- a/drivers/staging/tidspbridge/core/tiomap3430.c +++

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-14 Thread Ramirez Luna, Omar
On Tue, Feb 14, 2012 at 10:23 AM, Felipe Contreras felipe.contre...@gmail.com wrote: When that case is applicable, we should first modify the loader code or prepare the baseimages to be common so we can get rid of specific loaders and just dump them into memory. I'd say the less workarounds,

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-13 Thread Ramirez Luna, Omar
On Feb 11, 2012 3:03 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Feb 11, 2012 at 9:19 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Feb 10, 2012 12:44 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Feb 10, 2012 at 10:35 PM, Dan Carpenter

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-13 Thread Ramirez Luna, Omar
On Thu, Feb 9, 2012 at 9:18 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote: Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Again, I'm totally confused as to _WHY_ this needs to be y

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-09 Thread Ramirez Luna, Omar
Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Again, I'm totally confused as to _WHY_ this needs to be y.  What is causing this oops without it?  If an oops is happening, then shouldn't this be a strict dependancy?  Why allow it to be disabled at all if

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-01 Thread Ramirez Luna, Omar
On Wed, Feb 1, 2012 at 2:11 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Feb 1, 2012 at 5:22 AM, Justin P. Mattock justinmatt...@gmail.com wrote: not sure if I see this warning or not on my machine, but is there a fix for the warning? I would rather see that, than hide it

Re: [PATCH 2/2] staging: tidspbridge: fix incorrect free to drv_datap

2012-01-31 Thread Ramirez Luna, Omar
On Tue, Jan 31, 2012 at 2:21 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Mon, Jan 30, 2012 at 07:20:18PM -0600, Omar Ramirez Luna wrote: This structure is still used after it has been freed, since it is being allocated in probe, calls to free it have been moved to module's remove

Re: [PATCH 1/5] staging: tidspbridge: more readable code

2012-01-30 Thread Ramirez Luna, Omar
2012/1/24 Felipe Contreras felipe.contre...@gmail.com: 2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: Uppercase function names are not pretty. Also the code flow readability is enhanced. Looks good to me. FWIW, I agree. Regards, Omar ___

Re: [PATCH 2/5] staging: tidspbridge: remove unused header

2012-01-30 Thread Ramirez Luna, Omar
2012/1/24 Felipe Contreras felipe.contre...@gmail.com: 2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: No functional changes. The header file drv_interface.h was only used locally, hence there's no need to have it. Also the only prototyped functions were the file_operations

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Ramirez Luna, Omar
2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: No functional changes. According to Lindent, the file drv_internface.c had some lines with bad indentation. This commit is the output of Lindent. Usually lindent tends to do whatever it wants, unless carefully configured... ... @@

Re: [PATCH 4/5] staging: tidspbridge: silence the compiler

2012-01-30 Thread Ramirez Luna, Omar
2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: Silence the warning when compiling drv_interface.c Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com ---  drivers/staging/tidspbridge/rmgr/drv_interface.c |    5 +++--  1 files changed, 3 insertions(+), 2 deletions(-) diff

Re: [PATCH] tidspbridge: Rename module from bridgedriver to tidspbridge

2012-01-30 Thread Ramirez Luna, Omar
On Tue, Jan 24, 2012 at 3:25 PM, Joe Perches j...@perches.com wrote: tidspbridge when built as a module is named bridgedriver. bridgedriver is not a particularly good module name. tidspbridge is what the source is named.  That seems a more appropriate module name too as it describes the

Re: [PATCH v2] staging: tidspbridge: request dmtimer clocks on init

2011-12-10 Thread Ramirez Luna, Omar
On Fri, Dec 9, 2011 at 4:38 PM, Greg KH g...@kroah.com wrote: How about for 3.2.1?  I'll try to get this into 3.2, but I can't guarantee anything so late in the release cycle, sorry. Sounds fair, fingers crossed for 3.2 ;) Thanks, Omar ___ devel

Re: [PATCH v2] staging: tidspbridge: request dmtimer clocks on init

2011-12-08 Thread Ramirez Luna, Omar
On Wed, Dec 7, 2011 at 4:11 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna omar.rami...@ti.com wrote: Given that dm timer framework doesn't support request of clocks by soft | hard irqs because some recent changes, tidspbridge needs

Re: [PATCH v2] staging: tidspbridge: request dmtimer clocks on init

2011-12-08 Thread Ramirez Luna, Omar
On Thu, Dec 8, 2011 at 2:11 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Nov 19, 2011 at 12:18 AM, Omar Ramirez Luna omar.rami...@ti.com wrote: Given that dm timer framework doesn't support request of clocks by soft | hard irqs because some recent changes, tidspbridge needs

Re: [PATCH v2] staging: tidspbridge: request dmtimer clocks on init

2011-12-08 Thread Ramirez Luna, Omar
On Thu, Dec 8, 2011 at 6:07 PM, Greg KH g...@kroah.com wrote: Definitely 3.2-fix material IMO :) I believe it was pushed to staging-next... I'm rooting so it can be pushed to staging-linus :) As it wasn't originally stated that this was a problem that needed to be fixed for 3.2, can it

Re: [PATCH] staging: tidspbridge: request dmtimer clocks on init

2011-11-18 Thread Ramirez Luna, Omar
Hi Greg, On Fri, Nov 18, 2011 at 3:54 PM, Omar Ramirez Luna omar.rami...@ti.com wrote: diff --git a/drivers/staging/tidspbridge/core/dsp-clock.c b/drivers/staging/tidspbridge/core/dsp-clock.c index 3d1279c..1ba10ae 100644 --- a/drivers/staging/tidspbridge/core/dsp-clock.c +++

Re: [PATCH v4 0/6] staging tidspbridge: iommu migration

2011-05-03 Thread Ramirez Luna, Omar
On Tue, May 3, 2011 at 12:55 PM, Greg KH g...@kroah.com wrote: On Thu, Apr 28, 2011 at 10:31:46AM -0500, Omar Ramirez Luna wrote: DO-NOT-APPLY to staging yet. Then don't send them to me :) Not a problem. Thanks, Omar ___ devel mailing list

Re: [PATCH v4 0/6] staging tidspbridge: iommu migration

2011-05-03 Thread Ramirez Luna, Omar
Hi Arnd, On Tue, May 3, 2011 at 3:18 PM, Arnd Bergmann a...@arndb.de wrote: On Thursday 28 April 2011 17:31:46 Omar Ramirez Luna wrote: Rework and rebase of the previous set of patches for iommu migration[1]. Reorganized the patches to avoid several iterations to change the same code.

Re: [GIT PULL] staging: tidspbridge for 2.6.39

2011-02-04 Thread Ramirez Luna, Omar
Hi, On Fri, Feb 4, 2011 at 3:10 PM, Greg KH g...@kroah.com wrote: On Tue, Feb 01, 2011 at 02:13:04PM -0600, Omar Ramirez Luna wrote: The following changes since commit c56eb8fb6dccb83d9fe62fd4dc00c834de9bc470:   Linux 2.6.38-rc1 (2011-01-18 15:14:02 -0800) are available in the git

Re: [PATCH 00/12]staging:tidspbridge - Remove hungarian notation from structures

2011-01-27 Thread Ramirez Luna, Omar
On Mon, Jan 17, 2011 at 9:19 PM, Armando Uribe x0095...@ti.com wrote: This series of patches remove the hungarian notation from the structure's elements. Also the whole patch series has been rebased to the latest of tidspbridge tree, and minor corrections were made from the original version

Re: [PATCH 0/2] staging: tidspbridge for 2.6.38

2011-01-19 Thread Ramirez Luna, Omar
Hi Greg, On Thu, Jan 13, 2011 at 11:34 PM, Omar Ramirez Luna omar.rami...@ti.com wrote: Set of important changes for 2.6.38, to fix a critical bug (1) and a compile break (2). Guzman Lugo, Fernando (1):  staging: tidspbridge: configure full L1 MMU range Omar Ramirez Luna (1):  staging:

Re: [PATCH 2/2] staging: tidspbridge: replace mbox callback with notifier_call

2011-01-14 Thread Ramirez Luna, Omar
On Thu, Jan 13, 2011 at 11:34 PM, Omar Ramirez Luna omar.rami...@ti.com wrote: Lately, mailbox callbacks have been replaced by notifier block call chains, this needs to be changed in the users of mailbox, otherwise compilation will break due to missing parameters. Please hold on applying this

Re: [PATCHv2] staging: tidspbridge: configure full L1 MMU range

2011-01-13 Thread Ramirez Luna, Omar
Hi, On Wed, Jan 5, 2011 at 3:25 PM, Fernando Guzman Lugo fernando.l...@ti.com wrote: From: Guzman Lugo, Fernando fernando.l...@ti.com IVA MMU can manage up to 4GB of address space through its page tables, given that it's L1 is divided into 1MB sections it requires at least 16KB for its table

Re: [PATCH] staging: tidspbridge: replace mbox callback with notifier_call

2011-01-13 Thread Ramirez Luna, Omar
On Wed, Jan 5, 2011 at 4:55 PM, Omar Ramirez Luna omar.rami...@ti.com wrote: Lately, mailbox callbacks have been replaced by notifier block call chains, this needs to be changed in the users of mailbox, otherwise compilation will break due to missing parameters. Reported-by: Hari Kanigeri

Re: [PATCH] staging: tidspbridge - configure full L1 MMU range

2011-01-05 Thread Ramirez Luna, Omar
Hi, On Wed, Jan 5, 2011 at 12:20 AM, Fernando Guzman Lugo fernando.l...@ti.com wrote: Otherwise a virtual address beyond of the L1 size is used, the MMU hardware will look into a memory that does not belong to L1 translation tables. IOW; the MMU would allow to access any memory, configured or

Re: [GIT PULL] staging: tidspbridge for 2.6.38

2011-01-05 Thread Ramirez Luna, Omar
On Wed, Jan 5, 2011 at 3:18 PM, Greg KH g...@kroah.com wrote: On Fri, Dec 24, 2010 at 02:15:43AM -0600, Omar Ramirez Luna wrote: Hi Greg, This is the first pull request of changes for tidspbridge driver for 2.6.38, I expect to make another request with at least one bug fix, but in the mean

Re: [PATCH] staging: tidspbridge: remove file handling functions for loader

2010-12-10 Thread Ramirez Luna, Omar
On Wed, Dec 8, 2010 at 5:49 PM, Greg KH g...@kroah.com wrote: BTW, I don't expect this pushed through staging yet, I need to include it to my branch first and then I'll send a pull request with the pile of patches. Sorry for the misunderstanding and thanks for the review. Well, don't send me

Re: [PATCH] staging: tidspbridge: remove file handling functions for loader

2010-12-08 Thread Ramirez Luna, Omar
Hi, On Wed, Dec 8, 2010 at 4:26 PM, Greg KH g...@kroah.com wrote: On Tue, Dec 07, 2010 at 12:09:06AM -0600, Omar Ramirez Luna wrote: Instead use request_firmware and friends to get a valid firmware image. Right now the image is supplied dynamically through udev and the following rule:

Re: [PATCH] staging: tidspbridge: remove file handling functions for loader

2010-12-08 Thread Ramirez Luna, Omar
On Wed, Dec 8, 2010 at 5:08 PM, Greg KH g...@kroah.com wrote: On Wed, Dec 08, 2010 at 05:02:20PM -0600, Ramirez Luna, Omar wrote: Hi, On Wed, Dec 8, 2010 at 4:26 PM, Greg KH g...@kroah.com wrote: On Tue, Dec 07, 2010 at 12:09:06AM -0600, Omar Ramirez Luna wrote: Instead use

Re: [PATCH] staging: tidspbridge: overwrite DSP error codes

2010-12-06 Thread Ramirez Luna, Omar
On Wed, Nov 3, 2010 at 7:31 PM, Rene Sapiens rene.sapi...@ti.com wrote: When calling the DSP's remote functions, the DSP returns error codes different from the ones managed by the kernel, the function's return value is shared with the MPU using a shared structure. This patch overwrites those

RE: OMAP3 DSP MMU fault + off mode issue

2010-09-15 Thread Ramirez Luna, Omar
venki kaps wrote: ... My problem is resolved.GPtimer7 was not reset during the MMU FAULT occurrence before the first power cycle. So this pending interrupt is preventing the system sleep entry. Now it works fine after resetting Gptimer7 in pm suspend path. That's doesn't sound right, why