[PATCH] staging: ozwpan: Change Maintainer

I will be not able to work on ozwpan driver anymore. Remove my name add Tateno as maintainer. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- MAINTAINERS |2 +- drivers/staging/ozwpan/TODO |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] staging/ozwpan: formatting coding style

/ozpd.h index 56e6fdf..ad5fe7a 100644 --- a/drivers/staging/ozwpan/ozpd.h +++ b/drivers/staging/ozwpan/ozpd.h @@ -22,7 +22,7 @@ #define OZ_TIMER_HEARTBEAT2 #define OZ_TIMER_STOP 3 -/* +/* *External spinlock variable */ extern spinlock_t g_polling_lock; Acked-by: Rupesh

Re: [PATCH 2/3] staging/ozwpan: coding style __constant_

); Acked-by: Rupesh Gujare rupesh.guj...@atmel.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

= container_of(e, struct oz_pd, link); - memcpy(addr[count++], pd-mac_addr, ETH_ALEN); + ether_addr_copy(addr[count++], pd-mac_addr); } spin_unlock_bh(g_polling_lock); return count; Acked-by: Rupesh Gujare rupesh.guj...@atmel.com

Re: [PATCH] drivers:staging:ozwpan Replaced wrapper functions with actual spin lock function

oz_pd *pd); -void oz_polling_lock_bh(void); -void oz_polling_unlock_bh(void); void oz_pd_heartbeat_handler(unsigned long data); void oz_pd_timeout_handler(unsigned long data); enum hrtimer_restart oz_pd_heartbeat_event(struct hrtimer *timer); Acked-by: Rupesh Gujare rupesh.guj...@atmel.com

[v2 PATCH 1/3] staging: ozwpan: Increase ISOC IN buffer depth

Buffer depth of 50 units is not sufficient when there is considerable delay occuring on air due to interference, increase ISOC IN buffer depth to 100 units. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 file changed, 1 insertion(+), 1

[v2 PATCH 2/3] staging: ozwpan: Change error number.

Incorrect error number was returned here (EPERM), ENXIO is more appropriate. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozcdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan

[v2 PATCH 3/3] staging: ozwpan: Return error, if PD is not connected.

Return error if we receive write(), while PD is not connected. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozcdev.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 50722ea

[PATCH 2/4] staging: ozwpan: Reset PORT_ENABLE bit.

Reset PORT_ENABLE bit of port status on loosing PD. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index b0398c5

Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

On 23/08/13 10:05, Dan Carpenter wrote: On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote: +/*-- * Context: softirq-serialized */ Don't resend the patch, but these comments are not in kernel style

[PATCH 2/3] staging: ozwpan: Fix wrong error check.

schedule_work() returns true if succeeded false on failure, error check was doing exactly reverse. Also removes extra variable. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozpd.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 2/6] staging: ozwpan: Convert hard coded value to Macro

Use macro instead of hard coded value for readability. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 83ed64c

[PATCH 4/6] staging: ozwpan: change variable type.

We have icreased interrupt end point buffer size to 512 bytes, Change variable data type to accomodate it. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan

[PATCH 6/6] staging: ozwpan: change max. TX frame size supported.

Max. TX frame size supported is changed to 760 bytes. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozproto.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozproto.h b/drivers/staging/ozwpan/ozproto.h index e532347

[PATCH 1/4] ozwpan: staging: Fix crash for race condition.

Do not allocate a port to new device or process URB when its status is yet to be read. This avoids race condition when USB core read hub status a bit late, while new device tries to acquire port. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |5

[PATCH 3/4] staging: ozwpan: Increment reference counter.

Increment PD reference counter, on every timer event so that we do not loose PD object by mistake. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozproto.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozproto.c

[PATCH 2/4] staging: ozwpan: Check error condition before creating endpoint.

Check if interface number is correct before creating an end point. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 4682d78

[PATCH 2/2] staging: ozwpan: Remove extra variable.

We should not use extra variable just to copy pointer value, renaming parameter name serves pupose removes extra variable. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH 00/10] staging: ozwpan: Coding style fixes

This patch seriese mostly contains coding style fixes removes unneeded variable initialization. Dan Carpenter (1): staging: ozwpan: Separate success failure case for oz_hcd_pd_arrived() Rupesh Gujare (9): staging: ozwpan: Add a blank line between declaraction and code. staging

[PATCH 04/10] staging: ozwpan: Fix coding style.

Put spaces around math operations. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers

[PATCH 03/10] staging: ozwpan: Simply if condition

Making code simpler for readability. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b

[PATCH 05/10] staging: ozwpan: Remove unnecessary pointer check.

We are already checking ep earlier in function. Do not need to check again. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 06/10] staging: ozwpan: Make oz_hcd_pd_arrived() return a struct pointer

oz_hcd_pd_arrived returns struct oz_port *, change function declaration to avoid ambiguity. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |4 ++-- drivers/staging/ozwpan/ozhcd.h |2 +- 2 files

[PATCH 07/10] staging: ozwpan: Make oz_hcd_pd_departed() take a struct pointer.

oz_hcd_pd_departed() takes struct oz_port pointer instead of void *, change function declaration to avoid ambiguity. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |4 ++-- drivers/staging/ozwpan

[PATCH 08/10] staging: ozwpan: Remove unneeded initializers

Remove variable initialization wherever it is not required. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozeltbuf.c |2 +- drivers/staging/ozwpan/ozhcd.c| 18 +- drivers/staging/ozwpan/ozpd.c |4 ++-- 3 files changed, 12

[PATCH 09/10] staging: ozwpan: Swap arguments of oz_ep_alloc() to match kmalloc()

Swap arguments of oz_ep_alloc() to match kmalloc() for better readability. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan

[PATCH 10/10] staging: ozwpan: Separate success failure case for oz_hcd_pd_arrived()

/pipermail/driverdev-devel/2013-August/040113.html Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c | 54 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging

Re: [PATCH 07/10] staging: ozwpan: Make oz_hcd_pd_departed() take a struct pointer.

On 13/08/13 18:35, Sergei Shtylyov wrote: Hello. On 08/13/2013 09:29 PM, Rupesh Gujare wrote: oz_hcd_pd_departed() takes struct oz_port pointer instead of void *, change function declaration to avoid ambiguity. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Rupesh

Re: [PATCH] staging: ozwpan: Fix build warning.

-credit += timespec_to_ns(delta) / NSEC_PER_MSEC; + ep-credit += div64_u64(timespec_to_ns(delta), NSEC_PER_MSEC); Thank you Anca. I will resend the patch. -- Regards, Rupesh Gujare ___ devel mailing list de...@linuxdriverproject.org http

[PATCH v2] staging: ozwpan: Fix build warning.

This patch fixes following build warning. drivers/built-in.o: In function `oz_hcd_heartbeat': (.text+0x30aadd): undefined reference to `__divdi3' drivers/built-in.o: In function `oz_hcd_heartbeat': (.text+0x30ac85): undefined reference to `__divdi3' Signed-off-by: Rupesh Gujare rupesh.guj

[PATCH v2] staging: ozwpan: Fix farewell report.

the remote attacker can just rewrite it using the memcpy() on the next line. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozpd.h|2 +- drivers/staging/ozwpan/ozproto.c |2 +- 2 files changed, 2

[PATCH 1/4] staging: ozwpan: Fixes crash due to invalid port aceess.

This patch fixes kernel crash issue, when we receive URB request after de-enumerating device. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b

[PATCH 2/4] staging: ozwpan: Increment port number for new device.

in unstable system crash. Above issue is resolved by making sure that we always assign new port to new device, making sure that USB core reads correct hub status. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c | 16 +++- 1 file changed, 11

Re: [PATCH 3/4] staging: ozwpan: Reset port configuration number.

On 05/08/13 19:21, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 06:40:14PM +0100, Rupesh Gujare wrote: Make sure that we reset port configuration no. when PD departs. What happens if we don't do this? What is the user visible effect of this patch? There is no user visible effect

Re: [PATCH 5/6] staging: ozwpan: Increase farewell report size.

On 02/08/13 11:27, Dan Carpenter wrote: On Thu, Aug 01, 2013 at 06:45:01PM +0100, Rupesh Gujare wrote: Farewell report size can be bigger than one byte, increase array size to accomodate maximum 32 bytes of farewell report. Gar... No. This is not right. 1) There is no check limiting

[PATCH 0/6] staging: ozwpan: Use Kernel API Bug fixes

This patch series removes duplicate code, replaces it with kernel library functions, and few bug fixes. Rupesh Gujare (6): staging: ozwpan: Use kernel list function for managing interface list. staging: ozwpan: Mark string as const staging: ozwpan: Use kernel strncmp function

Re: [PATCH] staging: ozwpan: Fix coding style.

On 24/07/13 15:06, Rupesh Gujare wrote: This patch fixes coding style issues reported by Dan here:- http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozcdev.c | 15

[PATCH] staging: ozwpan: Fix coding style.

This patch fixes coding style issues reported by Dan here:- http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozcdev.c | 15 --- 1 file changed, 8 insertions(+), 7

Re: [PATCH v2 5/5] staging: ozwpan: Rename Kbuild to Makefile

On 04/07/13 13:35, Rupesh Gujare wrote: From: Joe Perches j...@perches.com Pardon my ignorance, above error occurred while creating patch series. I should had been careful about it. -- Regards, Rupesh Gujare ___ devel mailing list de

Re: [PATCH 7/7] staging/ozwpan: Fix NULL vs zero in ozhcd.c (sparse warning)

Thanks Peter, Looks good to me. Acked-by: Rupesh Gujare rupesh.guj...@atmel.com -- Regards, Rupesh Gujare ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: staging: ozwpan: Added USB HCD implementation

. Staging-next tree with gcc version 4.6.1, do not pop out above warning for me. -- Regards, Rupesh Gujare ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[PATCH] staging:ozwpan: Fix following warning.

Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index b2d77df..9154f33 100644 --- a/drivers/staging/ozwpan/ozhcd.c +++ b

[V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

Call kfree only if required else return from function. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozpd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ozwpan

[V2 PATCH 0/3] staging : ozwpan: Remove NULL pointer check

This patch series removes NULL pointer check before kfree Rupesh Gujare (3): staging: ozwpan: Remove redundant null check before kfree in ozpd.c staging: ozwpan: Remove redundant null check before kfree in ozproto.c staging: ozwpan: Remove redundant null check before kfree in ozhcd.c

[V2 PATCH 3/3] staging: ozwpan: Remove redundant null check before kfree in ozhcd.c

Call kfree only if required else return from function. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozhcd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ozwpan

[V2 PATCH 2/3] staging: ozwpan: Remove redundant null check before kfree in ozproto.c

Free memory if timer pool count OZ_MAX_TIMER_POOL_SIZE Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozproto.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging

Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

On 21/11/12 13:05, Dan Carpenter wrote: On Wed, Nov 21, 2012 at 12:46:15PM +, Rupesh Gujare wrote: Call kfree only if required else return from function. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com I'm not sure this is right

Re: [PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

On 21/11/12 13:09, Dan Carpenter wrote: On Tue, Nov 20, 2012 at 04:18:06PM +, Rupesh Gujare wrote: On 20/11/12 14:16, Dan Carpenter wrote: But more importantly does any of the memory pools code actually make a difference in benchmarks? What is the difference between running

Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

?) for this patch series ? I am more than happy to accept either. -- Regards, Rupesh Gujare ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

On 21/11/12 21:48, Greg KH wrote: On Wed, Nov 21, 2012 at 05:26:12PM +, Rupesh Gujare wrote: On 21/11/12 16:19, Dan Carpenter wrote: When someone sends a patch there are a several possible responses: 1) Ack the patch. 2) Request that the submitter redo it. The downside is that no one

Re: [PATCH 1/1] staging: ozwpan: Include oz_events_clear() conditionally

-missed_events = 0; spin_unlock_irqrestore(dev-lock, irqstate); } -#ifdef CONFIG_DEBUG_FS /*-- * Context: process */ Acked-by: Rupesh Gujarerguj...@ozmodevices.com -- Regards, Rupesh Gujare

Re: [PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

confuses reader about logic flow. 2. We can save few CPU cycles by checking NULL pointer here, rather than relying on kfree(). -- Regards, Rupesh Gujare ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman

Re: [PATCH] staging: ozwpan: remove pointless conditional before kfree_skb()

oz_isoc_stream *st) { - if (st-skb) - kfree_skb(st-skb); + kfree_skb(st-skb); kfree(st); } /*-- Acked-by: Rupesh Gujare rguj...@ozmodevices.com

RE: [staging-next V3] ozwpan: fix memcmp() test in oz_set_active_pd()

From: Tomas Winkler [tomas.wink...@intel.com] Sent: 19 August 2012 17:36 To: gre...@linuxfoundation.org Cc: a...@linux.intel.com; devel@linuxdriverproject.org; kernel-janit...@vger.kernel.org; Tomas Winkler; Dan Carpenter; Rupesh Gujare Subject: [staging

Re: [patch] staging: ozwpan: fix memcmp() test in oz_set_active_pd()

{ - if (!memcmp(addr, \0\0\0\0\0\0, sizeof(addr))) { + if (!memcmp(addr, \0\0\0\0\0\0, ETH_ALEN)) { spin_lock_bh(g_cdev.lock); pd = g_cdev.active_pd; g_cdev.active_pd = 0; -- Regards, Rupesh Gujare

Re: [patch] staging: ozwpan: fix memcmp() test in oz_set_active_pd()

not to use 'if (is_zero_ether_addr()) from linux/etherdevice.h Tom, Thanks for pointing this out, that looks more efficient. Interested in submitting a patch ? Dan, What do you think ? -- Regards, Rupesh Gujare ___ devel mailing list devel

[PATCH 0/5] staging: ozwpan: Various Bug fixes

This patch series fixes various bugs found during development bumps version number to keep it in sync with internal version number. Rupesh Gujare (5): staging: ozwpan: buffer frame if urb not available. staging: ozwpan: Insulate driver from HZ value staging: ozwpan: Return correct

[PATCH 2/5] staging: ozwpan: Insulate driver from HZ value

This patch fixes issue caused due to different HZ value on system which do not have HZ=1000 Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozhcd.c |8 drivers/staging/ozwpan/ozproto.h |2 +- 2 files changed, 5 insertions(+), 5 deletions

[PATCH 3/5] staging: ozwpan: Return correct actual_length to userland

This fixes issue where wrong retrun value was received by userland application after writing data to raw hid device. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozhcd.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH 5/5] staging: ozwpan: Bump version number

Bump version numbers to keep in sync with internal version information. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozmain.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ozwpan/ozmain.c b/drivers/staging/ozwpan

[PATCH 1/5] staging: ozwpan: buffer frame if urb not available.

For interrupt end point buffer frames, if urb is not available give back as soon as urb is received from usb core. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozhcd.c | 67 +-- 1 files changed, 63 insertions(+), 4

[PATCH 4/5] staging: ozwpan: isoc latency for audio burst

Set audio latency. This fixes issue where audio clips heard during link outage. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozpd.c |8 +--- drivers/staging/ozwpan/ozpd.h |1 + drivers/staging/ozwpan/ozproto.c| 13

Re: [PATCH 1/6] staging: ozwpan: ISOC transfer in triggered mode

that following is in-kernel tracing infrastructure ? http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Documentation/trace/tracepoints.txt;h=c0e1ceed75a441b692bf447b3fcdc49d8abdd1cc;hb=HEAD -- Regards, Rupesh Gujare ___ devel

Re: [PATCH 4/6] staging: ozwpan: set last_pkt_nb

On 23/06/12 10:39, Dan Carpenter wrote: On Wed, Jun 20, 2012 at 01:36:09PM +0100, Rupesh Gujare wrote: In case of trigeered ISOC mode set last_pkt_nb only when we are ready to send data. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozpd.c |9

[PATCH 1/3] staging: ozwpan: Unregister with sysfs while unloading.

Destroy device node unregister device class from sysfs while unloading driver Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozcdev.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers

[PATCH 2/3] staging: ozwpan: Fix compilation issue due to export.h

Fixes compilation error caused due to header file. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 251f07c

[PATCH 3/3] staging: ozwpan: Update TODO file

Update TODO file. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/TODO | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ozwpan/TODO b/drivers/staging/ozwpan/TODO index c2d30a7..b5db245 100644 --- a/drivers/staging

Re: [PATCH 2/6] staging: ozwpan: Correct ioctl numbers.

On 21/06/12 00:04, Greg KH wrote: On Wed, Jun 20, 2012 at 01:36:07PM +0100, Rupesh Gujare wrote: ioctl numbers were not in order, rearranging them in ascending order. Signed-off-by: Rupesh Gujarerguj...@ozmodevices.com --- drivers/staging/ozwpan/ozappif.h |6 +++--- 1 files changed, 3

Re: [PATCH 1/6] staging: ozwpan: ISOC transfer in triggered mode

On 21/06/12 00:05, Greg KH wrote: On Wed, Jun 20, 2012 at 01:36:06PM +0100, Rupesh Gujare wrote: This patch implements ISOC frame transfer while PD is in triggered mode. Signed-off-by: Rupesh Gujarerguj...@ozmodevices.com It's great to see new features for this driver, but I really would

[PATCH 0/6] staging: ozwpan: Fixes feature enhancement

Following patch series implements triggered mode ISOC transfer fixes various issues found during development. Rupesh Gujare (6

[PATCH 1/6] staging: ozwpan: ISOC transfer in triggered mode

This patch implements ISOC frame transfer while PD is in triggered mode. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozmain.c |2 +- drivers/staging/ozwpan/ozpd.c | 171 +-- drivers/staging/ozwpan/ozpd.h

[PATCH 4/6] staging: ozwpan: set last_pkt_nb

In case of trigeered ISOC mode set last_pkt_nb only when we are ready to send data. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozpd.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers

[PATCH 2/6] staging: ozwpan: Correct ioctl numbers.

ioctl numbers were not in order, rearranging them in ascending order. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozappif.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ozwpan/ozappif.h b/drivers/staging/ozwpan

[PATCH 3/6] staging: ozwpan: kmalloc flag

Pass right flag as memory is assigned in process context. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozproto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c

[PATCH 5/6] staging: ozwpan: udev support

Register ozmo_wpan class with sysfs support for udev to create device node. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozcdev.c | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ozwpan/ozcdev.c b

[PATCH 6/6] staging: ozwpan: Set AC_VO priority

Set packet priority to AC_VO for audio data. Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com --- drivers/staging/ozwpan/ozpd.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c index 25a8a08..6c287ac

Re: [PATCH] Fix bug where kfree is called twice.

Hi Dan, It's a good patch and it fixes a bug, but could you resend with the subject: [PATCH] Staging: ozwpan: Fix bug where kfree is called twice. Sorry about subject line. I should have spend a bit more time in formatting subject line. However it looks like Greg have already pulled this patch

Re: [PATCH] Fix bug where kfree is called twice.

to queue it up for 3.4 as well ? -- Regards, Rupesh Gujare ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH] Fix bug where kfree is called twice.

Is it possible to queue it up for 3.4 as well ? Yes, now done so. Thanks a lot Greg. :-) -- Regards, Rupesh Gujare ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[PATCH] Fix bug where kfree is called twice.

Signed-off-by: Rupesh Gujare rguj...@ozmodevices.com Signed-off-by: Chris Kelly cke...@ozmodevices.com --- drivers/staging/ozwpan/ozpd.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c index 2b45d3d..04cd57f