[PATCHv13 1/4] debugfs: add get/set for atomic types

2013-06-03 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Acked-by: Mel

[PATCHv13 0/4] zswap: compressed swap caching

2013-06-03 Thread Seth Jennings
-53% %CPU utilization (out of 400% on 4 cpus) N basezswap %change 8 317 319 1% 12 267 311 16% 16 179 191 7% 20 94 143 52% 24 60 128 113% Seth Jennings (4): debugfs: add get/set for atomic types zbud: add to mm

[PATCHv13 3/4] zswap: add to mm/

2013-06-03 Thread Seth Jennings
be moved out of zswap to the swap device so newer pages can be compressed and stored in zswap. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Rik van Riel r...@redhat.com --- mm/Kconfig | 20 ++ mm/Makefile |1 + mm/zswap.c | 943

[PATCHv13 4/4] zswap: add documentation

2013-06-03 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Rik van Riel r...@redhat.com --- Documentation/vm/zswap.txt | 68 1 file changed, 68 insertions(+) create mode

[PATCHv13 2/4] zbud: add to mm/

2013-06-03 Thread Seth Jennings
elements that were ingrained throughout and provide a generic allocation interface that can later be used by zsmalloc and others. This patch adds zbud to mm/ for later use by zswap. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Rik van Riel r...@redhat.com --- include/linux

Re: [PATCHv12 2/4] zbud: add to mm/

2013-05-30 Thread Seth Jennings
On Wed, May 29, 2013 at 02:29:04PM -0700, Andrew Morton wrote: On Wed, 29 May 2013 14:09:02 -0700 (PDT) Dan Magenheimer dan.magenhei...@oracle.com wrote: memory_failure() is merely an example of a general problem: code which reads from the memmap[] array and expects its elements to be

Re: [PATCHv12 2/4] zbud: add to mm/

2013-05-30 Thread Seth Jennings
Andrew, Mel, This struct page stuffing is taking a lot of time to work out and _might_ be fraught with peril when memmap peekers are considered. What do you think about just storing the zbud page metadata inline in the memory page in the first zbud page chunk? Mel, this kinda hurts you plans

Re: [PATCHv12 3/4] zswap: add to mm/

2013-05-29 Thread Seth Jennings
On Tue, May 28, 2013 at 02:59:18PM -0700, Andrew Morton wrote: On Mon, 20 May 2013 11:26:07 -0500 Seth Jennings sjenn...@linux.vnet.ibm.com wrote: zswap is a thin backend for frontswap that takes pages that are in the process of being swapped out and attempts to compress them and store

Re: [PATCHv12 2/4] zbud: add to mm/

2013-05-29 Thread Seth Jennings
On Tue, May 28, 2013 at 02:59:11PM -0700, Andrew Morton wrote: On Mon, 20 May 2013 11:26:06 -0500 Seth Jennings sjenn...@linux.vnet.ibm.com wrote: zbud is an special purpose allocator for storing compressed pages. It is designed to store up to two compressed pages per physical page

Re: [PATCHv12 3/4] zswap: add to mm/

2013-05-29 Thread Seth Jennings
On Wed, May 29, 2013 at 11:29:29AM -0700, Andrew Morton wrote: On Wed, 29 May 2013 09:57:20 -0500 Seth Jennings sjenn...@linux.vnet.ibm.com wrote: +/* +* helpers +**/ +static inline bool zswap_is_full(void

Re: [PATCHv12 3/4] zswap: add to mm/

2013-05-29 Thread Seth Jennings
On Wed, May 29, 2013 at 12:57:47PM -0700, Andrew Morton wrote: On Wed, 29 May 2013 14:50:27 -0500 Seth Jennings sjenn...@linux.vnet.ibm.com wrote: On Wed, May 29, 2013 at 11:29:29AM -0700, Andrew Morton wrote: On Wed, 29 May 2013 09:57:20 -0500 Seth Jennings sjenn

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-20 Thread Seth Jennings
On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: My first guess is that the external fragmentation situation you are referring to is a workload in which all pages compress to greater than half a page. If so

[PATCHv12 0/4] zswap: compressed swap caching

2013-05-20 Thread Seth Jennings
191 179 -6% 20 371 240 -35% 24 570 267 -53% %CPU utilization (out of 400% on 4 cpus) N basezswap %change 8 317 319 1% 12 267 311 16% 16 179 191 7% 20 94 143 52% 24 60 128 113% Seth

[PATCHv12 2/4] zbud: add to mm/

2013-05-20 Thread Seth Jennings
elements that were ingrained throughout and provide a generic allocation interface that can later be used by zsmalloc and others. This patch adds zbud to mm/ for later use by zswap. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Rik van Riel r...@redhat.com --- include/linux

[PATCHv12 1/4] debugfs: add get/set for atomic types

2013-05-20 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Acked-by: Mel

[PATCHv12 3/4] zswap: add to mm/

2013-05-20 Thread Seth Jennings
be moved out of zswap to the swap device so newer pages can be compressed and stored in zswap. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Rik van Riel r...@redhat.com --- mm/Kconfig | 22 +- mm/Makefile | 1 + mm/zswap.c | 947

[PATCHv12 4/4] zswap: add documentation

2013-05-20 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Rik van Riel r...@redhat.com --- Documentation/vm/zswap.txt | 68 ++ 1 file changed, 68 insertions(+) create mode

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-19 Thread Seth Jennings
On Fri, May 17, 2013 at 04:48:37PM +0100, Mel Gorman wrote: On Mon, May 13, 2013 at 07:40:01AM -0500, Seth Jennings wrote: zbud is an special purpose allocator for storing compressed pages. It is designed to store up to two compressed pages per physical page. While this design limits

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-19 Thread Seth Jennings
On Fri, May 17, 2013 at 05:54:18PM +0100, Mel Gorman wrote: On Mon, May 13, 2013 at 07:40:02AM -0500, Seth Jennings wrote: zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them in a compressed memory pool, resulting in an effective

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Seth Jennings
On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote: Sorry, but I don't think that's appropriate for a patch in the MM subsystem. I am heading to the airport shortly so this email is a bit hastily typed. Perhaps a compromise can be reached where this code is merged as a

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 05:19:19PM +0800, Bob Liu wrote: Hi Seth, Hi Bob, thanks for the review! On 05/13/2013 08:40 PM, Seth Jennings wrote: zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them in a compressed memory pool

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Mon, May 13, 2013 at 03:31:42PM -0700, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: [PATCHv11 3/4] zswap: add to mm/ zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 04:47:24PM +0800, Bob Liu wrote: Hi Seth, On 05/13/2013 08:40 PM, Seth Jennings wrote: zbud is an special purpose allocator for storing compressed pages. It is designed to store up to two compressed pages per physical page. While this design limits storage

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 09:37:08AM -0700, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: Re: [PATCHv11 3/4] zswap: add to mm/ On Tue, May 14, 2013 at 05:19:19PM +0800, Bob Liu wrote: Hi Seth, Hi Bob, thanks for the review

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 01:18:48PM -0700, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: Re: [PATCHv11 3/4] zswap: add to mm/ snip +/* The maximum percentage of memory that the compressed pool can occupy */ +static unsigned int

[PATCHv11 2/4] zbud: add to mm/

2013-05-13 Thread Seth Jennings
that zbud can never do harm by using more pages to store zpages than the uncompressed zpages would have used on their own. This patch adds zbud to mm/ for later use by zswap. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/zbud.h | 22 ++ mm/Kconfig | 10

[PATCHv11 3/4] zswap: add to mm/

2013-05-13 Thread Seth Jennings
a true cache in that, once the cache is full or can't grow due to memory pressure, the oldest pages can be moved out of zswap to the swap device so newer pages can be compressed and stored in zswap. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com

[PATCHv11 4/4] zswap: add documentation

2013-05-13 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zswap.txt | 72 1 file changed, 72 insertions(+) create mode 100644 Documentation/vm/zswap.txt diff

[PATCHv11 0/4] zswap: compressed swap caching

2013-05-13 Thread Seth Jennings
basezswap %change 8 317 319 1% 12 267 311 16% 16 179 191 7% 20 94 143 52% 24 60 128 113% Seth Jennings (4): debugfs: add get/set for atomic types zbud: add to mm/ zswap: add to mm/ zswap: add documentation

[PATCHv11 1/4] debugfs: add get/set for atomic types

2013-05-13 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Acked-by: Mel

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-13 Thread Seth Jennings
On Mon, May 13, 2013 at 08:43:36AM -0700, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Sent: Monday, May 13, 2013 6:40 AM Subject: [PATCHv11 2/4] zbud: add to mm/ One comment about a questionable algorithm change (vs my original zbud code) below... I'll

Re: [PATCHv10 1/4] debugfs: add get/set for atomic types

2013-05-09 Thread Seth Jennings
On Thu, May 09, 2013 at 11:58:49AM -0700, Greg Thelen wrote: On Wed, May 08 2013, Seth Jennings wrote: debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Signed

[PATCHv10 0/4] zswap: compressed swap caching

2013-05-08 Thread Seth Jennings
317 319 1% 12 267 311 16% 16 179 191 7% 20 94 143 52% 24 60 128 113% Seth Jennings (4): debugfs: add get/set for atomic types zbud: add to mm/ zswap: add to mm/ zswap: add documentation Documentation/vm/zswap.txt | 72

[PATCHv10 3/4] zswap: add to mm/

2013-05-08 Thread Seth Jennings
a true cache in that, once the cache is full or can't grow due to memory pressure, the oldest pages can be moved out of zswap to the swap device so newer pages can be compressed and stored in zswap. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com

[PATCHv10 4/4] zswap: add documentation

2013-05-08 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zswap.txt | 72 ++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/vm/zswap.txt diff

[PATCHv10 2/4] zbud: add to mm/

2013-05-08 Thread Seth Jennings
that zbud can never do harm by using more pages to store zpages than the uncompressed zpages would have used on their own. This patch adds zbud to mm/ for later use by zswap. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/zbud.h | 22 ++ mm/Kconfig | 10

Re: [PATCHv9 7/8] zswap: add swap page writeback support

2013-04-17 Thread Seth Jennings
On Sun, Apr 14, 2013 at 01:45:28AM +0100, Mel Gorman wrote: On Wed, Apr 10, 2013 at 01:18:59PM -0500, Seth Jennings wrote: This patch adds support for evicting swap pages that are currently compressed in zswap to the swap device. This functionality is very important and make zswap a true

Re: [PATCHv9 4/8] zswap: add to mm/

2013-04-17 Thread Seth Jennings
On Sun, Apr 14, 2013 at 01:45:06AM +0100, Mel Gorman wrote: On Wed, Apr 10, 2013 at 01:18:56PM -0500, Seth Jennings wrote: zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them in a compressed memory pool, resulting in an effective

Re: [PATCHv9 1/8] zsmalloc: add to mm/

2013-04-17 Thread Seth Jennings
any of that then sorry. Great! That means you'll have the most fresh perspective :) I very much appreciate you taking your valuable time to understand and review the code! On Wed, Apr 10, 2013 at 01:18:53PM -0500, Seth Jennings wrote: SNIP Also, zsmalloc allows objects to span page

[PATCHv9 0/8] zswap: compressed swap caching

2013-04-10 Thread Seth Jennings
94 143 52% 24 60 128 113% Seth Jennings (8): zsmalloc: add to mm/ zsmalloc: add documentation debugfs: add get/set for atomic types zswap: add to mm/ mm: break up swap_writepage() for frontswap backends mm: allow for outstanding swap writeback accounting

[PATCHv9 1/8] zsmalloc: add to mm/

2013-04-10 Thread Seth Jennings
noncontigious pages. zsmalloc fulfills the allocation needs for zram and zswap. Acked-by: Nitin Gupta ngu...@vflare.org Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/zsmalloc.h | 56 +++ mm/Kconfig | 24 + mm

[PATCHv9 5/8] mm: break up swap_writepage() for frontswap backends

2013-04-10 Thread Seth Jennings
is to be resumed can be added to the swap cache. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 2 ++ mm/page_io.c | 16 +--- mm/swap_state.c | 2 +- 3 files changed, 16 insertions(+), 4 deletions

[PATCHv9 7/8] zswap: add swap page writeback support

2013-04-10 Thread Seth Jennings
code path is operating on it. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/zswap.c | 530 ++--- 1 file changed, 508 insertions(+), 22 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index db283c4..edb354b 100644 --- a/mm

[PATCHv9 3/8] debugfs: add get/set for atomic types

2013-04-10 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- fs

[PATCHv9 4/8] zswap: add to mm/

2013-04-10 Thread Seth Jennings
this compressed store much more quickly than reading from tradition swap devices resulting in faster performance for many workloads. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/Kconfig | 15 ++ mm/Makefile | 1 + mm/zswap.c | 665

[PATCHv9 8/8] zswap: add documentation

2013-04-10 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zsmalloc.txt | 2 +- Documentation/vm/zswap.txt| 82 +++ 2 files changed, 83 insertions(+), 1 deletion

[PATCHv9 2/8] zsmalloc: add documentation

2013-04-10 Thread Seth Jennings
This patch adds a documentation file for zsmalloc at Documentation/vm/zsmalloc.txt Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zsmalloc.txt | 68 +++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/vm

[PATCHv9 6/8] mm: allow for outstanding swap writeback accounting

2013-04-10 Thread Seth Jennings
the accounting is done. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 4 +++- mm/page_io.c | 12 +++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/include/linux/swap.h b/include/linux

[PATCHv8 0/8] zswap: compressed swap caching

2013-04-04 Thread Seth Jennings
14352% 2460128113% Seth Jennings (8): zsmalloc: add to mm/ zsmalloc: add documentation debugfs: add get/set for atomic types zswap: add to mm/ mm: break up swap_writepage() for frontswap backends mm: allow for outstanding swap writeback accounting

[PATCHv8 1/8] zsmalloc: add to mm/

2013-04-04 Thread Seth Jennings
noncontigious pages. zsmalloc fulfills the allocation needs for zram and zswap. Acked-by: Nitin Gupta ngu...@vflare.org Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/zsmalloc.h | 56 +++ mm/Kconfig | 24 + mm

[PATCHv8 3/8] debugfs: add get/set for atomic types

2013-04-04 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- fs

[PATCHv8 4/8] zswap: add to mm/

2013-04-04 Thread Seth Jennings
this compressed store much more quickly than reading from tradition swap devices resulting in faster performance for many workloads. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/Kconfig | 15 ++ mm/Makefile | 1 + mm/zswap.c | 665

[PATCHv8 7/8] zswap: add swap page writeback support

2013-04-04 Thread Seth Jennings
code path is operating on it. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/zswap.c | 532 ++--- 1 file changed, 510 insertions(+), 22 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index db283c4..ecdb835 100644 --- a/mm

[PATCHv8 5/8] mm: break up swap_writepage() for frontswap backends

2013-04-04 Thread Seth Jennings
is to be resumed can be added to the swap cache. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 2 ++ mm/page_io.c | 16 +--- mm/swap_state.c | 2 +- 3 files changed, 16 insertions(+), 4 deletions

[PATCHv8 6/8] mm: allow for outstanding swap writeback accounting

2013-04-04 Thread Seth Jennings
the accounting is done. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 4 +++- mm/page_io.c | 12 +++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/include/linux/swap.h b/include/linux

[PATCHv8 8/8] zswap: add documentation

2013-04-04 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zswap.txt | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/vm/zswap.txt diff

[PATCHv8 2/8] zsmalloc: add documentation

2013-04-04 Thread Seth Jennings
This patch adds a documentation file for zsmalloc at Documentation/vm/zsmalloc.txt Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zsmalloc.txt | 68 +++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/vm

Re: [PATCHv8 5/8] mm: break up swap_writepage() for frontswap backends

2013-04-04 Thread Seth Jennings
On 04/04/2013 05:10 PM, Seth Jennings wrote: swap_writepage() is currently where frontswap hooks into the swap write path to capture pages with the frontswap_store() function. However, if a frontswap backend wants to resume the writeback of a page to the swap device, it can't call

Re: [PATCHv7 4/8] zswap: add to mm/

2013-03-07 Thread Seth Jennings
On 03/07/2013 01:00 PM, Dave Hansen wrote: On 03/06/2013 07:52 AM, Seth Jennings wrote: +static int __zswap_cpu_notifier(unsigned long action, unsigned long cpu) +{ +struct crypto_comp *tfm; +u8 *dst; + +switch (action) { +case CPU_UP_PREPARE: +tfm

[PATCHv7 0/8] zswap: compressed swap caching

2013-03-06 Thread Seth Jennings
128 113% Seth Jennings (8): zsmalloc: add to mm/ zsmalloc: add documentation debugfs: add get/set for atomic types zswap: add to mm/ mm: break up swap_writepage() for frontswap backends mm: allow for outstanding swap writeback accounting zswap: add swap page writeback support

[PATCHv7 5/8] mm: break up swap_writepage() for frontswap backends

2013-03-06 Thread Seth Jennings
is to be resumed can be added to the swap cache. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 2 ++ mm/page_io.c | 16 +--- mm/swap_state.c | 2 +- 3 files changed, 16 insertions(+), 4 deletions

[PATCHv7 3/8] debugfs: add get/set for atomic types

2013-03-06 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- fs

[PATCHv7 6/8] mm: allow for outstanding swap writeback accounting

2013-03-06 Thread Seth Jennings
the accounting is done. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 4 +++- mm/page_io.c | 12 +++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/include/linux/swap.h b/include/linux

[PATCHv7 2/8] zsmalloc: add documentation

2013-03-06 Thread Seth Jennings
This patch adds a documentation file for zsmalloc at Documentation/vm/zsmalloc.txt Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zsmalloc.txt | 68 +++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/vm

[PATCHv7 7/8] zswap: add swap page writeback support

2013-03-06 Thread Seth Jennings
code path is operating on it. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/zswap.c | 532 ++--- 1 file changed, 512 insertions(+), 20 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index d777e63..9b86ad9 100644 --- a/mm

[PATCHv7 1/8] zsmalloc: add to mm/

2013-03-06 Thread Seth Jennings
noncontigious pages. zsmalloc fulfills the allocation needs for zram and zswap. Acked-by: Nitin Gupta ngu...@vflare.org Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/zsmalloc.h | 56 +++ mm/Kconfig | 24 + mm

[PATCHv7 4/8] zswap: add to mm/

2013-03-06 Thread Seth Jennings
this compressed store much more quickly than reading from tradition swap devices resulting in faster performance for many workloads. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/Kconfig| 15 ++ mm/Makefile | 1 + mm/zsmalloc.c | 2

[PATCHv7 8/8] zswap: add documentation

2013-03-06 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zswap.txt | 82 ++ mm/zswap.c | 17 +- 2 files changed, 90 insertions(+), 9

Re: [PATCHv5 2/8] zsmalloc: add documentation

2013-02-25 Thread Seth Jennings
On 02/23/2013 06:37 PM, Ric Mason wrote: On 02/23/2013 05:02 AM, Seth Jennings wrote: On 02/21/2013 08:56 PM, Ric Mason wrote: On 02/21/2013 11:50 PM, Seth Jennings wrote: On 02/21/2013 02:49 AM, Ric Mason wrote: On 02/19/2013 03:16 AM, Seth Jennings wrote: On 02/16/2013 12:21 AM, Ric Mason

Re: [PATCHv6 4/8] zswap: add to mm/

2013-02-25 Thread Seth Jennings
On 02/24/2013 10:35 PM, Joonsoo Kim wrote: Hello, Seth. Here comes minor comments. snip +static int __zswap_cpu_notifier(unsigned long action, unsigned long cpu) +{ +struct crypto_comp *tfm; +u8 *dst; + +switch (action) { +case CPU_UP_PREPARE: +tfm =

Re: [PATCHv5 7/8] zswap: add swap page writeback support

2013-02-25 Thread Seth Jennings
On 02/24/2013 08:54 PM, Minchan Kim wrote: Hi Seth, On Wed, Feb 13, 2013 at 12:38:50PM -0600, Seth Jennings wrote: This patch adds support for evicting swap pages that are currently compressed in zswap to the swap device. This functionality is very important and make zswap a true cache

Re: [PATCHv5 1/8] zsmalloc: add to mm/

2013-02-25 Thread Seth Jennings
On 02/25/2013 11:05 AM, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Sent: Friday, February 22, 2013 1:04 PM To: Joonsoo Kim Subject: Re: [PATCHv5 1/8] zsmalloc: add to mm/ On 02/22/2013 03:24 AM, Joonsoo Kim wrote: It's my quick thought. So

Re: [PATCHv6 1/8] zsmalloc: add to mm/

2013-02-22 Thread Seth Jennings
On 02/22/2013 03:40 AM, Joonsoo Kim wrote: On Wed, Feb 20, 2013 at 04:04:41PM -0600, Seth Jennings wrote: = DO NOT MERGE, FOR REVIEW ONLY This patch introduces zsmalloc as new code, however, it already exists in drivers/staging. In order to build successfully, you must select EITHER

Re: [PATCHv5 1/8] zsmalloc: add to mm/

2013-02-22 Thread Seth Jennings
On 02/22/2013 03:24 AM, Joonsoo Kim wrote: On Wed, Feb 20, 2013 at 08:37:33AM +0900, Minchan Kim wrote: On Tue, Feb 19, 2013 at 11:54:21AM -0600, Seth Jennings wrote: On 02/19/2013 03:18 AM, Joonsoo Kim wrote: Hello, Seth. I'm not sure that this is right time to review, because I already have

Re: [PATCHv5 2/8] zsmalloc: add documentation

2013-02-22 Thread Seth Jennings
On 02/21/2013 08:56 PM, Ric Mason wrote: On 02/21/2013 11:50 PM, Seth Jennings wrote: On 02/21/2013 02:49 AM, Ric Mason wrote: On 02/19/2013 03:16 AM, Seth Jennings wrote: On 02/16/2013 12:21 AM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: This patch adds a documentation

Re: [PATCHv5 2/8] zsmalloc: add documentation

2013-02-21 Thread Seth Jennings
On 02/21/2013 02:49 AM, Ric Mason wrote: On 02/19/2013 03:16 AM, Seth Jennings wrote: On 02/16/2013 12:21 AM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: This patch adds a documentation file for zsmalloc at Documentation/vm/zsmalloc.txt Signed-off-by: Seth Jennings sjenn

Re: [PATCHv6 0/8] zswap: compressed swap caching

2013-02-21 Thread Seth Jennings
On 02/21/2013 09:50 AM, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: [PATCHv6 0/8] zswap: compressed swap caching Changelog: v6: * fix improper freeing of rbtree (Cody) Cody's bug fix reminded me of a rather fundamental question: Why does

Re: [PATCHv6 1/8] zsmalloc: add to mm/

2013-02-21 Thread Seth Jennings
On 02/21/2013 02:36 PM, Cody P Schafer wrote: On Wed, Feb 20, 2013 at 04:04:41PM -0600, Seth Jennings wrote: diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c +#define MAX(a, b) ((a) = (b) ? (a) : (b)) +/* ZS_MIN_ALLOC_SIZE must be multiple of ZS_ALIGN */ +#define ZS_MIN_ALLOC_SIZE \ +MAX(32

Re: [PATCHv5 4/8] zswap: add to mm/

2013-02-20 Thread Seth Jennings
On 02/18/2013 01:55 PM, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: Re: [PATCHv5 4/8] zswap: add to mm/ On 02/15/2013 10:04 PM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: snip + * The statistics below are not protected from

[PATCHv6 0/8] zswap: compressed swap caching

2013-02-20 Thread Seth Jennings
179 191 7% 20 94 143 52% 24 60 128 113% Seth Jennings (8): zsmalloc: add to mm/ zsmalloc: add documentation debugfs: add get/set for atomic types zswap: add to mm/ mm: break up swap_writepage() for frontswap backends mm: allow for outstanding swap

[PATCHv6 4/8] zswap: add to mm/

2013-02-20 Thread Seth Jennings
this compressed store much more quickly than reading from tradition swap devices resulting in faster performance for many workloads. This patch adds the zswap driver to mm/ Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/Kconfig | 15 ++ mm/Makefile | 1 + mm/zswap.c | 665

[PATCHv6 1/8] zsmalloc: add to mm/

2013-02-20 Thread Seth Jennings
noncontigious pages. zsmalloc fulfills the allocation needs for zram and zswap. Acked-by: Nitin Gupta ngu...@vflare.org Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/zsmalloc.h | 56 +++ mm/Kconfig | 24 + mm

[PATCHv6 8/8] zswap: add documentation

2013-02-20 Thread Seth Jennings
This patch adds the documentation file for the zswap functionality Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zswap.txt | 82 ++ 1 file changed, 82 insertions(+) create mode 100644 Documentation/vm/zswap.txt diff

[PATCHv6 3/8] debugfs: add get/set for atomic types

2013-02-20 Thread Seth Jennings
debugfs currently lack the ability to create attributes that set/get atomic_t values. This patch adds support for this through a new debugfs_create_atomic_t() function. Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- fs

[PATCHv6 2/8] zsmalloc: add documentation

2013-02-20 Thread Seth Jennings
This patch adds a documentation file for zsmalloc at Documentation/vm/zsmalloc.txt Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zsmalloc.txt | 68 +++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/vm

[PATCHv6 7/8] zswap: add swap page writeback support

2013-02-20 Thread Seth Jennings
code path is operating on it. Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- mm/zswap.c | 531 ++--- 1 file changed, 511 insertions(+), 20 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index d3b4943..364bc18 100644 --- a/mm

[PATCHv6 5/8] mm: break up swap_writepage() for frontswap backends

2013-02-20 Thread Seth Jennings
is to be resumed can be added to the swap cache. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 2 ++ mm/page_io.c | 16 +--- mm/swap_state.c | 2 +- 3 files changed, 16 insertions(+), 4 deletions

[PATCHv6 6/8] mm: allow for outstanding swap writeback accounting

2013-02-20 Thread Seth Jennings
the accounting is done. Acked-by: Minchan Kim minc...@kernel.org Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- include/linux/swap.h | 4 +++- mm/page_io.c | 12 +++- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/include/linux/swap.h b/include/linux

Re: [PATCHv5 1/8] zsmalloc: add to mm/

2013-02-19 Thread Seth Jennings
! But, I read the code, now, and then some comments below. On Wed, Feb 13, 2013 at 12:38:44PM -0600, Seth Jennings wrote: = DO NOT MERGE, FOR REVIEW ONLY This patch introduces zsmalloc as new code, however, it already exists in drivers/staging. In order to build successfully, you

Re: [PATCHv5 1/8] zsmalloc: add to mm/

2013-02-18 Thread Seth Jennings
On 02/15/2013 09:26 PM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: = DO NOT MERGE, FOR REVIEW ONLY This patch introduces zsmalloc as new code, however, it already exists in drivers/staging. In order to build successfully, you must select EITHER to driver/staging

Re: [PATCHv5 2/8] zsmalloc: add documentation

2013-02-18 Thread Seth Jennings
On 02/16/2013 12:21 AM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: This patch adds a documentation file for zsmalloc at Documentation/vm/zsmalloc.txt Signed-off-by: Seth Jennings sjenn...@linux.vnet.ibm.com --- Documentation/vm/zsmalloc.txt | 68

Re: [PATCHv5 4/8] zswap: add to mm/

2013-02-18 Thread Seth Jennings
On 02/15/2013 10:04 PM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: snip + * The statistics below are not protected from concurrent access for + * performance reasons so they may not be a 100% accurate. However, + * the do provide useful information on roughly how many times

Re: [PATCHv5 7/8] zswap: add swap page writeback support

2013-02-18 Thread Seth Jennings
On 02/16/2013 12:11 AM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: snip +/*** +* page pool for temporary compression result +/ +#define ZSWAP_TMPPAGE_POOL_PAGES 16 Why not the number

Re: [PATCHv5 0/8] zswap: compressed swap caching

2013-02-18 Thread Seth Jennings
On 02/15/2013 09:20 PM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: snip Some addition performance metrics regarding the performance improvements and I/O reductions that can be achieved using zswap as measured by SPECjbb are provided here: http://ibm.co/VCgHvM I see

Re: [PATCHv5 4/8] zswap: add to mm/

2013-02-18 Thread Seth Jennings
On 02/18/2013 01:49 PM, Cody P Schafer wrote: On 02/18/2013 11:24 AM, Seth Jennings wrote: On 02/15/2013 10:04 PM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: snip +/* invalidates all pages for the given swap type */ +static void zswap_frontswap_invalidate_area(unsigned

Re: [PATCHv5 4/8] zswap: add to mm/

2013-02-18 Thread Seth Jennings
On 02/18/2013 01:55 PM, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: Re: [PATCHv5 4/8] zswap: add to mm/ On 02/15/2013 10:04 PM, Ric Mason wrote: On 02/14/2013 02:38 AM, Seth Jennings wrote: snip + * The statistics below are not protected from

Re: [PATCHv4 2/7] zsmalloc: promote to lib/

2013-02-13 Thread Seth Jennings
On 01/29/2013 04:51 PM, Andrew Morton wrote: On Tue, 29 Jan 2013 15:40:22 -0600 Seth Jennings sjenn...@linux.vnet.ibm.com wrote: This patch promotes the slab-based zsmalloc memory allocator from the staging tree to lib/ Hate to rain on the parade, but... we haven't reviewed zsmalloc yet

Re: [PATCHv4 6/7] zswap: add flushing support

2013-02-12 Thread Seth Jennings
On 02/01/2013 01:27 AM, Minchan Kim wrote: On Tue, Jan 29, 2013 at 03:40:26PM -0600, Seth Jennings wrote: This patchset adds support for flush pages out of the compressed pool to the swap device Thanks for the review Minchan! Sorry for the delayed response. I'm prepping v5 for posting. I

Re: [PATCHv2 8/9] zswap: add to mm/

2013-02-07 Thread Seth Jennings
On 01/29/2013 04:21 AM, Lord Glauber Costa of Sealand wrote: On 01/28/2013 07:27 PM, Seth Jennings wrote: Yes, I prototyped a shrinker interface for zswap, but, as we both figured, it shrinks the zswap compressed pool too aggressively to the point of being useless. Can't you advertise

Re: [PATCHv4 0/7] zswap: compressed swap caching

2013-02-04 Thread Seth Jennings
On 02/02/2013 06:17 PM, Simon Jeons wrote: On Fri, 2013-02-01 at 09:13 -0600, Seth Jennings wrote: On 01/31/2013 07:39 PM, Simon Jeons wrote: Hi Seth, On Tue, 2013-01-29 at 15:40 -0600, Seth Jennings wrote: snip Performance, Kernel Building: Setup Gentoo w/ kernel v3.7-rc7 Quad

  1   2   3   4   >