[389-devel] Re: Updated commit message format

2019-04-04 Thread Lukas Slebodnik
On (04/04/19 13:52), Matus Honek wrote: >Hello, > >I would like to bring to your attention a recent change in our >Contribution Guide [1]. We have updated the recommended commit message >format. In particular, the "Fixes " string prefixing the URL which >will make our lives easier in case of pull

[389-devel] Re: 389ds build failure on alpine

2018-10-17 Thread Lukas Slebodnik
On (17/10/18 12:01), Mark Reynolds wrote: > >On 10/17/18 11:27 AM, Brian Matheson wrote: >> Hi list, >> >> I'm attempting th build 389ds with gperftools under alpine linux, but >> have run into the following snag: >> >> /BUILD # make >> make all-am >> make[1]: Entering directory '/BUILD' >>

[389-devel] Re: csiphash on Sparc

2017-10-26 Thread Lukas Slebodnik
On (13/10/17 20:35), William Brown wrote: >On Wed, 2017-10-11 at 13:36 +0200, Lukas Slebodnik wrote: >> But following code should work. Please correct me if I am wrong. I didn't >> test. >> char *str = strdup("ABCDEFGH12345678"); >> char *key = malloc(16

[389-devel] Re: csiphash on Sparc

2017-10-11 Thread Lukas Slebodnik
On (11/10/17 12:42), Carsten Grzemba wrote: > > >On 11.10.17 10:54, William Brown wrote: >> >> On Tue, 2017-10-10 at 16:28 +0200, Carsten Grzemba wrote: >> > >> > On 10.10.17 16:10, William Brown wrote: >> > > >> > > On Fri, 2017-10-06 at 10:21

[389-devel] Re: Build failed in Jenkins: 389-DS-NIGHTLY #165

2017-02-16 Thread Lukas Slebodnik
On (16/02/17 09:50), William Brown wrote: >On Wed, 2017-02-15 at 08:16 -0500, Mark Reynolds wrote: >> >> On 02/15/2017 04:48 AM, Lukas Slebodnik wrote: >> > On (15/02/17 09:05), Jenkins wrote: >> >> See >> >> <http://vm-058-081.abc.idm

[389-devel] Re: Build failed in Jenkins: 389-DS-NIGHTLY #165

2017-02-15 Thread Lukas Slebodnik
On (15/02/17 09:05), Jenkins wrote: >See > > Is there a reason why jenkins failures are ignored for a week? LS ___ 389-devel mailing list --

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

2017-02-13 Thread Lukas Slebodnik
On (13/02/17 08:38), Noriko Hosoi wrote: >On 02/12/2017 06:14 PM, William Brown wrote: >> On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote: >> > On 02/12/2017 03:51 PM, Noriko Hosoi wrote: >> > > https://pagure.io/389-ds-base/issue/49121 >> > > >> > >

Re: Are partial upgrades expected to work in rawhide?

2017-01-05 Thread Lukas Slebodnik
> On 01/05/2017 08:19 PM, Lukas Slebodnik wrote: > > Even if we had this capability, I'm not sure if we would use it in > rawhide. It could considerably increase the size of the dependency > information. > You would remove "temporary versions" with official re

Re: Are partial upgrades expected to work in rawhide?

2017-01-05 Thread Lukas Slebodnik
I think that we need to wait for https://bugzilla.redhat.com/show_bug.cgi?id=1320954 But I think it still would be good to to at least rebuild images. LS ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to

Re: Are partial upgrades expected to work in rawhide?

2017-01-03 Thread Lukas Slebodnik
> On Tue, Jan 03, 2017 at 08:08:32AM -0000, Lukas Slebodnik wrote: > > But there is nothing that can be done about it. The symbol versions come > from upstream, every release that adds new symbols adds new symbol version, > and we do want to test glibc before it is released, we

Re: Are partial upgrades expected to work in rawhide?

2017-01-03 Thread Lukas Slebodnik
> It has nothing to do with rawhide. It is a best practice how to use > map symbols/version script and to have stable API/ABI > https://www.akkadia.org/drepper/dsohowto.pdf > > quote: > > I know it is not a high critical issue and therefore I suggested (in BZ) to > to automatically rebuild

Re: Are partial upgrades expected to work in rawhide?

2017-01-03 Thread Lukas Slebodnik
> On Mon, 2017-01-02 at 20:43 -0800, Adam Williamson wrote: > > ...but to expand on that, that's for stable releases. So far as Rawhide > is concerned, historically my understanding has been the same as > Florian's, we haven't ever claimed that dependencies will be so > comprehensive that you can

Re: Are partial upgrades expected to work in rawhide?

2017-01-02 Thread Lukas Slebodnik
> On Mon, Jan 02, 2017 at 02:29:47PM +0100, Florian Weimer wrote: > > I think officially, we don't "support" anything but all-or-nothing > upgrades in *all* branches. That is, if you cherry-pick an update from > updates (or even updates-testing) and it also needs some other package > to be

Re: Are partial upgrades expected to work in rawhide?

2017-01-02 Thread Lukas Slebodnik
> On 01/02/2017 05:22 PM, Lukas Slebodnik wrote: > The bug is in the user-supplied container build scripts. Recommended > practice is to run “dnf update” (or “yum update”) as part of the build > process. Could you provide some link where it is recommended? Because most of pages

Re: Are partial upgrades expected to work in rawhide?

2017-01-02 Thread Lukas Slebodnik
> On Mon, Jan 02, 2017 at 02:29:47PM +0100, Florian Weimer wrote: > > This is rawhide, if it breaks, people should keep the pieces. > We shouldn't > change what we do with symbol versions just because of it. > It has nothing to do with rawhide. It is a best practice how to use map

[389-devel] Re: please review: Ticket 48978 - Fix implicit function declaration

2016-11-29 Thread Lukas Slebodnik
On (29/11/16 23:59), Lukas Slebodnik wrote: >https://fedorahosted.org/389/ticket/48978 > >https://fedorahosted.org/389/attachment/ticket/48797/0001-Ticket-48978-Fix-implicit-function-declaration.patch > I am sorry I attached the patch to the different ticket https://fedorahosted.org/38

[389-devel] please review: Ticket 48978 - Fix implicit function declaration

2016-11-29 Thread Lukas Slebodnik
https://fedorahosted.org/389/ticket/48978 https://fedorahosted.org/389/attachment/ticket/48797/0001-Ticket-48978-Fix-implicit-function-declaration.patch Please modify commit message yourself if it does not match your style. BTW the bug is when compliing with systemd-journald. LS

[389-devel] Re: Enable quiet build on ds, ns, svrcore

2016-10-25 Thread Lukas Slebodnik
On (25/10/16 14:23), William Brown wrote: >Hi, > >I want to get feedback from the team about a small change I would like >to make to our configure.ac. I want to add the following to >configure.ac. > >m4_ifdef([AM_SILENT_RULES], [ > AM_SILENT_RULES([yes]) >]) > We(sssd) do not use it by default

[389-devel] Please review: Fix warnings Wstrict prototypes

2016-09-03 Thread Lukas Slebodnik
ehlo, https://fedorahosted.org/389/ticket/48979 The 1st 16 patches are preparation for a last huge patch which uses "(void)" for functions which does not expect any arguments. https://fedorahosted.org/389/attachment/ticket/48979/0001-Ticket-48979-Remove-unused-forward-declaration.patch

[389-devel] Re: [389-commits] 2 commits - dirsrvtests/tests ldap/servers

2016-09-02 Thread Lukas Slebodnik
On (31/08/16 23:38), Noriko Hosoi wrote: > dirsrvtests/tests/tickets/ticket48896_test.py | 181 > ++ > ldap/servers/slapd/modify.c |3 > ldap/servers/slapd/pw.c | 43 -- > ldap/servers/slapd/slapi-plugin.h |4

[389-devel] Re: [389-commits] wrappers/systemd.template.service.in

2016-02-29 Thread Lukas Slebodnik
On (29/02/16 11:36), Noriko Hosoi wrote: >On 02/29/2016 11:01 AM, Lukas Slebodnik wrote: >>On (29/02/16 18:43), Noriko Hosoi wrote: >>>wrappers/systemd.template.service.in |2 +- >>>1 file changed, 1 insertion(+), 1 deletion(-) &g

[389-devel] Re: [389-commits] wrappers/systemd.template.service.in

2016-02-29 Thread Lukas Slebodnik
On (29/02/16 18:43), Noriko Hosoi wrote: > wrappers/systemd.template.service.in |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >New commits: >commit 1e2cfe2ea4ebc7ac31f292bf0076cc1befd15a78 >Author: Viktor Ashirov >Date: Mon Feb 29 19:07:12 2016 +0100 > >

Re: [389-devel] Please review: [nunc-stans] Remove extra curly brace

2015-11-10 Thread Lukas Slebodnik
On (10/11/15 10:25), Noriko Hosoi wrote: >On 11/10/2015 01:29 AM, Lukas Slebodnik wrote: >>ehlo, >> >>I'm too lazy to follow all contribution steps for one liner :-) >>So simple patch is attached. >> >>LS >> >> >>-- >>389

[389-devel] Please review: [nunc-stans] Remove extra curly brace

2015-11-10 Thread Lukas Slebodnik
ehlo, I'm too lazy to follow all contribution steps for one liner :-) So simple patch is attached. LS >From 30aed3d8879338c8713d845803cd178beab9c57d Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Tue, 10 Nov 2015 10:16:46 +0100 Subject: [PATCH] Remove ex

Re: [389-devel] Please review: [nunc-stans] Remove extra curly brace

2015-11-10 Thread Lukas Slebodnik
On (10/11/15 21:29), Lukas Slebodnik wrote: >On (10/11/15 10:25), Noriko Hosoi wrote: >>On 11/10/2015 01:29 AM, Lukas Slebodnik wrote: >>>ehlo, >>> >>>I'm too lazy to follow all contribution steps for one liner :-) >>>So simple patch is attached. >

Re: [389-devel] Please comment: [389 Project] #48285: The dirsrv user/group should be created in rpm %pre, and ideally with fixed uid/gid

2015-10-21 Thread Lukas Slebodnik
On (21/10/15 11:20), Noriko Hosoi wrote: >Thanks to William for his reviewing the patch. I'm going to push it. But >before doing so, I have a question regarding the autogen files. > >The proposed patch requires to rerun autogen.sh and push the generated files >to the git. My current env has

Re: [389-devel] Please comment: [389 Project] #48285: The dirsrv user/group should be created in rpm %pre, and ideally with fixed uid/gid

2015-10-21 Thread Lukas Slebodnik
On (21/10/15 12:34), Rich Megginson wrote: >On 10/21/2015 12:29 PM, Lukas Slebodnik wrote: >>On (21/10/15 11:20), Noriko Hosoi wrote: >>>Thanks to William for his reviewing the patch. I'm going to push it. But >>>before doing so, I have a question regarding the autogen

Re: [389-devel] No rule to make target dbmon.sh

2015-02-26 Thread Lukas Slebodnik
On (26/02/15 18:05), Noriko Hosoi wrote: Hi William, Could you check if you have ./ldap/admin/src/scripts/dbmon.sh in your build tree? I'm suspecting you might have wiped out by some clean procedure. I usually build my local tree with rpmbuild which copies a build tree from the source tree

[389-devel] please review: Ticket 47440 - Fix compilation warnings

2013-07-22 Thread Lukas Slebodnik
https://fedorahosted.org/389/ticket/47440 https://fedorahosted.org/389/attachment/ticket/47440/0001-Fix-compilation-warnings.patch https://fedorahosted.org/389/attachment/ticket/47440/0002-Use-right-prototype-for-auxprop_lookup-in-sasl-plugi.patch