Re: Request to review a MinGW subpackges in libsodium

2023-08-21 Thread Daniel P . Berrangé
On Mon, Aug 21, 2023 at 03:17:21PM +0200, Marián Konček wrote: > I opened a PR adding mingw subpackages to libsodium according to my best > knowledge (which is not too large related to mingw packaging): > https://src.fedoraproject.org/rpms/libsodium/pull-request/3 > > I talked with the maintainer

Re: Request to review a MinGW subpackges in libsodium

2023-08-21 Thread Sandro Mani
Hi Please check out [1] for a sample unified native/mingw spec with autotools build. Specific remarks: - Add %{?mingw_debug_package} - Explicit BR on mingw-binutils probably unnecessary - Try %global _configure ../configure instead of cloning the entire source tree - Add

Request to review a MinGW subpackges in libsodium

2023-08-21 Thread Marián Konček
I opened a PR adding mingw subpackages to libsodium according to my best knowledge (which is not too large related to mingw packaging): https://src.fedoraproject.org/rpms/libsodium/pull-request/3 I talked with the maintainer and it could be accepted, but I would like someone more experienced