Re: [PATCH 10/11] nodedev: Implement virNodeDeviceUpdateXML

2024-01-31 Thread Jonathon Jongsma
On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Implement the API functions in the node device driver by using mdevctl modify with the options defined and live. Increase the minimum mdevctl version to 1.3.0 in spec file to ensure support exists in mdevctl. mdevctl 1.3.0 was only released about 3

Re: [PATCH 06/11] nodedev: add persisted and transient filter on list

2024-01-31 Thread Jonathon Jongsma
On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Allow to filter node devices based on their persisted or transient states. Signed-off-by: Boris Fiuczynski --- include/libvirt/libvirt-nodedev.h | 2 ++ src/conf/node_device_conf.h | 7 ++- src/conf/virnodedeviceobj.c | 8

Re: [PATCH 07/11] tools: add switches persisted and transient to nodedev-list

2024-01-31 Thread Jonathon Jongsma
On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Now that we can filter persisted and transient node devices in virConnectListAllNodeDevices(), add these switches also to the virsh nodedev-list command. Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 8 ++--

Re: [PATCH 05/11] tools: add option inactive to nodedev-dumpxml

2024-01-31 Thread Jonathon Jongsma
On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Allow to dump the XML of the persisted mdev when the mdev has been started instead of the current state only. Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 7 +-- tools/virsh-nodedev.c | 15 ++- 2 files

Re: [PATCH 04/11] nodedev: add an active config to mdev

2024-01-31 Thread Jonathon Jongsma
On 1/19/24 10:38 AM, Boris Fiuczynski wrote: The configuration of a defined mdev can be modified after the mdev is started. The defined configuration and the active configuration can therefore run out of sync. Handle this by storing the modifiable data which is the mdev type and attributes in

Re: [PATCH 02/11] node_device: refactor mdev attributes handling

2024-01-31 Thread Jonathon Jongsma
On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Refactor attribute handling code into methods for easier reuse. Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 27 --- src/node_device/node_device_driver.c | 108 --- 2 files changed, 83

Re: [PATCH 1/2] conf: Introduce mshv hypervisor type

2024-01-31 Thread Daniel P . Berrangé
On Wed, Jan 31, 2024 at 12:49:50PM -0800, Praveen Paladugu wrote: > > Am I right in thinking that "Microsoft Hypervisor" in this context is > > simply Hyper-V, aka, the same hypervisor you traditionally have under > > a Windows Dom0 ? > > > > If so then I could think that we probably don't need

Re: [PATCH 1/2] conf: Introduce mshv hypervisor type

2024-01-31 Thread Praveen Paladugu
On Wed, Jan 31, 2024 at 09:55:29AM +, Daniel P. Berrang?? wrote: > On Tue, Jan 30, 2024 at 02:44:40PM -0600, Praveen K Paladugu wrote: > > This hypervisor type is available on a host running Microsoft Hypervisor > > and Linux as the Dom0. The Dom0 should load "mshv" drivers to expose the > >

Re: [PATCH 07/10] qemu-replies-tool: Add validation of known fields in 'query-qmp-schema'

2024-01-31 Thread Peter Krempa
On Tue, Jan 16, 2024 at 17:12:41 +0100, Peter Krempa wrote: > If the schema itself is extended in qemu we need to have a notification > to add appropriate handling to ensure that we have full coverage of all > fields. > > Add validation that only fields that libvirt currently knows about are >

[libvirt PATCH] qemu_snapshot: allow reverting to external disk only snapshot

2024-01-31 Thread Pavel Hrdina
When snapshot is created with disk-only flag it is always external snapshot without memory state. Historically when there was not support to revert external snapshots this produced error message. error: Failed to revert snapshot s1 error: internal error: Invalid target domain state

Re: [PATCH 0/3] qemu: Improvements related to MODEL_SCSI_AUTO

2024-01-31 Thread Jonathon Jongsma
On 1/30/24 10:57 AM, Andrea Bolognani wrote: Andrea Bolognani (3): tests: Add controller-scsi-auto qemu: Handle MODEL_SCSI_{AUTO,DEFAULT} appropriately qemu: Use virDomainControllerDefNew() more src/qemu/qemu_command.c | 4 +-- src/qemu/qemu_domain_address.c

Re: [PATCH 10/10] qemu-replies-tool: Dump 'device-list-properties'

2024-01-31 Thread Peter Krempa
On Thu, Jan 25, 2024 at 10:10:32 -0800, Andrea Bolognani wrote: > On Tue, Jan 16, 2024 at 05:12:44PM +0100, Peter Krempa wrote: > > + --dump-device-list-properties > > + > > +Dumps all properties (in stable order) of devices (in order libvirt > > queries > > +them) along with types and

Re: Re: [PATCH 07/10] qemu-replies-tool: Add validation of known fields in 'query-qmp-schema'

2024-01-31 Thread Peter Krempa
On Fri, Jan 26, 2024 at 06:40:23 -0800, Andrea Bolognani wrote: > On Fri, Jan 26, 2024 at 09:33:13AM +0100, Peter Krempa wrote: > > On Thu, Jan 25, 2024 at 09:47:11 -0800, Andrea Bolognani wrote: > > > On Tue, Jan 16, 2024 at 05:12:41PM +0100, Peter Krempa wrote: > > > > +def

Re: Re: [PATCH] apparmor: Add user session path for PID and socket files used by passt

2024-01-31 Thread Andrea Bolognani
On Tue, Jan 30, 2024 at 05:21:02PM -0700, Jim Fehlig wrote: > On 1/30/24 11:55, Andrea Bolognani wrote: > > On Tue, Jan 30, 2024 at 10:47:54AM -0800, Andrea Bolognani wrote: > > > On Tue, Jan 30, 2024 at 07:15:51PM +0100, Stefano Brivio wrote: > > > > -owner /{,var/}run/libvirt/qemu/passt/*

Re: Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-31 Thread Andrea Bolognani
On Wed, Jan 31, 2024 at 11:20:41AM +0800, lixianglai wrote: > > > In the qemu code, loongarch virt machine does only create a pflash, > > > > > > which is used for nvram, and uefi code is loaded by rom. > > > > > > In summary, loongarch virt machine can use nvram with the following > > > command:

Re: [PATCH 1/2] conf: Introduce mshv hypervisor type

2024-01-31 Thread Daniel P . Berrangé
On Tue, Jan 30, 2024 at 02:44:40PM -0600, Praveen K Paladugu wrote: > This hypervisor type is available on a host running Microsoft Hypervisor > and Linux as the Dom0. The Dom0 should load "mshv" drivers to expose the > hypervisor device to userspace. > > Cloud-Hypervisor supports running guests

Re: [PATCH 00/31] pci vpd: Fix broken XML formatter and refactor questionable error reporting

2024-01-31 Thread Ján Tomko
On a Tuesday in 2024, Peter Krempa wrote: The first part of the series fixes the XML formatter of nodedevs to not generate invalid XML if a PCI device custom field contains '>' which would be printed unescaped The rest fixes questionable and broken error reporting from the pci vpd device code

Re: [PATCH 31/31] virPCIVPDParse: Do reasonable error reporting

2024-01-31 Thread Ján Tomko
s/reporting/logging/ The error is reset in patch 23/31 so nothing gets 'raised' or 'reported' anyway. Jano On a Tuesday in 2024, Peter Krempa wrote: Remove the wannabe error reporting via 'VIR_DEBUG/VIR_INFO' in favor of proper errors. Signed-off-by: Peter Krempa --- src/util/virpcivpd.c |

Re: [PATCH 20/31] util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword

2024-01-31 Thread Peter Krempa
On Wed, Jan 31, 2024 at 09:06:06 +0100, Ján Tomko wrote: > On a Tuesday in 2024, Peter Krempa wrote: > > The function always succeeded and after the removal of programing error > > checks doesn't even have a 'return false' case. Additionally one of the > > tests in 'virpcivpdtest' tested that this

Re: [PATCH 29/31] virPCIVPDParseVPDLargeResourceFields: Refactor return logic

2024-01-31 Thread Ján Tomko
On a Tuesday in 2024, Peter Krempa wrote: Rewrite the conditions after exiting the parser so that they are easier to understand. This partially decreases the granularity of "error" messages as they are not strictly necessary albeit for debugging. As it was already observed in this code the

Re: [PATCH 27/31] virPCIVPDParseVPDLargeResourceFields: Remove impossible 'default' swithch case

2024-01-31 Thread Ján Tomko
*switch Jano On a Tuesday in 2024, Peter Krempa wrote: The 'fieldFormat' variable is guaranteed to have only the proper enum values by virPCIVPDResourceGetFieldValueFormat. Signed-off-by: Peter Krempa --- src/util/virpcivpd.c | 3 --- 1 file changed, 3 deletions(-) signature.asc

Re: [PATCH 20/31] util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword

2024-01-31 Thread Ján Tomko
On a Tuesday in 2024, Peter Krempa wrote: The function always succeeded and after the removal of programing error checks doesn't even have a 'return false' case. Additionally one of the tests in 'virpcivpdtest' tested that this function never failed on wrong data. Embrace this logic and remove