[libvirt PATCH 7/7] NEWS: Mention systemd-resolved support in network driver

2024-02-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e2796fd8b2..15b0da31b6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -23,6 +23,13 @@ v10.1.0 (unreleased) Additionally, if CPU clusters are present in the host topology,

[libvirt PATCH 6/7] network: Make virtual domains resolvable from the host

2024-02-01 Thread Jiri Denemark
This patch adds a new attribute "register" to the element. If set to "yes", the DNS server created for the virtual network is registered with systemd-resolved as a name server for the associated domain. The names known to the dnsmasq process serving DNS and DHCP requests for the virtual network

[libvirt PATCH 5/7] tests: Add tests for virSystemdResolvedRegisterNameServer

2024-02-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- tests/virsystemdtest.c | 147 + 1 file changed, 147 insertions(+) diff --git a/tests/virsystemdtest.c b/tests/virsystemdtest.c index fcd76514e1..004b0549ce 100644 --- a/tests/virsystemdtest.c +++ b/tests/virsystemdtest.c

[libvirt PATCH 4/7] util: Introduce virSystemdResolvedRegisterNameServer

2024-02-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/libvirt_private.syms | 1 + src/util/virsystemd.c| 79 +++- src/util/virsystemd.h| 5 +++ 3 files changed, 84 insertions(+), 1 deletion(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

[libvirt PATCH 3/7] util: Introduce virSocketAddrBytes

2024-02-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/libvirt_private.syms | 1 + src/util/virsocketaddr.c | 63 src/util/virsocketaddr.h | 4 +++ 3 files changed, 68 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

[libvirt PATCH 2/7] util: Introduce virSystemdHasResolved

2024-02-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/libvirt_private.syms | 2 ++ src/util/virsystemd.c | 15 +++ src/util/virsystemd.h | 2 ++ src/util/virsystemdpriv.h | 1 + 4 files changed, 20 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

[libvirt PATCH 1/7] util: Refactor virSystemdHas{Machined,Logind}

2024-02-01 Thread Jiri Denemark
To reduce code duplication both function now use a common virSystemdHasService helper. Signed-off-by: Jiri Denemark --- src/util/virsystemd.c | 76 --- 1 file changed, 36 insertions(+), 40 deletions(-) diff --git a/src/util/virsystemd.c

[libvirt PATCH 0/7] Configure systemd-resolved when starting networks

2024-02-01 Thread Jiri Denemark
See 6/7 for more details. Jiri Denemark (7): util: Refactor virSystemdHas{Machined,Logind} util: Introduce virSystemdHasResolved util: Introduce virSocketAddrBytes util: Introduce virSystemdResolvedRegisterNameServer tests: Add tests for virSystemdResolvedRegisterNameServer network:

[libvirt PATCH] docs: Fix typo in network XML documentation

2024-02-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- Pushed as trivial. docs/formatnetwork.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnetwork.rst b/docs/formatnetwork.rst index 809e842487..16e81246fa 100644 --- a/docs/formatnetwork.rst +++ b/docs/formatnetwork.rst @@ -141,7

Re: [PATCH 10/11] nodedev: Implement virNodeDeviceUpdateXML

2024-02-01 Thread Jonathon Jongsma
On 2/1/24 11:07 AM, Boris Fiuczynski wrote: On 1/31/24 22:41, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Implement the API functions in the node device driver by using mdevctl modify with the options defined and live. Increase the minimum mdevctl version to 1.3.0 in

Re: [PATCH 10/11] nodedev: Implement virNodeDeviceUpdateXML

2024-02-01 Thread Boris Fiuczynski
On 1/31/24 22:41, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Implement the API functions in the node device driver by using mdevctl modify with the options defined and live. Increase the minimum mdevctl version to 1.3.0 in spec file to ensure support exists in mdevctl.

Re: [PATCH 05/11] tools: add option inactive to nodedev-dumpxml

2024-02-01 Thread Boris Fiuczynski
On 2/1/24 17:39, Jonathon Jongsma wrote: @@ -608,7 +613,15 @@ cmdNodeDeviceDumpXML(vshControl *ctl, const vshCmd *cmd)   if (!device)   return false; -    if (!(xml = virNodeDeviceGetXMLDesc(device, 0))) +    if (vshCommandOptBool(cmd, "inactive")) { +    flags |=

Re: [PATCH 04/11] nodedev: add an active config to mdev

2024-02-01 Thread Boris Fiuczynski
On 2/1/24 17:16, Jonathon Jongsma wrote: +/** + * virNodeDeviceGetXMLDescFlags: + * + * Flags used to provide the state of the returned node device configuration. + * + * Since: 10.1.0 + */ +typedef enum { +    VIR_NODE_DEVICE_GET_XML_DESC_INACTIVE    = 1 << 0, /* dump inactive device

Re: [PATCH 05/11] tools: add option inactive to nodedev-dumpxml

2024-02-01 Thread Jonathon Jongsma
On 2/1/24 8:35 AM, Boris Fiuczynski wrote: On 1/31/24 22:34, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Allow to dump the XML of the persisted mdev when the mdev has been started instead of the current state only. Signed-off-by: Boris Fiuczynski ---  

Re: [PATCH] virt-admin: Add warning when connection to default daemon fails

2024-02-01 Thread Jonathon Jongsma
On 2/1/24 9:35 AM, Peter Krempa wrote: The admin connection defaults to the system-wide 'libvirtd' daemon to manage (libvirtd:///system). As we've now switched to modular daemons this will not work for most users out of the box: $ virt-admin version error: Failed to connect to the admin

Re: [PATCH 04/11] nodedev: add an active config to mdev

2024-02-01 Thread Jonathon Jongsma
On 2/1/24 6:17 AM, Boris Fiuczynski wrote: On 1/31/24 22:30, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: The configuration of a defined mdev can be modified after the mdev is started. The defined configuration and the active configuration can therefore run out of sync.

Re: [PATCH v2 0/5] Initial network support in ch driver.

2024-02-01 Thread Praveen Paladugu
On Tue, Jan 30, 2024 at 06:28:05PM +0100, Michal Pr??vozn??k wrote: > On 1/16/24 22:25, Praveen K Paladugu wrote: > > v2: > > * Refactor virSocketRecvHttpResponse to return responses without parsing > > http > > responses. > > * Use errno to report errors in virsocket.c > > * Address WIN32

[PATCH] virt-admin: Add warning when connection to default daemon fails

2024-02-01 Thread Peter Krempa
The admin connection defaults to the system-wide 'libvirtd' daemon to manage (libvirtd:///system). As we've now switched to modular daemons this will not work for most users out of the box: $ virt-admin version error: Failed to connect to the admin server error: no valid connection error:

Re: [PATCH 07/11] tools: add switches persisted and transient to nodedev-list

2024-02-01 Thread Boris Fiuczynski
On 1/31/24 22:38, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Now that we can filter persisted and transient node devices in virConnectListAllNodeDevices(), add these switches also to the virsh nodedev-list command. Signed-off-by: Boris Fiuczynski ---  

Re: [PATCH 06/11] nodedev: add persisted and transient filter on list

2024-02-01 Thread Boris Fiuczynski
On 1/31/24 22:38, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Allow to filter node devices based on their persisted or transient states. Signed-off-by: Boris Fiuczynski ---   include/libvirt/libvirt-nodedev.h | 2 ++   src/conf/node_device_conf.h   | 7 ++-  

Re: [PATCH 05/11] tools: add option inactive to nodedev-dumpxml

2024-02-01 Thread Boris Fiuczynski
On 1/31/24 22:34, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Allow to dump the XML of the persisted mdev when the mdev has been started instead of the current state only. Signed-off-by: Boris Fiuczynski ---   docs/manpages/virsh.rst |  7 +--  

Re: [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 12:30, Alex Bennée wrote: > > This regressed qemu-system-xtensa: > > TESTtest_load_store on xtensa > qemu-system-xtensa: Some ROM regions are overlapping > These ROM regions might have been loaded by direct user request or by > default. > They could be

Re: [PATCH 0/4] qemu: Stop adding 'raw' -blockdev layer unless necessary

2024-02-01 Thread Ján Tomko
On a Thursday in 2024, Peter Krempa wrote: Peter Krempa (4): tests: qemucapabilitiesdata: Update 'caps_9.0.0_x86_64.replies' qemu: capabilities: Introduce QEMU_CAPS_BLOCKJOB_BACKING_MASK_PROTOCOL qemu: monitor: Use 'backing-mask-protocol' for blockjobs when available

Re: [PATCH 2/5] docs: mark CRIS support as deprecated

2024-02-01 Thread Thomas Huth
On 01/02/2024 13.28, Alex Bennée wrote: This might be premature but while streamling the avocado tests I s/streamling/streamlining/ ? realised the only tests we have are "check-tcg" ones. The aging fedora-criss-cross image works well enough for developers but can't be s/criss/cris/ used

Re: [PATCH 5/5] kconfig: use "select" to enable semihosting

2024-02-01 Thread Thomas Huth
On 01/02/2024 13.28, Alex Bennée wrote: From: Paolo Bonzini Just like all other dependencies, these can be expressed in Kconfig files rather than in the default configurations. Signed-off-by: Paolo Bonzini Acked-by: Alistair Francis Message-Id: <20240129115809.1039924-1-pbonz...@redhat.com>

[PATCH 5/5] kconfig: use "select" to enable semihosting

2024-02-01 Thread Alex Bennée
From: Paolo Bonzini Just like all other dependencies, these can be expressed in Kconfig files rather than in the default configurations. Signed-off-by: Paolo Bonzini Acked-by: Alistair Francis Message-Id: <20240129115809.1039924-1-pbonz...@redhat.com> Signed-off-by: Alex Bennée ---

[PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size"

2024-02-01 Thread Alex Bennée
This regressed qemu-system-xtensa: TESTtest_load_store on xtensa qemu-system-xtensa: Some ROM regions are overlapping These ROM regions might have been loaded by direct user request or by default. They could be BIOS/firmware images, a guest kernel, initrd or some other file loaded

[PATCH 1/5] tests/docker: Add sqlite3 module to openSUSE Leap container

2024-02-01 Thread Alex Bennée
From: Fabiano Rosas Avocado needs sqlite3: Failed to load plugin from module "avocado.plugins.journal": ImportError("Module 'sqlite3' is not installed. Use: sudo zypper install python311 to install it") >From 'zypper info python311': "This package supplies rich command line features

[PATCH 3/5] configure: run plugin TCG tests again

2024-02-01 Thread Alex Bennée
From: Paolo Bonzini Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18) dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion caused by the shadowing of $config_host_mak. However, TCG tests were still expecting it. Oops. Put it back, in the

[PATCH 0/5] maintainer updates for 9.0 (docker, plugin tests, deprecation, elf, semihosting)

2024-02-01 Thread Alex Bennée
A fairly random collection of fixes in this tree. I've still got a report of openbsd rebuilding which is confusing me but I didn't want to hold up getting eyes on real fixes. The plugins register support may get added to the PR if it gets any review. The following need review: Revert

[PATCH 2/5] docs: mark CRIS support as deprecated

2024-02-01 Thread Alex Bennée
This might be premature but while streamling the avocado tests I realised the only tests we have are "check-tcg" ones. The aging fedora-criss-cross image works well enough for developers but can't be used in CI as we need supported build platforms to build QEMU. Does this mean the writing is on

Re: [PATCH 04/11] nodedev: add an active config to mdev

2024-02-01 Thread Boris Fiuczynski
On 1/31/24 22:30, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: The configuration of a defined mdev can be modified after the mdev is started. The defined configuration and the active configuration can therefore run out of sync. Handle this by storing the modifiable data

[PATCH 3/4] qemu: monitor: Use 'backing-mask-protocol' for blockjobs when available

2024-02-01 Thread Peter Krempa
Store whether qemu supports the appropriate option for block-stream and block-commit commands and always use it if available. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor_json.c | 10 ++ src/qemu/qemu_monitor_priv.h | 2 ++ 3 files changed,

[PATCH 2/4] qemu: capabilities: Introduce QEMU_CAPS_BLOCKJOB_BACKING_MASK_PROTOCOL

2024-02-01 Thread Peter Krempa
The capability is asserted when both block-stream and block-commit QMP commands support the 'backing-mask-protocol' argument. The argument causes qemu to record 'raw' as the backing file format in case when a protocol node is used directly. This is needed to preserve compatibility of images after

[PATCH 1/4] tests: qemucapabilitiesdata: Update 'caps_9.0.0_x86_64.replies'

2024-02-01 Thread Peter Krempa
Update to 'v8.2.0-952-g14639717bf'. Notable changes: - 'backing-mask-protocol' feature added for block-commit and block-stream - 'singlestep' mode dropped - 'cmpccxadd' cpu feature became available Signed-off-by: Peter Krempa --- For reference is the difference between the versions judged by

[PATCH 0/4] qemu: Stop adding 'raw' -blockdev layer unless necessary

2024-02-01 Thread Peter Krempa
Peter Krempa (4): tests: qemucapabilitiesdata: Update 'caps_9.0.0_x86_64.replies' qemu: capabilities: Introduce QEMU_CAPS_BLOCKJOB_BACKING_MASK_PROTOCOL qemu: monitor: Use 'backing-mask-protocol' for blockjobs when available qemuBlockStorageSourceNeedsFormatLayer: Stop formatting 'raw'

Re: [PATCH 02/11] node_device: refactor mdev attributes handling

2024-02-01 Thread Boris Fiuczynski
On 1/31/24 22:03, Jonathon Jongsma wrote: On 1/19/24 10:38 AM, Boris Fiuczynski wrote: Refactor attribute handling code into methods for easier reuse. Signed-off-by: Boris Fiuczynski ---   src/conf/node_device_conf.c  |  27 ---   src/node_device/node_device_driver.c | 108

Re: [libvirt PATCH] conf: Fix error message in virNetworkForwardDefParseXML

2024-02-01 Thread Peter Krempa
On Thu, Feb 01, 2024 at 12:16:37 +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/conf/network_conf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c > index a2220c05a6..ef3415cd89 100644 > ---

[libvirt PATCH] conf: Fix error message in virNetworkForwardDefParseXML

2024-02-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/conf/network_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index a2220c05a6..ef3415cd89 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -1362,8 +1362,9