It was introduced to make installation of the corresponding
file conditional based on the build platform, but we've
already changed the spec file so that all the decisions on
the matter happen there, which makes having yet another meson
option for the purpose unnecessary.
Signed-off-by: Andrea
Instead of enabling the feature conditionally, always enable
it and then remove the installed file when building on a
platform that doesn't need it.
We already perform the complementary check to decide whether
the file should be included in the package.
Signed-off-by: Andrea Bolognani
---
Recently introduced as part of [1].
We can skip the meson part for this one, and deal with everything
in the spec file only.
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1176890275
[1]
We currently rely on it being enabled by default.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 49ce717e1b..af2ba20c02 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1368,6 +1368,7 @@
On 2/13/24 3:04 AM, Boris Fiuczynski wrote:
On 2/9/24 23:45, Jonathon Jongsma wrote:
On 2/7/24 7:39 AM, Boris Fiuczynski wrote:
Implement the API functions in the node device driver by using
mdevctl modify with the options defined and live.
Instead of increasing the minimum mdevctl version to
On 2/14/24 6:59 AM, Boris Fiuczynski wrote:
On 2/13/24 14:43, Boris Fiuczynski wrote:
Tangentially related:
Almost all of the other API objects can update their persistent
definition from an XML file by calling the $(OBJECT)DefineXML command
to replace the existing definition. The Node
Currently we fall back to the x86-derived default of piix3-uhci,
which is a USB1 controller that's not virtualization-friendly
and overall a terrible choice for a modern architecture. The
fact that we didn't choose a better default when RISC-V support
was introduced was an oversight which is now
Just like qemuDomainDefaultSCSIControllerModel() before that,
split the function into an internal part and a trivial public
wrapper.
This allows us to rewrite the internal logic in the much more
compact and readable
if (condition)
return value;
if (other_condition)
return
In addition to the code in qemuDomainControllerDefPostParse(),
which we have just factored into its own function, we also have
some code in qemuDomainDefAddDefaultDevices() that deals with
choosing the model for a USB controller, specifically for q35
guests. Integrate it into the newly-created
Extract the logic from qemuDomainControllerDefPostParse().
The behavior is unchanged, we simply use an out argument to
return the model and entertain the possibility of the process
failing, even though the current implementation never will.
Signed-off-by: Andrea Bolognani
---
With the recent changes, we have ensured that all situations
that would have until now caused this code to be executed are
either handled by dropping the USB controller or by raising
an error.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 78
Right now we call qemuValidateDomainDeviceDefControllerUSB()
quite late, just as we're generating the QEMU command line.
The intention here is to prevent configurations from being
rejected, even though a default USB controller model could not
be found, because using -usb could work as a last
Use the same wording as for SCSI controllers, which also
happens to contain additional information (the controller's
index).
The new error message and error type are more accurate anyway:
in most cases, it's perfectly fine for the user not to provide
a controller model explicitly, as libvirt will
With the way the code is currently written, we can end up using
the legacy USB controller (-usb) for a guest that doesn't have
any USB controllers at all in its configuration.
This is pretty harmless, since in these cases QEMU will ignore
the request and not create any USB controller, but it's
When support for s390x was introduced in libvirt, it naturally
followed the conventions established at the time for x86, which
were to have a USB controller added by default.
Later, in 2013, commit 3a82f628a964 made the default USB
controller model for s390x VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE,
We have special handling for this configuration, so make sure
that there is some test coverage too.
Signed-off-by: Andrea Bolognani
---
.../usb-legacy-multiple.x86_64-latest.err | 1 +
.../usb-legacy-multiple.x86_64-latest.xml | 32 +++
This provides coverage for the scenario in which an attempt is
made to use a USB device together with the legacy USB controller.
Note that, while the test case passes, the configuration it
produces doesn't actually work:
$ qemu-system-x86_64 -M pc -usb -device usb-tablet,bus=usb.0
Bus
Just like piix3-uhci for USB, the choice of lsilogic for SCSI
was dictated entirely by that being the default for legacy x86
guests. Use virtio-scsi instead.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c| 4 +++-
Make the helper stateless. This requires the caller to check
whether it needs to be called in the first place instead of
adding this check inside the function, which makes for more
readable, if a little more verbose, code.
At the same time, change it so that it uses an out argument to
return the
Use a better order for sections, improve comments.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 39 +--
1 file changed, 29 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
We want this helper to work more like other similar ones, where
error reporting is performed by the caller. This introduces a
small amount of code duplication but makes for a cleaner API.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 9 +
src/qemu/qemu_hotplug.c | 3 +++
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 8
src/qemu/qemu_domain.h | 6 +++---
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index d7be544710..01f4ed6917 100644
---
This provides coverage for the (very unlikely) scenario in
which none of the possible devices are built into QEMU.
Signed-off-by: Andrea Bolognani
---
...ler-scsi-default-unavailable.x86_64-latest.err | 1 +
.../controller-scsi-default-unavailable.xml | 15 +++
Changes from [v1]:
* several patches have been pushed;
* of the remaining changes, only the ones related to SCSI and USB
controllers have been retained. I still intend to pursue the
rest, but those two are where the real nasty stuff happens, so
I'm focusing on them only for now;
On a Wednesday in 2024, Pavel Hrdina wrote:
On Wed, Feb 14, 2024 at 01:31:29PM +0100, Peter Krempa wrote:
On Tue, Feb 13, 2024 at 19:16:00 +0100, Jiri Denemark wrote:
> The %meson* macros pass --auto-features=enabled to enable all "auto"
> features, which means we have to explicitly disable
On Wed, Feb 14, 2024 at 01:31:29PM +0100, Peter Krempa wrote:
> On Tue, Feb 13, 2024 at 19:16:00 +0100, Jiri Denemark wrote:
> > The %meson* macros pass --auto-features=enabled to enable all "auto"
> > features, which means we have to explicitly disable them.
>
> This is not the first time we've
On Wed, Feb 14, 2024 at 13:23:09 +0100, Tim Wiederhake wrote:
> On Wed, 2024-02-14 at 12:39 +0100, Jiri Denemark wrote:
> > On Wed, Feb 14, 2024 at 12:07:46 +0100, Michal Prívozník wrote:
> > > On 2/9/24 11:52, Tim Wiederhake wrote:
> > > > The mpx feature was removed from the corresponding qemu
On 2/13/24 14:43, Boris Fiuczynski wrote:
Tangentially related:
Almost all of the other API objects can update their persistent
definition from an XML file by calling the $(OBJECT)DefineXML command
to replace the existing definition. The Node device API does not yet
support doing that, maybe
On Tue, Feb 13, 2024 at 19:16:00 +0100, Jiri Denemark wrote:
> The %meson* macros pass --auto-features=enabled to enable all "auto"
> features, which means we have to explicitly disable them.
This is not the first time we've hit this. I really think the only sane
option for --auto-features= for
On Wed, Feb 14, 2024 at 13:17:39 +0100, Peter Krempa wrote:
> On Wed, Feb 14, 2024 at 14:17:57 +0900, Hiroki Narukawa wrote:
> > There is a case that locking hits a bug and users wants to disable
> > locking like bug in Linux kernel.
> >
> > This commit adds option to configure locking for file
On Wed, Feb 14, 2024 at 14:17:58 +0900, Hiroki Narukawa wrote:
> There is a case that locking hits a bug and users wants to disable
> locking like bug in Linux kernel.
>
> This commit adds actual qemu option to the domain conf added in previous
> commit.
>
> Signed-off-by: Hiroki Narukawa
> ---
On Wed, 2024-02-14 at 12:39 +0100, Jiri Denemark wrote:
> On Wed, Feb 14, 2024 at 12:07:46 +0100, Michal Prívozník wrote:
> > On 2/9/24 11:52, Tim Wiederhake wrote:
> > > The mpx feature was removed from the corresponding qemu cpu
> > > models.
> > > With mpx in the libvirt cpu models, libvirt
On Wed, Feb 14, 2024 at 14:17:57 +0900, Hiroki Narukawa wrote:
> There is a case that locking hits a bug and users wants to disable
> locking like bug in Linux kernel.
>
> This commit adds option to configure locking for file source.
>
> Signed-off-by: Hiroki Narukawa
> ---
>
On Wed, Feb 14, 2024 at 12:07:46 +0100, Michal Prívozník wrote:
> On 2/9/24 11:52, Tim Wiederhake wrote:
> > The mpx feature was removed from the corresponding qemu cpu models.
> > With mpx in the libvirt cpu models, libvirt believes the feature
> > to be implicitly enabled when creating qemu VMs,
On 2/9/24 11:52, Tim Wiederhake wrote:
> The mpx feature was removed from the corresponding qemu cpu models.
> With mpx in the libvirt cpu models, libvirt believes the feature
> to be implicitly enabled when creating qemu VMs, while in fact it is
> disabled.
>
> This became an issue when commit
On 2/14/24 09:35, Adam Julis wrote:
> Signed-off-by: Adam Julis
> ---
> tools/virsh-completer-pool.c | 11 +++
> tools/virsh-completer-pool.h | 5 +
> tools/virsh-pool.c | 2 ++
> 3 files changed, 18 insertions(+)
>
> diff --git a/tools/virsh-completer-pool.c
Signed-off-by: Adam Julis
---
tools/virsh-completer-pool.c | 11 +++
tools/virsh-completer-pool.h | 5 +
tools/virsh-pool.c | 2 ++
3 files changed, 18 insertions(+)
diff --git a/tools/virsh-completer-pool.c b/tools/virsh-completer-pool.c
index 0600394411..1081e5c10c
37 matches
Mail list logo
