Re: [PATCH v3 01/12] cpu_map: update script to handle versioned CPUs

2024-02-21 Thread Jim Fehlig
On 2/21/24 13:56, Jonathon Jongsma wrote: On 2/20/24 6:08 PM, Jim Fehlig wrote: On 12/15/23 15:11, Jonathon Jongsma wrote: Previously, the script only generated the parent CPU and any versions that had a defined alias. The script now generates all CPU versions. Any version that had a defined

Re: [PATCH v3 05/12] cpu_map: Add versioned EPYC CPUs

2024-02-21 Thread Jonathon Jongsma
On 2/20/24 6:28 PM, Jim Fehlig wrote: On 12/15/23 15:12, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma ---   src/cpu_map/index.xml |   6 +   src/cpu_map/meson.build   |   6 +   src/cpu_map/x86_EPYC-Milan-v2.xml | 108

Re: [PATCH v3 01/12] cpu_map: update script to handle versioned CPUs

2024-02-21 Thread Jonathon Jongsma
On 2/20/24 6:08 PM, Jim Fehlig wrote: On 12/15/23 15:11, Jonathon Jongsma wrote: Previously, the script only generated the parent CPU and any versions that had a defined alias. The script now generates all CPU versions. Any version that had a defined alias will continue to use that alias, but

Re: [PATCH v3 12/12] nodedev: allow modify on define of a persistent node device

2024-02-21 Thread Jonathon Jongsma
On 2/16/24 8:52 AM, Boris Fiuczynski wrote: Allow to modify a node device by using virNodeDeviceDefineXML() to align its behavior with other drivers define methods. Signed-off-by: Boris Fiuczynski --- NEWS.rst | 5 +++ src/libvirt-nodedev.c| 4

Re: [PATCH v2 1/2] domain_validate: Account for NVDIMM label size properly when checking for memory conflicts

2024-02-21 Thread Michal Prívozník
On 2/20/24 17:29, Martin Kletzander wrote: > On Tue, Feb 20, 2024 at 04:53:29PM +0100, Michal Privoznik wrote: >> As of v9.8.0-rc1~7 we check whether two devices don't >> overlap (since we allow setting where a device should >> be mapped to). We do this pretty straightforward, by comparing >>

[PATCH] qemu: Fix guest-sync response time in qga command

2024-02-21 Thread ray
The current implementation sets the guest-sync timeout to the smaller value between the default value (QEMU_AGENT_WAIT_TIME) and agent->timeout, without considering the timeout passed via the qga command. This patch enhances the guest-sync timeout logic to use the minimum value among the default

Re: [PATCH v3 06/12] nodedev: add persisted and transient filter on list

2024-02-21 Thread Boris Fiuczynski
On 2/20/24 23:23, Jonathon Jongsma wrote: Minor nit: the commit subject still says "persisted" instead of "persistent" Sorry I missed these. I have sent a v4 fixing these. On 2/16/24 8:52 AM, Boris Fiuczynski wrote: Allow to filter node devices based on their persisted or transient states.

[PATCH v4 11/12] virsh: add nodedev-update

2024-02-21 Thread Boris Fiuczynski
Add ability to update node devices. Signed-off-by: Boris Fiuczynski --- docs/drvnodedev.rst | 4 +- docs/manpages/virsh.rst | 19 tools/virsh-nodedev.c | 98 + 3 files changed, 120 insertions(+), 1 deletion(-) diff --git

[PATCH v4 09/12] api: add virNodeDeviceUpdate()

2024-02-21 Thread Boris Fiuczynski
A public API method which allows to update or modify objects is implemented for almost all other objects that have a concept of persistent definition and activatability. Currently node devices of type mdev can be persistent and active. This new method allows to update defined and active node

[PATCH v4 04/12] nodedev: add an active config to mdev

2024-02-21 Thread Boris Fiuczynski
The configuration of a defined mdev can be modified after the mdev is started. The defined configuration and the active configuration can therefore run out of sync. Handle this by storing the modifiable data which is the mdev type and attributes in two separate active and defined configurations.

[PATCH v4 10/12] nodedev: Implement virNodeDeviceUpdate

2024-02-21 Thread Boris Fiuczynski
Implement the API functions in the node device driver by using mdevctl modify with the options defined and live. Instead of increasing the minimum mdevctl version to 1.3.0 in the spec file to ensure support exists in mdevctl the support is dynamically checked before using mdevctl. Signed-off-by:

[PATCH v4 07/12] tools: add switches persistent and transient to nodedev-list

2024-02-21 Thread Boris Fiuczynski
Now that we can filter persistent and transient node devices in virConnectListAllNodeDevices(), add these switches also to the virsh nodedev-list command. Signed-off-by: Boris Fiuczynski Reviewed-by: Jonathon Jongsma --- docs/manpages/virsh.rst | 8 ++-- tools/virsh-nodedev.c | 24

[PATCH v4 12/12] nodedev: allow modify on define of a persistent node device

2024-02-21 Thread Boris Fiuczynski
Allow to modify a node device by using virNodeDeviceDefineXML() to align its behavior with other drivers define methods. Signed-off-by: Boris Fiuczynski --- NEWS.rst | 5 +++ src/libvirt-nodedev.c| 4 +- src/node_device/node_device_driver.c | 62

[PATCH v4 06/12] nodedev: add persistent and transient filter on list

2024-02-21 Thread Boris Fiuczynski
Allow to filter node devices based on their persistent or transient states. Signed-off-by: Boris Fiuczynski Reviewed-by: Jonathon Jongsma --- include/libvirt/libvirt-nodedev.h | 2 ++ src/conf/node_device_conf.h | 7 ++- src/conf/virnodedeviceobj.c | 8 3 files

[PATCH v4 02/12] node_device: refactor mdev attributes handling

2024-02-21 Thread Boris Fiuczynski
Refactor attribute handling code into methods for easier reuse. Signed-off-by: Boris Fiuczynski Reviewed-by: Jonathon Jongsma --- src/conf/node_device_conf.c | 27 --- src/node_device/node_device_driver.c | 104 --- 2 files changed, 80 insertions(+), 51

[PATCH v4 05/12] tools: add option inactive to nodedev-dumpxml

2024-02-21 Thread Boris Fiuczynski
Allow to dump the XML of the persistent mdev when the mdev has been started instead of the current state only. Signed-off-by: Boris Fiuczynski Reviewed-by: Jonathon Jongsma --- docs/manpages/virsh.rst | 7 +-- tools/virsh-nodedev.c | 10 +- 2 files changed, 14 insertions(+), 3

[PATCH v4 08/12] virsh: doc fix on nodedev-list

2024-02-21 Thread Boris Fiuczynski
Commit 26136e3 allowed to use option all with option tree but did not update the manpage. Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index

[PATCH v4 03/12] node_device: remove unnecessary checks in virNodeDeviceDefFormat

2024-02-21 Thread Boris Fiuczynski
virBufferEscapeString already contains the null check. Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index a8554102fc..febc58afd1 100644 ---

[PATCH v4 01/12] virmdev: prepare type and attributes for dual state

2024-02-21 Thread Boris Fiuczynski
Create a new structure holding type and attributes as these are modifiable in a persistent mdev configuration and run out of sync with the active mdev configuration. Signed-off-by: Boris Fiuczynski --- src/conf/node_device_conf.c | 18 +++ src/conf/node_device_conf.h | 4

[PATCH v4 00/12] nodedev state and update

2024-02-21 Thread Boris Fiuczynski
The series adds a dual state to the mdev node devices as these objects can be active and defined at the same time. These two states can become different. To be able to also introspect the persistent and transient nodedevs filtering is added. To be able to also dump the XML of an inactive state

[libvirt PATCH V3 3/4] Implement the method of getting host info for loongarch

2024-02-21 Thread Xianglai Li
Implement method for loongarch to get host info, such as cpu frequency, system info, etc. Signed-off-by: Xianglai Li --- src/util/virarch.c| 2 ++ src/util/virhostcpu.c | 7 +-- src/util/virsysinfo.c | 3 ++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git

[libvirt PATCH V3 0/4] add loongarch support for libvirt

2024-02-21 Thread Xianglai Li
Hello, Everyone: This patch series adds libvirt support for loongarch.Although the bios path and name has not been officially integrated into qemu and we think there are still many shortcomings, we try to push a version of patch to the community according to the opinions of the community, hoping

[libvirt PATCH V3 2/4] Support for loongarch64 in the QEMU driver

2024-02-21 Thread Xianglai Li
Implement support for loongarch64 in the QEMU driver. Signed-off-by: Xianglai Li --- src/qemu/qemu_capabilities.c | 7 +++--- src/qemu/qemu_command.c | 7 -- src/qemu/qemu_domain.c | 41 +--- src/qemu/qemu_domain.h | 1 +

[libvirt PATCH V3 1/4] Add loongarch cpu support

2024-02-21 Thread Xianglai Li
Add loongarch cpu support, Define new cpu type 'loongarch64' and implement it's driver functions. Signed-off-by: Xianglai Li --- src/conf/schemas/basictypes.rng | 1 + src/cpu/cpu.c | 2 ++ src/cpu/cpu_loongarch.c | 58 +