Hi,
Bumping this up for review.
Thanks,
Pavan
On Mon, Mar 11, 2024 at 09:43:56AM +, Purna Pavan Chandra Aekkaladevi wrote:
> save, managedsave and restore operations for ch_driver are now supported for
> domains without any network, hostdev config defined. The input `path` to save
> and
From: Brett Holman
The SMBIOS specification[1] includes RISC-V and mips, and some systems have
SMBIOS info. Attempt to read dmidecode and fall back to old behavior if that
fails.
[1]
https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0.pdf
Signed-off-by: Brett Holman
This patch intends to add DMI support to libvirt for RISC-V and mips.
This change is based on commit ec6ce6363, which added ARM support.
This is not tested on the target arches, as I've been unable to find
hardware to test this on.
src/util/virsysinfo.c | 2 ++
1 file changed, 2 insertions(+)
On 3/18/24 15:25, Martin Kletzander wrote:
On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote:
On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote:
On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník wrote:
> On 3/18/24 12:45, Denis V. Lunev wrote:
> > On 3/18/24 11:42,
On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote:
On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote:
On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník wrote:
> On 3/18/24 12:45, Denis V. Lunev wrote:
> > On 3/18/24 11:42, Michal Prívozník wrote:
> >> On 3/17/24
On 3/18/24 14:31, Wei Gong wrote:
> when the thread pool is dynamically expanded, threads should
> not be created from the existing workers; they should be created
> from the newly expanded workers
>
> Signed-off-by: Wei Gong
> ---
> src/util/virthreadpool.c | 13 ++---
> 1 file
when the thread pool is dynamically expanded, threads should
not be created from the existing workers; they should be created
from the newly expanded workers
Signed-off-by: Wei Gong
---
src/util/virthreadpool.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote:
> On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník wrote:
> > On 3/18/24 12:45, Denis V. Lunev wrote:
> > > On 3/18/24 11:42, Michal Prívozník wrote:
> > >> On 3/17/24 16:00, Denis V. Lunev wrote:
> > >>> Signed-off-by: Denis V.
On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník wrote:
> On 3/18/24 12:45, Denis V. Lunev wrote:
> > On 3/18/24 11:42, Michal Prívozník wrote:
> >> On 3/17/24 16:00, Denis V. Lunev wrote:
> >>> Signed-off-by: Denis V. Lunev
> >>> ---
> >>> .gitignore | 1 +
> >>> 1 file changed, 1
On 3/18/24 12:45, Denis V. Lunev wrote:
> On 3/18/24 11:42, Michal Prívozník wrote:
>> On 3/17/24 16:00, Denis V. Lunev wrote:
>>> Signed-off-by: Denis V. Lunev
>>> ---
>>> .gitignore | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/.gitignore b/.gitignore
>>> index
On 3/14/24 04:23, Wei Gong wrote:
> when the thread pool is dynamically expanded, threads should
> not be created from the existing workers; they should be created
> from the newly expanded workers
>
> Signed-off-by: Wei Gong
> ---
> src/util/virthreadpool.c | 2 +-
> 1 file changed, 1
On 3/18/24 11:42, Michal Prívozník wrote:
On 3/17/24 16:00, Denis V. Lunev wrote:
Signed-off-by: Denis V. Lunev
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 4695391342..44a9b446bd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -20,6 +20,7 @@
On 3/11/24 15:59, Ján Tomko wrote:
> Ján Tomko (3):
> qemu: virtiofs: do not crash if cgroups are missing
> qemu: virtiofs: set correct label when creating the socket
> qemu: virtiofs: error out if getting the group or user name fails
>
> src/qemu/qemu_virtiofs.c | 8 +++-
> 1 file
On 3/17/24 16:00, Denis V. Lunev wrote:
> Signed-off-by: Denis V. Lunev
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index 4695391342..44a9b446bd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -20,6 +20,7 @@ __pycache__/
> /build/
>
On 3/14/24 21:22, Rayhan Faizel wrote:
> Signed-off-by: Rayhan Faizel
> ---
> src/openvz/openvz_conf.c | 60
> 1 file changed, 17 insertions(+), 43 deletions(-)
Reviewed-by: Michal Privoznik
and merged. Congratulations on your first libvirt
On Mon, Mar 18, 2024 at 10:00:25AM +0100, Denis V. Lunev wrote:
> On 3/18/24 09:56, Peter Krempa wrote:
> > FYI: Gmail decided that your whole series is spam. I'm not sure whether
> > it's just gmail's spam filter being silly or your mail infra has
> > something wrong, but just so you know.
> >
>
On Mon, Mar 18, 2024 at 09:56:35 +0100, Denis V. Lunev wrote:
> On 3/18/24 09:37, Peter Krempa wrote:
> > On Sun, Mar 17, 2024 at 18:08:49 +0100, Denis V. Lunev wrote:
> > > Technically commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 does not
> > > really introduces a leak, but it is incorrect
Technically commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 does not
really introduces a leak, but it is incorrect ideologically. Neither
function accepting non-const pointer to virDomainDef does not
provide any warrantee that the object will not be improved inside.
Thus, keeping object model in
Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 is idealogically corrent,
but unfortunately is incomplete. There are other similar objects in the
module which are used also without proper initialization.
This patch adds proper clauses to
remoteRelayNetworkEventCheckACL
Signed-off-by: Denis V. Lunev
CC: Peter Krempa
CC: Roman Grigoriev
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
Signed-off-by: Karim Taha
---
src/node_device/node_device_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/node_device/node_device_driver.c
b/src/node_device/node_device_driver.c
index ce42b1ca63..d99b48138e 100644
--- a/src/node_device/node_device_driver.c
Signed-off-by: Karim Taha
---
src/openvz/openvz_driver.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index 1bd96dfb56..fd3c25a393 100644
--- a/src/openvz/openvz_driver.c
+++
Substitute VIR_FREE with g_autofree annotations in openvz_driver.c and
node_device_driver.c whenever possible.
The remaining instances of VIR_FREE are used to free return values
in case of error.
Kariiem (2):
openvz_driver: use g_autofree instead of VIR_FREE in openvz_driver.c
node_device:
Signed-off-by: Denis V. Lunev
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 4695391342..44a9b446bd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -20,6 +20,7 @@ __pycache__/
/build/
/ci/scratch/
tags
+cscope.*
# clangd related ignores
Signed-off-by: Karim Taha
---
src/node_device/node_device_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/node_device/node_device_driver.c
b/src/node_device/node_device_driver.c
index ce42b1ca63..d99b48138e 100644
--- a/src/node_device/node_device_driver.c
Signed-off-by: Karim Taha
---
src/openvz/openvz_driver.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index 1bd96dfb56..fd3c25a393 100644
--- a/src/openvz/openvz_driver.c
+++
Substitute VIR_FREE with g_autofree annotations in openvz_driver.c and
node_device_driver.c whenever possible.
The remaining instances of VIR_FREE are used to free return values
in case of error.
Kariiem (2):
openvz_driver: use g_autofree instead of VIR_FREE in openvz_driver.c
node_device:
From: Kariiem
Signed-off-by: Karim Taha
---
src/node_device/node_device_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/node_device/node_device_driver.c
b/src/node_device/node_device_driver.c
index ce42b1ca63..d99b48138e 100644
---
From: Kariiem
Signed-off-by: Karim Taha
---
src/openvz/openvz_driver.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index 1bd96dfb56..fd3c25a393 100644
--- a/src/openvz/openvz_driver.c
+++
Substiute VIR_FREE with g_autofree annotations in openvz_driver.c and
node_device_driver.c, whenever possbile.
The remaining instances cannot be changed, they are used to free return
values in case of error.
Kariiem (2):
openvz_driver: use g_autofree instead of VIR_FREE in openvz_driver.c
The current way of updating a network configuration uses `virsh
net-update` to add, delete or modify entries. But with such a mechansim
one should know if an entry with current info already exists. Adding
modify-or-add option automatically performs either modify or add
depending on the current
On 3/18/24 09:56, Peter Krempa wrote:
FYI: Gmail decided that your whole series is spam. I'm not sure whether
it's just gmail's spam filter being silly or your mail infra has
something wrong, but just so you know.
On Sun, Mar 17, 2024 at 18:08:50 +0100, Denis V. Lunev wrote:
Commit
On 3/18/24 09:37, Peter Krempa wrote:
On Sun, Mar 17, 2024 at 18:08:49 +0100, Denis V. Lunev wrote:
Technically commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 does not
really introduces a leak, but it is incorrect ideologically. Neither
function accepting non-const pointer to virDomainDef does
FYI: Gmail decided that your whole series is spam. I'm not sure whether
it's just gmail's spam filter being silly or your mail infra has
something wrong, but just so you know.
On Sun, Mar 17, 2024 at 18:08:50 +0100, Denis V. Lunev wrote:
> Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 is
On Sun, Mar 17, 2024 at 18:08:49 +0100, Denis V. Lunev wrote:
> Technically commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 does not
> really introduces a leak, but it is incorrect ideologically. Neither
> function accepting non-const pointer to virDomainDef does not
> provide any warrantee that
On Tue, Mar 12, 2024 at 17:58:08 +, m kamal wrote:
> Thanks a lot for the review, Peter.
>
> The first name I used was by mistake, it's the name of my Github profile,
> Github desktop probably auto-configured it as the global user name for git on
> my machine. It's in Arabic so it could
36 matches
Mail list logo
