[PATCH 1/2] conf: allow display and ramfb for vfio pci hostdevs

2024-03-19 Thread Jonathon Jongsma
We already allow the user to specify display="on" and ramfb="on" for mdev host devices. But newer GPU models will no longer use the mdev framework, so we should enable this same functionality for other non-mdev passthrough PCI devices. Resolves: https://issues.redhat.com/browse/RHEL-28808

[PATCH 2/2] qemu: enable display/ramfb for vfio pci hostdevs

2024-03-19 Thread Jonathon Jongsma
Implement display="on" and ramfb="on" for vfio PCI host devices in qemu. This enables passthrough PCI devices for display just like we did for mdevs. Resolves: https://issues.redhat.com/browse/RHEL-28808 Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_command.c | 10

[PATCH 0/2] Add 'display' and 'ramfb' option for pci hostdevs

2024-03-19 Thread Jonathon Jongsma
see https://issues.redhat.com/browse/RHEL-28808 Jonathon Jongsma (2): conf: allow display and ramfb for vfio pci hostdevs qemu: enable display/ramfb for vfio pci hostdevs docs/formatdomain.rst | 8 src/conf/domain_conf.c| 20 -

Re: [PATCH 0/7] qemu XML testing improvements, part 3 - xmlout->xmlout testing and fixes

2024-03-19 Thread Peter Krempa
On Tue, Mar 19, 2024 at 21:31:52 +0100, Michal Prívozník wrote: > On 1/12/24 17:05, Peter Krempa wrote: > > The main goal of part 3 is to add testing based on parsing of the > > libvirt-formatted files from tests/qemuxml2xmloutdata and formatting > > them back, and checking that they are

Re: [PATCH 0/7] qemu XML testing improvements, part 3 - xmlout->xmlout testing and fixes

2024-03-19 Thread Michal Prívozník
On 1/12/24 17:05, Peter Krempa wrote: > The main goal of part 3 is to add testing based on parsing of the > libvirt-formatted files from tests/qemuxml2xmloutdata and formatting > them back, and checking that they are identical. Firstly, sorry for resurrecting an old thread. Secondly, sorry for

Re: [PATCH] virsysinfo: Try reading DMI table

2024-03-19 Thread Daniel P . Berrangé
On Tue, Mar 19, 2024 at 07:53:35PM -, brett.hol...@canonical.com wrote: > My apologies for this duplicate, please direct reviews to this thread -> > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/G6GPDHYL7CT7MFRECAPL7ZDSXOWQUABG/ No worries, it was my oversight to

Re: [PATCH] virsysinfo: Try reading DMI table

2024-03-19 Thread brett . holman
My apologies for this duplicate, please direct reviews to this thread -> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/G6GPDHYL7CT7MFRECAPL7ZDSXOWQUABG/ ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an

Re: [PATCH] virsysinfo: Try reading DMI table

2024-03-19 Thread brett . holman
My apologies for this duplicate, please direct reviews to this thread -> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/G6GPDHYL7CT7MFRECAPL7ZDSXOWQUABG/ ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an

[PATCH] NEWS: Announce support for MTP filesystem driver type

2024-03-19 Thread Rayhan Faizel
Signed-off-by: Rayhan Faizel --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 489201d3fc..16a34e8114 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v10.2.0 (unreleased) * **New features** + * qemu: Support for driver type ``mtp`` in

Re: [PATCH 0/2] meson: Fix/improve detection of scheduler-related functionality

2024-03-19 Thread Andrea Bolognani
On Tue, Mar 19, 2024 at 05:45:10PM +0100, Michal Prívozník wrote: > On 2/27/24 19:30, Andrea Bolognani wrote: > > This applies on top of [1]. Test pipeline: [2] > > > > Upon further investigation, I have determined that not only > > we are unintentionally using the Linux APIs on FreeBSD instead >

Re: [PATCH 0/2] meson: Fix/improve detection of scheduler-related functionality

2024-03-19 Thread Michal Prívozník
On 2/27/24 19:30, Andrea Bolognani wrote: > This applies on top of [1]. Test pipeline: [2] > > Upon further investigation, I have determined that not only > we are unintentionally using the Linux APIs on FreeBSD instead > of the native ones, but we are also accidentally skipping some > setup

Re: [PATCH 0/4] qemu: Add support for mtp filesystem driver

2024-03-19 Thread Michal Prívozník
On 3/8/24 21:16, Rayhan Faizel wrote: > This patch series adds support for the mtp backed filesystem device > exposed through a virtual USB MTP device. > > Usage: > > > > > > > > Rayhan Faizel (4): > qemu_capabilities: Add QEMU_CAPS_DEVICE_MTP capability > qemu: Support for

Re: [PATCH 2/4] qemu: Support for parsing usb-mtp devices

2024-03-19 Thread Michal Prívozník
On 3/8/24 21:16, Rayhan Faizel wrote: > The source tag sets the rootdir property of the device, which is the directory > exposed to the guest via the MTP device. The target tag sets the desc > property. > This device supports read-only mode as well. Like virtiofs, it does not > support additional

Re: [PATCH 1/4] qemu_capabilities: Add QEMU_CAPS_DEVICE_MTP capability

2024-03-19 Thread Michal Prívozník
On 3/8/24 21:16, Rayhan Faizel wrote: > Signed-off-by: Rayhan Faizel > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1 + >

Re: [PATCH 01/28] vshCmddefHelp: Drop empty line at the end

2024-03-19 Thread Ján Tomko
On a Friday in 2024, Peter Krempa wrote: All virsh commands in non-quiet mode append another separator line thus having two is unnecessary and in quiet mode it still has a trailing blank line. Remove it. Signed-off-by: Peter Krempa --- tools/vsh.c | 1 - 1 file changed, 1 deletion(-)

Plans for 10.2.0 release (freeze on Monday 25 Mar)

2024-03-19 Thread Jiri Denemark
We are getting close to 10.2.0 release of libvirt. To aim for the release on Tuesday 02 Apr I suggest entering the freeze on Monday 25 Mar and tagging RC2 on Thursday 28 Mar. I hope this works for everyone. Jirka ___ Devel mailing list --

Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Claudio Fontana
On 3/19/24 15:58, Jiri Denemark wrote: > On Tue, Mar 19, 2024 at 14:34:08 +0100, Claudio Fontana wrote: >> On 3/19/24 12:02, Adam Julis wrote: >>> vshAdmCatchDisconnect requires non-NULL structure vshControl for >>> getting connection name (stored at opaque), but >>>

Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Ján Tomko
On a Tuesday in 2024, Adam Julis wrote: vshAdmCatchDisconnect requires non-NULL structure vshControl for getting connection name (stored at opaque), but virAdmConnectRegisterCloseCallback at vshAdmConnect called it with NULL. Signed-off-by: Adam Julis --- tools/virt-admin.c | 2 +- 1 file

Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Jiri Denemark
On Tue, Mar 19, 2024 at 14:34:08 +0100, Claudio Fontana wrote: > On 3/19/24 12:02, Adam Julis wrote: > > vshAdmCatchDisconnect requires non-NULL structure vshControl for > > getting connection name (stored at opaque), but > > virAdmConnectRegisterCloseCallback at vshAdmConnect called it > > with

[PATCH v2 1/1] remote: properly initialize objects in ACL helpers

2024-03-19 Thread Denis V. Lunev
Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to implement two things: reduce stack usage inside ACL helpers and minimally initialize virDomainDef object to avoid passing garbage inside validation framework. Though original commit has not touched other ACL helpers. This patch adds

Re: [PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Claudio Fontana
On 3/19/24 12:02, Adam Julis wrote: > vshAdmCatchDisconnect requires non-NULL structure vshControl for > getting connection name (stored at opaque), but > virAdmConnectRegisterCloseCallback at vshAdmConnect called it > with NULL. > > Signed-off-by: Adam Julis > --- > tools/virt-admin.c | 2 +- >

Re: [PATCH 1/2] openvz_driver: use g_autofree instead of VIR_FREE in openvz_driver.c

2024-03-19 Thread Michal Prívozník
On 3/17/24 16:19, Karim Taha wrote: > Signed-off-by: Karim Taha > --- > src/openvz/openvz_driver.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c > index 1bd96dfb56..fd3c25a393 100644 > ---

Re: [PATCH 0/2] Use g_autofree annotatins instead of VIR_FREE

2024-03-19 Thread Michal Prívozník
On 3/17/24 16:19, Karim Taha wrote: > Substitute VIR_FREE with g_autofree annotations in openvz_driver.c and > node_device_driver.c whenever possible. > > The remaining instances of VIR_FREE are used to free return values > in case of error. > > Kariiem (2): > openvz_driver: use g_autofree

[PATCH] virsysinfo: Try reading DMI table

2024-03-19 Thread brett . holman
From: Brett Holman The SMBIOS specification[1] includes RISC-V and mips, and some systems have SMBIOS info. Attempt to read dmidecode and fall back to old behavior if that fails. [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0.pdf Signed-off-by: Brett Holman

[RFC] virsysinfo: Try reading DMI table

2024-03-19 Thread brett . holman
This patch intends to add DMI support to libvirt for RISC-V and mips. This change is based on commit ec6ce6363, which added ARM support. This is not tested on the target arches, as I've been unable to find hardware to test this on. src/util/virsysinfo.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH] virsysinfo: Try reading DMI table

2024-03-19 Thread brett . holman
From: Brett Holman The SMBIOS specification[1] includes RISC-V and mips, and some systems have SMBIOS info. Attempt to read dmidecode and fall back to old behavior if that fails. [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0.pdf Signed-off-by: Brett Holman

[RFC] virsysinfo: Try reading DMI table

2024-03-19 Thread brett . holman
This patch intends to add DMI support to libvirt for RISC-V and mips. This is based on commit ec6ce6363, which added ARM support. This is untested, as I've been unable to find hardware to test this on. src/util/virsysinfo.c | 2 ++ 1 file changed, 2 insertions(+) Cheers, Brett Holman P.S.

[PATCH] virt-admin: Fix segfault when libvirtd dies

2024-03-19 Thread Adam Julis
vshAdmCatchDisconnect requires non-NULL structure vshControl for getting connection name (stored at opaque), but virAdmConnectRegisterCloseCallback at vshAdmConnect called it with NULL. Signed-off-by: Adam Julis --- tools/virt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 1/1] gitignore: add cscope files to git ignore

2024-03-19 Thread Denis V. Lunev
On 3/19/24 11:02, Martin Kletzander wrote: On Mon, Mar 18, 2024 at 09:35:32PM +0100, Denis V. Lunev wrote: On 3/18/24 15:25, Martin Kletzander wrote: On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote: On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote: On Mon, Mar 18,

Re: [PATCH 1/1] gitignore: add cscope files to git ignore

2024-03-19 Thread Martin Kletzander
On Mon, Mar 18, 2024 at 09:35:32PM +0100, Denis V. Lunev wrote: On 3/18/24 15:25, Martin Kletzander wrote: On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote: On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote: On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník

Re: [PATCH] qemu: Add sysusers config file for qemu & kvm user/groups

2024-03-19 Thread Andrea Bolognani
On Mon, Feb 05, 2024 at 03:10:41PM +0100, Peter Krempa wrote: > On Fri, Feb 02, 2024 at 18:59:44 -, t...@siosm.fr wrote: > > Install a systemd sysusers config file for the qemu & kvm user/groups. > > > > We can not use the sysusers_create_compat macro in the RPM specfile to > > create those