Re: [PATCH] security: Ensure kernel/initrd exist before restoring label

2024-04-01 Thread Jim Fehlig
On 3/27/24 08:01, Daniel P. Berrangé wrote: On Mon, Mar 25, 2024 at 07:13:05PM -0600, Jim Fehlig wrote: On 3/21/24 08:57, Daniel P. Berrangé wrote: On Fri, Mar 08, 2024 at 04:26:27PM -0700, Jim Fehlig wrote: When performing an install, it's common for tooling such as virt-install to remove

[PATCH V2] security: Ensure file exists before attempting to restore label

2024-04-01 Thread Jim Fehlig
When performing an install, it's common for tooling such as virt-install to remove the install kernel/initrd once they are successfully booted and the domain has been redefined to boot without them. After the installation is complete and the domain is rebooted/shutdown, the DAC and selinux

[PATCH 3/3] tests: Add testcase for usb-net

2024-04-01 Thread Rayhan Faizel
Add small test case to demonstrate use of usb-net with user networking backend. Signed-off-by: Rayhan Faizel --- .../net-usb.x86_64-latest.args| 35 +++ .../qemuxmlconfdata/net-usb.x86_64-latest.xml | 35 +++ tests/qemuxmlconfdata/net-usb.xml

[PATCH 2/3] conf: Improve parsing of usb-net devices

2024-04-01 Thread Rayhan Faizel
This patch will allow usb-net devices to be automatically assigned a USB address (and skip any attempt to assign a PCI one). Signed-off-by: Rayhan Faizel --- docs/formatdomain.rst | 2 +- src/conf/domain_conf.c | 9 - src/qemu/qemu_domain_address.c | 5 + 3 files

[PATCH 1/3] qemu_capabilities: Re-add QEMU_CAPS_DEVICE_USB_NET capability

2024-04-01 Thread Rayhan Faizel
This capability was previously prefixed with X_ due to not being in use. Signed-off-by: Rayhan Faizel --- src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1 +

[PATCH 0/3] qemu: Improve support for usb-net devices

2024-04-01 Thread Rayhan Faizel
Though usb-net is not explicitly supported, it is already possible to use usb-net devices directly with libvirt (Simply by setting model type as 'usb-net' and manually providing a USB address) This patch series intends to fill in some remaining gaps. 1. Re-add usb-net capability 2. Automatic USB

Re: [PATCH v2 1/1] remote: properly initialize objects in ACL helpers

2024-04-01 Thread Denis V. Lunev
On 3/19/24 15:07, Denis V. Lunev wrote: Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to implement two things: reduce stack usage inside ACL helpers and minimally initialize virDomainDef object to avoid passing garbage inside validation framework. Though original commit has not

[PATCH 2/2] virsh: Display more empathy towards inconsolable VMs :(

2024-04-01 Thread Andrea Bolognani
After attempting, and failing, to console a sad VM, we get back to the user with a fairly sterile message such as error: internal error: character device serial0 is not using a PTY That doesn't properly communicate the extent of our regret for having been unable to cheer up the poor VM despite

[PATCH 1/2] virsh: Show 'connected to console' message later

2024-04-01 Thread Andrea Bolognani
Right now, we display the message before actually attempting to connect to the VM console. That operation, however, can fail for a number of reasons: for example, is the VM doesn't have a serial device, the output ends up looking like $ virsh console cirros Connected to domain 'cirros'

[PATCH 0/2] virsh: Improve console functionality

2024-04-01 Thread Andrea Bolognani
*** APRIL BLURBS *** Andrea Bolognani (2): virsh: Show 'connected to console' message later virsh: Display more empathy towards inconsolable VMs :( tools/virsh-console.c | 24 +--- tools/virsh-domain.c | 7 --- 2 files changed, 17 insertions(+), 14 deletions(-) --