> A colleague asked about the status of this patch and it's availability in
> downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina
> has also reviewed the patch. I've added both R-B to the commit and pushed it.
I appreciate the review and push \o/
Should I have
On 4/3/24 4:26 AM, Marc Hartmayer wrote:
Make sure the old value in `scsi_target->wwpn` is free'd before replacing it.
==9104== 38 bytes in 2 blocks are definitely lost in loss record 1,943 of 3,250
==9104==at 0x483B8C0: malloc (vg_replace_malloc.c:442)
==9104==by 0x4DFB69B: g_malloc
On 4/3/24 6:44 AM, Peter Krempa wrote:
Rework 'virDomainUSBDeviceDefForeach' to use virDomainDeviceInfoIterate
instead of open-coding all iterators. To achieve this
'virDomainDeviceIsUSB' needs to be fixed as it didn't properly handle
'sound', 'fs', 'chr', 'ccid', and 'net usb devices.
missing
On 4/3/24 6:44 AM, Peter Krempa wrote:
Since libvirt now tries to interpret network device models (unless an
unknow model is used) the documentation didn't make a good job
specifying what is supported.
Rewrite the docs to explicitly list the models which we do parse.
Signed-off-by: Peter
If path to the build directory contains spaces (e.g. meson setup
'a b') then our mocks don't work. The problem is in glibc where
not just a colon but also a space character is a delimiter for
LD_PRELOAD [1]. Hence, a test using mock tries to preload
something like libvirt.git/a
The virt-aa-helper bash script constructs a path to itself when
it runs. But it isn't prepared for the case when there is a space
in the path leading to the script (something, something, double
quotes, something).
Signed-off-by: Michal Privoznik
---
tests/virt-aa-helper-test | 4 ++--
1 file
The other day somebody on #virt complained about test suite failing on a
fresh checkout. Turned out, our mocking and some bash scripts are not
prepared for a case when there's a space in builddir path.
After these, there are still some tests failing, but my brain is too
small to fix them:
1)
