Re: [PATCH 2/3] qemu: roll back if not all nbdkit backends are successful

2024-02-12 Thread Peter Krempa
On Thu, Feb 08, 2024 at 15:11:25 -0600, Jonathon Jongsma wrote: > On 1/29/24 2:30 AM, Peter Krempa wrote: > > On Thu, Jan 25, 2024 at 14:52:10 -0600, Jonathon Jongsma wrote: > > > When starting nbdkit processes for the backing store of a disk, we were > > > returning an error if any backing store

Re: [PATCH 2/3] qemu: roll back if not all nbdkit backends are successful

2024-02-08 Thread Jonathon Jongsma
On 1/29/24 2:30 AM, Peter Krempa wrote: On Thu, Jan 25, 2024 at 14:52:10 -0600, Jonathon Jongsma wrote: When starting nbdkit processes for the backing store of a disk, we were returning an error if any backing store failed, but we were not cleaning up processes that succeeded higher in the

Re: [PATCH 2/3] qemu: roll back if not all nbdkit backends are successful

2024-01-29 Thread Peter Krempa
On Thu, Jan 25, 2024 at 14:52:10 -0600, Jonathon Jongsma wrote: > When starting nbdkit processes for the backing store of a disk, we were > returning an error if any backing store failed, but we were not cleaning > up processes that succeeded higher in the chain. Make sure that if we > return a

[PATCH 2/3] qemu: roll back if not all nbdkit backends are successful

2024-01-25 Thread Jonathon Jongsma
When starting nbdkit processes for the backing store of a disk, we were returning an error if any backing store failed, but we were not cleaning up processes that succeeded higher in the chain. Make sure that if we return a failure status from qemuNbdkitStartStorageSource() that we roll back any