Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-18 Thread Denis V. Lunev
On 12/18/23 12:03, Daniel P. Berrangé wrote: On Mon, Dec 18, 2023 at 10:32:07AM +, Daniel P. Berrangé wrote: On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: RPC client implementation uses the following paradigm. The critical section is organized via

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-18 Thread Daniel P . Berrangé
On Mon, Dec 18, 2023 at 10:32:07AM +, Daniel P. Berrangé wrote: > On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: > > RPC client implementation uses the following paradigm. The critical > > section is organized via virObjectLock(client)/virObjectUnlock(client) > > braces. Though

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Denis V. Lunev
On 12/15/23 16:07, Daniel P. Berrangé wrote: On Fri, Dec 15, 2023 at 01:48:09PM +, Efim Shevrin wrote: Hello, here are call traces with two threads generated by python script // == [root@dandreev-vz-6-0-0-243-master libvirt]# gdb -p 288985 (gdb) t a a bt Thread

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Denis V. Lunev
:* Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread [You don't often get email from berra...@redhat.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: RPC client implementation uses

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Daniel P . Berrangé
gt; > *Subject:* Re: [PATCH 3/3] rpc: Rework rpc notifications in main and > > side thread > > [You don't often get email from berra...@redhat.com. Learn why this is > > important at https://aka.ms/LearnAboutSenderIdentification ] > > > > On Fri, Dec 15, 2023 at 02:32

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Daniel P . Berrangé
On Fri, Dec 15, 2023 at 01:48:09PM +, Efim Shevrin wrote: > Hello, > > here are call traces with two threads generated by python script > // == > [root@dandreev-vz-6-0-0-243-master libvirt]# gdb -p 288985 > (gdb) t a a bt > > Thread 2 (Thread 0x7f2112862640 (LWP

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Denis V. Lunev
ration or something similar could be used. Fima Shevrin *From:* Daniel P. Berrangé *Sent:* Friday, December 15, 2023 19:09 *To:* Efim Shevrin *Cc:* devel@lists.libvirt.org ; d...@openvz.org *Subject:* Re: [PATCH

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Efim Shevrin
imilar could be used. Fima Shevrin From: Daniel P. Berrangé Sent: Friday, December 15, 2023 19:09 To: Efim Shevrin Cc: devel@lists.libvirt.org ; d...@openvz.org Subject: Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread [You don't often

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Daniel P . Berrangé
On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: > RPC client implementation uses the following paradigm. The critical > section is organized via virObjectLock(client)/virObjectUnlock(client) > braces. Though this is potentially problematic as > main thread:

[PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-14 Thread Fima Shevrin
RPC client implementation uses the following paradigm. The critical section is organized via virObjectLock(client)/virObjectUnlock(client) braces. Though this is potentially problematic as main thread:side thread: virObjectUnlock(client);