Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

On 4/23/24 3:41 AM, Marc Hartmayer wrote: On Tue, Apr 23, 2024 at 10:06 AM +0100, Daniel P. Berrangé wrote: On Tue, Apr 23, 2024 at 10:46:14AM +0200, Marc Hartmayer wrote: On Tue, Apr 23, 2024 at 09:10 AM +0100, Daniel P. Berrangé wrote: On Tue, Apr 23, 2024 at 10:03:35AM +0200, Marc

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

On Tue, Apr 23, 2024 at 10:06 AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 23, 2024 at 10:46:14AM +0200, Marc Hartmayer wrote: >> On Tue, Apr 23, 2024 at 09:10 AM +0100, Daniel P. Berrangé >> wrote: >> > On Tue, Apr 23, 2024 at 10:03:35AM +0200, Marc Hartmayer wrote: >> >> On Fri, Apr 19,

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

On Tue, Apr 23, 2024 at 10:46:14AM +0200, Marc Hartmayer wrote: > On Tue, Apr 23, 2024 at 09:10 AM +0100, Daniel P. Berrangé > wrote: > > On Tue, Apr 23, 2024 at 10:03:35AM +0200, Marc Hartmayer wrote: > >> On Fri, Apr 19, 2024 at 02:23 PM -0500, Jonathon Jongsma > >> wrote: > >> > On 4/19/24

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

On Tue, Apr 23, 2024 at 09:10 AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 23, 2024 at 10:03:35AM +0200, Marc Hartmayer wrote: >> On Fri, Apr 19, 2024 at 02:23 PM -0500, Jonathon Jongsma >> wrote: >> > On 4/19/24 9:49 AM, Marc Hartmayer wrote: >> >> It's better practice for all functions

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

On Tue, Apr 23, 2024 at 10:03:35AM +0200, Marc Hartmayer wrote: > On Fri, Apr 19, 2024 at 02:23 PM -0500, Jonathon Jongsma > wrote: > > On 4/19/24 9:49 AM, Marc Hartmayer wrote: > >> It's better practice for all functions called by the threads to pass the > >> driver > >> via parameter and not

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

On Fri, Apr 19, 2024 at 02:23 PM -0500, Jonathon Jongsma wrote: > On 4/19/24 9:49 AM, Marc Hartmayer wrote: >> It's better practice for all functions called by the threads to pass the >> driver >> via parameter and not global variables. Easier to test and cleaner. >> […snip…] >> >> >>

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

Reviewed-by: Boris Fiuczynski On 4/19/24 16:49, Marc Hartmayer wrote: It's better practice for all functions called by the threads to pass the driver via parameter and not global variables. Easier to test and cleaner. Signed-off-by: Marc Hartmayer --- src/node_device/node_device_driver.h |

Re: [PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

On 4/19/24 9:49 AM, Marc Hartmayer wrote: It's better practice for all functions called by the threads to pass the driver via parameter and not global variables. Easier to test and cleaner. Signed-off-by: Marc Hartmayer --- src/node_device/node_device_driver.h | 2 +-

[PATCH v1 15/20] node_device_udev: Pass the driver state as parameter in preparation for the next commit

It's better practice for all functions called by the threads to pass the driver via parameter and not global variables. Easier to test and cleaner. Signed-off-by: Marc Hartmayer --- src/node_device/node_device_driver.h | 2 +- src/node_device/node_device_driver.c | 6 +--