Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 09:03:45AM -0500, Jonathon Jongsma wrote: > On 4/18/24 8:52 AM, Cole Robinson wrote: > > On 4/17/24 10:12 AM, Daniel P. Berrangé wrote: > > > On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote: > > > > On 4/9/24 11:20 AM, Boris Fiuczynski wrote: > > > > > On

Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-18 Thread Jonathon Jongsma
On 4/18/24 8:52 AM, Cole Robinson wrote: On 4/17/24 10:12 AM, Daniel P. Berrangé wrote: On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote: On 4/9/24 11:20 AM, Boris Fiuczynski wrote: On 4/9/24 16:56, Cole Robinson wrote: Commit v10.0.0-265-ge67bca23e4 added a `active_config` and

Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-18 Thread Cole Robinson
On 4/18/24 5:11 AM, Boris Fiuczynski wrote: > On 4/17/24 15:58, Cole Robinson wrote: Simplest solution is to fill in `active_config` at XML define time as well. The real node_device driver already takes care to free any `active_config` when it live updates this info, so we are safe

Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-18 Thread Cole Robinson
On 4/17/24 10:12 AM, Daniel P. Berrangé wrote: > On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote: >> On 4/9/24 11:20 AM, Boris Fiuczynski wrote: >>> On 4/9/24 16:56, Cole Robinson wrote: Commit v10.0.0-265-ge67bca23e4 added a `active_config` and `defined_config` to nodedev

Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-18 Thread Boris Fiuczynski
On 4/17/24 15:58, Cole Robinson wrote: Simplest solution is to fill in `active_config` at XML define time as well. The real node_device driver already takes care to free any `active_config` when it live updates this info, so we are safe there. I do not think that it is a good idea to hack the

Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-17 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 09:58:10AM -0400, Cole Robinson wrote: > On 4/9/24 11:20 AM, Boris Fiuczynski wrote: > > On 4/9/24 16:56, Cole Robinson wrote: > >> Commit v10.0.0-265-ge67bca23e4 added a `active_config` and > >> `defined_config` to nodedev mdev internal XML handling. > >> `defined_config`

Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-17 Thread Cole Robinson
On 4/9/24 11:20 AM, Boris Fiuczynski wrote: > On 4/9/24 16:56, Cole Robinson wrote: >> Commit v10.0.0-265-ge67bca23e4 added a `active_config` and >> `defined_config` to nodedev mdev internal XML handling. >> `defined_config` can be filled at XML parse time, but `active_config` >> must be filled in

Re: [PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-09 Thread Boris Fiuczynski
On 4/9/24 16:56, Cole Robinson wrote: Commit v10.0.0-265-ge67bca23e4 added a `active_config` and `defined_config` to nodedev mdev internal XML handling. `defined_config` can be filled at XML parse time, but `active_config` must be filled in by nodedev driver. This wasn't implemented for the test

[PATCH v3 5/5] conf: nodedev: Fill active_config at XML parse time

2024-04-09 Thread Cole Robinson
Commit v10.0.0-265-ge67bca23e4 added a `active_config` and `defined_config` to nodedev mdev internal XML handling. `defined_config` can be filled at XML parse time, but `active_config` must be filled in by nodedev driver. This wasn't implemented for the test driver however, which caused