[PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest

2023-11-02 Thread Laine Stump
This environment variable is supposedly set according to the contents of ~/.CFUserTextEncoding, and certainly on MacOS 14 (Sonoma) it shows up in the environment, causing commandtest to fail. However, the value that is shown in $__CF_USER_TEXT_ENCODING during the test 1) is not in the environment

Re: [libvirt PATCH 0/2] rpc: Make rpcgen produce ANSI C code

2023-11-02 Thread Laine Stump
On 11/2/23 7:37 PM, Andrea Bolognani wrote: Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059558331 Should make it possible to build libvirt on macOS 14, where it currently fails with src/rpc/virnetprotocol.c:13:1: error: a function definition without a prototype is

[libvirt PATCH 2/2] rpc: Make rpcgen produce ANSI C code

2023-11-02 Thread Andrea Bolognani
This is the default for the version of rpcgen shipped with Linux distributions, but the one in macOS and possibly others default to K C, which modern compilers don't appreciate. Luckily, all versions of rpcgen shipped with our target platforms seem to support the -C option. Signed-off-by: Andrea

[libvirt PATCH 1/2] rpc: Drop support for portable-rpcgen

2023-11-02 Thread Andrea Bolognani
We use the native version of rpcgen everywhere. Signed-off-by: Andrea Bolognani --- meson.build| 12 +--- src/rpc/genprotocol.pl | 3 --- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/meson.build b/meson.build index dc0969abcc..158a7cae01 100644 ---

[libvirt PATCH 0/2] rpc: Make rpcgen produce ANSI C code

2023-11-02 Thread Andrea Bolognani
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059558331 Should make it possible to build libvirt on macOS 14, where it currently fails with src/rpc/virnetprotocol.c:13:1: error: a function definition without a prototype is deprecated in all versions of C and is not

Re: mingw rpm build busted? (was: Release of libvirt-9.9.0)

2023-11-02 Thread Andrea Bolognani
On Wed, Nov 01, 2023 at 05:21:18PM -0400, Cole Robinson wrote: > On 11/1/23 11:02 AM, Daniel P. Berrangé wrote: > > On Wed, Nov 01, 2023 at 10:54:25AM -0400, Cole Robinson wrote: > >> RPM build is busted in mingw meson step. rawhide log: > >>

[libvirt PATCH 09/11] rpm: Introduce with_native

2023-11-02 Thread Andrea Bolognani
The new _without_native knob makes it possible to skip the native build completely and build for MinGW only. Best viewed with 'git show -w'. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 395 +--- 1 file changed, 210 insertions(+), 185

[libvirt PATCH 10/11] ci: Refresh generated files

2023-11-02 Thread Andrea Bolognani
The native version of gettext is now included in MinGW containers. Signed-off-by: Andrea Bolognani --- ci/buildenv/fedora-38-cross-mingw32.sh| 1 + ci/buildenv/fedora-38-cross-mingw64.sh| 1 + ci/buildenv/fedora-rawhide-cross-mingw32.sh | 1 +

[libvirt PATCH 11/11] ci: Build RPMs on MinGW

2023-11-02 Thread Andrea Bolognani
Now that the spec file supports selectively disabling the native, mingw32 and mingw64 parts, we can add coverage for the MinGW RPM builds. Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 11 --- ci/jobs.sh | 19 ++- 2 files changed, 26 insertions(+), 4

[libvirt PATCH 08/11] rpm: Introduce with_mingw32/with_mingw64

2023-11-02 Thread Andrea Bolognani
These replace the existing with_mingw but offer additional granularity. The existing _without_mingw knob retains its behavior of disabling all MinGW builds at once for convenience, while the newly introduced _without_mingw32/_without_mingw64 knobs make it possible to disable only one of them.

[libvirt PATCH 07/11] rpm: Split call to mingw_debug_package

2023-11-02 Thread Andrea Bolognani
This is functionally equivalent and will make future patches nicer. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index dc67ffabcc..6a999860f5 100644 --- a/libvirt.spec.in +++

[libvirt PATCH 06/11] rpm: Shuffle BuildRequires around

2023-11-02 Thread Andrea Bolognani
Move all dependencies that are needed both for native builds and for MinGW ones near the top of the list. This will make future patches nicer. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libvirt.spec.in

[libvirt PATCH 05/11] rpm: Add libxml2 BuildRequires for xmllint

2023-11-02 Thread Andrea Bolognani
It's already been dragged in by the -devel package, but since we use the command line tool directly as part of our build process it's more correct to explicitly depend on the runtime package. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git

[libvirt PATCH 04/11] rpm: Explain a couple of BuildRequires

2023-11-02 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index d16d622153..8248e2ca80 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -292,6 +292,7 @@ BuildRequires: xen-devel %endif BuildRequires:

[libvirt PATCH 03/11] rpm: Rename module-init-tools -> kmod

2023-11-02 Thread Andrea Bolognani
The old package name is only kept around for compatibility reasons. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f21f76b256..d16d622153 100644 --- a/libvirt.spec.in +++

[libvirt PATCH 02/11] rpm: Explicitly enable NLS support

2023-11-02 Thread Andrea Bolognani
We want it both for native builds and MinGW ones. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 342a88024a..f21f76b256 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@

[libvirt PATCH 00/11] ci: Build RPMs on MinGW

2023-11-02 Thread Andrea Bolognani
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059447352 The openSUSE Leap 15 job failed, but that's caused by an unrelated packaging issue: $ pkg-config --cflags libtirpc -I/usr/include/tirpc $ rpm -ql libtirpc-devel | grep usr/include /usr/include/netconfig.h

[libvirt PATCH 01/11] rpm: Disable expensive tests for MinGW builds

2023-11-02 Thread Andrea Bolognani
Tests are disabled so this combination never made any sense, but with recent changes it has turned into a build failure. Fixes: 8ce0decc372051d616018f57ae268e2f03082eec Reported-by: Cole Robinson Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] virDomainDeviceInfoCheckABIStability: Implement proper check for CCW addresses

2023-11-02 Thread Peter Krempa
CCW addresses need to be also checked for ABI stability. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 80f467ae7a..5ce1793c2d 100644 ---

Re: [PATCH v8 0/4] pci hotplug tracking

2023-11-02 Thread Vladimir Sementsov-Ogievskiy
On 02.11.23 16:32, Michael S. Tsirkin wrote: On Thu, Nov 02, 2023 at 04:28:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 02.11.23 15:12, Michael S. Tsirkin wrote: On Thu, Nov 02, 2023 at 03:00:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 02.11.23 14:31, Michael S. Tsirkin wrote:

Re: [PATCH v8 0/4] pci hotplug tracking

2023-11-02 Thread Michael S. Tsirkin
On Thu, Nov 02, 2023 at 04:28:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 02.11.23 15:12, Michael S. Tsirkin wrote: > > On Thu, Nov 02, 2023 at 03:00:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 02.11.23 14:31, Michael S. Tsirkin wrote: > > > > On Thu, Oct 05, 2023 at

Re: [PATCH v8 0/4] pci hotplug tracking

2023-11-02 Thread Vladimir Sementsov-Ogievskiy
On 02.11.23 15:12, Michael S. Tsirkin wrote: On Thu, Nov 02, 2023 at 03:00:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 02.11.23 14:31, Michael S. Tsirkin wrote: On Thu, Oct 05, 2023 at 12:29:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi all! Main thing this series does is

Re: [PATCH v8 0/4] pci hotplug tracking

2023-11-02 Thread Michael S. Tsirkin
On Thu, Nov 02, 2023 at 03:00:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 02.11.23 14:31, Michael S. Tsirkin wrote: > > On Thu, Oct 05, 2023 at 12:29:22PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Hi all! > > > > > > Main thing this series does is DEVICE_ON event - a

Re: [PATCH v8 0/4] pci hotplug tracking

2023-11-02 Thread Vladimir Sementsov-Ogievskiy
On 02.11.23 14:31, Michael S. Tsirkin wrote: On Thu, Oct 05, 2023 at 12:29:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi all! Main thing this series does is DEVICE_ON event - a counter-part to DEVICE_DELETED. A guest-driven event that device is powered-on. Details are in patch 2. The new

Re: [PATCH v8 0/4] pci hotplug tracking

2023-11-02 Thread Vladimir Sementsov-Ogievskiy
[cc Peter, Nikolay and libvirt list] On 02.11.23 11:06, Vladimir Sementsov-Ogievskiy wrote: Ping. And some addition. We have the case, when the commit commit 7bed89958bfbf40df9ca681cefbdca63abdde39d Author: Maxim Levitsky Date:   Tue Oct 6 14:38:58 2020 +0200     device_core: use