Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Bernhard Beschow
Am 26. März 2024 13:29:58 UTC schrieb "Philippe Mathieu-Daudé" : >Hi Igor, > >On 26/3/24 14:08, Thomas Huth wrote: >> >> s/iaspc/isapc/ in the subject >> >> On 26/03/2024 13.51, Igor Mammedov wrote: >>> ISAPC machine was introduced 25 years ago and it's a lot of time since >>> such machine

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Paolo Bonzini
Il mer 27 mar 2024, 14:09 Igor Mammedov ha scritto: > It's question of whether we are willing to do unthinkable, > i.e. to break QEMU <-> guest ABI for isapc case by removing > corresponding fwcfg entries. > It's not unthinkable since it's unversioned. we are loosing a chance to cleanup > QEMU

Re: [PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Richard Henderson
On 3/27/24 04:48, Philippe Mathieu-Daudé wrote: TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé --- fpu/softfloat-specialize.c.inc | 2 +-

Re: [PATCH v2 1/1] remote: properly initialize objects in ACL helpers

2024-03-27 Thread Denis V. Lunev
On 3/19/24 15:07, Denis V. Lunev wrote: Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to implement two things: reduce stack usage inside ACL helpers and minimally initialize virDomainDef object to avoid passing garbage inside validation framework. Though original commit has not

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 18:29, Marcin Juszkiewicz wrote: W dniu 27.03.2024 o 17:54, Philippe Mathieu-Daudé pisze: diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7b548519b5..345c35507f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -208,6 +208,13 @@ is no

Re: [PATCH 2/3] nodedev: immediate update of active config on udev add

2024-03-27 Thread Marc Hartmayer
On Wed, Mar 27, 2024 at 10:53 AM -0500, Jonathon Jongsma wrote: > On 3/20/24 10:46 AM, Boris Fiuczynski wrote: >> When an udev add event occurs the mdev active config data requires an >> update via mdevctl as the udev does not contain all config data. >> This update needs to occur immediate and

Re: [libvirt PATCH] NEWS: Update

2024-03-27 Thread Andrea Bolognani
On Wed, Mar 27, 2024 at 04:07:13PM +0100, Ján Tomko wrote: > Update NEWS with new news. > > Signed-off-by: Ján Tomko > --- > NEWS.rst | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index ef9e312698..ce83ee629f 100644 > --- a/NEWS.rst > +++

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 16:39, Thomas Huth wrote: On 27/03/2024 15.15, Philippe Mathieu-Daudé wrote: On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code

[RFC PATCH 0/2] One memory leak fix and one question

2024-03-27 Thread Marc Hartmayer
Marc Hartmayer (2): node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak TODO virNodeDeviceUpdateCaps: checks missing? src/conf/node_device_conf.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) -- 2.34.1

[PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
Per Daniel suggestion [*]: > isapc could arguably be restricted to just 32-bit CPU models, > because we should not need it to support any feature that didn't > exist prior to circa 1995. eg refuse to start with isapc, if 'lm' > is present in the CPU model for example. Display a warning when

[RFC PATCT 2/2] TODO virNodeDeviceUpdateCaps: checks missing?

2024-03-27 Thread Marc Hartmayer
I'm not familiar with the code so I cannot decide if ignoring the return values is a bug or not. At least, it looks awkward and should be annotated. Signed-off-by: Marc Hartmayer --- src/conf/node_device_conf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[RFC PATCH 1/2] node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak

2024-03-27 Thread Marc Hartmayer
Make sure the old value in `scsi_target->wwpn` is free'd before replacing it. While at it, simplify the code. ==9104== 38 bytes in 2 blocks are definitely lost in loss record 1,943 of 3,250 ==9104==at 0x483B8C0: malloc (vg_replace_malloc.c:442) ==9104==by 0x4DFB69B: g_malloc (gmem.c:130)

Re: [PATCH for 10.2.0 0/3] Fix spurious error from PCI VPD parsing

2024-03-27 Thread Ján Tomko
On a Wednesday in 2024, Peter Krempa wrote: Multiple people complained, let's fix it for the next release. Peter Krempa (3): virpcivpd: Revert error reporting from PCI VPD parser pci: Remove error reporting from PCI VPD parsing NEWS: Mention fix for PCI VPD error reporting NEWS.rst

Re: [PATCH 2/3] pci: Remove error reporting from PCI VPD parsing

2024-03-27 Thread Ján Tomko
On a Wednesday in 2024, Peter Krempa wrote: The PCI VPD (Vital Product Data) may be missing or the kernel can report presence but not actually have the data. Also the data is specified by the device vendor and thus may be invalid in some cases. To avoid log spamming, since the only usage in the

[PATCH 2/3] pci: Remove error reporting from PCI VPD parsing

2024-03-27 Thread Peter Krempa
The PCI VPD (Vital Product Data) may be missing or the kernel can report presence but not actually have the data. Also the data is specified by the device vendor and thus may be invalid in some cases. To avoid log spamming, since the only usage in the node device driver is ignoring errors, remove

[PATCH 3/3] NEWS: Mention fix for PCI VPD error reporting

2024-03-27 Thread Peter Krempa
Signed-off-by: Peter Krempa --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ef9e312698..05fd9e3194 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -52,6 +52,17 @@ v10.2.0 (unreleased) releases to 10.2.0 works as well, but the other direction

[PATCH for 10.2.0 0/3] Fix spurious error from PCI VPD parsing

2024-03-27 Thread Peter Krempa
Multiple people complained, let's fix it for the next release. Peter Krempa (3): virpcivpd: Revert error reporting from PCI VPD parser pci: Remove error reporting from PCI VPD parsing NEWS: Mention fix for PCI VPD error reporting NEWS.rst| 11 po/POTFILES

[PATCH 1/3] virpcivpd: Revert error reporting from PCI VPD parser

2024-03-27 Thread Peter Krempa
The VPD parsing is fragile and depends on hardware vendor's adherance to standards. Since libvirt only ever uses this data to report it in the nodedev XML which ignores any errors there's no much point in having error reporting which I've added recently. Turn the errors into VIR_DEBUG statements

Re: [PATCH-for-9.0] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2024 at 04:35:17PM +0100, Philippe Mathieu-Daudé wrote: > Per Daniel suggestion [*]: > > > isapc could arguably be restricted to just 32-bit CPU models, > > because we should not need it to support any feature that didn't > > exist prior to circa 1995. eg refuse to start with

Re: [PATCH 2/3] nodedev: immediate update of active config on udev add

2024-03-27 Thread Jonathon Jongsma
On 3/20/24 10:46 AM, Boris Fiuczynski wrote: When an udev add event occurs the mdev active config data requires an update via mdevctl as the udev does not contain all config data. This update needs to occur immediate and to be finished before the libvirt CREATE event is issued to keep the API

Re: [PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Thomas Huth
On 27/03/2024 15.48, Philippe Mathieu-Daudé wrote: TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé --- fpu/softfloat-specialize.c.inc |

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
On 27/03/2024 15.15, Philippe Mathieu-Daudé wrote: On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1

[PATCH-for-9.0] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
Per Daniel suggestion [*]: > isapc could arguably be restricted to just 32-bit CPU models, > because we should not need it to support any feature that didn't > exist prior to circa 1995. eg refuse to start with isapc, if 'lm' > is present in the CPU model for example. [*]

[libvirt PATCH] NEWS: Update

2024-03-27 Thread Ján Tomko
Update NEWS with new news. Signed-off-by: Ján Tomko --- NEWS.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ef9e312698..ce83ee629f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -36,6 +36,13 @@ v10.2.0 (unreleased) use the upcoming QEMU

[PATCH-for-9.1 v2 3/3] hw/timer: Remove the ALTERA_TIMER model

2024-03-27 Thread Philippe Mathieu-Daudé
The ALTERA_TIMER was only used by Nios II machines, which have been removed. Since it has no direct user, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/altera_timer.c | 244 hw/timer/Kconfig| 4 - hw/timer/meson.build| 1 -

[PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Philippe Mathieu-Daudé
TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé --- fpu/softfloat-specialize.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH-for-9.1 v2 0/3] target/nios2: Remove the deprecated Nios II target

2024-03-27 Thread Philippe Mathieu-Daudé
Since v1: - Remove user emulation too - Remove ALTERA_TIMER Philippe Mathieu-Daudé (3): fpu/softfloat: Remove mention of TILE-Gx target target/nios2: Remove the deprecated Nios II target hw/timer: Remove the ALTERA_TIMER model MAINTAINERS | 13 -

Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device

2024-03-27 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > The whole RDMA subsystem was deprecated in commit e9a54265f5 > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") > released in v8.2. Time to remove it. > > Keep the RAM_SAVE_FLAG_HOOK definition since it might appears > in old migration streams. > >

Re: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 15:08, Zhao Liu wrote: On Wed, Mar 27, 2024 at 10:51:12AM +0100, Philippe Mathieu-Daudé wrote: Date: Wed, 27 Mar 2024 10:51:12 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() X-Mailer:

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture").

Re: [PATCH] security: Ensure kernel/initrd exist before restoring label

2024-03-27 Thread Daniel P . Berrangé
On Mon, Mar 25, 2024 at 07:13:05PM -0600, Jim Fehlig wrote: > On 3/21/24 08:57, Daniel P. Berrangé wrote: > > On Fri, Mar 08, 2024 at 04:26:27PM -0700, Jim Fehlig wrote: > > > When performing an install, it's common for tooling such as virt-install > > > to remove the install kernel/initrd once

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Tue, Mar 26, 2024 at 02:29:58PM +0100, Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 26/3/24 14:08, Thomas Huth wrote: > > > > s/iaspc/isapc/ in the subject > > > > On 26/03/2024 13.51, Igor Mammedov wrote: > > > ISAPC machine was introduced 25 years ago and it's a lot of time since > > >

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2024 at 01:27:58PM +, Peter Maydell wrote: > On Wed, 27 Mar 2024 at 13:23, Daniel P. Berrangé wrote: > > > > On Wed, Mar 27, 2024 at 02:09:17PM +0100, Igor Mammedov wrote: > > > On Wed, 27 Mar 2024 10:49:43 + > > > Daniel P. Berrangé wrote: > > > It's question of whether

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Peter Maydell
On Wed, 27 Mar 2024 at 13:23, Daniel P. Berrangé wrote: > > On Wed, Mar 27, 2024 at 02:09:17PM +0100, Igor Mammedov wrote: > > On Wed, 27 Mar 2024 10:49:43 + > > Daniel P. Berrangé wrote: > > It's question of whether we are willing to do unthinkable, > > i.e. to break QEMU <-> guest ABI for

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 14:09, Igor Mammedov wrote: On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote:

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2024 at 02:09:17PM +0100, Igor Mammedov wrote: > On Wed, 27 Mar 2024 10:49:43 + > Daniel P. Berrangé wrote: > > > On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: > > > On Tue, 26 Mar 2024 14:29:58 +0100 > > > Philippe Mathieu-Daudé wrote: > > > > > > > Hi

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture"). Please remind me, why didn't we

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Thomas Huth
On 27/03/2024 14.09, Igor Mammedov wrote: On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote:

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: > On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: > > On Tue, 26 Mar 2024 14:29:58 +0100 > > Philippe Mathieu-Daudé wrote: > > > > > Hi Igor, > > > > > > On 26/3/24 14:08, Thomas Huth wrote: > > > > > > > >

Re: [PATCH-for-9.1 v2 02/21] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:04AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:04 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 02/21] hw/usb/hcd-xhci: Remove > XHCI_FLAG_FORCE_PCIE_ENDCAP flag > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 01/21] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:03AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:03 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 01/21] hw/i386/pc: Remove deprecated > pc-i440fx-2.0 machine > X-Mailer: git-send-email 2.41.0 > > The pc-i440fx-2.0

[PATCH v2] Extend libvirt-guests to shutdown only persistent VMs

2024-03-27 Thread Benjamin Taubmann
At the moment, there is no configuration option for the libvirt-guests service that allows users to define that only persistent virtual machines should be shutdown on host shutdown. Currently, the service config allows to choose between two ON_SHUTDOWN actions that are executed on running virtual

Re: [PATCH-for-9.0 0/2] target/monitor: Deprecate 'info tlb/mem' in favor of 'info mmu'

2024-03-27 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Wed, 20 Mar 2024 at 17:06, Philippe Mathieu-Daudé > wrote: > > > > +Alex/Daniel > > > > On 20/3/24 17:53, Peter Maydell wrote: > > > On Wed, 20 Mar 2024 at 16:40, Philippe Mathieu-Daudé > > > wrote: > > >> > > >> 'info tlb' and 'info mem'

Re: [PATCH] virsysinfo: Try reading DMI table

2024-03-27 Thread Kristina Hanicova
On Tue, Mar 26, 2024 at 8:45 PM wrote: > From: Brett Holman > > Add DMI support for risc-v and mips. Attempt to read dmidecode and > fall back to old behavior if that fails. > > The SMBIOS specification[1] officially supports both RISC-V and LoongArch. > Some mips-based Loongson-3 processors

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture"). Cc: Marek Vasut Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS

Re: [libvirt PATCH 2/2] qemu_snapshot: correctly update metadata when deleting external snapshot with multiple branches

2024-03-27 Thread Peter Krempa
On Mon, Feb 26, 2024 at 14:40:50 +0100, Pavel Hrdina wrote: > XML metadata for snapshot contains only single list of disk overlays > from the moment when the snapshot was taken. When user creates multiple > branches of snapshots the parent snapshot will still list only the > original disk

Re: [libvirt PATCH 1/2] qemu_snapshot: call qemuSnapshotDeleteUpdateDisks only for external snapshots

2024-03-27 Thread Peter Krempa
On Mon, Feb 26, 2024 at 14:40:49 +0100, Pavel Hrdina wrote: > Calling this function when deleting internal snapshot isn't required > because with internal snapshots all changes are done within the file > itself so there is no file deletion and no need to update snapshot > metadata. > >

Re: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

2024-03-27 Thread David Hildenbrand
On 27.03.24 10:51, Philippe Mathieu-Daudé wrote: 'legacy_align' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-11-phi...@linaro.org> --- I was really confused for a second until I saw that this series is dependent

Re: [PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-03-27 Thread David Hildenbrand
void memory_device_pre_plug(MemoryDeviceState *md, MachineState *ms, -const uint64_t *legacy_align, Error **errp) +Error **errp) { const MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(md); Error *local_err = NULL; @@

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: > On Tue, 26 Mar 2024 14:29:58 +0100 > Philippe Mathieu-Daudé wrote: > > > Hi Igor, > > > > On 26/3/24 14:08, Thomas Huth wrote: > > > > > > s/iaspc/isapc/ in the subject > > > > > > On 26/03/2024 13.51, Igor Mammedov wrote: > >

[PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::acpi_data_size was only used by the pc-i440fx-2.0 machine, which got removed. Since it is constant, replace the class field by a definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-19-phi...@linaro.org> ---

[PATCH-for-9.1 v2 20/21] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-03-27 Thread Philippe Mathieu-Daudé
X86CPU::kvm_no_smi_migration was only used by the pc-i440fx-2.3 machine, which got removed. Remove it and simplify kvm_put_vcpu_events(). Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.h | 3 --- target/i386/cpu.c | 2 -- target/i386/kvm/kvm.c | 7 +-- 3 files changed, 1

[PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4 to 2.7 pc-i440fx machines

2024-03-27 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.3 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Similarly to the cited commit, deprecate the 2.4 to 2.7 machines. Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH-for-9.1 v2 18/21] hw/i386/acpi: Remove AcpiBuildState::rsdp field

2024-03-27 Thread Philippe Mathieu-Daudé
AcpiBuildState::rsdp is always NULL, remove it, simplifying acpi_build_update(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-16-phi...@linaro.org> --- hw/i386/acpi-build.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff

[PATCH-for-9.1 v2 17/21] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::rsdp_in_ram was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_setup(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-15-phi...@linaro.org> --- include/hw/i386/pc.h

[PATCH-for-9.1 v2 16/21] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::resizable_acpi_blob was only used by the pc-i440fx-2.2 machine, which got removed. It is now always true. Remove it, simplifying acpi_build(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/acpi-build.c | 10 -- hw/i386/pc.c | 1

[PATCH-for-9.1 v2 15/21] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine

2024-03-27 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.2 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-03-27 Thread Philippe Mathieu-Daudé
'legacy_align' is always NULL, remove it, simplifying memory_device_pre_plug(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-12-phi...@linaro.org> --- include/hw/mem/memory-device.h | 2 +- hw/i386/pc.c | 3 +--

[PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

2024-03-27 Thread Philippe Mathieu-Daudé
'legacy_align' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240305134221.30924-11-phi...@linaro.org> --- include/hw/mem/pc-dimm.h | 3 +-- hw/arm/virt.c| 2 +- hw/i386/pc.c | 2 +- hw/loongarch/virt.c | 2

[PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::enforce_aligned_dimm was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true. Remove it, simplifying pc_get_device_memory_range(). Update the comment in Avocado test_phybits_low_pse36(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h

[PATCH-for-9.1 v2 11/21] hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid()

2024-03-27 Thread Philippe Mathieu-Daudé
'smbios_encode_uuid' is always true, remove it, simplifying smbios_encode_uuid(). Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 8261eb716f..3b7703489d 100644

[PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-03-27 Thread Philippe Mathieu-Daudé
'uuid_encoded' is always NULL, remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/firmware/smbios.h | 3 +-- hw/arm/virt.c| 3 +-- hw/i386/fw_cfg.c | 2 +- hw/loongarch/virt.c | 2 +- hw/riscv/virt.c | 2 +- hw/smbios/smbios.c

[PATCH-for-9.1 v2 09/21] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::smbios_uuid_encoded was only used by the pc-i440fx-2.1 machine, which got removed. It is now always true, remove it. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/fw_cfg.c | 3 +-- hw/i386/pc.c | 1 - 3 files

[PATCH-for-9.1 v2 08/21] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h'

2024-03-27 Thread Philippe Mathieu-Daudé
x86_cpu_change_kvm_default() was only used out of kvm-cpu.c by the pc-i440fx-2.1 machine, which got removed. Make it static, and remove its declaration. "kvm-cpu.h" is now empty, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH-for-9.1 v2 07/21] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine

2024-03-27 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.1 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH-for-9.1 v2 06/21] hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug'

2024-03-27 Thread Philippe Mathieu-Daudé
acpi_memory_hotplug::is_enabled is set to %true once via ich9_lpc_initfn() -> ich9_pm_add_properties(). No need to check it, so remove now dead code. Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/ich9.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-)

[PATCH-for-9.1 v2 05/21] hw/acpi/ich9: Remove 'memory-hotplug-support' property

2024-03-27 Thread Philippe Mathieu-Daudé
No external code sets the 'memory-hotplug-support' property, remove it. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/ich9.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 573d032e8e..9b605af21a 100644

[PATCH-for-9.1 v2 04/21] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size

2024-03-27 Thread Philippe Mathieu-Daudé
PCMachineClass::legacy_acpi_table_size was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify acpi_build(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/acpi-build.c | 62 +--- 2 files

[PATCH-for-9.1 v2 03/21] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag

2024-03-27 Thread Philippe Mathieu-Daudé
XHCI_FLAG_SS_FIRST was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify various functions in hcd-xhci.c. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-xhci.h | 3 +-- hw/usb/hcd-xhci-nec.c | 2 -- hw/usb/hcd-xhci-pci.c | 1

[PATCH-for-9.1 v2 02/21] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag

2024-03-27 Thread Philippe Mathieu-Daudé
XHCI_FLAG_FORCE_PCIE_ENDCAP was only used by the pc-i440fx-2.0 machine, which got removed. Remove it and simplify usb_xhci_pci_realize(). Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-xhci.h | 1 - hw/usb/hcd-xhci-nec.c | 2 -- hw/usb/hcd-xhci-pci.c | 3 +--

[PATCH-for-9.1 v2 01/21] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

2024-03-27 Thread Philippe Mathieu-Daudé
The pc-i440fx-2.0 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id:

[PATCH-for-9.1 v2 00/21] hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines

2024-03-27 Thread Philippe Mathieu-Daudé
Missing review: 4-6, 10-12, 16, 19-20 Since v1: - Addressed Zhao and Thomas review comments - Removal around ICH9 acpi_memory_hotplug (Thomas) Kill legacy code, because we need to evolve. I ended there via dynamic machine -> ICH9 -> legacy ACPI... This should also help Igor cleanups:

Re: [PATCH-for-9.1 17/18] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-03-27 Thread Philippe Mathieu-Daudé
On 6/3/24 19:30, Thomas Huth wrote: On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: X86CPU::kvm_no_smi_migration was only used by the pc-i440fx-2.3 machine, which got removed. Remove it and simplify kvm_put_vcpu_events(). Signed-off-by: Philippe Mathieu-Daudé ---   target/i386/cpu.h |

Re: [PATCH-for-9.1 01/18] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

2024-03-27 Thread Philippe Mathieu-Daudé
On 6/3/24 17:41, Thomas Huth wrote: On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote: The pc-i440fx-2.0 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Gerd Hoffmann
On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote: > Heh I've actually been using isapc over the past couple of weeks to fire up > some old programs in a Windows 3 VM :) I'm wondering why these use cases can't simply use the 'pc' machine type? The early pci chipsets of the 90-ies