From: Zhao Liu
The "parameter=0" SMP configurations have been marked as deprecated
since v6.2.
For these cases, -smp currently returns the warning and adjusts the
zeroed parameters to 1 by default.
Remove the above compatibility logic in v9.0, and return error directly
if any -smp
Hi Prasad,
On Mon, Mar 04, 2024 at 11:23:58AM +0530, Prasad Pandit wrote:
> Date: Mon, 4 Mar 2024 11:23:58 +0530
> From: Prasad Pandit
> Subject: Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0"
> SMP configurations
>
> On Mon, 4 Mar 2024 at 10:0
Hi Prasad,
> On Mon, 4 Mar 2024 at 12:19, Zhao Liu wrote:
> > > unsigned maxcpus = config->has_maxcpus ? config->maxcpus : 0;
> >
> > This indicates the default maxcpus is initialized as 0 if user doesn't
> > specifies it.
>
> * 'has_maxcpus' should b
Hi Philippe,
On Tue, Mar 05, 2024 at 02:42:04PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Tue, 5 Mar 2024 14:42:04 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 02/18] hw/usb/hcd-xhci: Enumerate xhci_flags
> setting values
> X-Mailer: git-send-email 2.41.0
>
> xhci_flags
On Thu, Mar 07, 2024 at 07:22:10AM +0100, Thomas Huth wrote:
> Date: Thu, 7 Mar 2024 07:22:10 +0100
> From: Thomas Huth
> Subject: Re: [PATCH 02/14] hw/core/machine-smp: Deprecate unsupported
> "parameter=1" SMP configurations
>
> On 06/03/2024 10.53, Zhao L
Hi Prasad,
> On Tue, 5 Mar 2024 at 12:59, Zhao Liu wrote:
> > After simple test, if user sets maxcpus as 0, the has_maxcpus will be
> > true as well...I think it's related with QAPI code generation logic.
>
> * Right.
>
> [Maybe we digressed a bit in the di
On Wed, Mar 06, 2024 at 10:19:41AM +0530, Prasad Pandit wrote:
> Date: Wed, 6 Mar 2024 10:19:41 +0530
> From: Prasad Pandit
> Subject: Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0"
> SMP configurations
>
> Hello Zhao,
>
> On Wed, 6
From: Zhao Liu
The "parameter=0" SMP configurations have been marked as deprecated
since v6.2.
For these cases, -smp currently returns the warning and adjusts the
zeroed parameters to 1 by default.
Remove the above compatibility logic in v9.0, and return error directly
if any -smp
From: Zhao Liu
Currentlt, it was allowed for users to specify the unsupported
topology parameter as "1". For example, x86 PC machine doesn't
support drawer/book/cluster topology levels, but user could specify
"-smp drawers=1,books=1,clusters=1".
This is meaningle
ligned_dimm
> -property for pc machines and pc_get_device_memory_range()). That
> leaves
> + for dimm alignment for all machines. That leaves
Just nit, better align it here.
Reviewed-by: Zhao Liu
> total hotpluggable actual memory size of 59 GiB. If the VM is starte
---
> 2 files changed, 12 insertions(+), 51 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
--
> hw/i386/pc.c | 1 -
> 3 files changed, 14 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
| 21 -----
> 5 files changed, 4 insertions(+), 51 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
nd-email 2.41.0
>
> 'smbios_encode_uuid' is always true, remove it,
> simplifying smbios_encode_uuid().
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/smbios/smbios.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Zhao Liu
__
No external code sets the 'memory-hotplug-support'
> property, remove it.
>
> Suggested-by: Thomas Huth
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/acpi/ich9.c | 18 --
> 1 file changed, 18 deletions(-)
Reviewed-by: Zhao Liu
ult_props table.
> - */
> -void x86_cpu_change_kvm_default(const char *prop, const char *value);
Features in kvm_default_props[] are supposed to be supported on the
oldest kernal version (v4.5, from docs/system/target-i386.rst).
So future PC machines will not use this interface to adjust
compat
1 file changed, 6 insertions(+), 22 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
--
> hw/usb/hcd-xhci-pci.c | 1 -
> hw/usb/hcd-xhci.c | 42 --
> 4 files changed, 9 insertions(+), 39 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
i386/pc.c | 2 +-
> hw/loongarch/virt.c | 2 +-
> hw/mem/pc-dimm.c | 6 ++
> hw/ppc/spapr.c | 2 +-
> 6 files changed, 7 insertions(+), 10 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- d
h | 2 +-
> hw/i386/pc.c | 3 +--
> hw/mem/memory-device.c | 12
> hw/mem/pc-dimm.c | 2 +-
> hw/virtio/virtio-md-pci.c | 2 +-
> 5 files changed, 8 insertions(+), 13 deletions(-)
Reviewed-by: Zhao Liu
moment, 32K should be enough for a while.
> + */
> +#define PC_ACPI_DATA_SIZE (0x2 + 0x8000)
> +
What about putting this in pc.h? Because it is a general definition for
PC.
Others are good for me,
Reviewed-by: Zhao Liu
___
Devel mailing lis
t; +smbios_set_defaults("QEMU", mc->desc, mc->name, true);
Since this parameter is always ture, then we can drop it and further
clean up the static flag "smbios_uuid_encoded" in hw/smbios/smbios.c.
Reviewed-by: Zhao Liu
__
23 -------
> 5 files changed, 2 insertions(+), 35 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
t;
> ---
> include/hw/i386/pc.h | 1 -
> hw/i386/acpi-build.c | 35 ---
> hw/i386/pc.c | 1 -
> 3 files changed, 4 insertions(+), 33 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- deve
AcpiBuildState::rsdp is always NULL, remove it,
> simplifying acpi_build_update().
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Thomas Huth
> Message-Id: <20240305134221.30924-16-phi...@linaro.org>
> ---
> hw/i386/acpi-build.c | 8 +---
> 1 file changed, 1
hci-nec.c | 2 --
> hw/usb/hcd-xhci-pci.c | 3 +--
> 3 files changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
37 -----
> 5 files changed, 2 insertions(+), 57 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
rt.c | 2 +-
> hw/riscv/virt.c | 2 +-
> hw/smbios/smbios.c | 6 ++
> 6 files changed, 7 insertions(+), 11 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
> Since this parameter is always ture, then we can drop it and further
> clean up the static flag "smbios_uuid_encoded" in hw/smbios/smbios.c.
Oops, my email didn't sync up well, the next two patches were doing
just that.
Thanks,
Zhao
___
Devel mailing
6/kvm/kvm.c | 7 +--
> 3 files changed, 1 insertion(+), 11 deletions(-)
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
Hi Philippe,
On Wed, Mar 27, 2024 at 10:51:21AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:21 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4
> to 2.7 pc-i440fx machines
> X-Mailer: git-send-email 2.41.0
+--
> docs/about/removed-features.rst | 2 +-
> hw/i386/pc.c| 25 -
> hw/i386/pc_piix.c | 19 ---
> 4 files changed, 3 insertions(+), 47 deletions(-)
Reviewed-by: Zhao Liu
_
hw/i386/pc_piix.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
LGTM,
Reviewed-by: Zhao Liu
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
gt; This effectively reverts
>
> commit 54c4ea8f3ae614054079395842128a856a73dbf9
> Author: Zhao Liu
> Date: Sat Mar 9 00:01:37 2024 +0800
>
> hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP
> configurations
>
> but is not done as a
> I'm failing to see what real world technical problems QEMU faces
> with a parameter being set to '1' by a mgmt app, when QEMU itself
> treats all omitted values as being '1' anyway.
>
> If we're trying to faithfully model the real world, then restricting
> the topology against machine types
On Wed, May 15, 2024 at 06:06:56PM +0100, Daniel P. Berrangé wrote:
> Date: Wed, 15 May 2024 18:06:56 +0100
> From: "Daniel P. Berrangé"
> Subject: Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any
> machine
>
> On Tue, May 14, 2024 at 11:4
tively reverts
>
> commit 54c4ea8f3ae614054079395842128a856a73dbf9
> Author: Zhao Liu
> Date: Sat Mar 9 00:01:37 2024 +0800
>
> hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP
> configurations
>
> but is not done as a 'git revert' since the part of the changes to t
GY_GENERIC(8, 2, 2, 2, 8),
> +.expect_prefer_cores = CPU_TOPOLOGY_GENERIC(8, 2, 2, 2, 8),
> },
> };
>
As Xiaoyao's suggestion, only the nit in the comment.
Others look good to me, so,
Reviewed-by: Zhao Liu
38 matches
Mail list logo
