On 4/2/24 09:31, Peter Krempa wrote:
On Tue, Mar 19, 2024 at 15:07:04 +0100, Denis V. Lunev wrote:
Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to
implement two things: reduce stack usage inside ACL helpers and
minimally initialize virDomainDef object to avoid passing garbage
On 3/19/24 15:07, Denis V. Lunev wrote:
Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to
implement two things: reduce stack usage inside ACL helpers and
minimally initialize virDomainDef object to avoid passing garbage
inside validation framework. Though original commit has
On 3/19/24 15:07, Denis V. Lunev wrote:
Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to
implement two things: reduce stack usage inside ACL helpers and
minimally initialize virDomainDef object to avoid passing garbage
inside validation framework. Though original commit has
proper clauses to
remoteRelayNetworkEventCheckACL
remoteRelayStoragePoolEventCheckACL
remoteRelayNodeDeviceEventCheckACL
remoteRelaySecretEventCheckACL
Signed-off-by: Denis V. Lunev
CC: Peter Krempa
CC: Roman Grigoriev
---
src/remote/remote_daemon_dispatch.c | 32
On 3/19/24 11:02, Martin Kletzander wrote:
On Mon, Mar 18, 2024 at 09:35:32PM +0100, Denis V. Lunev wrote:
On 3/18/24 15:25, Martin Kletzander wrote:
On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote:
On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote:
On Mon, Mar 18
On 3/18/24 15:25, Martin Kletzander wrote:
On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote:
On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote:
On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník wrote:
> On 3/18/24 12:45, Denis V. Lunev wrote:
> > On 3/18
On 3/18/24 11:42, Michal Prívozník wrote:
On 3/17/24 16:00, Denis V. Lunev wrote:
Signed-off-by: Denis V. Lunev
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 4695391342..44a9b446bd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -20,6 +20,7
xes: 2ecdf259299813c2c674377e22a0acbce5ccbbb2
Signed-off-by: Denis V. Lunev
CC: Peter Krempa
CC: Roman Grigoriev
---
src/remote/remote_daemon_dispatch.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/remote/remote_daemon_dispatch.c
b/src/remote/remote_daemon_dispatch.c
in
remoteRelayStoragePoolEventCheckACL
remoteRelayNodeDeviceEventCheckACL
remoteRelaySecretEventCheckACL
Signed-off-by: Denis V. Lunev
CC: Peter Krempa
CC: Roman Grigoriev
---
src/remote/remote_daemon_dispatch.c | 32 ++---
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git
Signed-off-by: Denis V. Lunev
CC: Peter Krempa
CC: Roman Grigoriev
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
Signed-off-by: Denis V. Lunev
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 4695391342..44a9b446bd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -20,6 +20,7 @@ __pycache__/
/build/
/ci/scratch/
tags
+cscope.*
# clangd related ignores
On 3/18/24 09:56, Peter Krempa wrote:
FYI: Gmail decided that your whole series is spam. I'm not sure whether
it's just gmail's spam filter being silly or your mail infra has
something wrong, but just so you know.
On Sun, Mar 17, 2024 at 18:08:50 +0100, Denis V. Lunev wrote:
Commit
On 3/18/24 09:37, Peter Krempa wrote:
On Sun, Mar 17, 2024 at 18:08:49 +0100, Denis V. Lunev wrote:
Technically commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 does not
really introduces a leak, but it is incorrect ideologically. Neither
function accepting non-const pointer to virDomainDef does
op,
NULL);
+g_source_attach(wakeup, client->eventCtx);
/* If we are non-blocking, detach the thread and keep the call in the
* queue. */
Reviewed-by: Denis V. Lunev
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe s
This functionality is to be extended, simple call to g_main_loop_quit()
is not enough. In order to make changes convinient, the helper is
required.
Signed-off-by: Denis V. Lunev
---
src/rpc/virnetclient.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git
They are not exported from the module and thus should be static.
Signed-off-by: Denis V. Lunev
---
src/util/vireventglibwatch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/vireventglibwatch.c b/src/util/vireventglibwatch.c
index b7f3a8786a..b21e505731 100644
nstead of poll
The cure is to revert back to old roots and use file descriptor for
wakeup notifications. The code written is well suited for Linux while it
is completely unclear how it will behave on Windows.
Signed-off-by: Denis V. Lunev
---
src/rpc/virnetclient.
This is a dirty working code using pipes.
Sent for discussion of the approach. Made against our downstream
based on libvirt 8.5.
Signed-off-by: Denis V. Lunev
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le
On 12/18/23 12:03, Daniel P. Berrangé wrote:
On Mon, Dec 18, 2023 at 10:32:07AM +, Daniel P. Berrangé wrote:
On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote:
RPC client implementation uses the following paradigm. The critical
section is organized via
On 12/15/23 16:07, Daniel P. Berrangé wrote:
On Fri, Dec 15, 2023 at 01:48:09PM +, Efim Shevrin wrote:
Hello,
here are call traces with two threads generated by python script
// ==
[root@dandreev-vz-6-0-0-243-master libvirt]# gdb -p 288985
(gdb) t a a bt
Thread
On 12/15/23 16:47, Daniel P. Berrangé wrote:
On Fri, Dec 15, 2023 at 03:51:19PM +0100, Denis V. Lunev wrote:
On 12/15/23 14:48, Efim Shevrin wrote:
*From:* Daniel P. Berrangé
*Sent:* Friday, December 15, 2023 19:09
*To:* Efim Shevrin
*Cc:* devel@lists.libvirt.org ; d...@openvz.org
*Subject
On 12/15/23 14:48, Efim Shevrin wrote:
Hello,
here are call traces with two threads generated by python script
// ==
[root@dandreev-vz-6-0-0-243-master libvirt]# gdb -p 288985
(gdb) t a a bt
Thread 2 (Thread 0x7f2112862640 (LWP 288986) "python3"):
#0
On 12/14/23 19:32, Fima Shevrin wrote:
From: "Denis V. Lunev"
They are not exported from the module and thus should be static.
Signed-off-by: Denis V. Lunev
Signed-off-by: Fima Shevrin
---
src/util/vireventglibwatch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
23 matches
Mail list logo
