Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Daniel-Constantin Mierla
On 03/03/08 06:21, Juha Heinanen wrote: i noticed that if allow_source_address_from_group() returns group value 0, statement $var(group) = allow_source_address_from_group(); never returns. is this intentional, i.e., are functions disallowed to return value 0? by returning 0, the

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: by returning 0, the execution of the script is interrupted -- same behavior as 'exit'. that is what i suspected. in my opinion there is too much under cover things happening here. it would be easier to debug and understand things if script would not

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Juha Heinanen
Daniel-Constantin Mierla writes: perhaps going to clear return codes handling will be better. Since the beginning of ser, the meaning of return codes was: - greater than 0 was considered true - less than 0 was considered false - 0 was considered exit. Now it is about backward

[OpenSER-Devel] SF.net SVN: openser: [3820] branches/1.3/modules/presence

2008-03-03 Thread Bogdan-Andrei Iancu
Revision: 3820 http://openser.svn.sourceforge.net/openser/?rev=3820view=rev Author: bogdan_iancu Date: 2008-03-03 01:02:24 -0800 (Mon, 03 Mar 2008) Log Message: --- Backport from trunk (rev #3802) - removed the unused totag_avpid module parameter. The TOTAG is not passed

[OpenSER-Devel] SF.net SVN: openser: [3821] branches/1.2/modules/presence

2008-03-03 Thread Bogdan-Andrei Iancu
Revision: 3821 http://openser.svn.sourceforge.net/openser/?rev=3821view=rev Author: bogdan_iancu Date: 2008-03-03 01:07:55 -0800 (Mon, 03 Mar 2008) Log Message: --- Backport from trunk (rev #3802) - removed the unused totag_avpid module parameter. The TOTAG is not passed

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Iñaki Baz Castillo
El Monday 03 March 2008 09:54:23 Juha Heinanen escribió: Daniel-Constantin Mierla writes: perhaps going to clear return codes handling will be better. Since the beginning of ser, the meaning of return codes was: - greater than 0 was considered true - less than 0 was considered false

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Dan Pascu
On Monday 03 March 2008, Juha Heinanen wrote: Daniel-Constantin Mierla writes: perhaps going to clear return codes handling will be better. Since the beginning of ser, the meaning of return codes was: - greater than 0 was considered true - less than 0 was considered false - 0 was

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Juha Heinanen
Dan Pascu writes: My guess is that this will not be easy to do as there are currently functions that rely on this to stop processing the message and they do so based on some internal checks/conditions that are not testable from the script. are you saying that you have lots of

[OpenSER-Devel] [ openser-Bugs-1518732 ] openserctl - cannot add a new subscriber

2008-03-03 Thread SourceForge.net
Bugs item #1518732, was opened at 2006-07-07 06:18 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1518732group_id=139143 Please note that this message will contain a full copy of the comment

[OpenSER-Devel] SF.net SVN: openser: [3822] trunk/modules/ratelimit/doc/ratelimit_user.sgml

2008-03-03 Thread Henning Westerholt
Revision: 3822 http://openser.svn.sourceforge.net/openser/?rev=3822view=rev Author: henningw Date: 2008-03-03 01:47:54 -0800 (Mon, 03 Mar 2008) Log Message: --- - some small spelling fixes Modified Paths: -- trunk/modules/ratelimit/doc/ratelimit_user.sgml

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Dan Pascu
On Monday 03 March 2008, Juha Heinanen wrote: Dan Pascu writes: My guess is that this will not be easy to do as there are currently functions that rely on this to stop processing the message and they do so based on some internal checks/conditions that are not testable from the script.

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Juha Heinanen
Dan Pascu writes: AFAIK, there are functions in tm that rely on this, including t_relay if I'm not mistaken. I'd say that until a list of the module functions that use this behavior is made so we can draw a conclusion, it's premature to assume this will be easy to change, or that is

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Henning Westerholt
On Monday 03 March 2008, Juha Heinanen wrote: Dan Pascu writes: AFAIK, there are functions in tm that rely on this, including t_relay if I'm not mistaken. I'd say that until a list of the module functions that use this behavior is made so we can draw a conclusion, it's premature to

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Juha Heinanen
Henning Westerholt writes: yes, i've also the same opinion. But there will be probably many configs out there that do rely on this behaviour, and will break if we change this. So i also think this is not something that we should treat lightly. in that case perhaps we can add a config

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Dan Pascu
On Monday 03 March 2008, Juha Heinanen wrote: Dan Pascu writes: AFAIK, there are functions in tm that rely on this, including t_relay if I'm not mistaken. I'd say that until a list of the module functions that use this behavior is made so we can draw a conclusion, it's premature to

[OpenSER-Devel] SF.net SVN: openser: [3823] branches/1.3/modules/carrierroute/route_func.c

2008-03-03 Thread Henning Westerholt
Revision: 3823 http://openser.svn.sourceforge.net/openser/?rev=3823view=rev Author: henningw Date: 2008-03-03 03:26:16 -0800 (Mon, 03 Mar 2008) Log Message: --- - apply fix for error logging, closes #1896648, patch provided from Ovidiu Sas - backport from rev 3733 - fix

[OpenSER-Devel] [ openser-Bugs-1896648 ] carrierroute: improper info in the logs

2008-03-03 Thread SourceForge.net
Bugs item #1896648, was opened at 2008-02-19 05:20 Message generated for change (Comment added) made by henningw You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1896648group_id=139143 Please note that this message will contain a full copy of the comment

[OpenSER-Devel] SF.net SVN: openser: [3824] trunk/modules/carrierroute/route_func.c

2008-03-03 Thread Henning Westerholt
Revision: 3824 http://openser.svn.sourceforge.net/openser/?rev=3824view=rev Author: henningw Date: 2008-03-03 03:31:14 -0800 (Mon, 03 Mar 2008) Log Message: --- - forward port logging fix from 1.3, rev 3823 Revision Links: --

[OpenSER-Devel] SF.net SVN: openser: [3825] trunk/modules/dispatcher/dispatcher.c

2008-03-03 Thread Daniel-Constantin Mierla
Revision: 3825 http://openser.svn.sourceforge.net/openser/?rev=3825view=rev Author: miconda Date: 2008-03-03 03:46:33 -0800 (Mon, 03 Mar 2008) Log Message: --- - typo in renaming to hash_param_model (reported by Henning Westerholt) Modified Paths: --

Re: [OpenSER-Devel] SF.net SVN: openser: [3819] trunk/modules/dispatcher

2008-03-03 Thread Daniel-Constantin Mierla
Hello Henning, On 03/03/08 12:09, Henning Westerholt wrote: On Sunday 02 March 2008, Daniel-Constantin Mierla wrote: Revision: 3819 http://openser.svn.sourceforge.net/openser/?rev=3819view=rev Author: miconda Date: 2008-03-02 03:34:42 -0800 (Sun, 02 Mar 2008) Log

[OpenSER-Devel] SF.net SVN: openser: [3826] branches/1.3/ChangeLog

2008-03-03 Thread Henning Westerholt
Revision: 3826 http://openser.svn.sourceforge.net/openser/?rev=3826view=rev Author: henningw Date: 2008-03-03 04:19:04 -0800 (Mon, 03 Mar 2008) Log Message: --- - update changelog for release Modified Paths: -- branches/1.3/ChangeLog This was sent by the

[OpenSER-Devel] SF.net SVN: openser: [3827] branches/1.3/doc/authors.xml

2008-03-03 Thread Henning Westerholt
Revision: 3827 http://openser.svn.sourceforge.net/openser/?rev=3827view=rev Author: henningw Date: 2008-03-03 04:25:15 -0800 (Mon, 03 Mar 2008) Log Message: --- - update authors file, backport from trunk Modified Paths: -- branches/1.3/doc/authors.xml

[OpenSER-Devel] SF.net SVN: openser: [3828] trunk/modules/usrloc/urecord.c

2008-03-03 Thread Bogdan-Andrei Iancu
Revision: 3828 http://openser.svn.sourceforge.net/openser/?rev=3828view=rev Author: bogdan_iancu Date: 2008-03-03 07:17:33 -0800 (Mon, 03 Mar 2008) Log Message: --- -fixed bogus timer routine (bug introduced during the last fixup) Modified Paths: --

[OpenSER-Devel] SF.net SVN: openser: [3829] trunk/modules/usrloc/urecord.c

2008-03-03 Thread Bogdan-Andrei Iancu
Revision: 3829 http://openser.svn.sourceforge.net/openser/?rev=3829view=rev Author: bogdan_iancu Date: 2008-03-03 07:19:28 -0800 (Mon, 03 Mar 2008) Log Message: --- - fixed inverted comments Modified Paths: -- trunk/modules/usrloc/urecord.c This was sent

[OpenSER-Devel] SF.net SVN: openser: [3831] branches/1.2/modules/usrloc

2008-03-03 Thread Bogdan-Andrei Iancu
Revision: 3831 http://openser.svn.sourceforge.net/openser/?rev=3831view=rev Author: bogdan_iancu Date: 2008-03-03 07:30:51 -0800 (Mon, 03 Mar 2008) Log Message: --- backport from trunk (rev #3723 + #3828 + #3829): - fixed critical bug - DB operations do not have any

[OpenSER-Devel] [ openser-Patches-1872331 ] dialog: get_direction() api enhancement

2008-03-03 Thread SourceForge.net
Patches item #1872331, was opened at 2008-01-15 21:29 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743022aid=1872331group_id=139143 Please note that this message will contain a full copy of the

[OpenSER-Devel] SF.net SVN: openser: [3832] trunk/test

2008-03-03 Thread Henning Westerholt
Revision: 3832 http://openser.svn.sourceforge.net/openser/?rev=3832view=rev Author: henningw Date: 2008-03-03 07:43:16 -0800 (Mon, 03 Mar 2008) Log Message: --- - extend cr test with actual failure routes - small cleanups, add ratelimit to test 2 Modified Paths:

[OpenSER-Devel] SF.net SVN: openser: [3833] trunk/modules/carrierroute/route_func.c

2008-03-03 Thread Henning Westerholt
Revision: 3833 http://openser.svn.sourceforge.net/openser/?rev=3833view=rev Author: henningw Date: 2008-03-03 07:47:09 -0800 (Mon, 03 Mar 2008) Log Message: --- - extend the failure route logging like the normal routing Modified Paths: --

[OpenSER-Devel] SF.net SVN: openser: [3834] trunk/modules/carrierroute

2008-03-03 Thread Henning Westerholt
Revision: 3834 http://openser.svn.sourceforge.net/openser/?rev=3834view=rev Author: henningw Date: 2008-03-03 07:47:43 -0800 (Mon, 03 Mar 2008) Log Message: --- - small cleanups in documentation Modified Paths: -- trunk/modules/carrierroute/README

[OpenSER-Devel] [ openser-Patches-1872331 ] dialog: get_direction() api enhancement

2008-03-03 Thread SourceForge.net
Patches item #1872331, was opened at 2008-01-15 14:29 Message generated for change (Comment added) made by osas You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743022aid=1872331group_id=139143 Please note that this message will contain a full copy of the comment

[OpenSER-Devel] SF.net SVN: openser: [3835] trunk/pvar.h

2008-03-03 Thread Daniel-Constantin Mierla
Revision: 3835 http://openser.svn.sourceforge.net/openser/?rev=3835view=rev Author: miconda Date: 2008-03-03 09:42:25 -0800 (Mon, 03 Mar 2008) Log Message: --- - pv_parse_index() exported to be available for modules' PV Modified Paths: -- trunk/pvar.h

Re: [OpenSER-Devel] returning 0 from function

2008-03-03 Thread Klaus Darilion
Juha Heinanen wrote: Dan Pascu writes: My guess is that this will not be easy to do as there are currently functions that rely on this to stop processing the message and they do so based on some internal checks/conditions that are not testable from the script. are you saying

[OpenSER-Devel] SF.net SVN: openser: [3836] trunk

2008-03-03 Thread Daniel-Constantin Mierla
Revision: 3836 http://openser.svn.sourceforge.net/openser/?rev=3836view=rev Author: miconda Date: 2008-03-03 13:46:37 -0800 (Mon, 03 Mar 2008) Log Message: --- - added fixup functions for parameters that can be int or PV Modified Paths: -- trunk/mod_fix.c

[OpenSER-Devel] [ openser-Bugs-1896648 ] carrierroute: improper info in the logs

2008-03-03 Thread SourceForge.net
Bugs item #1896648, was opened at 2008-02-19 00:20 Message generated for change (Comment added) made by osas You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1896648group_id=139143 Please note that this message will contain a full copy of the comment