Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Bogdan-Andrei Iancu
Hi Henning, maybe there is no need for TEXT, but for sure you need some escaping for BLOB type - I remember this issue some time ago in the the postgres module. Regards, Bogdan Henning Westerholt wrote: On Sunday 20 April 2008, Bogdan-Andrei Iancu wrote: I think option 2 will be better,

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Dan Pascu
On Monday 21 April 2008, Bogdan-Andrei Iancu wrote: Hi Dan, Right, this is one more reason for having in the DB API a clear distinction between the string-like and blob-like types. SQL injection can happen with any of blob, text, char, varchar if not escaped. There is no distinction between

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Juha Heinanen
Bogdan-Andrei Iancu writes: maybe there is no need for TEXT, but for sure you need some escaping for BLOB type - I remember this issue some time ago in the the postgres module. i don't know if this is related, but when i write value to mysql blob column from php, i have to escape it using

[OpenSER-Devel] [ openser-Bugs-1940022 ] CPL and postgres problems

2008-04-21 Thread SourceForge.net
Bugs item #1940022, was opened at 2008-04-11 10:23 Message generated for change (Comment added) made by henningw You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1940022group_id=139143 Please note that this message will contain a full copy of the comment

Re: [OpenSER-Devel] Should fixup functons be moved co core?

2008-04-21 Thread Henning Westerholt
On Saturday 19 April 2008, Peter Lemenkov wrote: Just wondering why every module developer needs to create its own realization of fixup functions for variables transforming? IMHO we need generic fixup functions sitting in the core of openser. Modules should deal with variables values rather

[OpenSER-Devel] SF.net SVN: openser: [4059] trunk/modules/db_postgres

2008-04-21 Thread Henning Westerholt
Revision: 4059 http://openser.svn.sourceforge.net/openser/?rev=4059view=rev Author: henningw Date: 2008-04-21 02:22:55 -0700 (Mon, 21 Apr 2008) Log Message: --- - rename files to match the scheme used from the other database modules Modified Paths: --

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Juha Heinanen
Henning Westerholt writes: According to the documentation its not necessary to do the unescaping for the retrieval of binary data in binary format, but i think we're using the text format here. yes, i don't need to do any unescaping when i read binary data from blob column. i just need

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Henning Westerholt
On Saturday 19 April 2008, Daniel-Constantin Mierla wrote: for DB_STRING it has to be checked if all drivers return a null terminated string, as some just set reference to the value in the library result and not clone the value. Otherwise, I would say that the most suitable type in DB api

Re: [OpenSER-Devel] dialog callbacks: mi enhancements

2008-04-21 Thread Dan Pascu
On Monday 21 April 2008, Bogdan-Andrei Iancu wrote: Hi Dan, So far it was about displaying information regarding dialogs and additional context - no other kind of ops. I think the main issue is about the generic low level support offered by dialog module and if the dialog module shold be

Re: [OpenSER-Devel] dialog callbacks: mi enhancements

2008-04-21 Thread Bogdan-Andrei Iancu
Hi Dan, So far it was about displaying information regarding dialogs and additional context - no other kind of ops. I think the main issue is about the generic low level support offered by dialog module and if the dialog module shold be aware and do some something for the modules on top of

[OpenSER-Devel] SF.net SVN: openser: [4061] trunk/scripts/postgres/rls-create.sql

2008-04-21 Thread Henning Westerholt
Revision: 4061 http://openser.svn.sourceforge.net/openser/?rev=4061view=rev Author: henningw Date: 2008-04-21 04:17:16 -0700 (Mon, 21 Apr 2008) Log Message: --- - fix error in postgres SQL scripts, introduced in rev 4047 Revision Links: --

[OpenSER-Devel] SF.net SVN: openser: [4058] trunk/modules

2008-04-21 Thread Henning Westerholt
Revision: 4058 http://openser.svn.sourceforge.net/openser/?rev=4058view=rev Author: henningw Date: 2008-04-21 02:18:34 -0700 (Mon, 21 Apr 2008) Log Message: --- - db_postgres and db_unixodbc handles TEXT colums now as DB_BLOB type similar to the other database modules -

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Dan Pascu
On Monday 21 April 2008, Henning Westerholt wrote: On Sunday 20 April 2008, Bogdan-Andrei Iancu wrote: I think option 2 will be better, mainly because we have 2 different data types - BLOB cannot be 100% mapped over string as BLOB was specifically design for: 1) large amount of data

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Henning Westerholt
On Monday 21 April 2008, Dan Pascu wrote: Right, this is one more reason for having in the DB API a clear distinction between the string-like and blob-like types. SQL injection can happen with any of blob, text, char, varchar if not escaped. There is no distinction between the 2 regarding

[OpenSER-Devel] [ openser-Patches-1927301 ] add SQL support to dbtext

2008-04-21 Thread SourceForge.net
Patches item #1927301, was opened at 2008-03-27 17:32 Message generated for change (Comment added) made by henningw You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743022aid=1927301group_id=139143 Please note that this message will contain a full copy of the comment

[OpenSER-Devel] dialog callback names

2008-04-21 Thread Dan Pascu
I noticed there is a new dialog callback type: DLGCB_WITHIN_RESPONSE. I think that for having a consistent naming scheme, it should be called DLGCB_RESPONSE_WITHIN, considering that we already had DLGCB_REQ_WITHIN and DLGCB_RESPONSE_FWDED. Also, I think the use of abbreviations should be

Re: [OpenSER-Devel] Header not supported

2008-04-21 Thread Klaus Darilion
openser is a SIP proxy, thus any header is supported. If the request is forwarded, the header will be forwarded too unless it is explicitly removed by remove_hf() function. You can also add any of these headers using the append_hf() or similar functions from textops module. You can access the

[OpenSER-Devel] [ openser-Patches-1947804 ] SDP parser - add media attributes for MSRP protocol(rfc4975)

2008-04-21 Thread SourceForge.net
Patches item #1947804, was opened at 2008-04-21 20:00 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743022aid=1947804group_id=139143 Please note that this message will contain a full copy

Re: [OpenSER-Devel] extending SDP parser to support MSRP attributes

2008-04-21 Thread Denis Bilenko
Thanks Ovidiu, http://sourceforge.net/tracker/index.php?func=detailaid=1947804group_id=139143atid=743022 On Monday 21 April 2008 19:11:30 you wrote: Hello Denis, Please upload the patch into the tracker and I will take a look.

[OpenSER-Devel] [ openser-Bugs-1947841 ] Error in lcr in function next_gw

2008-04-21 Thread SourceForge.net
Bugs item #1947841, was opened at 2008-04-21 17:33 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1947841group_id=139143 Please note that this message will contain a full copy of

[OpenSER-Devel] [ openser-Bugs-1947841 ] Error in lcr in function next_gw

2008-04-21 Thread Juha Heinanen
SourceForge.net writes: Initial Comment: If the first gateway, got from main route, do not answer at all (we can see retransmissions), calling function next_gw for searching a next gateway in failure route cause error: openser: ERROR: append_branch: max nr of branches exceeded

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Iouri Kharon
Hi Henning! Monday, April 21, 2008, you wrote: SQL injection can happen with any of blob, text, char, varchar if not escaped. There is no distinction between the 2 regarding this issue. at least db_mysql and db_postgres uses escaping functions for DB_STRING, DB_STR and DB_BLOB. Iouri,

[OpenSER-Devel] [ openser-Bugs-1947888 ] Error in lcr in function next_gw

2008-04-21 Thread SourceForge.net
Bugs item #1947888, was opened at 2008-04-21 18:10 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1947888group_id=139143 Please note that this message will contain a full copy of

[OpenSER-Devel] [ openser-Bugs-1947841 ] Error in lcr in function next_gw

2008-04-21 Thread SourceForge.net
Bugs item #1947841, was opened at 2008-04-21 06:33 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1947841group_id=139143 Please note that this message will contain a full copy of the comment

[OpenSER-Devel] SF.net SVN: openser: [4063]

2008-04-21 Thread Juha Heinanen
Revision: 4063 http://openser.svn.sourceforge.net/openser/?rev=4063view=rev Author: juhe Date: 2008-04-21 08:04:23 -0700 (Mon, 21 Apr 2008) Log Message: --- * Fixed two memory leaks in next_gw() function. Modified Paths: --

[OpenSER-Devel] [ openser-Bugs-1936591 ] mi_datagram module bind failure

2008-04-21 Thread SourceForge.net
Bugs item #1936591, was opened at 2008-04-07 12:38 Message generated for change (Comment added) made by jaybeepee You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743020aid=1936591group_id=139143 Please note that this message will contain a full copy of the comment

[OpenSER-Devel] SF.net SVN: openser: [4064] trunk/modules

2008-04-21 Thread Anca Vamanu
Revision: 4064 http://openser.svn.sourceforge.net/openser/?rev=4064view=rev Author: anca_vamanu Date: 2008-04-21 09:41:48 -0700 (Mon, 21 Apr 2008) Log Message: --- - clarified hash table size parameter description in documentation - fixed returning value for exported

[OpenSER-Devel] generating readme files does not work

2008-04-21 Thread Anca Vamanu
Hi, I have tried to generate readme files with 'make modules-readme ..' but got the following errors: /presence_admin.xml:4: parser error : Entity 'adminguide' not defined titleadminguide;/title ^ presence_admin.xml:515: parser error : chunk is not well

[OpenSER-Devel] SF.net SVN: openser: [4065] branches/1.3/modules

2008-04-21 Thread Anca Vamanu
Revision: 4065 http://openser.svn.sourceforge.net/openser/?rev=4065view=rev Author: anca_vamanu Date: 2008-04-21 10:06:17 -0700 (Mon, 21 Apr 2008) Log Message: --- - clarified hash table size parameter description in documentation - fixed returning value for exported

Re: [OpenSER-Devel] generating readme files does not work

2008-04-21 Thread Daniel-Constantin Mierla
Hello, can you check if you haven't mixed devel files in the 1.3 branch? Seems to build fine here. Cheers, Daniel On 04/21/08 19:46, Anca Vamanu wrote: Hi, I have tried to generate readme files with 'make modules-readme ..' but got the following errors: /presence_admin.xml:4: parser

[OpenSER-Devel] [ openser-Patches-1927301 ] add SQL support to dbtext

2008-04-21 Thread SourceForge.net
Patches item #1927301, was opened at 2008-03-27 19:32 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=743022aid=1927301group_id=139143 Please note that this message will contain a full copy of the comment

Re: [OpenSER-Devel] TEXT vs BLOB data in database modules

2008-04-21 Thread Daniel-Constantin Mierla
Hello Henning, On 04/21/08 11:44, Henning Westerholt wrote: On Saturday 19 April 2008, Daniel-Constantin Mierla wrote: for DB_STRING it has to be checked if all drivers return a null terminated string, as some just set reference to the value in the library result and not clone the value.