Interesting (to me) Compiler checking

While I was working on the extra+port stuff I had the following code bool new_interface; ... new_interface = update_interfaces_phase1(NTP_PORT); if (extra_port) new_interface |= update_interfaces_phase1(extra_port); Note that there is no initialization on new_interface. I wanted to

Re: Alternatives to port 123

Richard Laager said: > Why two options that do the same thing? Thanks for asking. I meant to say something about that. I think the reason there are two is that I had a typo or such and couldn't get >extra port < to work. After banging my head against the wall for a while, I gave up and

Alternatives to port 123

I've pushed the code for alternatives to port 123. It's working for me, but could use more testing. You might hit a case I didn't consider. There are 2 new options for the config file: nts port extra port They do the same thing. Pick one. There are two parts. If a server

Testing

Does anybody test our code on Apple? Solaris? Does anybody use any of the fancy interface logic? It's available both vie the command line and the config file. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org

Is anybody using/testing the interface options?

There is an option in the config file and more on the command line. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: Hack for monitoring NTP servers

James Browning said: > If you were thinking of adding way too many servers you might want to replace > the bubble sort around lines 1709-1728 of ntp_proto.c That code is only sorting the servers that get used. Anything with noselect got tossed back at line 1619. if

Crappy testing

If you use the extra port stuff I pushed last night, port 123 stops working. Ugh, blush. I usually do better than that. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org

extra port nnnn, nts port nnnn

I just pushed code that optionally listens on a second port. The NTS-KE server will tell the client to use that port. Requests going out will be from the new port. The idea is to bypass ISP filtering on port 123. Testing encouraged. I've been testing with nts port 8123 Be sure to let

CI is broken

I just pushed some code. The CI stuff sent me a Failed pipeline message. [0K[31;1mERROR: Job failed: failed to pull image "registry.gitlab.com/gitlab-or g/gitlab-runner/gitlab-runner-helper:x86_64-v16.11.0" with specified policies [always]: Error response from daemon: manifest for

Hack for monitoring NTP servers

If somebody feels like hacking, something like this should be fun. The idea is to setup a ntpd server watching the servers you want to monitor. (noselect on the server line does that) The new code is a program that watches that server to see if the servers to be monitored are responding

Re: What next?

James Browning said: >> I think we should split ntpd into several independant programs. >> More in another message. > I gave up on that notion; I lacked the patience to do it. I think we can take small steps. Or at least some of them. > Yeah, the IETF NTP WG shot down the notion of NTP

Re: What next?

(I found some more notes...) We should test the config file stuff to see that all the options at least get past the parser. Better would be to actually run the code. We should check FIPS mode. Do any of the CI options include FIPS? I got half way there by building OpenSSL to include FIPS

Splitting ntpd

Here are the cnhnks I have in mind: NTP server NTS-KE server NTP/NTS client refclocks monitoring/ntpq I have debugged the lockclock mode so we now have a stand-alone NTP server. It gets the error data from the krenel. (Or can/should. I haven't checked that code.) As just a

What next?

Is anybody thinking about what we should be doing? Here is my list: Port to Windows Does anybody know anything about Windows? Is there a decent POSIX environment? How well does waf work on Windows? We can get the magic code from ntp-classic. I think we should split ntpd into

FreeBSD is phasing out support for 32 bit systems

Future of 32-bit platform support in FreeBSD FreeBSD is deprecating 32-bit platforms over the next couple of major releases. We anticipate FreeBSD 15.0 will not include the armv6, i386, and powerpc platforms, and FreeBSD 16.0 will not include armv7. Support for executing 32-bit binaries on

FYI: Dave Mills has passed away

On Thu, Jan 18, 2024 at 08:35:14PM -0500, vinton cerf via Internet-history wrote: > His daughter, Leigh, just sent me the news that Dave passed away peacefully > on January 17, 2024. He was such an iconic element of the early Internet. > Network Time Protocol, the Fuzzball routers of the early

Re: Addressing the Python 2, AsciiDoc classic, and AsciiDoc 3 tangle

I have no strong opinions on this area. I won't grumble if our doc stuff doesn't build on Python2 as long as we have a copy of the doc on the web. Or somebody who really wants their own can build it on a more modern system and copy the files over. -- These are my opinions. I hate spam.

Re: NTPsec 1.2.3 released

Fred Wright said: [context is my reply to the released message.] > For some reason the antecedent to this message wasn't sent to the list, > though I'd noticed the release by checking the repo. My copy was sent to: Subject: NTPsec 1.2.3 released From: Matthew Selsky via announce Date:

Re: NTPsec 1.2.3 released

Thanks. and thanks to all who contributed and tested. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: Regression in OpenBSD

>> Please say more about your Mac patches? > The patches come in two categories: > Fallback for missing clock_gettime() and clock_settime(). My copy of OpenBSD 7.4 has clock_gettime() and clock_settime(). So we can take the first step without changing that area. The timex stuff will be a bit

Re: Regression in OpenBSD

Let's put that stuff on the back burner until the release is out. > Ntpsec doesn't fully support OpenBSD anyway, due to the lack of "timex" > (though my Mac patches fix that), and the fact that OpenBSD provides > LibreSSL rather than OpenSSL, but the 1.2.2a "Mac" version did build with >

Re: Missing clockwork

James said: > It sounds like a race condition in our wscript files or waf. How willing are > you to sink time into this, I think it's a losing proposition. I've got a --jobs=1 in my script. That was added to make sure the printout was easy to read when there were compiler errors. I'm

Missing clockwork

Anybody recognize this? I've seen a missing file once before. I think it was clockwork.?? It works if I try it again. Waf: Entering directory `/home/murray/ntpsec/raw/test-all/main' --- PYTHONPATH is not set, loading the Python ntp library may be troublesome --- [ 1/137] Compiling

Re: Release

Fred Wright said: > I also stumbled across something (which may not be new) where it appears > that if libaes_siv is installed as a system library, it's preferred over the > bundled version. That probably doesn't change the actual behavior, but may > lead to opportunistic builds. That seems

Re: Release

Fred Wright said: > The main issue I've found is that the "struct var" in ntp_control.c, is > relying on anonymous unions, which are a relatively new language feature. That is my attempt at getting a sane procedure for adding slots to the table. The old scheme required coordinated edits in

Re: Certificate geekery

Thanks. > If that's a thing you want to do on your system, you can. IMHO, it's not > something that we particularly need to promote, nor would I find it > desirable operationally. If my NTP server changes their CA provider, then I > won't be able to talk to them any more until I take manual

Re: What does gitlab's "Successful pipeline" mean?

James said: > Maybe we should add -Werror or such to CFLAGS. Sounds like a good idea to me. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

What does gitlab's "Successful pipeline" mean?

Does that mean no warnings? If not, how are we expected to learn about code that generates warnings on obscure systems? -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org

Any Coverity wizards?

I expect the comment on the previous line to tell Coverity to not complain about this case. Is there a typo or such that I'm missing? 149/* coverity[checked_return] */ CID 462307 (#1 of 1): Unchecked return value (CHECKED_RETURN) 15. check_return: Calling CMAC_Update without

Re: Release

> I'll aim to release ~15-Dec-2023 Sounds good. Thanks. > I'm thinking about AES becoming the new default for ntpq, etc. I got a few a day or so ago. I missed that one. I'll get it tonight. -- These are my opinions. I hate spam. ___ devel

Re: How does the parser work?

James said: >The host phase of Waf build generates tablegen which in turn generates >keywords.h IIRC. I have no idea how the internals work. I took a look at the code. It looks like there are 2 tables of keywords, one in ntp_keyword.h (build by keyword-gen) and another in

How does the parser work?

ntp_parser.y contqains: %token T_Tinker %token T_Tlsciphers %token T_Tlsciphersuites I'd expect those tokens to come from the keywords header file. But tlsciphers isn't in the keyword list. tlscipehrswuites is in the list. -- These are my opinions. I hate spam.

Asciidoc question

What does the $$ after the +aga+ do? |+year+|One generation file element is generated per year. The filename suffix consists of a dot and a 4 digit year number. |+age+$$ |This type of file generation sets changes to a new element of the file set every 24

Re: Release

Gary said: > DO you have an account on: https://scan.coverity.com/ > If so, I think I can add you to the project. Thanks. I think i worked. How does their stuff work? How often do they check NTPsec? Or what should I be asking? How much mail should I expect? ... There are 3 Coverity

Re: Release

Gary said: > Uh, not quite. Check the Coverity stuff. How do I do that? I'd expect something to send me email but I don't remember anything about Coverity. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org

Certificate geekery

I'm working on devel-TODO-NTS. (mostly deleting things) Currently, if a bad guy hacks or arm-twists a certificate authority, they can sign a certificate that the bad guy can use for a MITM attack. We can make that a lot harder if we lookup the current root certificate that a server is

Release

I think you should release what we have as soon as it is convenient. There are many more things I would like to include but we aren't making much progress so it's time to do it. -- These are my opinions. I hate spam. ___ devel mailing list

Re: [Git][NTPsec/ntpsec][master] Fix mode 6 client to round up to 4 bytes (was 8)

> Does the comment on line 880 also need to be updated? Good catch. Thanks. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Documentation tangle

We have a mix of man pages and web pages. I think all the man pages have a web version generated from the same source. There are some/many web pages without the corresponding man page. Debian includes the web pages in ntpsec-doc Fedora doesn't have a separate doc package for ntpsec. Their

Re: I/we need a lesson in git and/or gitlab and/or merge requests

Fred Wright said: > In general, it's a good idea to read an actual book on git, rather than > trying to understand it purely through manpages. The one I used (almost a > decade ago) is this one: > https://www.amazon.com/gp/product/1449316387/ Thanks. I like books. There is a 3rd

SHA1 or SHA-1?

I'm looking into making our documentation consistent. NIST and Wikipedia use SHA-1. Ages ago. ntpkeygen used SHA1. OpenSSL seems to prefer SHA1, but it has an alias for SHA-1. To list the digests: openssl dgst -list -- These are my opinions. I hate spam.

I/we need a lesson in git and/or gitlab and/or merge requests

Merge requests seem reasonable if all goes well. My work flow is roughly: download the patch (URL plus ".patch") scan it maybe apply and test approve and merge But things go downhill if I don't like something. What I get from James is an update to the MR, a patch to the patch. That

Re: Time for a release?

Is updating PIVOT.h on your checklist and/or should I update it now while I/we think of it? -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: Time for a release?

> What sort of testing did you have in mind? Nothing in particular. We haven't had a release in a while so I hope everybody will run git head and keep an eye out for glitches, make sure their favorite toys work as expected, double check log files, etc... > Any specific doc cleanup? Our doc

Time for a release?

The last time this was suggested, I encouraged waiting until we fixed mssntp. Well, I think we have it fixed but we haven't found anybody to test it. So I think it's time to get ready for a release. Time for lots of testing. And documentation checking/cleanup. Does anybody have any

Re: What's magic about /tmp/? ntpd can't find UNIX socket

Found it. systemd sets up separate /tmp for some services. Features/ServicesPrivateTmp https://fedoraproject.org/wiki/Features/ServicesPrivateTmp Run some services started by systemd with a private /tmp directory. This would mitigate the chance of a service making a mistake with how it

Re: What's magic about /tmp/? ntpd can't find UNIX socket

matthew.sel...@twosigma.com said: > Are you running ntpd with --jaildir (or -i) or some chroot-like > functionality? Not that I know of. Oct 18 23:17:42 hgm ntpd[16099]: INIT: Command line: /usr/local/sbin/ntpd -g -N -u ntp:ntp But systemd might be doing something like that without telling

Re: What's magic about /tmp/? ntpd can't find UNIX socket

Gary said: > Notice the "nodev"? > From "man chmod": >nodev >Do not interpret character or block special devices on the >filesystem. It works fine from my test program. What's different about ntpd? Is a UNIX socket (fifo?) a special device? When I see

Re: What's magic about /tmp/? ntpd can't find UNIX socket

devel@ntpsec.org said: > Can you provide: > ~ $ ls -ld /tmp drwxrwxrwt 12 root root 580 Oct 19 11:00 /tmp srwxrwxrwx 1 murray murray 0 Oct 18 20:51 /tmp/fake-samba-socket/socket drwxrwxrwx 2 ntpntp 60 Oct 18 20:51 /tmp/fake-samba-socket/ drwxrwxrwt 19 root root 500 Oct 19 13:19

Re: What's magic about /tmp/? ntpd can't find UNIX socket

matthew.sel...@twosigma.com said: > Are you using selinux or something that would prevent access to /tmp? I have selinux=0 and audit=0 on the kernel command line. What sort of rule would keep ntpd from seeing /tmp/ and where would that sort of rule live? Is this something from systemd? --

What's magic about /tmp/? ntpd can't find UNIX socket

I'm working on MS-SNTP. I have some hack programs that should help exercise all the code. [We should have done this ages ago.] I put James's patches into my server and tweaked the config. I put the samba socket in /tmp/ ntpd couldn't see it. My test programs work fine. 18 Oct 20:52:00

Re: Too many merge requests

James said: > MR 1333 should address the issue where every response in an mssntp-restricted > subnet gets lost in ntp_signd. Is there any reason to approve it now when we don't know if it works yet? Are all the changes inside an #ifdef? (and thus unlikely to break normal operations) > MR

Re: mssntp option breaking time service: tester(s) wanted

Google found this: [MS-SNTP]: Network Time Protocol (NTP) Authentication Extensions https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-sntp/8106cb73- ab3a-4542-8bc8-784dd32031cc Which links to: [MS-SNTP]: Network Time Protocol (NTP) Authentication Extensions

Re: mssntp option breaking time service: tester(s) wanted

Does anybody have details on how MSSNTP signing works? If we can find that, we can write some POSIX code to test things. There is a link in ntpd/ntp_signd.c http://msdn.microsoft.com/en-us/library/cc212930.aspx But I didn't find anything interesting there. (Maybe my browser was filtering

Re: I just pushed ntsstats and ntskestats

> After glancing at the tops and bottoms fo some of the HTML docs, I think I > have some issues to correct. I think the last line of the man pages used to have the version number. I'm not seeing that now. Is that because I'm doing something special to get the date in the version string (

Re: I just pushed ntsstats and ntskestats

>I am willing to break out some instant expert credentials on this until >someone better shows up. Thanks. >I will take a look at it. Would you like a single or double-line 'box' I have a slight preference for double, but it doesn't really matter. I've seen some example with

I just pushed ntsstats and ntskestats

There was a request for ntpviz to show NTS traffic. We now have the log files to make that possible. Any documentation wizards? Please look at the indentation around the info for the *stats options in both the man page for ntp.conf and the html pages for ntp_conf and monopt. The web pages

Testing -4 and -6

Does anybody have a recipe (or pointer to one) for how to get a system running without any IPv6? I want something such that isc_net_probeipv6_bool() will return false. Do we have to build our own kernel with some config variable turned off? Or will just not configuring any IPv6 interfaces be

Tangle with -4 and -6

-4 and -6 work on the server line in ntp.conf but are not documented -4/ipv4 and -6/ipv6 "work" on the command line, but they don't do what the documentation says. The man page says: Force DNS resolution of following host names on the command line to the IPv4 namespace.

Windows time scrambling (from the TZ list)

"Windows feature that resets system clocks based on random data is wreaking havoc." https://arstechnica.com/security/2023/08/windows-feature-that-resets-system-clo cks-based-on-random-data-is-wreaking-havoc/ -- These are my opinions. I hate spam.

Re: Go GC

Gary said: > Avoiding creating garbage is hard. In general, yes. But the inner loop of the server side is not very complicated. The APIs that I'm looking at are read-into-my-buffer rather than return a new buffer that needs to be GCed. I think it's worth some effort to investigate this

Go GC

Gary said: >James Browning via devel wrote: >> It would appear there is a way to turn off GC under runtime/, > How? Link? https://pkg.go.dev/runtime/debug#SetGCPercent It's not clear to me how to take advantage of that. You still have to turn it on occasionally or your world will fill up

Re: Is python2 dead?

Gary said: > Please, no. Go is a garbage collected language. Just what NTPsec does not > need, random, unpredictable delays. I was thinking of the Python code in ntpclients/ and pylib/ Is there anything in there that is time sensitive? There are lots of ways to inject timing bumps before we

Re: Is python2 dead?

Thanks. Maybe it's time to switch to Go? How long would it take us to rewrite, from scratch, everything in ntpclients? I occasionally poke around in ntpq. I find it very hard to work with. I think the others are much simpler. Is the basic structure right? If we were starting from scratch,

Re: Is python2 dead?

Gary said: > Let's try again in a year. Sounds good to me. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Is python2 dead?

Really really dead? Or maybe just hiding in some dark corner? Should we drop support for python2 as part of the next release? Or announce in the next release that we will drop it as part of the following release? -- These are my opinions. I hate spam.

Re: nts and ntske log files

>Expires February 2036 minus the current date >is about 12 years and 5 months maybe ish... The context is a duration of time rather than time of day. eg the result of sub_tspec() How many seconds did it take to do X? The current date has nothing to do with it. -- These are my

Re: nts and ntske log files

James Browning said: > The NTP solution would be to convert the mess to l_fp which > will work for a bit less than 13 years. Thanks. l_fp is the right answer. How did you get 13 years? I get 136. Did you drop/typo the 6? > My joke would be to have it as a long long of micro-seconds which

nts and ntske log files

I just pushed the first cut. No documentation yet. Like sysstats and usestats, ntsstats and ntskestats get logged every hour. If you look at the output from ntpq -c nts, the counters fall into two clumps, one for NTS and one for NTS-KE. All the counters get logged in the same order. Should

Windows time confusion (long)

Windows feature that resets system clocks based on random data is wreaking havoc https://arstechnica.com/security/2023/08/windows-feature-that-resets-system-c locks-based-on-random-data-is-wreaking-havoc/ Windows Secure Time Seeding resets clocks months or years off the correct time. That's

Re: Release, project sleeping, and running down the clock.

James Browning said: > If the project is sleeping, then you may as >well cut the new release now. I think we should do a normal release. That includes scanning the issues and merge requests. And lots of testing. I'm working on making a couple of new stats files for NTP packets using NTS

What does bison do with undefined tokens?

ntpd/ntp_parser.y has this line: %token T_Timingstats T_Timingstats is never defined. All the other similar tokens are defined in ntpd/keyword-gen.c -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org

Re: NTPsec 1.2.2a released

Should that also go to users@ and devel@? What fraction of people on users or devel are also on announce? -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: Old email on gitlab

Thanks Gary and Fred. I found it in ~/.gitconfig It would have taken me a long long long time to look there. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Old email on gitlab

git log on a fresh clone shows things like this: Author: Hal Murray Date: Tue Jul 4 15:16:47 2023 -0700 Squash warnings about not handled enumeration I haven't used that email in ages. My profile has been updated. Mail from gitlab goes to the right place. Where is the other address

Re: Warnings from unity

> That usually means there is no "default:" case in a switch. OK, but where did the unity code come from and/or have we cloned it or are we tracking what they do? Or ... -- These are my opinions. I hate spam. ___ devel mailing list

Warnings from unity

Is anybdy familiar with this area? Is this something I did? Or are others seeing the same problem? (I might have turned on some more-warnings flag, but I don't think so.) ../../tests/unity/unity.c:984:5: warning: enumeration value \u2018UNITY_FLOAT_INVALID_TRAIT\u2019 not handled in switch

Re: UnicodeDecodeError from tty.readline(), u-Blox 8

Gary said: > Weird... Since ttyACM0 is USB, maybe a driver thing. Yes, I'm using the USB port rather than the serial port. The question is: Which driver? Linux or U-Blox? -- These are my opinions. I hate spam. ___ devel mailing list

Re: UnicodeDecodeError from tty.readline(), u-Blox 8

Gary said: > To open to read binary: > tty = open("/dev/ttyACM0", "rb") > The line will be binary. Getting just the NMEA out will be fun. Thanks. That's what I needed. There is no problem getting just the NMEA. I'm using isASCII to detect the garbage cases. I get things like: ### Not

UnicodeDecodeError from tty.readline(), u-Blox 8

Can somebody give me a lesson on this area? The code is: tty = open("/dev/ttyACM0") forever: line = tty.readline() a) How do I read mostly ASCII without crashing when there is non-ASCII? b) Why is a u-Blox LEA-M8T sending me non-ASCII crap? This is coming from the USB port. It's

Book: The Go Programming Language

By Alan L Donovan and Brian W Kernighan 350+ pages In case you didn't notice, that's the K of K I don't know anything about Go, yet, but I like books. This is a good one. I flipped around, reading a paragraph or a page or two. It feels good. Lots of examples. The text is easy to read and

Re: ntpsec | mssntp in ntp.conf breaks time service to all clients (#785)

I took a scan at the code. It's pretty broken. It won't be a quick fix. Given how broken the code is, this seems to be the first time anybody has tried to use that feature. :) [If there were others, they didn't bother to tell anybody.] Can we get a packet trace of a working example? I

Re: master broken on macos

> one is to append '||cat build/config.log' to lines 386 and 402 (ish) of > .gitlab-ci.yml Worked. Thanks. err: ../../test.c:3:10: fatal error: 'openssl/opensslv.h' file not found #include -- These are my opinions. I hate spam. ___ devel

master broken on macos

I merged James' latest version for printing out the OpenSSL version during configure. It barfs on macos. https://gitlab.com/NTPsec/ntpsec/-/jobs/4105995926#L126 The log file says: Checking for OpenSSL != 1.1.1a : yes OpenSSL version

ntpq/mode6 cleanup

>> For a small project, I think we should make mode6/ntpq require the cookie on >> everything but getting the cookie, and we should make sure that there is no >> amplification when getting the cookie. > That would break compatibility with ntpq from classic NTP. There are 2 areas I'm interested

Re: Updated to-do list?

[Context is a multi-threaded Go echo server] > I can manage to do that. I'll send you the C code off list. Here is an outline of the big picture: Linux and FreeBSD have a SO_REUSEPORT option. The idea is that you can open several sockets on the same port number. The kernel will hash on

Re: Updated to-do list?

>Given that the things I have been turning in are not in the direction >we are headed, what should I be working on? Other than trying to do a >Golang port by myself, or revisiting the more than a-year-old list? MR 1307 and/or 1309 is high on my list. I was hoping somebody else

Anybody using seccomp? (MR 1316)

Or interested in it? I gave up a long time ago. It was too fiddly. James has split the list of syscalls out from a list built into the source (with a few ifdefs) to a text file. I think we will need a file for each libc/kernel cross each hardware. But I think that gets us the right

MR 1307 and/or 1309

Has anybody tried them? -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Does anybody use (aka test) MDNS?

-- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

CI happy now

I was thinking that "latest" suggested newer. 3.1 is out, but none of the distros I test with are using it yet. I was expecting a bug in that area. It turns out that ubuntu-latest has an older version of OpenSSL 3. It's using 3.0.2. The oldest 3.0 I have is 3.0.3. Many distros are using

Re: I've broken something

> I am reasonably sure about it. Jammy comes from [1] which come after looking > at ./dockerfiles/ubuntu-latest to get ubuntu:latest Thanks. > Seriously though, docker works great for this, and you don't need to glass > wipe a machine. But I don't know anything about docker and I do know

Re: I've broken something

James Browning said: >> Where/how do I get ubuntu-latest? > I would suggest `docker push registry.gitlab.com/na280/ntpsec`, but it seems > that it rarely is acceptable, or go to the Ubuntu website and download Jammy. Are you sure about Jammy? Where did that come from? I found a download page

I've broken something

The pipeline fails on: Name: ubuntu-latest-basic Name: ubuntu-latest-refclocks Name: macos-basic Name: macos-refclocks All 4 get the same clump of errors: TEST(macencrypt, CMAC_Encrypt)../../tests/libntp/macencrypt.c:109::FAIL: Expected TRUE Was FALSE TEST(macencrypt,

Re: New Defects reported by Coverity Scan for ntpsec

Thanks. matthew.sel...@twosigma.com said: >> Should we document that? Where? > The account creation seems self-explanatory. Or did you want to document > something else? I don't know. I was just tossing out a suggestion based on my stumbling. Yes, it's reasonably obvious, but only after you

Re: New Defects reported by Coverity Scan for ntpsec

I took a look at the Coverity reports for ntpsec. There are 10 of them. 10 is a small number. We should be able to fix them all. The Coverity report that started this thread was actually a bug. The code I had was bool once = false; if (once) return; once = true; ... I was so

Re: New Defects reported by Coverity Scan for ntpsec

>> OK, I propose to turn on -Wswitch-enum and fix all the warnings I >> find. Then I/we fix whatever Coverity complains about. If that is >> too painful, we can back out of -Wswitch-enum. > Seems good to me. OK, I'll start working on it when I get time. > There are so many Coverity warnings

Re: New Defects reported by Coverity Scan for ntpsec

Thanks. > Do you have a coverity account? > https://scan.coverity.com/ > Then go to "My Dashboard" and "Add project". Should we document that? Where? It looks like Coverity is running over on github. Is our copy-to-github stuff documented? I'm waiting for somebody to approve me. >>

Re: New Defects reported by Coverity Scan for ntpsec

>> But then Coverity will barf (DEADCODE) at all the defaults. > What purpose do they still have? None. But we have -Wswitch-default so it will barf if we remove them. They would be useful if an illegal value was passed in. At least in the case that started this thread, the values are

Re: New Defects reported by Coverity Scan for ntpsec

> Sadly some compilers will always complain if there is no default. So I > always add a default. We turn on -Wswitch-default I'd like to turn on -Wswitch-enum That generates a handful of warnings that I'm willing to fix. But then Coverity will barf (DEADCODE) at all the defaults. I think

  1   2   3   4   5   6   7   8   9   10   >