Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-12 Thread Love, Robert W
On 12-09-11 10:36 AM, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip This feels a little awkward with all the special control files. Have you thought about something designed for

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Chris Leech
On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Chris Leech
On Mon, Sep 10, 2012 at 5:05 PM, Bhanu Prakash Gollapudi bprak...@broadcom.com wrote: I'm concerned that we will be breaking user space compatibility with this change, as there should be a corresponding fcoemon/fipvlan change along with this, and existing utilities will not work. Also the way

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip 1) Create/alloc the port - Allocate kernel memory and create per-instance sysfs devices - No discovery or login # echo eth3.172-fcoe

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Bhanu Prakash Gollapudi
On 9/11/2012 10:36 AM, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip 1) Create/alloc the port - Allocate kernel memory and create per-instance sysfs devices - No

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 11:31:08 AM PDT, Bhanu Prakash Gollapudi wrote: On 9/11/2012 10:36 AM, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love robert.w.l...@intel.com wrote: snip 1) Create/alloc the port - Allocate

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Love, Robert W
On Mon 10 Sep 2012 05:05:20 PM PDT, Bhanu Prakash Gollapudi wrote: On 9/10/2012 3:59 PM, Robert Love wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastructure was added to the kernel a few cycles

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Bhanu Prakash Gollapudi
On 9/10/2012 6:41 PM, Love, Robert W wrote: On Mon 10 Sep 2012 05:05:20 PM PDT, Bhanu Prakash Gollapudi wrote: On 9/10/2012 3:59 PM, Robert Love wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs