Re: [Open-FCoE] [PATCH 1/6] fcoemon: Improve some logging statements

On Tue, Sep 25, 2012 at 01:21:29PM -0700, Robert Love wrote: Remove a few unnecessary and unhelpful messages and improve the readability of others. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com Acked-by: Neil Horman

Re: [Open-FCoE] [PATCH 2/6] fcoemon: Use MAX_PATH_LEN variable instead of hardcoded constant

On Tue, Sep 25, 2012 at 01:21:35PM -0700, Robert Love wrote: Use maximum path length variable instead of a hardcoded constant. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com

Re: [Open-FCoE] [PATCH 4/6] fcoemon, fipvlan: Share some defined variables

On Tue, Sep 25, 2012 at 01:21:45PM -0700, Robert Love wrote: Reuse common definitions. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com ___ devel

Re: [Open-FCoE] [PATCH 5/6] fcoemon: Fix typo

On Tue, Sep 25, 2012 at 01:21:50PM -0700, Robert Love wrote: Fix spelling of 'failed' and add a '_' to the string 'fc_host', the 'fc_host' as represented in sysfs has an underscore. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com ---

Re: [Open-FCoE] [PATCH 6/6] fcoemon: Add unknown command value to debug statement

On Tue, Sep 25, 2012 at 01:21:55PM -0700, Robert Love wrote: Provide more useful information to the user who is debugging. Signed-off-by: Robert Love robert.w.l...@intel.com --- fcoemon.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fcoemon.c b/fcoemon.c

[Open-FCoE] [RFC PATCH v2 0/5] Add new fcoe_sysfs based control interfaces to libfcoe, bnx2fc and fcoe

This series applies to the v3.5 kernel. The following series adds /sys/bus/fcoe based control interfaces to libfcoe. A fcoe_sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that work. The patches deprecate the old create, vn2vn_create, destroy, enable and

[Open-FCoE] [RFC PATCH v2 1/5] fix_section_mismatch

Already fixed upstream. --- drivers/scsi/fcoe/fcoe_transport.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index b46f43d..71cc909 100644 --- a/drivers/scsi/fcoe/fcoe_transport.c +++

[Open-FCoE] [RFC PATCH v2 2/5] libfcoe: Add fcoe_sysfs debug logging level

Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git

[Open-FCoE] [RFC PATCH v2 3/5] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

This patch does a few things. 1) Makes /sys/bus/fcoe/ctlr_{create,destroy} interfaces. These interfaces take an ifname and will either create an FCoE Controller or destroy an FCoE Controller depending on which file is written to. The new FCoE Controller will start in a DISABLED

[Open-FCoE] [RFC PATCH v2 4/5] fcoe: Use the fcoe_sysfs control interface

This patch adds support for the new fcoe_sysfs control interface to fcoe.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the new interfaces or the old ones, but not both.

[Open-FCoE] [RFC PATCH v2 5/5] bnx2fc: Use the fcoe_sysfs control interface

This patch adds support for the new fcoe_sysfs control interface to bnx2fc.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the new interfaces or the old ones, but not