[Open-FCoE] [RFC PATCH v4 0/5] Add new fcoe_sysfs based control interfaces to libfcoe, bnx2fc and fcoe

2012-10-09 Thread Robert Love
v4: @Neil: Policy is now: 'mode' attribute: input: Fabric VN2VN (case insensitive) output: Fabric VN2VN 'enabled' attribute: input: 1 0 output: 1 0 @Mark: Initial patch now optimizes enum-to-string

[Open-FCoE] [RFC PATCH v4 1/5] libfcoe: Save some memory and optimize name lookups

2012-10-09 Thread Robert Love
Instead of creating a structure with an enum and a pointer to a string, simply allocate an array of strings and use the enum values for the indicies. This means that we do not need to iterate through the list of entries when looking up a string name by its enum key. This will also help with a

[Open-FCoE] [RFC PATCH v4 2/5] libfcoe: Add fcoe_sysfs debug logging level

2012-10-09 Thread Robert Love
Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git

[Open-FCoE] [RFC PATCH v4 3/5] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

2012-10-09 Thread Robert Love
This patch does a few things. 1) Makes /sys/bus/fcoe/ctlr_{create,destroy} interfaces. These interfaces take an ifname and will either create an FCoE Controller or destroy an FCoE Controller depending on which file is written to. The new FCoE Controller will start in a DISABLED

[Open-FCoE] [RFC PATCH v4 4/5] fcoe: Use the fcoe_sysfs control interface

2012-10-09 Thread Robert Love
This patch adds support for the new fcoe_sysfs control interface to fcoe.ko. It keeps the deprecated interface in tact and therefore either the legacy or the new control interfaces can be used. A mixed mode is not supported. A user must either use the new interfaces or the old ones, but not both.

[Open-FCoE] [RFC PATCH 0/4] Add support for fcoe_sysfs kernel interfaces

2012-10-09 Thread Robert Love
The kernel now exposes interfaces under /sys/bus/fcoe/. This series adds support for those interfaces to fcoemon. These patches make it so that fcoemon checks for /sys/bus/fcoe/ctlr_create. If the file exists and is writable then fcoemon will use the new interfaces, if those conditions aren't met

[Open-FCoE] [RFC PATCH 2/4] fcoemon: Create a function template for the libfcoe module paramater interface

2012-10-09 Thread Robert Love
The libfcoe module parameter interface for create, destroy, enable and disable are being deprecated. The first step is to generalize and abstract the legacy interface by making calls to it through a function template. The next patch in this series will add a new template implemenation with calls

[Open-FCoE] [RFC PATCH 3/4] fcoemon: Add fcoe_sysfs based kernel interface support

2012-10-09 Thread Robert Love
Add a function template implementation for the new fcoe_sysfs kernel interfaces. When the /sys/bus/fcoe/ctlr_create file exists and is writable by fcoemon the new template will be used. To write to the new sysfs locations the new helper routines, fcm_write_str_to_sysfs_file and

[Open-FCoE] [RFC PATCH 4/4] fcoemon: Add a force legacy mode option

2012-10-09 Thread Robert Love
Add an option to fcoemon to force it to use the legacy kernel interfaces. Signed-off-by: Robert Love robert.w.l...@intel.com --- doc/fcoemon.8 | 22 ++ doc/fcoemon.txt |6 +- fcoemon.c | 10 -- 3 files changed, 31 insertions(+), 7 deletions(-)

[Open-FCoE] [RFC PATCH 1/4] fcoemon: Find the fcoe_cltr for an ifname in sysfs

2012-10-09 Thread Robert Love
The kernel now displays fcoe_ctlr_device represenations in sysfs. We will need a reference to these devices in later patches when we start using the kernel's new fcoe_sysfs based create, destroy, enable and disable interfaces. Signed-off-by: Robert Love robert.w.l...@intel.com --- fcoemon.c

[Open-FCoE] [PATCH 1/2] QUICKSTART: Add clone instructions for libhbalinux and fcoe-utils

2012-10-09 Thread Robert Love
The QUICKSTART lists these repos at the top of the file, but doesn't mention the repo names at all in the install instructions. This patch explains where to clone from in the install instructions for both libhbalinux.git and fcoe-utils.git. Signed-off-by: Robert Love robert.w.l...@intel.com

[Open-FCoE] [PATCH 2/2] QUICKSTART: Update references to libHBAAPI.git

2012-10-09 Thread Robert Love
The SourceForge HBAAPI project has merged into the hbaapi_build.git repository, resulting in the libHBAAPI.git repository. This patch converts the documentation to point to the new repository and removes a now unnecessary installation step. Signed-off-by: Robert Love robert.w.l...@intel.com

[Open-FCoE] [PATCH 1/2] INSTALL: Remove unnecessary build step

2012-10-09 Thread Robert Love
Now that the SourceForge HBAAPI code has merged into hbaapi_build to create libHBAAPI we no longer need to instruct the user to download the code. This patch updates the INSTALL document to remove the download step. The patch also updates the header at the top of the file to remove a reference to

[Open-FCoE] [PATCH 2/2] hbaapi: Remove WIN32 defines

2012-10-09 Thread Robert Love
This code base is intended for Linux, remove WIN32 defines. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com --- hbaapilib.c | 319 +-- 1 file changed, 4 insertions(+), 315 deletions(-)