Re: [PATCH v2] bsps: Add BSP_FLUSH_KERNEL_CHAR_OUTPUT BSP option

2024-03-19 Thread Chris Johns
On 19/3/2024 7:39 pm, Sebastian Huber wrote: > Make the kernel I/O output character device flushing configurable. The > bsp_reset() function should reset the unit and do nothing else. This changes existing behaviour. RTEMS is poor at cleanly handling the console output on reset. Working with the

Re: [PATCH v2] bsps: Add BSP_FLUSH_KERNEL_CHAR_OUTPUT BSP option

2024-03-19 Thread Chris Johns
On 20/3/2024 2:03 am, Sebastian Huber wrote: > On 19.03.24 14:50, Kinsey Moore wrote: >> The xilinx-zynqmp-rpu bsp_reset() is modified, but not included in the spec >> file for the new option. Its family differs from the arm/xilinx-zynqmp BSP >> family with a -rpu suffix. > > Yes, but this BSP is

Re: [PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp

2024-03-19 Thread Sebastian Huber
On 19.03.24 18:34, Chris Johns wrote: I will build the BSPs for each commit today. Thanks. The reason I raised this is GitLab can squash merges to `main` and the reason is always being able to bisect `main` so it is an issue being considered. This patch set made me wonder what we do now? I

Re: [PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp

2024-03-19 Thread Chris Johns
On 19/3/2024 5:59 pm, Sebastian Huber wrote: > On 19.03.24 03:21, Chris Johns wrote: >> Does this patch series build at the per commit level? > > I used > > ./waf bspdefaults > a.txt > apply patch > ./waf bspdefaults > b.txt > diff a.txt b.txt > > to check that the defaults don't change.

Re: [PATCH 3/5] xilinx-zynqmp-rpu: Remove URLs from copyrights

2024-03-19 Thread Chris Johns
On 19/3/2024 5:52 pm, Sebastian Huber wrote: > On 19.03.24 03:20, Chris Johns wrote: >> On 19/3/2024 3:30 am, Sebastian Huber wrote: >>> --- >>>   spec/build/bsps/arm/xilinx-zynqmp-rpu/abi.yml    | 2 +- >>>   spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml  | 2 +- >>>  

Re: [PATCH 3/5] xilinx-zynqmp-rpu: Remove URLs from copyrights

2024-03-19 Thread Philip Kirkpatrick
Sebastian, Looks good with me. Stanislav also gave approval. -Phil From: Stanislav Pankevich Sent: Tuesday, March 19, 2024 5:45 PM To: Philip Kirkpatrick Subject: WG: [PATCH 3/5] xilinx-zynqmp-rpu: Remove URLs from copyrights

Re: utf32 support

2024-03-19 Thread John Howard
A 32 bit character type is supported by FreeBSD. Unicode 2012 says utf32 must be a 32 bit signed integer. Unicode only defines the Codepoint character attribute. RTEMS now uses libBSD and newlib. Need kernel to support the Codepoint range of values. Applications can then use additional

[PATCH] dev/irq: Optional arm_gic_irq_processor_count()

2024-03-19 Thread Sebastian Huber
Provide arm_gic_irq_processor_count() only in SMP configurations. --- bsps/include/dev/irq/arm-gic-irq.h | 2 ++ bsps/shared/dev/irq/arm-gicv2.c| 2 ++ bsps/shared/dev/irq/arm-gicv3.c| 2 ++ 3 files changed, 6 insertions(+) diff --git a/bsps/include/dev/irq/arm-gic-irq.h

Re: [PATCH v2] bsps: Add BSP_FLUSH_KERNEL_CHAR_OUTPUT BSP option

2024-03-19 Thread Sebastian Huber
On 19.03.24 14:50, Kinsey Moore wrote: The xilinx-zynqmp-rpu bsp_reset() is modified, but not included in the spec file for the new option. Its family differs from the arm/xilinx-zynqmp BSP family with a -rpu suffix. Yes, but this BSP is quite new. I would prefer to let it not flush anything

Re: [PATCH v2] user: Add docu for use of Rust with RTEMS

2024-03-19 Thread Frank Kühndel
Hi Chris, On 3/19/24 03:24, Chris Johns wrote: On 16/3/2024 1:14 am, Frank Kühndel wrote: Ping! The last discussion of this patch was https://lists.rtems.org/pipermail/devel/2024-February/077289.html Does the fact that I recive no further comments to this patch mean it can be pushed to

Re: [PATCH v2] bsps: Add BSP_FLUSH_KERNEL_CHAR_OUTPUT BSP option

2024-03-19 Thread Kinsey Moore
The xilinx-zynqmp-rpu bsp_reset() is modified, but not included in the spec file for the new option. Its family differs from the arm/xilinx-zynqmp BSP family with a -rpu suffix. I'd be fine with this being enabled for the AArch64 BSPs as well, but I imagine that's better as a separate patch.

AW: bsps: xilinx-zynqmp-rpu: fix the integer truncation in Triple Timer Counter clock driver

2024-03-19 Thread Stanislav Pankevich
Hello Sebastian, I have also reviewed the other changes that we now have since the original BSP patch, and it looks like our current queue for Zynq RPU is empty. We are curious to see which changes/rework for RPU you are preparing. Thanks, Stanislav Von:

Re: utf32 support

2024-03-19 Thread Frank Kühndel
Hello John, just a side node: Strictly speaking UTF32 does not exist [1]. The correct name is UCS-4 (i.e store each character in four bytes). "Current plans are that there will never be characters assigned outside the 21-bit code space from 0x00 to 0x10" [2]. References: [1]

Re: bsps: xilinx-zynqmp-rpu: fix the integer truncation in Triple Timer Counter clock driver

2024-03-19 Thread Sebastian Huber
Hello Stanislav, that is a nice coincidence. I started to work with this BSP last week and I also fixed this issue, but I had some other patches in the queue. I reworked this driver a bit. I will check in your patch first. On 19.03.24 10:54, Stanislav Pankevich wrote: Dear RTEMS developers,

bsps: xilinx-zynqmp-rpu: fix the integer truncation in Triple Timer Counter clock driver

2024-03-19 Thread Stanislav Pankevich
Dear RTEMS developers, Here is a follow-up patch to our previous work on the Zynq US+ RPU BSP. In fact, we had fixed this issue a few months ago but didn't find a good time to upstream it since then. P.S. It is great to see that the migration to GitLab is happening. Thanks, Stanislav ---

[PATCH v2] bsps: Add BSP_FLUSH_KERNEL_CHAR_OUTPUT BSP option

2024-03-19 Thread Sebastian Huber
Make the kernel I/O output character device flushing configurable. The bsp_reset() function should reset the unit and do nothing else. The arm/xilinx-zynq and arm/xilinx-zynqmp BSPs were the only ones doing an UART flush in bsp_reset(). The bsp_reset() function should reset the system and do

Re: [PATCH 1/5] bsps: Use bsps/aarch64/xilinx-zynqmp

2024-03-19 Thread Sebastian Huber
On 19.03.24 03:21, Chris Johns wrote: Does this patch series build at the per commit level? I used ./waf bspdefaults > a.txt apply patch ./waf bspdefaults > b.txt diff a.txt b.txt to check that the defaults don't change. I will build the BSPs for each commit today. -- embedded brains GmbH

Re: [PATCH] improved error checking in ticks per timeslice

2024-03-19 Thread Sebastian Huber
On 18.03.24 21:31, Kinsey Moore wrote: Sorry, I didn't realize I had tests turned off in my local build when I checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well. This is fine for fixing the build, but I would rather fix the tests. Applications may have there own clock

Re: [PATCH 3/5] xilinx-zynqmp-rpu: Remove URLs from copyrights

2024-03-19 Thread Sebastian Huber
On 19.03.24 03:20, Chris Johns wrote: On 19/3/2024 3:30 am, Sebastian Huber wrote: --- spec/build/bsps/arm/xilinx-zynqmp-rpu/abi.yml| 2 +- spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml | 2 +- spec/build/bsps/arm/xilinx-zynqmp-rpu/linkcmds.yml | 2 +-

Re: [PATCH] bsps: Add BSP_FLUSH_KERNEL_CHAR_OUTPUT option

2024-03-19 Thread Sebastian Huber
On 19.03.24 03:16, Chris Johns wrote: On 19/3/2024 3:49 am, Sebastian Huber wrote: Make the kernel I/O output character device flushing configurable. The bsp_reset() function should reset the unit and do nothing else. --- bsps/aarch64/xilinx-zynqmp/console/console.c | 3 ++-