[PATCH] Re: xmag segv's

2003-02-28 Thread Kevin Brosius
Yeah, that's what it's trying to do. The problem is it doesn't check the first child of root for InputOnly, only 2nd children on up. E17 has an InputOnly window as the first child of root, which breaks xmag. I'd suggest the following patch. It checks to make sure all children are InputOutput

Re: xmag segv's

2003-02-26 Thread Kevin Brosius
The background reports Depth: 0 with xwininfo. That looks like a problem. The x,y,... to the GetImage seem good, 1103,302,64,64. -- Kevin Mark Vojkovich wrote: Are there depth 32 windows or something? If not GetImageAndAttributes should call XGetImage on the root window. It

Re: xmag segv's

2003-02-26 Thread Mark Vojkovich
On Wed, 26 Feb 2003, Kevin Brosius wrote: The background reports Depth: 0 with xwininfo. That looks like a problem. The x,y,... to the GetImage seem good, 1103,302,64,64. What does xwininfo say the Class is? It should be InputOnly. Depth 0 windows are InputOnly. Can you poke around

Re: xmag segv's

2003-02-26 Thread The Rasterman
On Wed, 26 Feb 2003 20:41:40 -0500 Kevin Brosius [EMAIL PROTECTED] babbled: The background reports Depth: 0 with xwininfo. That looks like a problem. The x,y,... to the GetImage seem good, 1103,302,64,64. naughty xmag. it's assuming it can do XGetImage on an InputOnlyWindow :) naughty

Re: xmag segv's

2003-02-26 Thread Mark Vojkovich
On Thu, 27 Feb 2003, Carsten Haitzler wrote: On Wed, 26 Feb 2003 20:41:40 -0500 Kevin Brosius [EMAIL PROTECTED] babbled: The background reports Depth: 0 with xwininfo. That looks like a problem. The x,y,... to the GetImage seem good, 1103,302,64,64. naughty xmag. it's assuming it

Re: xmag segv's

2003-02-26 Thread The Rasterman
On Wed, 26 Feb 2003 21:15:57 -0500 (EST) Mark Vojkovich [EMAIL PROTECTED] babbled: On Thu, 27 Feb 2003, Carsten Haitzler wrote: On Wed, 26 Feb 2003 20:41:40 -0500 Kevin Brosius [EMAIL PROTECTED] babbled: The background reports Depth: 0 with xwininfo. That looks like a problem.

Re: xmag segv's

2003-02-25 Thread Mark Vojkovich
Are there depth 32 windows or something? If not GetImageAndAttributes should call XGetImage on the root window. It looks like the checks in there are OK. Can you check the x,y,width,height to that first XGetImage in GetImageAndAttributes? Mark. On Tue, 25 Feb 2003,

Re: xmag segv's

2003-02-24 Thread Mark Vojkovich
I don't see how the window manager could be involved. How current of CVS? The last thing in the CHANGELOG on my machine is 862 and I don't see this problem. I think BadMatch can happen with GetImage only if the app trys to grab outside of the window. I think xmag grabs on the root