On Thu, 26 Jun 2003, David Dawes wrote: > Grepping through the driver source, I do see that one or two video > drivers do use this approach too. The "mga" driver even writes to a > (fixed) temporary file name in a publicly-writable location, which looks > like an open invitation for any user to overwrite arbitary system files. > (I don't know who reviewed/committed that stuff.)
Hmm, I don't like the current version of MGASwitchMode(). As well as the For starters should we be using fopen modes "rt" and "wt" ? On Linux and Solaris, and unlike "rb" and "rw", the "t"s aren't even documented as valid but having no effect. Then, as David says, it touches publicly writable files. The new MGASwitchMode came in with mga_driver.c 1.221 (a huge change with over 60 different reasons). It appears to allow an external program to call routines in mga_esc.c. I'm guessing that this is a program Matrox ship to allow reconfiguration of a running server. Can I take it that we can just remove it ? If not, we need some documentation, so that we can turn it into a server extension -- Andrew C Aitchison _______________________________________________ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
