Re: [PATCH] radeon Xv alpha blending support

2003-11-20 Thread Vladimir Dergachev
Hi Alex :) Thanks for the patch ! May I suggest that you change XV_GR_ALPHA and XV_OV_ALPHA to XV_GRAPHICS_ALPHA and XV_OVERLAY_ALPHA ? This does not cost anything in terms of performance. best Vladimir Dergachev On Wed, 19 Nov

Re: [PATCH] radeon Xv alpha blending support

2003-11-20 Thread Thomas Winischhofer
Alex Deucher wrote: The attached patch adds alpha blending support to the video overlay on radeon hardware. It's been tested on my 9200. It adds three new Xv attributes: XV_ALPHA_MODE, XV_GR_ALPHA, and XV_OV_ALPHA. XV_ALPHA_MODE - (0 or 1) selects the alpha blending mode. right now it only

Re: [PATCH] radeon Xv alpha blending support

2003-11-20 Thread Alex Deucher
--- Thomas Winischhofer [EMAIL PROTECTED] wrote: Alex Deucher wrote: The attached patch adds alpha blending support to the video overlay on radeon hardware. It's been tested on my 9200. It adds three new Xv attributes: XV_ALPHA_MODE, XV_GR_ALPHA, and XV_OV_ALPHA. XV_ALPHA_MODE - (0

Re: [PATCH] radeon Xv alpha blending support

2003-11-20 Thread Thomas Winischhofer
Alex Deucher wrote: radeon has an option XV_AUTOPAINT_COLORKEY that enables or disables the auto filling of the colorkey by the driver (stops xf86XVFillKeyHelper()). is this equivalent to what your option does? Not entirely. AUTOPAINT_COLORKEY does not stop applications from drawing the

Re: [PATCH] radeon Xv alpha blending support

2003-11-20 Thread Alex Deucher
This is probably due to my limited understanding of writing Xv apps but how do you keep the app from drawing the colorkey itself? isn't it just an X rectangle? is there an Xv function that the app uses or does it just draw a rectangle and paint it the colorkey color? How does the sis driver do

Re: [PATCH] radeon Xv alpha blending support

2003-11-20 Thread Thomas Winischhofer
Alex Deucher wrote: This is probably due to my limited understanding of writing Xv apps but how do you keep the app from drawing the colorkey itself? isn't it I simply assume that the app will, some way or the other, in the end use the XAA accelerator functions. As I said, my method is not

Re: [PATCH] radeon Xv alpha blending support

2003-11-20 Thread Thomas Winischhofer
Alex Deucher wrote: does Xv even work without a colokey? Yes, at least on SiS hardware. There are 16 combinations of src and dst combination (video-ROPs) available, include the standard one (video if background = colorkey) and all possible combinations of chroma- and colorkey (which monstly

[PATCH] radeon Xv alpha blending support

2003-11-19 Thread Alex Deucher
The attached patch adds alpha blending support to the video overlay on radeon hardware. It's been tested on my 9200. It adds three new Xv attributes: XV_ALPHA_MODE, XV_GR_ALPHA, and XV_OV_ALPHA. XV_ALPHA_MODE - (0 or 1) selects the alpha blending mode. right now it only supports key and global