Re: [PATCH] allow setting service-type for SMPP SMSC
David Holland wrote: Please find below a patch to allow an SMPP SMSC group to contain a service-type definition. Previously Kannel would always send NULL, i.e. use default service-type. I've tested this patch and it works against Xwireless/Mblox SMPP server. If no-one objects I'll commit it to CVS and update the userguide. Many thanks to Nick Clarey for writing this when I realised what the missing functionality was. seems clean to me from first glance, +1. One thing only: what's the default of the value if *no* config directive is given?! It looks you don't initialize the variable and hence you will pass garbage, or does cfg_get() return NULL in case the value is not given?! Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
Re: [PATCH] allow setting service-type for SMPP SMSC
On Tue, Feb 18, 2003 at 02:58:12PM +0100, Stipe Tolj wrote: One thing only: what's the default of the value if *no* config directive is given?! NULL. (and I have tested that -- it appears correctly in the PDU dump) It looks you don't initialize the variable and hence you will pass garbage, or does cfg_get() return NULL in case the value is not given?! Yes, that's what happens. Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 :: Even if you are on the right track, you'll get run over if you just sit there.
Re: [PATCH] allow setting service-type for SMPP SMSC
David Holland wrote: On Tue, Feb 18, 2003 at 02:58:12PM +0100, Stipe Tolj wrote: One thing only: what's the default of the value if *no* config directive is given?! NULL. (and I have tested that -- it appears correctly in the PDU dump) It looks you don't initialize the variable and hence you will pass garbage, or does cfg_get() return NULL in case the value is not given?! Yes, that's what happens. ok, then I'm off with ++1 :) Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
Re: [PATCH] allow setting service-type for SMPP SMSC
Hi, +1 from me too. We use similar patch for a while... Am Dienstag, 18. Februar 2003 15:08 schrieb Stipe Tolj: David Holland wrote: On Tue, Feb 18, 2003 at 02:58:12PM +0100, Stipe Tolj wrote: One thing only: what's the default of the value if *no* config directive is given?! NULL. (and I have tested that -- it appears correctly in the PDU dump) It looks you don't initialize the variable and hence you will pass garbage, or does cfg_get() return NULL in case the value is not given?! Yes, that's what happens. ok, then I'm off with ++1 :) Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are -- Best regards / Mit besten Grüßen aus Köln Dipl.-Ing. Alexander Malysh ___ Centrium GmbH Ehrenstraße 2 50672 Köln Fon: +49 (0221) 277 49 240 Fax: +49 (0221) 277 49 109 email: [EMAIL PROTECTED] web: www.centrium.de msn: [EMAIL PROTECTED]
Re: [PATCH] allow setting service-type for SMPP SMSC
+1 from me too. We use similar patch for a while... so why didn't you post it ;)) Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
Re: [PATCH] allow setting service-type for SMPP SMSC
On Tue, Feb 18, 2003 at 03:34:24PM +0100, Stipe Tolj wrote: so why didn't you post it ;)) Too late, I've committed it now :-) Dave -- :: David Holland :: Systems Manager :: 3G Lab :: +44 01223 478900 :: Fare evasion also adds a much needed element of excitement to the otherwise dull trek to work. -- Ronald Seegers
Re: [PATCH] allow setting service-type for SMPP SMSC
David Holland [EMAIL PROTECTED] wrote: I've tested this patch and it works against Xwireless/Mblox SMPP server. Heh, I wrote that server :) -- Ian Cass
Re: [PATCH] allow setting service-type for SMPP SMSC
Am Dienstag, 18. Februar 2003 15:34 schrieb Stipe Tolj: +1 from me too. We use similar patch for a while... so why didn't you post it ;)) ahh I thought it is uninteresting for all ;) Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are -- Best regards / Mit besten Grüßen aus Köln Dipl.-Ing. Alexander Malysh ___ Centrium GmbH Ehrenstraße 2 50672 Köln Fon: +49 (0221) 277 49 240 Fax: +49 (0221) 277 49 109 email: [EMAIL PROTECTED] web: www.centrium.de msn: [EMAIL PROTECTED]
Re: [PATCH] allow setting service-type for SMPP SMSC
Ian Cass wrote: David Holland [EMAIL PROTECTED] wrote: I've tested this patch and it works against Xwireless/Mblox SMPP server. Heh, I wrote that server :) ok, so we know who to blaim ;)) just kidding. I guess you're then interested in getting smppbox into Kannel's cvs repository, right?! Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
Re: [PATCH] allow setting service-type for SMPP SMSC
Stipe Tolj [EMAIL PROTECTED] wrote: Ian Cass wrote: Heh, I wrote that server :) ok, so we know who to blaim ;)) heh just kidding. I guess you're then interested in getting smppbox into Kannel's cvs repository, right?! No, it's a standalone app that has nothing to do with Kannel. -- Ian Cass
Re: [PATCH] allow setting service-type for SMPP SMSC
just kidding. I guess you're then interested in getting smppbox into Kannel's cvs repository, right?! No, it's a standalone app that has nothing to do with Kannel. I know (or I assumed to be more precise :). But I guessed you'd be interested in playing arround with out SMPP server implementation based on Kannel's sources. Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
Re: [PATCH] allow setting service-type for SMPP SMSC
At 01:51 PM 2/18/03 +, David Holland wrote: Please find below a patch to allow an SMPP SMSC group to contain a service-type definition. Previously Kannel would always send NULL, i.e. use default service-type. I've tested this patch and it works against Xwireless/Mblox SMPP server. If no-one objects I'll commit it to CVS and update the userguide. looks good +1 nisan
Re: [PATCH] allow setting service-type for SMPP SMSC
At 04:49 PM 2/18/03 +0100, Stipe Tolj wrote: just kidding. I guess you're then interested in getting smppbox into Kannel's cvs repository, right?! No, it's a standalone app that has nothing to do with Kannel. I know (or I assumed to be more precise :). But I guessed you'd be interested in playing arround with out SMPP server implementation based on Kannel's sources. I think many of us on the list would love to play with yur smpp box...hint... ;-) nisan Stipe [EMAIL PROTECTED] --- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de --- wapme.net - wherever you are
