Re: [SailfishDevel] Harbour validation rules for SFOS 3.3
You are welcome! Thanks for update, I just re-submit OSM Scout 2.2 to Harbour. Lukas Dne úterý 19. května 2020 10:13:07 CEST Ville Nummela napsal(a): > On 12.5.2020 15.25, Ville Nummela wrote: > > On 12.5.2020 12.35, Lukáš Karas wrote: > >> Both cases looks like false positive to me. Or there is any real > >> reason to > >> rejecting such binaries? > > > > You are right, these are both false positives. We will fix the > > validator. I will let you know (on this list) when it's done. > > According to our QA, the fixed validator is now in place. Thanks for the PR! > > -Ville > > ___ > SailfishOS.org Devel mailing list > To unsubscribe, please send a mail to devel-unsubscr...@lists.sailfishos.org signature.asc Description: This is a digitally signed message part. ___ SailfishOS.org Devel mailing list To unsubscribe, please send a mail to devel-unsubscr...@lists.sailfishos.org
Re: [SailfishDevel] Harbour validation rules for SFOS 3.3
On 12.5.2020 15.25, Ville Nummela wrote: On 12.5.2020 12.35, Lukáš Karas wrote: Both cases looks like false positive to me. Or there is any real reason to rejecting such binaries? You are right, these are both false positives. We will fix the validator. I will let you know (on this list) when it's done. According to our QA, the fixed validator is now in place. Thanks for the PR! -Ville ___ SailfishOS.org Devel mailing list To unsubscribe, please send a mail to devel-unsubscr...@lists.sailfishos.org
Re: [SailfishDevel] Harbour validation rules for SFOS 3.3
On 12.5.2020 16.07, Lukáš Karas wrote: Great to hear that :-) I may provide patch to speedup this fix, it seems to be simple shell script: https://github.com/sailfishos/sdk-harbour-rpmvalidator/blob/master/ rpmvalidation.sh#L1066 Question is, how it should be checked? Just ELF excutables and ignore /home/mersdk/* ? PRs are always welcome :) Our current thinking is that we should still keep checking all files, but only against /home/nemo/ and /home/defaultuser/. Those two are the most likely candidates to be accidentally hardcoded in apps. -Ville ___ SailfishOS.org Devel mailing list To unsubscribe, please send a mail to devel-unsubscr...@lists.sailfishos.org
Re: [SailfishDevel] Harbour validation rules for SFOS 3.3
Hi. > > You are right, these are both false positives. We will fix the > validator. I will let you know (on this list) when it's done. > Great to hear that :-) I may provide patch to speedup this fix, it seems to be simple shell script: https://github.com/sailfishos/sdk-harbour-rpmvalidator/blob/master/ rpmvalidation.sh#L1066 Question is, how it should be checked? Just ELF excutables and ignore /home/mersdk/* ? Lukas signature.asc Description: This is a digitally signed message part. ___ SailfishOS.org Devel mailing list To unsubscribe, please send a mail to devel-unsubscr...@lists.sailfishos.org
Re: [SailfishDevel] Harbour validation rules for SFOS 3.3
Hi, On 12.5.2020 12.35, Lukáš Karas wrote: ERROR [/usr/share/harbour-osmscout/map-icons/bus_stop.svg] Hardcoded path: inkscape:export-filename="/home/tim/projects/OSMScout/libosmscout/data/icons/ 14x14/standard/bus_stop.png" Another "errors" comes from application binary itself, for example: ERROR [/usr/bin/harbour-osmscout] Hardcoded path: /home/mersdk/share/ Both cases looks like false positive to me. Or there is any real reason to rejecting such binaries? You are right, these are both false positives. We will fix the validator. I will let you know (on this list) when it's done. -Ville ___ SailfishOS.org Devel mailing list To unsubscribe, please send a mail to devel-unsubscr...@lists.sailfishos.org
