[Development] bool QProcess::waitForFinished() Race Condition?

2012-09-26 Thread d3fault
Unable to confirm the race condition, which is why I'm posting here instead of filing the bug report. Isn't there a race condition between calling QProcess::start() and QProcess::waitForFinished()? Can't the OS switch contexts at ANY TIME (in this case, between the start() and waitForFinished()

Re: [Development] bool QProcess::waitForFinished() Race Condition?

2012-09-26 Thread Rohan McGovern
d3fault said: Unable to confirm the race condition, which is why I'm posting here instead of filing the bug report. Isn't there a race condition between calling QProcess::start() and QProcess::waitForFinished()? Can't the OS switch contexts at ANY TIME (in this case, between the start() and

Re: [Development] bool QProcess::waitForFinished() Race Condition?

2012-09-26 Thread d3fault
Ahh that makes sense. Thank you! Here is my proposed change for the documentation regarding the return value from waitForFinished() : Returns true if the process finished; otherwise returns false (if the operation timed out, if an error occurred, or if this QProcess is already finished. Note

Re: [Development] bool QProcess::waitForFinished() Race Condition?

2012-09-26 Thread André Somers
Op 26-9-2012 9:32, d3fault schreef: I don't have a git clone and gerrit set up atm otherwise I'd submit it. Can someone else do it for me? Well, this sounds like a fine time to get such a setup then? And another semi-OT question relating to documentation: how are we synchronizing wiki edits of

Re: [Development] bool QProcess::waitForFinished() Race Condition?

2012-09-26 Thread d3fault
On Wed, Sep 26, 2012 at 12:40 AM, André Somers an...@familiesomers.nl wrote: Op 26-9-2012 9:32, d3fault schreef: I don't have a git clone and gerrit set up atm otherwise I'd submit it. Can someone else do it for me? Well, this sounds like a fine time to get such a setup then? And another