Hello Mark,
I agree that the commit message could have a better description and I
understand your concerns. I'm not an SPI expert by any means but I did
my best to review the patches and provide feedback to Naveen on the
first iterations of the series.
On Mon, Jul 14, 2014 at 7:25 PM, Mark Brown
On Tue, Jul 15, 2014 at 09:33:21AM +0530, Naveen Krishna Ch wrote:
On 15 July 2014 00:45, Mark Brown broo...@kernel.org wrote:
The problem isn't what you're trying to do, the problem is verifying
that it has been done correctly - making sure that everything has been
accounted for in the
On Tue, Jul 15, 2014 at 12:38:58PM +0200, Javier Martinez Canillas wrote:
Hello Mark,
Don't top post.
On Mon, Jul 14, 2014 at 7:25 PM, Mark Brown broo...@kernel.org wrote:
On Mon, Jul 14, 2014 at 11:11:44AM +0530, Naveen Krishna Chatradhi wrote:
So, the .line field is used to specify a
Hi Naveen,
On 14.07.2014 07:41, Naveen Krishna Chatradhi wrote:
Since, (3146bee spi: s3c64xx: Added provision for dedicated cs pin)
spi-s3c64xx.c driver expects
1. chip select gpios from cs-gpio(singular) under the
controller-data node of the client/slave device of the SPI.
Please work
Hello Tomasz,
On 15 July 2014 22:25, Tomasz Figa t.f...@samsung.com wrote:
Hi Naveen,
On 14.07.2014 07:41, Naveen Krishna Chatradhi wrote:
Since, (3146bee spi: s3c64xx: Added provision for dedicated cs pin)
spi-s3c64xx.c driver expects
1. chip select gpios from cs-gpio(singular) under the
On Mon, Jul 14, 2014 at 11:11:44AM +0530, Naveen Krishna Chatradhi wrote:
@@ -812,6 +800,10 @@ static int s3c64xx_spi_setup(struct spi_device *spi)
spi-controller_data = cs;
}
+ /* For the non-DT platforms derive chip selects from controller data */
+ if
Hello Mark,
On 14 July 2014 22:55, Mark Brown broo...@kernel.org wrote:
On Mon, Jul 14, 2014 at 11:11:44AM +0530, Naveen Krishna Chatradhi wrote:
@@ -812,6 +800,10 @@ static int s3c64xx_spi_setup(struct spi_device *spi)
spi-controller_data = cs;
}
+ /* For the
On Tue, Jul 15, 2014 at 12:31:32AM +0530, Naveen Krishna Ch wrote:
in this case spi-s3c64xx.c will continue to ignore the generic SPI cs-gpios
implementation.
I'm willing to implement any suggestion to fix this issue.
The problem isn't what you're trying to do, the problem is verifying
that
Hello Mark,
On 15 July 2014 00:45, Mark Brown broo...@kernel.org wrote:
On Tue, Jul 15, 2014 at 12:31:32AM +0530, Naveen Krishna Ch wrote:
in this case spi-s3c64xx.c will continue to ignore the generic SPI cs-gpios
implementation.
I'm willing to implement any suggestion to fix this issue.
