[patch] ehci-ppc-of: problems in unwind

2010-08-14 Thread Dan Carpenter
The iounmap(ehci-ohci_hcctrl_reg); should be the first thing we do because the ioremap() was the last thing we did. Also if we hit any of the goto statements in the original code then it would have led to a NULL dereference of ehci. This bug was introduced in: 796bcae7361c USB: powerpc:

Re: olpc ofw question

2010-08-14 Thread Andres Salomon
On Wed, 11 Aug 2010 15:53:44 -1000 Mitch Bradley w...@firmworks.com wrote: [...] The proc_of.c code that I wrote in Dec 2006 uses the package-to-path method mentioned above, getting the n...@addr representation (package-to-path returns the full path, but you can easily extract just the tail

Re: olpc ofw question

2010-08-14 Thread Mitch Bradley
Andres Salomon wrote: On Wed, 11 Aug 2010 15:53:44 -1000 Mitch Bradley w...@firmworks.com wrote: [...] The proc_of.c code that I wrote in Dec 2006 uses the package-to-path method mentioned above, getting the n...@addr representation (package-to-path returns the full path, but you can easily