[PATCH] of: Add missing of_address.h to xilinx ehci driver

2011-02-14 Thread Michal Simek
Build log: In file included from drivers/usb/host/ehci-hcd.c:1208: drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe': drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource' Signed-off-by: John Williams

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

2011-02-14 Thread Grant Likely
On Mon, Feb 14, 2011 at 3:40 AM, Michal Simek mon...@monstr.eu wrote: Build log: In file included from drivers/usb/host/ehci-hcd.c:1208: drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe': drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function

[PATCH] Print a device-tree message at KERN_WARNING level

2011-02-14 Thread Paul Bolle
For some time now a laptop tracking Fedora's rawhide prints the message /proc/device-tree: can't find root early in each boot. It turns out that in recent Fedora kernels CONFIG_PROC_DEVICETREE is set to Y by default. (Note that the config help for PROC_DEVICETREE tells to say Y here if

Re: [PATCH v2] watchdog: Add driver for Altera Watchdog Timer

2011-02-14 Thread Jamie Iles
Hi Tobias, One very pedantic comment, otherwise looks great! On Tue, Feb 08, 2011 at 02:22:02PM +0100, Tobias Klauser wrote: This driver adds support for the Altera Timer in the Watchdog Timer configuration. This component is usually found on SOPC (System on Programmable Chip) for Altera

[PATCH v3] watchdog: Add driver for Altera Watchdog Timer

2011-02-14 Thread Tobias Klauser
This driver adds support for the Altera Timer in the Watchdog Timer configuration. This component is usually found on SOPC (System on Programmable Chip) for Altera FPGAs. Signed-off-by: Tobias Klauser tklau...@distanz.ch Reviewed-by: Jamie Iles ja...@jamieiles.com --- Thanks a lot to Jamie Iles

Re: [PATCH v3] watchdog: Add driver for Altera Watchdog Timer

2011-02-14 Thread Belisko Marek
On Wed, Feb 9, 2011 at 8:19 AM, Tobias Klauser tklau...@distanz.ch wrote: This driver adds support for the Altera Timer in the Watchdog Timer configuration. This component is usually found on SOPC (System on Programmable Chip) for Altera FPGAs. Signed-off-by: Tobias Klauser

Re: [PATCH v3] watchdog: Add driver for Altera Watchdog Timer

2011-02-14 Thread Tobias Klauser
On 2011-02-09 at 08:56:48 +0100, Belisko Marek marek.beli...@gmail.com wrote: On Wed, Feb 9, 2011 at 8:19 AM, Tobias Klauser tklau...@distanz.ch wrote: This driver adds support for the Altera Timer in the Watchdog Timer configuration. This component is usually found on SOPC (System on

RE: [RFC PATCH] ARM: pmu: add OF match support

2011-02-14 Thread Will Deacon
Hi Rob, Add OF match table to enable OF style driver binding. The dts entry is like this: pmu { compatible = arm,pmu; interrupts = 100 101; }; The use of pdev-id as an index breaks with OF device binding. Change to use a counter instead. If more than 1 pmu device is ever

[PATCH 3/4] tty: serial: altera_uart: Add devicetree support

2011-02-14 Thread Tobias Klauser
With the recent switch of the (currently still out-of-tree) Nios2 Linux port to devicetree we want to be able to retreive the resources and properties from dts. The old method to retreive resources and properties from platform data is still supported. Signed-off-by: Tobias Klauser

RE: [RFC PATCH] ARM: pmu: add OF match support

2011-02-14 Thread Will Deacon
Hi Grant, Rob, On Tue, Feb 8, 2011 at 8:53 PM, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com Add OF match table to enable OF style driver binding. The dts entry is like this: pmu { compatible = arm,pmu; interrupts = 100 101; };

Re: [PATCH v9] spi: New driver for Altera SPI

2011-02-14 Thread Ryan Mallon
On 02/14/2011 03:10 PM, Thomas Chou wrote: This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- +struct altera_spi { + /* bitbang has to be first */ + struct

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

2011-02-14 Thread Greg KH
On Mon, Feb 14, 2011 at 06:54:08AM -0700, Grant Likely wrote: On Mon, Feb 14, 2011 at 3:40 AM, Michal Simek mon...@monstr.eu wrote: Build log: In file included from drivers/usb/host/ehci-hcd.c:1208: drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':

RE: [RFC PATCH] ARM: pmu: add OF match support

2011-02-14 Thread Will Deacon
Grant, Following on from Rob's update, it would be nice if you could specify that the PMU is a CPU PMU (as opposed to L2-cache, bus, gpu etc) in the string. That way adding different PMUs in the future seems more natural and it accounts for your concerns above. Is that ok, or does the

Re: [PATCH] Print a device-tree message at KERN_WARNING level

2011-02-14 Thread Grant Likely
On Mon, Feb 7, 2011 at 6:26 AM, Paul Bolle pebo...@tiscali.nl wrote: For some time now a laptop tracking Fedora's rawhide prints the message    /proc/device-tree: can't find root early in each boot. It turns out that in recent Fedora kernels CONFIG_PROC_DEVICETREE is set to Y by default.

Re: Fwd: [PATCH] of: Add missing of_address.h to xilinx ehci driver

2011-02-14 Thread Harry Wei
On Mon, Feb 14, 2011 at 11:53:13PM +0800, harryxiyou wrote: -- Forwarded message -- From: Michal Simek mon...@monstr.eu Date: 2011/2/14 Subject: [PATCH] of: Add missing of_address.h to xilinx ehci driver To: glik...@secretlab.ca Cc: devicetree-discuss@lists.ozlabs.org,

[PATCH] [TRIVIAL] Drop an uninteresting message to pr_debug level

2011-02-14 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl --- On Mon, 2011-02-14 at 08:27 -0700, Grant Likely wrote: The message is unnecessary. It can just be dropped altogether, or changed to a pr_debug(). Thanks. I picked the second option, as it is enough to address my concerns. diff --git

Re: [PATCH v9] spi: New driver for Altera SPI

2011-02-14 Thread Thomas Chou
Dear Ryan, On 02/14/2011 10:20 AM, Ryan Mallon wrote: On 02/14/2011 03:10 PM, Thomas Chou wrote: This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Choutho...@wytron.com.tw --- +struct altera_spi { +