Re: [PATCH] ARM: Make sure appended device tree data won't overlap kernel BSS

2011-06-12 Thread Nicolas Pitre
On Fri, 13 May 2011, Tony Lindgren wrote: From: Tony Lindgren t...@atomide.com Date: Thu, 12 May 2011 05:29:49 -0700 Subject: [PATCH] ARM: zImage: Make sure appended device tree data won't overlap kernel BSS Do this before relocating the compressed kernel + device tree data. Otherwise we

[PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Nicolas Pitre
This is a resend of those patches with fixups after the latest changes in mainline. [PATCH 1/3] ARM: zImage: ensure it is always a multiple of 64 bits in size This one is new and trivial. [PATCH 2/3] ARM: zImage: Allow the appending of a device tree binary Mostly John Bonesio's version with some

[PATCH 1/3] ARM: zImage: ensure it is always a multiple of 64 bits in size

2011-06-12 Thread Nicolas Pitre
This is needed for proper alignment when the DTB appending feature is used. Signed-off-by: Nicolas Pitre nicolas.pi...@linaro.org --- arch/arm/boot/compressed/vmlinux.lds.in |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/compressed/vmlinux.lds.in

[PATCH 2/3] ARM: zImage: Allow the appending of a device tree binary

2011-06-12 Thread Nicolas Pitre
From: John Bonesio bo...@secretlab.ca This patch provides the ability to boot using a device tree that is appended to the raw binary zImage (e.g. cat zImage filename.dtb zImage_w_dtb). Signed-off-by: John Bonesio bo...@secretlab.ca [nico: adjusted to latest zImage changes plus additional

[PATCH 3/3] ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss

2011-06-12 Thread Nicolas Pitre
The appended DTB gets relocated with the decompressor code to get out of the way of the decompressed kernel. However the .bss section may be larger than the relocated code and data, therefore overwriting the DTB. Let's make sure the relocation takes care of moving zImage so no conflict with .bss

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 02:06:37AM -0400, Nicolas Pitre wrote: This is a resend of those patches with fixups after the latest changes in mainline. [PATCH 1/3] ARM: zImage: ensure it is always a multiple of 64 bits in size This one is new and trivial. [PATCH 2/3] ARM: zImage: Allow the

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Shawn Guo
On Sun, Jun 12, 2011 at 09:15:41AM +0100, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 02:06:37AM -0400, Nicolas Pitre wrote: This is a resend of those patches with fixups after the latest changes in mainline. [PATCH 1/3] ARM: zImage: ensure it is always a multiple of 64 bits

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 04:34:15PM +0800, Shawn Guo wrote: On Sun, Jun 12, 2011 at 09:15:41AM +0100, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 02:06:37AM -0400, Nicolas Pitre wrote: This is a resend of those patches with fixups after the latest changes in mainline.

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Shawn Guo
On Sun, Jun 12, 2011 at 10:21:31AM +0100, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 04:34:15PM +0800, Shawn Guo wrote: On Sun, Jun 12, 2011 at 09:15:41AM +0100, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 02:06:37AM -0400, Nicolas Pitre wrote: This is a resend

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Shawn Guo
On Sun, Jun 12, 2011 at 10:52:17AM +0100, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 05:38:23PM +0800, Shawn Guo wrote: On Sun, Jun 12, 2011 at 10:21:31AM +0100, Russell King - ARM Linux wrote: What if your platform doesn't use uboot? Add dtb parsing support with the help

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 06:42:16PM +0800, Shawn Guo wrote: On Sun, Jun 12, 2011 at 10:52:17AM +0100, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 05:38:23PM +0800, Shawn Guo wrote: On Sun, Jun 12, 2011 at 10:21:31AM +0100, Russell King - ARM Linux wrote: What if your platform

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 01:22:19PM +0200, Petr Štetiar wrote: Shawn Guo shawn@freescale.com [2011-06-12 16:34:15]: On Sun, Jun 12, 2011 at 09:15:41AM +0100, Russell King - ARM Linux wrote: One thing which has been bugging me for some time is that the DT stuff completely

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Arnd Bergmann
On Sunday 12 June 2011 13:58:20 Russell King - ARM Linux wrote: Exactly my point - I have quite a number of platforms here which will never be able to have a boot loader capable of modifying a DT blob for the kernel. One of the points of Nicolas' patch set is to allow existing boot loaders

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 04:15:23PM +0200, Arnd Bergmann wrote: On Sunday 12 June 2011 13:58:20 Russell King - ARM Linux wrote: Exactly my point - I have quite a number of platforms here which will never be able to have a boot loader capable of modifying a DT blob for the kernel. One of

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Grant Likely
On Sun, Jun 12, 2011 at 04:15:23PM +0200, Arnd Bergmann wrote: On Sunday 12 June 2011 13:58:20 Russell King - ARM Linux wrote: Exactly my point - I have quite a number of platforms here which will never be able to have a boot loader capable of modifying a DT blob for the kernel. One of

Re: [PATCH 2/3] ARM: zImage: Allow the appending of a device tree binary

2011-06-12 Thread Grant Likely
On Sun, Jun 12, 2011 at 02:06:39AM -0400, Nicolas Pitre wrote: From: John Bonesio bo...@secretlab.ca This patch provides the ability to boot using a device tree that is appended to the raw binary zImage (e.g. cat zImage filename.dtb zImage_w_dtb). Signed-off-by: John Bonesio

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Arnd Bergmann
On Sunday 12 June 2011 16:34:28 Russell King - ARM Linux wrote: I don't think you're considering real-world usage scenarios, but instead concentrating on the use issues. If you only do that you're boxing yourself into a corner and will cause a world of pain for folk who would just like the

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 08:57:51AM -0600, Grant Likely wrote: On Sun, Jun 12, 2011 at 04:15:23PM +0200, Arnd Bergmann wrote: But when you have both atag and DT and the atag overrides the DT, that means we have incorrect information in the DT, and code might later rely on that information.

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 05:01:22PM +0200, Arnd Bergmann wrote: Of course it should override the device tree, I'm not arguing that. All I'm saying is that we don't need to special-case this or support both formats once the kernel is there as long as we move the information into appropriate

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Nicolas Pitre
On Sun, 12 Jun 2011, Russell King - ARM Linux wrote: One of the points of Nicolas' patch set is to allow existing boot loaders to boot kernels where the hardware description is contained in a DT blob encapsulated with the kernel. That's great but the way things are currently setup, it means

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Nicolas Pitre
On Sun, 12 Jun 2011, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 08:57:51AM -0600, Grant Likely wrote: On Sun, Jun 12, 2011 at 04:15:23PM +0200, Arnd Bergmann wrote: But when you have both atag and DT and the atag overrides the DT, that means we have incorrect information in

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Russell King - ARM Linux
On Sun, Jun 12, 2011 at 11:47:59AM -0400, Nicolas Pitre wrote: On Sun, 12 Jun 2011, Russell King - ARM Linux wrote: And we've ended up with a fucked up situation which is extremely fragile, and actually makes me _NOT_ want to convert any existing platforms to use DT in the least. Agreed.

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Nicolas Pitre
On Sun, 12 Jun 2011, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 11:47:59AM -0400, Nicolas Pitre wrote: On Sun, 12 Jun 2011, Russell King - ARM Linux wrote: And we've ended up with a fucked up situation which is extremely fragile, and actually makes me _NOT_ want to convert

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Warner Losh
On Jun 12, 2011, at 9:59 AM, Russell King - ARM Linux wrote: On Sun, Jun 12, 2011 at 11:47:59AM -0400, Nicolas Pitre wrote: On Sun, 12 Jun 2011, Russell King - ARM Linux wrote: And we've ended up with a fucked up situation which is extremely fragile, and actually makes me _NOT_ want to

Re: [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage

2011-06-12 Thread Grant Likely
On Sun, Jun 12, 2011 at 12:06 AM, Nicolas Pitre nicolas.pi...@linaro.org wrote: This is a resend of those patches with fixups after the latest changes in mainline. [PATCH 1/3] ARM: zImage: ensure it is always a multiple of 64 bits in size This one is new and trivial. [PATCH 2/3] ARM: