Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-19 Thread Russell King - ARM Linux
On Tue, Jul 19, 2011 at 09:17:26AM +0800, Shawn Guo wrote: On Mon, Jul 18, 2011 at 10:02:44AM -0700, Dmitry Torokhov wrote: On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: The patch makes a copy of platform data into driver data, so that any reference to platform_data after .probe

Re: [PATCH 0/7] support DT on ARCH-MMP

2011-07-19 Thread Jean Delvare
Hi Haojian, On Tue, 19 Jul 2011 10:24:43 +0800, Haojian Zhuang wrote: It's used to support DT on ARCH-MMP. Haojian Zhuang (7): ARM: mmp: parse irq from DT ARM: mmp: append MMP_USE_OF config ARM: mmp: support DT on both dkb and brownstone tty: serial: support

Re: [PATCH v3 0/4] Add device tree probe for sdhci-esdhc-imx

2011-07-19 Thread Sascha Hauer
On Mon, Jul 18, 2011 at 09:51:28PM -0400, Chris Ball wrote: Hi Shawn, Sascha, On Sat, Jul 09 2011, Shawn Guo wrote: Shawn Guo (4): mmc: sdhci-esdhc-imx: do not reference platform data after probe mmc: sdhci-esdhc-imx: get rid of the uses of cpu_is_mx() mmc:

Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-19 Thread Shawn Guo
On Tue, Jul 19, 2011 at 08:48:41AM +0100, Russell King - ARM Linux wrote: On Tue, Jul 19, 2011 at 09:17:26AM +0800, Shawn Guo wrote: On Mon, Jul 18, 2011 at 10:02:44AM -0700, Dmitry Torokhov wrote: On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: The patch makes a copy of platform

Re: [PATCH v3 0/4] Add device tree probe for sdhci-esdhc-imx

2011-07-19 Thread Shawn Guo
On Tue, Jul 19, 2011 at 10:10:27AM +0200, Sascha Hauer wrote: On Mon, Jul 18, 2011 at 09:51:28PM -0400, Chris Ball wrote: Hi Shawn, Sascha, On Sat, Jul 09 2011, Shawn Guo wrote: Shawn Guo (4): mmc: sdhci-esdhc-imx: do not reference platform data after probe mmc:

Re: [PATCH 7/7] i2c: pxa: support to parse property

2011-07-19 Thread Eric Miao
On Tue, Jul 19, 2011 at 10:24 AM, Haojian Zhuang haojian.zhu...@marvell.com wrote: Support to parse some optional properties. These three properties are i2c-polling, i2c-frequency, i2c-class. After supporting these property, i2c-pxa driver can avoid to use platform data except for slave mode.

Re: [PATCH v2 1/2] irq: add irq_domain translation infrastructure

2011-07-19 Thread Ralf Baechle
On Mon, Jul 18, 2011 at 04:31:40PM -0600, Grant Likely wrote: This patch adds irq_domain infrastructure for translating from hardware irq numbers to linux irqs. This is particularly important for architectures adding device tree support because the current implementation (excluding PowerPC

Re: [PATCH 3/7] ARM: mmp: support DT on both dkb and brownstone

2011-07-19 Thread Mitch Bradley
Thanks for doing this work. I'm currently working on a One Laptop Per Child product that is based on the Armada 610, so this very timely for OLPC. See my in-line comments on the specification of the soc top-level nodes, related to the addressing of their children, and on the presence of

Re: Is there a binding for IORESOURCE_DMA population?

2011-07-19 Thread Arnd Bergmann
On Sunday 17 July 2011, Tabi Timur-B04825 wrote: Shawn Guo wrote: Ok, I will take this as a serious warning, and start evaluating the driver consolidation. I will absolutely need you help along the way. At least, when we get there, I need your favor to test mpc platform, as I do not have

Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine

2011-07-19 Thread G, Manjunath Kondaiah
On Tue, Jul 19, 2011 at 2:00 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jul 18, 2011 at 5:53 AM, G, Manjunath Kondaiah manj...@linaro.org wrote: Abraham, Few comments on i2c child devices handling: On 18 July 2011 06:20, Thomas Abraham thomas.abra...@linaro.org wrote: Add

Re: [PATCH 1/7] ARM: mmp: parse irq from DT

2011-07-19 Thread Grant Likely
On Mon, Jul 18, 2011 at 8:24 PM, Haojian Zhuang haojian.zhu...@marvell.com wrote: Parse irq sepcifier from DT and translate it to Linux irq number. Signed-off-by: Haojian Zhuang haojian.zhu...@marvell.com ---  .../devicetree/bindings/arm/marvell/intc.txt       |  120 +++  

Re: [PATCH 2/7] ARM: mmp: append MMP_USE_OF config

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 10:24:45AM +0800, Haojian Zhuang wrote: Since NR_IRQS is defined in irqs.h, parsing irq specifier will be started from NR_IRQS while both CONFIG_USE_OF and CONFIG_SPARSE_IRQ is enabled. It breaks the assumption that base irq is started from 0. Add CONFIG_MMP_USE_OF

Re: [PATCH 3/7] ARM: mmp: support DT on both dkb and brownstone

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 10:24:46AM +0800, Haojian Zhuang wrote: Add new boards.c to support both TTC-DKB and MMP2-BROWNSTONE. While CONFIG_MMP_USE_OF is selected, original ttc_dkb.c and brownstone.c won't be compiled. While everything moving to DT in ARCH-MMP, original ttc_dkb.c and

Re: [PATCH 4/7] tty: serial: support device tree in pxa

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 10:24:47AM +0800, Haojian Zhuang wrote: Support both normal platform driver and device tree driver in serial pxa. Signed-off-by: Haojian Zhuang haojian.zhu...@marvell.com --- drivers/tty/serial/Kconfig |4 +- drivers/tty/serial/of_serial.c | 12 +

Re: [PATCH 6/7] i2c: pxa: support i2c controller from DT

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 10:24:49AM +0800, Haojian Zhuang wrote: support i2c-pxa controller from DT. Signed-off-by: Haojian Zhuang haojian.zhu...@marvell.com --- drivers/i2c/busses/i2c-pxa.c | 58 ++--- 1 files changed, 42 insertions(+), 16 deletions(-)

Re: [PATCH 7/7] i2c: pxa: support to parse property

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 06:17:21PM +0800, Eric Miao wrote: On Tue, Jul 19, 2011 at 10:24 AM, Haojian Zhuang haojian.zhu...@marvell.com wrote: Support to parse some optional properties. These three properties are i2c-polling, i2c-frequency, i2c-class. After supporting these property,

Re: [PATCH 4/7] tty: serial: support device tree in pxa

2011-07-19 Thread Arnd Bergmann
On Tuesday 19 July 2011 13:40:10 Grant Likely wrote: On Tue, Jul 19, 2011 at 10:24:47AM +0800, Haojian Zhuang wrote: Support both normal platform driver and device tree driver in serial pxa. Signed-off-by: Haojian Zhuang haojian.zhu...@marvell.com --- drivers/tty/serial/Kconfig |

Re: [PATCH 4/7] tty: serial: support device tree in pxa

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 1:48 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 19 July 2011 13:40:10 Grant Likely wrote: On Tue, Jul 19, 2011 at 10:24:47AM +0800, Haojian Zhuang wrote: Support both normal platform driver and device tree driver in serial pxa. Signed-off-by: Haojian Zhuang

Re: [PATCH 4/7] tty: serial: support device tree in pxa

2011-07-19 Thread Russell King - ARM Linux
On Tue, Jul 19, 2011 at 01:53:53PM -0600, Grant Likely wrote: On Tue, Jul 19, 2011 at 1:48 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 19 July 2011 13:40:10 Grant Likely wrote: On Tue, Jul 19, 2011 at 10:24:47AM +0800, Haojian Zhuang wrote: Support both normal platform driver and

Re: [PATCH 3/4] dt: omap3: add generic board file for dt support

2011-07-19 Thread Grant Likely
On Mon, Jul 18, 2011 at 02:07:10AM -0700, Tony Lindgren wrote: * Grant Likely grant.lik...@secretlab.ca [110716 22:08]: The way I see it, you've got two options: 1) modify the of_platform_bus_create() to call some kind of of_platform_bus_create_omap() for devices that match

[PATCH 1/3] usb: tegra20-ehci: Add devicetree support.

2011-07-19 Thread achew
From: Andrew Chew ac...@nvidia.com Add code to try to get platform data information (register base, irq, modes, various tuning parameters) from device tree, if not present in board files. Signed-off-by: Andrew Chew ac...@nvidia.com --- .../devicetree/bindings/usb/tegra20-ehci.txt | 27

[PATCH 2/3] dt: tegra20: Add ehci host controller nodes.

2011-07-19 Thread achew
From: Andrew Chew ac...@nvidia.com These values were derived from various headers in arch/arm/mach-tegra. Signed-off-by: Andrew Chew ac...@nvidia.com --- arch/arm/boot/dts/tegra20.dtsi | 52 1 files changed, 52 insertions(+), 0 deletions(-) diff --git

RE: [PATCH 1/3] usb: tegra20-ehci: Add devicetree support.

2011-07-19 Thread Stephen Warren
ac...@nvidia.com wrote at Tuesday, July 19, 2011 4:47 PM: From: Andrew Chew ac...@nvidia.com Add code to try to get platform data information (register base, irq, modes, various tuning parameters) from device tree, if not present in board files. Signed-off-by: Andrew Chew ac...@nvidia.com

Re: [PATCH 1/3] usb: tegra20-ehci: Add devicetree support.

2011-07-19 Thread Grant Likely
On Tue, Jul 19, 2011 at 03:56:29PM -0700, Stephen Warren wrote: ac...@nvidia.com wrote at Tuesday, July 19, 2011 4:47 PM: From: Andrew Chew ac...@nvidia.com Add code to try to get platform data information (register base, irq, modes, various tuning parameters) from device tree, if not

RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

2011-07-19 Thread Stephen Warren
ac...@nvidia.com wrote at Tuesday, July 19, 2011 4:47 PM: From: Andrew Chew ac...@nvidia.com Signed-off-by: Andrew Chew ac...@nvidia.com Removing status=disabled from tegra20.dtsi makes this patch obsolete. Although that said, since many of the USB properties are board-specific and

RE: [PATCH 2/3] dt: tegra20: Add ehci host controller nodes.

2011-07-19 Thread Stephen Warren
Stephen Warren wrote at Tuesday, July 19, 2011 5:00 PM: ac...@nvidia.com wrote at Tuesday, July 19, 2011 4:47 PM: From: Andrew Chew ac...@nvidia.com These values were derived from various headers in arch/arm/mach-tegra. ... diff --git a/arch/arm/boot/dts/tegra20.dtsi

RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

2011-07-19 Thread Andrew Chew
Although that said, since many of the USB properties are board-specific and determined by system characterization, they aren't generally applicable to all Tegra devices. As such, should those values be moved into tegra-seaboard.dts instead? Perhaps tegra20.dtsi should specify the default

Re: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

2011-07-19 Thread Olof Johansson
On Tue, Jul 19, 2011 at 4:50 PM, Andrew Chew ac...@nvidia.com wrote: Although that said, since many of the USB properties are board-specific and determined by system characterization, they aren't generally applicable to all Tegra devices. As such, should those values be moved into

Re: [PATCH 2/3] dt: tegra20: Add ehci host controller nodes.

2011-07-19 Thread Olof Johansson
Hi, On Tue, Jul 19, 2011 at 3:46 PM, ac...@nvidia.com wrote: From: Andrew Chew ac...@nvidia.com These values were derived from various headers in arch/arm/mach-tegra. Signed-off-by: Andrew Chew ac...@nvidia.com ---  arch/arm/boot/dts/tegra20.dtsi |   52

RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

2011-07-19 Thread Andrew Chew
And since there are defaults specified in tegra20.dtsi, does it really make sense to also have default values assigned in ehci-tegra.c (for when a property is not present)?  I worry that the information is now duplicated.   If those properties aren't present, then someone's mucked with

Re: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

2011-07-19 Thread Olof Johansson
On Tue, Jul 19, 2011 at 5:07 PM, Andrew Chew ac...@nvidia.com wrote: And since there are defaults specified in tegra20.dtsi, does it really make sense to also have default values assigned in ehci-tegra.c (for when a property is not present)?  I worry that the information is now duplicated.

Re: [PATCH 7/7] i2c: pxa: support to parse property

2011-07-19 Thread Eric Miao
On Wed, Jul 20, 2011 at 3:45 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Jul 19, 2011 at 10:24:50AM +0800, Haojian Zhuang wrote: Support to parse some optional properties. These three properties are i2c-polling, i2c-frequency, i2c-class. After supporting these property, i2c-pxa

Re: [PATCH 4/7] tty: serial: support device tree in pxa

2011-07-19 Thread Eric Miao
On Wed, Jul 20, 2011 at 4:05 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jul 19, 2011 at 01:53:53PM -0600, Grant Likely wrote: On Tue, Jul 19, 2011 at 1:48 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 19 July 2011 13:40:10 Grant Likely wrote: On Tue, Jul 19, 2011

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote: +static const struct of_device_id dataflash_dt_ids[] = { + { .compatible = atmel,at45xxx, }, + { .compatible = atmel,dataflash, }, + { /* sentinel */ } +}; + This should be protected with a #ifdef CONFIG_OF/#else/#endif,

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Shawn Guo
On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote: On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote: +static const struct of_device_id dataflash_dt_ids[] = { + { .compatible = atmel,at45xxx, }, + { .compatible = atmel,dataflash, }, + { /*

Re: [PATCH v3] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Fri, 2011-07-15 at 16:38 +0800, Shawn Guo wrote: It adds device tree probe support for mtd_dataflash driver. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Cc: David Woodhouse dw...@infradead.org Cc: Artem Bityutskiy artem.bityuts...@nokia.com

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote: On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote: +static const struct of_device_id dataflash_dt_ids[] = { + { .compatible = atmel,at45xxx, }, + {

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 13:28 +0800, Shawn Guo wrote: On Wed, Jul 20, 2011 at 08:17:45AM +0300, Artem Bityutskiy wrote: On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote: On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote:

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Mike Frysinger
On Wed, Jul 20, 2011 at 01:32, Artem Bityutskiy wrote: On Wed, 2011-07-20 at 13:28 +0800, Shawn Guo wrote: On Wed, Jul 20, 2011 at 08:17:45AM +0300, Artem Bityutskiy wrote: On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote:

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Shawn Guo
On Wed, Jul 20, 2011 at 08:32:45AM +0300, Artem Bityutskiy wrote: On Wed, 2011-07-20 at 13:28 +0800, Shawn Guo wrote: On Wed, Jul 20, 2011 at 08:17:45AM +0300, Artem Bityutskiy wrote: On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 13:52 +0800, Shawn Guo wrote: The argument about this #ifdef thing was the driver could be used by some platforms that will never migrate to device tree. This table will be just a waste of bytes for those platforms, if we do not protect the table by '#ifdef CONFIG_OF'.