Re: [PATCH v2 1/4] ARM: vexpress: Get rid of MMIO_P2V

2011-11-28 Thread Russell King - ARM Linux
On Fri, Nov 25, 2011 at 04:15:00PM +, Dave Martin wrote: diff --git a/arch/arm/plat-versatile/headsmp.S b/arch/arm/plat-versatile/headsmp.S index d397a1f..0be2efc 100644 --- a/arch/arm/plat-versatile/headsmp.S +++ b/arch/arm/plat-versatile/headsmp.S @@ -28,6 +28,7 @@

Re: [PATCH v2 1/4] ARM: vexpress: Get rid of MMIO_P2V

2011-11-28 Thread Dave Martin
On Mon, Nov 28, 2011 at 10:44:16AM +, Russell King - ARM Linux wrote: On Fri, Nov 25, 2011 at 04:15:00PM +, Dave Martin wrote: diff --git a/arch/arm/plat-versatile/headsmp.S b/arch/arm/plat-versatile/headsmp.S index d397a1f..0be2efc 100644 --- a/arch/arm/plat-versatile/headsmp.S

Re: [PATCH v2 2/4] ARM: vexpress: Add DT support in v2m

2011-11-28 Thread Pawel Moll
On Fri, 2011-11-25 at 16:18 +, Dave Martin wrote: [Since this text is now stable enough to be proofread, I'll list minor pedantic nits along with the other comments -- they aren't vital to the meaning though, and the documentation still works if they aren't acted on.] [snip] Most

Re: [PATCH] of/irq: of_irq_init: add check for parent equal to child node

2011-11-28 Thread Pawel Moll
On Sun, 2011-11-27 at 20:49 -0600, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com With the revert of of/irq: of_irq_find_parent: check for parent equal to child (dc9372808412edb), we need another way to handle parent node equal to the child node. This can simply be handled in

[PATCH net-next v3 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-28 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-discuss@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang Grandegger w...@grandegger.com ---

[PATCH net-next v3 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-28 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: Devicetree-discuss@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Wolfgang

Re: [PATCH v2 2/4] ARM: vexpress: Add DT support in v2m

2011-11-28 Thread Dave Martin
On Mon, Nov 28, 2011 at 10:54:22AM +, Pawel Moll wrote: On Fri, 2011-11-25 at 16:18 +, Dave Martin wrote: [Since this text is now stable enough to be proofread, I'll list minor pedantic nits along with the other comments -- they aren't vital to the meaning though, and the

Re: [PATCH net-next v3 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-28 Thread Marc Kleine-Budde
On 11/28/2011 12:30 PM, Wolfgang Grandegger wrote: This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: Devicetree-discuss@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC:

[PATCH 0/5] Add device tree support for mc13892 regulator driver

2011-11-28 Thread Shawn Guo
The first patch adds device tree probe support for mc13xxx mfd driver. The patches #2 and #3 make small changes to regulator OF function for supporting the case like mc13892 regulator driver, where device_node does not have a struct device behind it. I'm sorry for that I did not notice them

[PATCH 1/5] mfd: mc13xxx: add device tree probe support

2011-11-28 Thread Shawn Guo
It adds device tree probe support for mc13xxx mfd driver. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/mc13xxx-core.c | 121 1 files changed, 89 insertions(+), 32 deletions(-) diff --git

[PATCH 2/5] regulator: fix label names used in device tree bindings

2011-11-28 Thread Shawn Guo
Device tree compiler does not recognize '-' in label name. Instead, '_' works fine. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Liam Girdwood l...@ti.com --- .../devicetree/bindings/regulator/regulator.txt| 10 +- 1 files

[PATCH 3/5] regulator: pass device_node to of_get_regulator_init_data()

2011-11-28 Thread Shawn Guo
It's not always true that the device_node of regulator can be found at dev-of_node, because in some cases the regulator nodes in device tree do not even have 'struct device' behind them. The patch adds device_node as a new parameter to of_get_regulator_init_data(), so that caller can pass in the

[PATCH 4/5] regulator: mc13892: add device tree probe support

2011-11-28 Thread Shawn Guo
It adds device tree probe support for mc13892-regulator driver. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Mark Brown broo...@opensource.wolfsonmicro.com Cc: Liam Girdwood l...@ti.com --- drivers/regulator/mc13892-regulator.c | 43 +++-

[PATCH 5/5] arm/imx: add mc13892 support into imx51-babbage.dts

2011-11-28 Thread Shawn Guo
It adds mc13892 support into imx51-babbage device tree source. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Sascha Hauer s.ha...@pengutronix.de --- arch/arm/boot/dts/imx51-babbage.dts | 100 ++- 1 files changed, 99 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 3/5] regulator: pass device_node to of_get_regulator_init_data()

2011-11-28 Thread Mark Brown
On Mon, Nov 28, 2011 at 09:37:17PM +0800, Shawn Guo wrote: --- drivers/regulator/of_regulator.c |7 --- include/linux/regulator/of_regulator.h |6 -- 2 files changed, 8 insertions(+), 5 deletions(-) Clearly this is going to break the build as you've not updated the

Re: [PATCH 4/5] regulator: mc13892: add device tree probe support

2011-11-28 Thread Mark Brown
On Mon, Nov 28, 2011 at 09:37:18PM +0800, Shawn Guo wrote: It adds device tree probe support for mc13892-regulator driver. You haven't documented the binding here at all. Documentation is mandatory for all device tree bindings. ___ devicetree-discuss

Re: [PATCH v2 3/4] omap-serial: Add minimal device tree support

2011-11-28 Thread Rob Herring
On 11/22/2011 07:44 AM, Rajendra Nayak wrote: Adapt the driver to device tree and pass minimal platform data from device tree needed for console boot. No power management features will be suppported for now since it requires more tweaks around OCP settings to toggle forceidle/noidle/smaridle

Re: [PATCH v2 4/4] ARM: omap: pass minimal SoC/board data for UART from dt

2011-11-28 Thread Rob Herring
On 11/22/2011 07:44 AM, Rajendra Nayak wrote: Pass minimal data needed for console boot, from dt, for OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the static initialization from generic board file. Signed-off-by: Rajendra Nayak rna...@ti.com Acked-by: Rob Herring

Re: [PATCH 3/5] regulator: pass device_node to of_get_regulator_init_data()

2011-11-28 Thread Shawn Guo
On Mon, Nov 28, 2011 at 01:34:26PM +, Mark Brown wrote: On Mon, Nov 28, 2011 at 09:37:17PM +0800, Shawn Guo wrote: --- drivers/regulator/of_regulator.c |7 --- include/linux/regulator/of_regulator.h |6 -- 2 files changed, 8 insertions(+), 5 deletions(-)

Re: [PATCH 4/5] regulator: mc13892: add device tree probe support

2011-11-28 Thread Shawn Guo
On Mon, Nov 28, 2011 at 01:35:45PM +, Mark Brown wrote: On Mon, Nov 28, 2011 at 09:37:18PM +0800, Shawn Guo wrote: It adds device tree probe support for mc13892-regulator driver. You haven't documented the binding here at all. Documentation is mandatory for all device tree bindings.

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Rob Herring
On 11/23/2011 09:01 AM, Pawel Moll wrote: Hello again, This version of the series (hopefully) addresses all the suggestions made by Dave, Rob and Russell. The compatible values are specific for the tiles now and the memory map variant is defined as a custom property in the motherboard

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Dave Martin
On Mon, Nov 28, 2011 at 08:25:12AM -0600, Rob Herring wrote: On 11/23/2011 09:01 AM, Pawel Moll wrote: Hello again, This version of the series (hopefully) addresses all the suggestions made by Dave, Rob and Russell. The compatible values are specific for the tiles now and the memory

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Dave Martin
On Mon, Nov 28, 2011 at 08:25:12AM -0600, Rob Herring wrote: On 11/23/2011 09:01 AM, Pawel Moll wrote: Hello again, This version of the series (hopefully) addresses all the suggestions made by Dave, Rob and Russell. The compatible values are specific for the tiles now and the memory

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Pawel Moll
On Mon, 2011-11-28 at 14:57 +, Dave Martin wrote: Oh, btw, git am reports a few whitespace errors on the last full post of the series (v2). Can you shove the series through checkpatch.pl and/or git am and fix any minor issues, now that the series is relatively stable? I did, actually:

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Dave Martin
On Mon, Nov 28, 2011 at 03:09:07PM +, Pawel Moll wrote: On Mon, 2011-11-28 at 14:57 +, Dave Martin wrote: Oh, btw, git am reports a few whitespace errors on the last full post of the series (v2). Can you shove the series through checkpatch.pl and/or git am and fix any minor

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Pawel Moll
On Mon, 2011-11-28 at 14:25 +, Rob Herring wrote: Other than Dave's comments, looks good. For the series: Acked-by: Rob Herring rob.herr...@calxeda.com Thanks! There are a number of compatible strings for various peripherals defined without documentation, but you're not really using

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Rob Herring
On 11/28/2011 09:20 AM, Pawel Moll wrote: On Mon, 2011-11-28 at 14:25 +, Rob Herring wrote: Other than Dave's comments, looks good. For the series: Acked-by: Rob Herring rob.herr...@calxeda.com Thanks! There are a number of compatible strings for various peripherals defined without

Re: [PATCH] of: Add Silicon Image vendor prefix

2011-11-28 Thread Rob Herring
On 11/08/2011 05:35 AM, Pawel Moll wrote: sil is the most commonly used abbreviation for Silicon Image products. Signed-off-by: Pawel Moll pawel.m...@arm.com --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 files changed, 1 insertions(+), 0 deletions(-) Applied. Rob

Re: [PATCH v2 0/4] Versatile Express DT support

2011-11-28 Thread Pawel Moll
On Mon, 2011-11-28 at 15:39 +, Rob Herring wrote: Okay. I'll apply. But that's just a vendor. There's still binding docs needed for the actual sil9022 device and some others. I think the sil one is the only undocumented device we use now, except for the primecells that Dave and I will

Re: [PATCH v2 4/4] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4

2011-11-28 Thread Dave Martin
On Wed, Nov 23, 2011 at 03:01:48PM +, Pawel Moll wrote: This patch adds Device Trees for ARM Ltd. CoreTile Express A5x2 and CoreTile Express A9x4 used with V2M motherboard and an initial implementation of the DT machine support (this code is separate from the current core tile code).

Re: [PATCH v2 4/4] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4

2011-11-28 Thread Pawel Moll
On Mon, 2011-11-28 at 16:29 +, Dave Martin wrote: +config ARCH_VEXPRESS_V2P_CA5S_CA9 + bool CoreTile Express A5x2 and A9x4 based platform support + select ARCH_VEXPRESS_RS1 + select ARCH_VEXPRESS_DT Shouldn't we depend on CPU_V7, ARM_GIC and CACHE_PL310 here? I get a lot of

Re: [PATCH v2 4/4] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4

2011-11-28 Thread Dave Martin
On Mon, Nov 28, 2011 at 05:00:02PM +, Pawel Moll wrote: On Mon, 2011-11-28 at 16:29 +, Dave Martin wrote: +config ARCH_VEXPRESS_V2P_CA5S_CA9 + bool CoreTile Express A5x2 and A9x4 based platform support + select ARCH_VEXPRESS_RS1 + select ARCH_VEXPRESS_DT Shouldn't we

Re: [PATCH 01/14] fdt: Tidy up a few fdtdec problems

2011-11-28 Thread Stephen Warren
On 11/23/2011 08:54 PM, Simon Glass wrote: This fixes three trivial issues in fdtdec.c: 1. fdtdec_get_is_enabled() doesn't really need a default value 2. The fdt must be word-aligned, since otherwise it will fail on ARM 3. The compat_names[] array is missing its first element diff --git

Re: [PATCH 02/14] fdt: Add functions to access phandles, arrays and bools

2011-11-28 Thread Stephen Warren
On 11/23/2011 08:54 PM, Simon Glass wrote: Add a function to lookup a property which is a phandle in a node, and another to read a fixed-length integer array from an fdt property. Also add a function to read boolean properties. Signed-off-by: Simon Glass s...@chromium.org Looking at the

Re: [PATCH 05/14] tegra: fdt: Add Tegra2x device tree file

2011-11-28 Thread Stephen Warren
On 11/23/2011 08:54 PM, Simon Glass wrote: This was taken from commit 1ea6b8f at: git://git.kernel.org/pub/scm/linux/kernel/git/olof/tegra.git That's not the latest version in linux-next. Also, this doesn't include quite a few changes that have been sent to the mailing lists but not yet

Re: [PATCH 2/5] regulator: fix label names used in device tree bindings

2011-11-28 Thread Mark Brown
On Mon, Nov 28, 2011 at 09:37:16PM +0800, Shawn Guo wrote: Device tree compiler does not recognize '-' in label name. Instead, '_' works fine. Applied, thanks. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org

Re: [PATCH v5] power: bq20z75: devicetree init support

2011-11-28 Thread Rhyland Klein
On Thu, 2011-11-24 at 10:42 -0800, Anton Vorontsov wrote: Hello Rhyland, Got this: CC [M] drivers/power/bq20z75.o drivers/power/bq20z75.c: In function ‘bq20z75_of_populate_pdata’: drivers/power/bq20z75.c:630:21: error: storage size of ‘gpio_flags’ isn’t known

RE: GPIO/IRQ expander cannot map interrupt

2011-11-28 Thread Stephen Warren
Thierry Reding wrote at Friday, November 25, 2011 3:45 AM: The following is an extract from a device tree of a Tegra2-based board I'm working on: [swarren: Abbreviated the DT during quoting] i2c@7000c000 { keypad1: sx8634@2b { interrupt-parent =

[PATCH] ASoC: Tegra I2S: Add device tree binding

2011-11-28 Thread Stephen Warren
Signed-off-by: Stephen Warren swar...@nvidia.com --- v2: * Modified binding to include the DMA controller's phandle. This value isn't used by the driver, but is useful to correctly represent the HW. * Renamed dma-channel property to dma-request-selector to better match what it describes. Added

Configurable interrupt sources, and DT bindings

2011-11-28 Thread Stephen Warren
Many interrupt sinks support various of active high/low, rising/falling edge. This can already be configured by setting #interrupt-cells appropriately, and defining an interrupt-controller-specific binding for the additional cells. At least some interrupt sources have similar configurability in

Re: Configurable interrupt sources, and DT bindings

2011-11-28 Thread Mark Brown
On Mon, Nov 28, 2011 at 03:29:51PM -0700, Stephen Warren wrote: Perhaps one of: irq-active-low; irq-active-high; irq-edge-falling; irq-edge-rising; or: interrupts-config = active-low // or active-high, etc. (perhaps with indices in that list matching the interrupts property) We do

Re: Configurable interrupt sources, and DT bindings

2011-11-28 Thread Rob Herring
On 11/28/2011 04:29 PM, Stephen Warren wrote: Many interrupt sinks support various of active high/low, rising/falling edge. This can already be configured by setting #interrupt-cells appropriately, and defining an interrupt-controller-specific binding for the additional cells. At least some

RE: [PATCH] ASoC: Tegra I2S: Add device tree binding

2011-11-28 Thread Stephen Warren
Stephen Warren wrote at Monday, November 28, 2011 2:08 PM: ... dmareq = platform_get_resource(pdev, IORESOURCE_DMA, 0); if (!dmareq) { - dev_err(pdev-dev, No DMA resource\n); - ret = -ENODEV; - goto err_clk_put; + if

RE: [PATCH] of/irq: of_irq_init: add check for parent equal to child node

2011-11-28 Thread Stephen Warren
Rob Herring wrote at Sunday, November 27, 2011 7:49 PM: From: Rob Herring rob.herr...@calxeda.com With the revert of of/irq: of_irq_find_parent: check for parent equal to child (dc9372808412edb), we need another way to handle parent node equal to the child node. This can simply be handled in

[PATCH V2] arm/tegra: convert tegra20 to GIC devicetree binding

2011-11-28 Thread Stephen Warren
From: pdeschrij...@nvidia.com pdeschrij...@nvidia.com Convert tegra20 IRQ intialization to the GIC devicetree binding. Modify the interrupt definitions in the dts files according to Documentation/devicetree/bindings/arm/gic.txt v2 (swarren): * Removed some stale GIC init code from board-dt.c *

Re: Configurable interrupt sources, and DT bindings

2011-11-28 Thread David Gibson
On Mon, Nov 28, 2011 at 03:29:51PM -0700, Stephen Warren wrote: Many interrupt sinks support various of active high/low, rising/falling edge. This can already be configured by setting #interrupt-cells appropriately, and defining an interrupt-controller-specific binding for the additional

Re: [PATCH 02/14] fdt: Add functions to access phandles, arrays and bools

2011-11-28 Thread David Gibson
On Mon, Nov 28, 2011 at 11:41:32AM -0700, Stephen Warren wrote: On 11/23/2011 08:54 PM, Simon Glass wrote: Add a function to lookup a property which is a phandle in a node, and another to read a fixed-length integer array from an fdt property. Also add a function to read boolean properties.

Re: [PATCH v4] net: add calxeda xgmac ethernet driver

2011-11-28 Thread David Miller
From: Rob Herring robherri...@gmail.com Date: Tue, 22 Nov 2011 21:18:19 -0600 From: Rob Herring rob.herr...@calxeda.com Add support for the XGMAC 10Gb ethernet device in the Calxeda Highbank SOC. Signed-off-by: Rob Herring rob.herr...@calxeda.com Applied.

Re: [PATCH v2 3/4] omap-serial: Add minimal device tree support

2011-11-28 Thread Rajendra Nayak
On Monday 28 November 2011 07:09 PM, Rob Herring wrote: On 11/22/2011 07:44 AM, Rajendra Nayak wrote: Adapt the driver to device tree and pass minimal platform data from device tree needed for console boot. No power management features will be suppported for now since it requires more tweaks

Pin control mappings for DT

2011-11-28 Thread Linus Walleij
Greetings, can we have some initial idea about DT support for pin control devices and how these will look? Since pin control seems to be a cruicial piece for people to get board data out of their kernels we'd better have a common understanding. The way I've understood it, we will need three