Re: [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings

2012-03-27 Thread Dmitry Torokhov
Hi Viresh, On Tue, Mar 27, 2012 at 11:08:12AM +0530, Viresh Kumar wrote: + if (np) { + pdata = devm_kzalloc(pdev-dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) { + dev_err(pdev-dev, DT: kzalloc failed\n); + return -ENOMEM;

Re: [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings

2012-03-27 Thread Viresh Kumar
On 3/27/2012 12:43 PM, Dmitry Torokhov wrote: I think the opposite order woudl make more sense - if pdata is supplied by the platform code then we should use it, otherwise try to see if there is OF data available instead. This way one can easily override OF data, if needed. Okay. Just for

Re: [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings

2012-03-27 Thread Dmitry Torokhov
On Tue, Mar 27, 2012 at 01:07:51PM +0530, Viresh Kumar wrote: On 3/27/2012 12:43 PM, Dmitry Torokhov wrote: I think the opposite order woudl make more sense - if pdata is supplied by the platform code then we should use it, otherwise try to see if there is OF data available instead. This

Re: [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings

2012-03-27 Thread Viresh Kumar
On 3/27/2012 1:21 PM, Dmitry Torokhov wrote: My reasoning is that device tree is in firmware and it might be desirable to override firmware in certain cases. Ok. Will do that. Otherwise, you are okay with both the patches? So that i can send V3. -- viresh

Re: kirkwood devicetree respin

2012-03-27 Thread Felipe Balbi
Hi, On Thu, Mar 22, 2012 at 06:28:26PM +, Paul Zimmerman wrote: context, toggle clocks, set pads in safe mode (when needed) and so on. But fair enough, both ways would work fine. I would also recommend your/Alan's approach to this over Felipe's way. We have a DWC3

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread Viresh Kumar
On 3/22/2012 7:50 PM, Arnd Bergmann wrote: The direct replacement is of_machine_is_compatible(), but there are a lot of cases where it's better to have a local property in the device node that a driver is using. Hey Arnd, I used of_machine_is_compatible() at several places, where it is not

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread Arnd Bergmann
On Tuesday 27 March 2012, Viresh Kumar wrote: On 3/22/2012 7:50 PM, Arnd Bergmann wrote: The direct replacement is of_machine_is_compatible(), but there are a lot of cases where it's better to have a local property in the device node that a driver is using. Hey Arnd, I used

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread Viresh Kumar
On 3/27/2012 4:45 PM, Arnd Bergmann wrote: On Tuesday 27 March 2012, Viresh Kumar wrote: The normal way is to turn around the logic so you don't have to include this test at all. Just have one soc-specific init_machine and map_io function, that calls both soc-specific and shared soc

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread Arnd Bergmann
On Tuesday 27 March 2012, Viresh Kumar wrote: On 3/27/2012 4:45 PM, Arnd Bergmann wrote: On Tuesday 27 March 2012, Viresh Kumar wrote: The normal way is to turn around the logic so you don't have to include this test at all. Just have one soc-specific init_machine and map_io function,

Re: [PATCH V2 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap()

2012-03-27 Thread Stephen Warren
On 03/26/2012 11:38 PM, Viresh Kumar wrote: We don't need to allocate memory for keymap in matrix_keyboard_of_fill_keymap(), as this would only be used by matrix_keyboard_of_free_keymap(). Instead create another routine matrix_keypad_of_build_keymap() which reads directly the property from

Re: [PATCH V2 2/2] Input: spear-keyboard: add device tree bindings

2012-03-27 Thread Stephen Warren
On 03/26/2012 11:38 PM, Viresh Kumar wrote: This adds simple DT bindings for spear-keyboard controller. Signed-off-by: Viresh Kumar viresh.ku...@st.com The binding documentation only, Reviewed-by: Stephen Warren swar...@wwwdotorg.org ___

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-03-27 Thread Chris Ball
Hi Kukjin, On Tue, Feb 21 2012, Chris Ball wrote: On Tue, Feb 21 2012, Kukjin Kim wrote: I created topic branch for this we talked. You can pull that following: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.4-for-cjb If any problems, please kindly let me know.

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-03-27 Thread Arnd Bergmann
On Tuesday 31 January 2012, Thomas Abraham wrote: + +Optional Board Specific Properties: +- samsung,sdhci-bus-width: Number of data lines connected to the controller. + Note: This excludes the clock,command and card detect lines. If this property + is not specified, default value is 1. +

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-03-27 Thread Arnd Bergmann
On Tuesday 31 January 2012, Thomas Abraham wrote: + +Optional Board Specific Properties: +- samsung,sdhci-bus-width: Number of data lines connected to the controller. + Note: This excludes the clock,command and card detect lines. If this property + is not specified, default value is 1. +

Re: [PATCH v7 2/4] MIPS: Octeon: Setup irq_domains for interrupts.

2012-03-27 Thread David Daney
On 03/26/2012 06:56 PM, Rob Herring wrote: On 03/26/2012 02:31 PM, David Daney wrote: From: David Daneydavid.da...@cavium.com [...] +static bool octeon_irq_ciu_is_edge(unsigned int line, unsigned int bit) +{ + bool edge = false; + + if (line == 0) + switch (bit) { +

Re: [PATCH v7 3/4] MIPS: Octeon: Add device tree source files.

2012-03-27 Thread David Daney
On 03/26/2012 07:38 PM, Rob Herring wrote: On 03/26/2012 02:31 PM, David Daney wrote: From: David Daneydavid.da...@cavium.com [...] +++ b/Documentation/devicetree/bindings/gpio/cavium-octeon-gpio.txt @@ -0,0 +1,48 @@ +* General Purpose Input Output (GPIO) bus. + +Properties: +- compatible:

[PATCH V3 3/5] ARM: kirkwood: Allow nand to be configured via. devicetree

2012-03-27 Thread Jamie Lentin
Add default configuration for NAND, to be enabled in your board config. Ensure clock gating is set appropriately when the NAND is enabled. Acked-by: Arnd Bergmann a...@arndb.de Signed-off-by: Jamie Lentin j...@lentin.co.uk --- arch/arm/boot/dts/kirkwood.dtsi | 15 ++-

[PATCH V3 2/5] mtd: Add orion_nand devicetree bindings

2012-03-27 Thread Jamie Lentin
Allow a NAND chip using the orion_nand driver to be described using devicetree. Acked-by: Arnd Bergmann a...@arndb.de Signed-off-by: Jamie Lentin j...@lentin.co.uk --- .../devicetree/bindings/mtd/orion-nand.txt | 46 drivers/mtd/nand/orion_nand.c

[PATCH V3 0/5] Add support for DNS-320 and DNS-325 using devicetree

2012-03-27 Thread Jamie Lentin
Thanks again to Arnd, Jason Scott. The differences here are fairly minor. Apart from documentation, I'm guessing that the changes aren't significant enough to revoke Acked-by, please flame me if I'm wrong! Changes since v2: * Split patches further, separating orion_nand and kirkwood changes *

[PATCH V3 4/5] ARM: kirkwood: Define DNS-320/DNS-325 NAND in fdt

2012-03-27 Thread Jamie Lentin
Use devicetree to define NAND partitions. Use D-link partition scheme by default, to be vaguely compatible with their userland. Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Jason Cooper ja...@lakedaemon.net Signed-off-by: Jamie Lentin j...@lentin.co.uk ---

[PATCH V3 1/5] ARM: kirkwood: Basic support for DNS-320 and DNS-325

2012-03-27 Thread Jamie Lentin
Add support for the DNS-320 and DNS-325. Describe as much as currently possible in the devicetree files, create a board-dnskw.c for everything else. Use IEEE-compliant okay, rather than ok Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Jason Cooper ja...@lakedaemon.net Signed-off-by: Jamie

Re: [PATCH v7 2/4] MIPS: Octeon: Setup irq_domains for interrupts.

2012-03-27 Thread Rob Herring
On 03/27/2012 01:24 PM, David Daney wrote: On 03/26/2012 06:56 PM, Rob Herring wrote: On 03/26/2012 02:31 PM, David Daney wrote: From: David Daneydavid.da...@cavium.com [...] +static bool octeon_irq_ciu_is_edge(unsigned int line, unsigned int bit) +{ +bool edge = false; + +if

Re: [PATCH v7 2/4] MIPS: Octeon: Setup irq_domains for interrupts.

2012-03-27 Thread David Daney
On 03/27/2012 03:05 PM, Rob Herring wrote: On 03/27/2012 01:24 PM, David Daney wrote: On 03/26/2012 06:56 PM, Rob Herring wrote: On 03/26/2012 02:31 PM, David Daney wrote: From: David Daneydavid.da...@cavium.com [...] +static bool octeon_irq_ciu_is_edge(unsigned int line, unsigned int bit)

[PATCH V2] dtc: Basic integer expressions

2012-03-27 Thread Stephen Warren
Written by David Gibson da...@gibson.dropbear.id.au. Additions by me: * Ported to ToT dtc. * Renamed cell to integer throughout. * Implemented value range checks. * Allow L/UL/LL/ULL suffix on literals. * Enabled the commented test. Signed-off-by: Stephen Warren swar...@wwwdotorg.org --- v2: *

[PATCH] dtc: check for duplicate labels when they are defined

2012-03-27 Thread Stephen Warren
Currently, the DT is checked for duplicate labels after the entire DT has been parsed. However, once parts of the DT can be deleted, some entities with labels may have been deleted by this time, thus making those labels invisible to the duplicate label check, which can then lead to false

Re: [PATCH] of/irq: add empty irq_of_parse_and_map() for non-dt builds

2012-03-27 Thread Grant Likely
On Sun, 25 Mar 2012 20:26:15 +0530, Thomas Abraham thomas.abra...@linaro.org wrote: On 25 March 2012 06:12, Grant Likely grant.lik...@secretlab.ca wrote: On Sat, 24 Mar 2012 08:12:39 -0500, Rob Herring robherri...@gmail.com wrote: On 03/24/2012 04:27 AM, Thomas Abraham wrote: Add a

[PATCH 7/7] sm501: restore big-endian operation.

2012-03-27 Thread Thomas Schwinge
On SH, as of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the endianess-agnostic I/O accessor functions. In commit bf5f0019046d596d613caf74722ba4994e153899, Heiko fixed this for 32-bit PowerPC; my patch now generalizes upon that. The device is now recognized correctly for both

[patch] sata_mv: silence an uninitialized variable warning

2012-03-27 Thread Dan Carpenter
Gcc version 4.6.2-12 complains that if we can't find the nr-ports property in of_property_read_u32_array() then n_ports is used uninitialized. Let's set it to zero in that case. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c

Re: [PATCH] stmmac: Add device-tree support

2012-03-27 Thread Giuseppe CAVALLARO
On 3/12/2012 4:06 PM, Stefan Roese wrote: Hi Rob, On Monday 12 March 2012 15:34:59 Rob Herring wrote: On 03/12/2012 09:05 AM, Stefan Roese wrote: This patch adds support to configure the STMMAC ethernet driver via device-tree instead of platform_data. Currently, only the properties needed

Re: [PATCH] stmmac: Add device-tree support

2012-03-27 Thread Giuseppe CAVALLARO
On 3/12/2012 5:23 PM, Stefan Roese wrote: On Monday 12 March 2012 16:30:37 Giuseppe CAVALLARO wrote: +Required properties: +- compatible: Should be stm,gmac This is too generic. This should be 1 string per version of h/w. Viresh, Giuseppe, can you please suggest a proper string for the

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-27 Thread Zach Sadecki
On 03/13/2012 09:35 AM, Rob Herring wrote: + ahb@8008 { + fec@800f { Use generic names: ethernet@800f Generic is good, but consistency is better, IMHO. grepping existing dts files in 3.2.9 finds 6 instances of fec@ and 0 instances of ethernet@ +

[patch] max17042_battery: fix a couple buffer overflows

2012-03-27 Thread Dan Carpenter
There are a couple issues here caused by confusion between sizeof() and ARRAY_SIZE(). table_size should be the number of elements, but we should allocate it with kcalloc() so that we allocate the correct number of bytes. In max17042_init_model() we don't allocate enough space so we go past the

[PATCH] Device Tree Bindings for Freescale TDM controller

2012-03-27 Thread Poonam Aggrwal
From: Poonam Aggrwal poonam.aggr...@freescale.com This TDM controller is available in various Freescale SOCs like MPC8315, P1020, P1022, P1010. Signed-off-by: Sandeep Singh sand...@freescale.com Signed-off-by: Poonam Aggrwal poonam.aggr...@freescale.com ---

RE: EHCI_MV confusion was: Re: kirkwood devicetree respin

2012-03-27 Thread Neil Zhang
-Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: 2012年3月22日 0:28 To: Nicolas Pitre Cc: Neil Zhang; Jason Cooper; Arnd Bergmann; Andrew Lunn; Jamie Lentin; USB list; mich...@walle.cc; devicetree-discuss@lists.ozlabs.org Subject: Re: EHCI_MV confusion was:

Re: uImage with integrated dtb file

2012-03-27 Thread Roland Stigge
On 26/03/12 17:06, Stephen Warren wrote: quiet_cmd_uimage = UIMAGE $@ - cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A arm -O linux -T kernel \ + cmd_uimage = cat $ arch/arm/boot/*.dtb $.tmp ; \ That won't work well when multiple .dtb files are built. That's completely correct!

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-03-27 Thread Tomasz Stanislawski
Hi Karol, Please refer to comments below, Regards, Tomasz Stanislawski On 03/13/2012 05:54 PM, Karol Lewandowski wrote: This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY device on Exynos4 platform. Some quirks are introduced due to differences between HDMIPHY and

Re: [PATCH v1 4/5] dma: mxs-dma: add dt probe support

2012-03-27 Thread Huang Shijie
Hi Aisheng: From: Dong Aishengdong.aish...@linaro.org Signed-off-by: Dong Aishengdong.aish...@linaro.org --- .../devicetree/bindings/dma/fsl-mxs-dma.txt| 17 drivers/dma/mxs-dma.c | 44 +-- 2 files changed, 47 insertions(+),

Re: [PATCH v1 5/5] ARM: mxs: add mxs dma dt support

2012-03-27 Thread Huang Shijie
Hi, + dma-apbh@80004000 { + compatible = fsl,mxs-dma-apbh; + reg =0x80004000 2000; + }; + Why you do not add the `interrupt` for the it? the gpmi-nand needs to parse the interrupt out. BR

Re: [PATCH v1 5/5] ARM: mxs: add mxs dma dt support

2012-03-27 Thread Huang Shijie
Hi Aisheng: The non-dt way also does not have interrupt resource for dma device. It seems the channel interrupt resource is handled in each client device. I'm not familiar with gpmi-nand, but I guess you may need to handle it in gpmi driver, just like mxs-mmc driver. ok, got it. thanks Huang

Re: [PATCH] stmmac: Add device-tree support

2012-03-27 Thread Giuseppe CAVALLARO
On 3/12/2012 3:38 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 15:05 Mon 12 Mar , Stefan Roese wrote: This patch adds support to configure the STMMAC ethernet driver via device-tree instead of platform_data. Currently, only the properties needed on SPEAr600 are provided. All other

Re: [PATCH] stmmac: Add device-tree support

2012-03-27 Thread Giuseppe CAVALLARO
On 3/14/2012 2:07 PM, Arnd Bergmann wrote: On Wednesday 14 March 2012, Giuseppe CAVALLARO wrote: On 3/12/2012 3:38 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 15:05 Mon 12 Mar , Stefan Roese wrote: This patch adds support to configure the STMMAC ethernet driver via device-tree instead

Re: [PATCH] stmmac: Add device-tree support

2012-03-27 Thread Giuseppe CAVALLARO
On 3/14/2012 5:26 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 12:38 Wed 14 Mar , Giuseppe CAVALLARO wrote: On 3/12/2012 3:38 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 15:05 Mon 12 Mar , Stefan Roese wrote: This patch adds support to configure the STMMAC ethernet driver via

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread viresh kumar
On Wed, Mar 21, 2012 at 6:06 PM, Arnd Bergmann a...@arndb.de wrote: Let's make sure we're on the same page with the process though. I hope you're aware that I took Stefan's spear6xx v5 patch. Ya. I already know that. :) Just let me know how you want to handle these things in the future --

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread viresh kumar
On Wed, Mar 21, 2012 at 7:34 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 21 March 2012, viresh kumar wrote: - Pinmux: I would remove our padmux and use pinmux, but what about its DT support.   I know stephen had few patches for it, but don't know there progress. I don't want to   do

RE: kirkwood devicetree respin

2012-03-27 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Wednesday, March 21, 2012 6:23 AM On Wed, Mar 21, 2012 at 01:17:38PM +, Arnd Bergmann wrote: On Wednesday 21 March 2012, Felipe Balbi wrote: I have explained an easy way

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread viresh kumar
On Wed, Mar 21, 2012 at 11:56 PM, Arnd Bergmann a...@arndb.de wrote: I just noticed that you have git trees on http://git.stlinux.com/, which I would personally prefer you to use actually. git.kernel.org is most useful for people that don't have their own git servers. Ah, that's even better

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread viresh kumar
On Mar 22, 2012 1:40 PM, Arnd Bergmann a...@arndb.de wrote: Don't hesitate to ask if you have further process questions, I know this can be confusing and we're doing things much stricter than other maintainters in order to keep up with ~600 patches per merge window. Everything is clear.

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread viresh kumar
On Mar 21, 2012 6:09 PM, Arnd Bergmann a...@arndb.de wrote: Regarding the spear3xx patches, I'm looking forward to your patches. I think spear is simple and clean enough that it can serve as an example for others doing DT conversion. Hi Arnd, I was doing DT stuff for 3xx and have a doubt

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread viresh kumar
On Mar 22, 2012 7:50 PM, Arnd Bergmann a...@arndb.de wrote: The direct replacement is of_machine_is_compatible(), but there are a lot of cases where it's better to have a local property in the device node that a driver is using. Thanks. ___

RE: kirkwood devicetree respin

2012-03-27 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, March 22, 2012 1:13 AM On Wed, Mar 21, 2012 at 08:06:12PM +, Paul Zimmerman wrote: From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Wednesday, March 21, 2012

Re: [PATCH 1/4] mmc: atmel-mci: add device tree support

2012-03-27 Thread Ludovic Desroches
On Thu, Mar 22, 2012 at 03:50:48PM +0100, Nicolas Ferre wrote: On 03/21/2012 07:03 PM, ludovic.desroc...@atmel.com : [...] diff --git a/Documentation/devicetree/bindings/mmc/atmel-hsmci.txt b/Documentation/devicetree/bindings/mmc/atmel-hsmci.txt new file mode 100644 index

Re: [PATCH 2/2] ARM: GIC: Create common infrastructure for GIC DT bindings

2012-03-27 Thread Lee Jones
On Fri, Mar 23, 2012 at 7:49 AM, Viresh Kumar viresh.ku...@st.com wrote: Few platforms define there own struct of_device_id[] for GIC. They don't do anything specific in init_irq() other than of_irq_init(). This patch creates this struct array in gic.c and make other platforms use it.

Re: [git pull] PCI changes (including maintainer change)

2012-03-27 Thread Yinghai Lu
On Thu, Mar 22, 2012 at 2:48 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: The following changes since commit 4f262acfde22b63498b5e4f165e53d3bb4e96400:  Merge branch 'fixes' of git://git.linaro.org/people/rmk/linux-arm (2012-03-07 08:33:03 -0800) are available in the git repository at:

Re: [git pull] PCI changes (including maintainer change)

2012-03-27 Thread Yinghai Lu
On Fri, Mar 23, 2012 at 2:10 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Mar 23, 2012 at 12:58 PM, Yinghai Lu ying...@kernel.org wrote: There are some merge conflicts. Hope attached patch could help Linus a little bit. Hmm. My merge does not agree with yours at all in the

Re: [PATCH] mtd: spear-smi: Update compatible property

2012-03-27 Thread viresh kumar
On Fri, Mar 23, 2012 at 7:40 PM, Rob Herring robherri...@gmail.com wrote: On 03/23/2012 03:48 AM, Viresh Kumar wrote: SPEAr SMI controller version is same for all SPEAr machines. Thus we don't need per machine compatible property in driver. Until the next chip... Sorry couldn't get you

Re: [PATCH 1/2] ARM: VIC: Create common infrastructure for vic DT bindings

2012-03-27 Thread viresh kumar
On Fri, Mar 23, 2012 at 6:10 PM, Rob Herring robherri...@gmail.com wrote: NAK None of these platforms have gpio interrupts or any other board interrupt controllers which need to be initialized early? Atleast SPEAr600 have GPIO interrupts. I don't think DT conversions are complete enough to

Re: [PATCH v4 1/2] mfd: add irq domain support for max8997 interrupts

2012-03-27 Thread MyungJoo Ham
On Sat, Mar 24, 2012 at 6:49 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Add irq domain support for max8997 interrupts. The reverse mapping method used is linear mapping since the sub-drivers of max8997 such as regulator and charger drivers can use the max8997 irq_domain to get the

Re: [PATCH 2/2] Input: spear-keyboard: add device tree bindings

2012-03-27 Thread viresh kumar
On Mar 26, 2012 9:00 PM, Stephen Warren swar...@wwwdotorg.org wrote: +- compatible: st,spear-kbd Should spear include some version number so that there's a clear path if/when future SoCs need a different binding? Ya. I will name it spear300-kbd. +- mode: keyboard mode: 0 - 9x9, 1 - 6x6,

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread viresh kumar
On Mar 27, 2012 7:07 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 27 March 2012, Viresh Kumar wrote: On 3/27/2012 4:45 PM, Arnd Bergmann wrote: On Tuesday 27 March 2012, Viresh Kumar wrote: The normal way is to turn around the logic so you don't have to include this test at all.

RE: kirkwood devicetree respin

2012-03-27 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, March 27, 2012 2:05 AM Hi, On Thu, Mar 22, 2012 at 06:28:26PM +, Paul Zimmerman wrote: context, toggle clocks, set pads in safe mode (when needed) and so on. But fair enough, both ways would work fine. I

Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards

2012-03-27 Thread Viresh Kumar
On 3/27/2012 7:29 PM, Arnd Bergmann wrote: That would be even better. I think we should generally try do initialization as late as possible, ideally from initcalls. The init_early() function should only be used for code that absolutely has to be run from setup_arch() and no later, while the

Re: [PATCH v2 1/1] ARM: imx28: add basic dt support

2012-03-27 Thread Shawn Guo
On Fri, Mar 23, 2012 at 10:31:10PM +0800, Dong Aisheng wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng dong.aish...@linaro.org --- ChangeLog v1-v2: * Some fixes addressed Rob's review