[patch] hwmon/max6697: fix memset size in max6697_init_chip()

sizeof(p) was intended instead of sizeof(data). data is a pointer and p is a 7 character struct. It probably doesn't make a difference most of the time, but it could result in using uninitialized data. Signed-off-by: Dan Carpenter diff --git a/drivers/hwmon/max6697.c b/drivers/hwmon/max6697.c

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

On Mon, Jan 14, 2013 at 10:24:11PM +, Arnd Bergmann wrote: > On Monday 14 January 2013, Thierry Reding wrote: > > It certainly sounds like a less complicated way to do it. But it also > > involves adding a function with a made up name and drop a function with > > a perfectly good name instead.

Re: [PATCH v4 1/5] mmc: dw_mmc: Add "disable-wp" device tree property

On Fri, Jan 11, 2013 at 09:03:50AM -0800, Doug Anderson wrote: > The "disable-wp" property is used to specify that a given SD card slot > doesn't have a concept of write protect. This eliminates the need for > special case code for SD slots that should never be write protected > (like a micro SD s

[PATCH v2 4/4] usb: chipidea: imx: Add system suspend/resume API

During the system suspend/resume procedure, the USB also needs to go suspend/resume procedure, this patch adds related APIs. It is tested at i.mx6q sabrelite. Meanwhile, it fixes the bug that the USB will out of work after system suspend/resume. Signed-off-by: Peter Chen --- drivers/usb/chipidea

[PATCH v2 3/4] usb: mxs-phy: add set_suspend API

It needs to call set_suspend during USB suspend/resume Signed-off-by: Peter Chen --- drivers/usb/otg/mxs-phy.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c index 49727dd..cad16e5 100644 --- a/dr

[PATCH v2 2/4] usb: mxs-phy: change clock usage for i.mx6q

For mxs-phy user i.mx6q, the PHY's clock is controlled by hardware automatically, the software only needs to enable it at probe, disable it at remove. But other mxs-phy users need to control that clock runtime, so we hardcode clk on/off, and give a reserved bit for clk on/off at clk code for i.mx6q

[PATCH v2 1/4] ARM i.MX6: use reserved bit for mxs phy clock gate

For mxs-phy user i.mx6q, the PHY's clock is controlled by hardware automatically, the software only needs to enable it at probe, disable it at remove. During the runtime, we don't need to control it. So for the usbphy clk policy: - Keep refcount for usbphy as clk framework needs to know if it is o

[PATCH v7] usb: phy: samsung: Add support to set pmu isolation

Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam Reviewed-by: Sylwester Nawrocki Reviewed-by: Doug Anderson --- Changes from v6: - Returning error code in samsung_usbphy_parse_dt() when 'usbphy-sys' s

Re: [PATCH v2] hwmon: Driver for Maxim MAX6697 and compatibles

On Mon, Jan 14, 2013 at 10:24:04PM +0100, Jean Delvare wrote: > Hi Guenter, > > Sorry for the late review, originally I planned to do a quick review > but apparently I am simply unable to do that. So here comes a complete > review. As usual, pick what you agree with and feel free to ignore the > r

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

Hi Doug, On Tue, Jan 15, 2013 at 3:41 AM, Doug Anderson wrote: > Vivek, > > Sorry for being so absent from these reviews. I'll try to look over a > few patches today, but please don't hold up anything on account of my > reviews. I'm definitely a bit of an interested bystander in USB land. > ;

[PATCH] ARM: bcm2835: fix clock node aliasing in device tree

Both clock nodes in the current device tree are named "clock" and hence end up being the same node. Rename the nodes to different names to avoid this. In fact, fixed-clock uses the node name as the clock name, so name the nodes after the clock they represent. Move the clocks into a "clocks" sub-nod

[PATCH V2] i2c: add bcm2835 driver

This implements a very basic I2C host driver for the BCM2835 SoC. Missing features so far are: * 10-bit addressing. * DMA. Signed-off-by: Stephen Warren --- v2: * Implemented clock divider configuration based on desired bus rate. * Make use of module_platform_driver(). * Removed use of devinit.

Re: [PATCH v2 1/8] sh-pfc: Add OF support

On Sat, Jan 12, 2013 at 06:18:54PM +0100, Guennadi Liakhovetski wrote: > Hi Laurent > > On Wed, 9 Jan 2013, Laurent Pinchart wrote: > > > Support device instantiation through the device tree. The compatible > > property is used to select the SoC pinmux information. > > > > Set the gpio_chip devi

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

Vivek, On Mon, Jan 14, 2013 at 12:06 AM, Vivek Gautam wrote: >> Is it fine if we don't use macro for SHIFT, earlier code also doesn't use it. >> Can we just do like this .. >> #define HOST_CTRL0_FSEL_MASK (0x7 << 16) >> #define HOST_CTRL0_FSEL_CLKSEL_50M(0x7 <<

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

On Jan 15, 2013 2:06 AM, "Tony Lindgren" wrote: > > * Ezequiel Garcia [121223 13:49]: > > On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack wrote: > > > + > > > +Example for an AM33xx board: > > > + > > > + gpmc: gpmc@5000 { > > > + compatible = "ti,am3352-gpmc"; > > > +

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

On Monday 14 January 2013, Thierry Reding wrote: > It certainly sounds like a less complicated way to do it. But it also > involves adding a function with a made up name and drop a function with > a perfectly good name instead. I wouldn't even know what name to choose > for the new API. > How abo

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

Vivek, Sorry for being so absent from these reviews. I'll try to look over a few patches today, but please don't hold up anything on account of my reviews. I'm definitely a bit of an interested bystander in USB land. ;) In general things look pretty good here. :) One last comment below... O

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

On Mon, Jan 14, 2013 at 08:16:44AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 14, 2013 at 04:49:59PM +0100, Thierry Reding wrote: > > On Wed, Jan 09, 2013 at 10:23:52AM +0100, Thierry Reding wrote: > > > On Wed, Jan 09, 2013 at 01:19:39AM -0800, Dmitry Torokhov wrote: > > > > On Wed, Jan 09, 20

Re: Early kernel hang with big DTB appended

On Fri, 11 Jan 2013, Sascha Hauer wrote: > On Thu, Jan 03, 2013 at 04:55:00PM +0100, Tomasz Figa wrote: > > Hi, > > > > I'm observing strange behavior when booting 3.8-rc1 and -rc2 with appended > > DTB. The kernel hangs very early when the DTB is bigger than some > > threshold somewhere around

Re: [PATCH v2] hwmon: Driver for Maxim MAX6697 and compatibles

Hi Guenter, Sorry for the late review, originally I planned to do a quick review but apparently I am simply unable to do that. So here comes a complete review. As usual, pick what you agree with and feel free to ignore the rest :) On Sun, 16 Dec 2012 21:33:09 -0800, Guenter Roeck wrote: > Add sup

[GIT PULL] DeviceTree fixes for 3.8

Linus, Please pull these 2 small fixes for DT. The move to common dtb build rules went in through the DT tree, so I'm taking the fixes too. Rob The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20: Linux 3.8-rc3 (2013-01-09 18:59:55 -0800) are available in the git repo

Re: [PATCH] cpsw: Add support to read cpu MAC address

On Fri, 11 Jan 2013 16:15:02 +0100, Michal Bachraty wrote: > Signed-off-by: Michal Bachraty > --- > Documentation/devicetree/bindings/net/cpsw.txt | 10 +- > arch/arm/boot/dts/am33xx.dtsi |5 +- > drivers/net/ethernet/ti/cpsw.c | 121 > ++

Re: [PATCH] documentation: devicetree: Fix typo within Documentation/devicetree

On Mon, 14 Jan 2013 15:14:56 +0900, Masanari Iida wrote: > Correct spelling typos within Documentation/devicetree > > Signed-off-by: Masanari Iida Applied, thanks. g. > --- > Documentation/devicetree/bindings/arm/atmel-aic.txt| 2 +- > Documentation/devicetree/bindings/arm/ex

Re: [PATCH] mmc: add BCM2835 driver

Hi Stephen, On Thu, Jan 03 2013, Stephen Warren wrote: > Add a very simple driver for the BCM2835 SoC, which is used in the > Raspberry Pi board. > > Signed-off-by: Stephen Warren Looks good, thanks -- pushed to mmc-next for 3.9. - Chris. -- Chris Ball One Laptop Per

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

* Ezequiel Garcia [121223 13:49]: > On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack wrote: > > + > > +Example for an AM33xx board: > > + > > + gpmc: gpmc@5000 { > > + compatible = "ti,am3352-gpmc"; > > + ti,hwmods = "gpmc"; > > + reg = <0x5000

Re: [PATCH V7] kbuild: create a rule to run the pre-processor on *.dts files

On 11:43 Wed 02 Jan , Stephen Warren wrote: > From: Stephen Warren > > Create cmd_dtc_cpp to run the C pre-processor on *.dts file before > passing them to dtc for final compilation. This allows the use of #define > and #include within the .dts file. > > Signed-off-by: Stephen Warren Acked-

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

On Mon, Jan 14, 2013 at 04:49:59PM +0100, Thierry Reding wrote: > On Wed, Jan 09, 2013 at 10:23:52AM +0100, Thierry Reding wrote: > > On Wed, Jan 09, 2013 at 01:19:39AM -0800, Dmitry Torokhov wrote: > > > On Wed, Jan 09, 2013 at 08:07:45AM +0100, Thierry Reding wrote: > > > > On Sun, Jan 06, 2013 a

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

On Wed, Jan 09, 2013 at 10:23:52AM +0100, Thierry Reding wrote: > On Wed, Jan 09, 2013 at 01:19:39AM -0800, Dmitry Torokhov wrote: > > On Wed, Jan 09, 2013 at 08:07:45AM +0100, Thierry Reding wrote: > > > On Sun, Jan 06, 2013 at 11:57:48AM -0800, Dmitry Torokhov wrote: > > > > On Sun, Jan 06, 2013

Re: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

On Mon, Jan 14, 2013 at 02:48:41PM +, Mark Rutland wrote: > Hello, > > This all looks good. I just have a couple of comments about the cpus node. > > On Sun, Jan 13, 2013 at 01:10:57AM +, Tomasz Figa wrote: > > This patch adds basic device tree definitions for Samsung S3C64xx SoCs. > > >

Re: [PATCH] OF: Link platform device resources properly.

On 01/03/2013 04:31 PM, Pantelis Antoniou wrote: > The resources of the platform devices created by the OF core were > not properly linked. Make sure that they are, so that we don't get > any crashes when trying to remove the device. > > Signed-off-by: Pantelis Antoniou > --- > drivers/of/device

Re: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

Hello, This all looks good. I just have a couple of comments about the cpus node. On Sun, Jan 13, 2013 at 01:10:57AM +, Tomasz Figa wrote: > This patch adds basic device tree definitions for Samsung S3C64xx SoCs. > > Since all the SoCs in the series are very similar, the files are created >

Re: [PATCH 4/4] mfd: tps65090: remove suspend/resume callbacks

On Fri, Dec 28, 2012 at 02:59:41PM +0530, Laxman Dewangan wrote: > The tps65090 mfd driver implement the suspend/resume callbacks > which just disable and enable irqs in suspend/resume respectively. > > This operation is already done in irq suspend and irq_resume and > hence it is not require to i

Re: [PATCH 2/4] regulator: tps65090: add DT support

On Fri, Dec 28, 2012 at 02:59:39PM +0530, Laxman Dewangan wrote: > Add DT support for TI PMIC tps65090 regulator driver. The DT of this > device have node regulator and all regulator's node of this device is > added under this node. Reviewed-by: Mark Brown Seems sensible for this to go via MFD g

[PATCH v3 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3.c | 349 ++ drivers/usb/phy/samsung-usbph

[PATCH v3 1/2] usb: phy: samsung: Common out the generic stuff

Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file "samsung-usbphy.c". Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Signed-off-by: Vivek Gautam --- drivers/usb/phy/Makefile |2 +- driv

[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

Changes from v2: - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating usb 2.0 phy controller's driver for Samsung's SoCs. - Moving the register definitions and strcuture definitions to common header file 'samsung-usbphy.h' to be used across usb 2.0 and usb 3.0 phy. - Keep

Re: [PATCH 2/2] ARM: tegra: Use DT /cpu node to detect number of CPU core

On Mon, Jan 14, 2013 at 09:49:25AM +, Hiroshi Doyu wrote: > Hi Russell, > > Russell King - ARM Linux wrote @ Mon, 14 Jan 2013 > 10:27:20 +0100: > > > On Mon, Jan 14, 2013 at 09:52:50AM +0200, Hiroshi Doyu wrote: > > > + if (!arm_dt_cpu_map_valid()) > > > + set_cpu_possible(0, true);

[PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam --- Changes from v6: - Changing macro names from 'HOST_CTRL0_FSEL_CLKSEL_XX' to 'FSEL_CLKSEL_XX' since it's being us

Re: [PATCH 0/4] gpio: introduce descriptor-based interface

On Monday 14 January 2013, Alex Courbot wrote: > On 01/10/2013 07:08 PM, Arnd Bergmann wrote: > > I found two that provide the generic gpio interfaces when gpiolib > > is disabled, but use gpiolib otherwise for the same hardware, > > arch/m68k/include/asm/mcfgpio.h and arch/blackfin/include/asm/gpi

Re: [PATCH 1/6] ARM: common: vic: Parse interrupt and resume masks from device tree

Hi Rob, 2013/1/14 Rob Herring : > On 01/12/2013 07:10 PM, Tomasz Figa wrote: >> This patch extends vic_of_init to parse valid interrupt sources >> and resume sources masks from device tree. >> >> If mask values are not specified in device tree, all sources >> are assumed to be valid, as before thi

Re: [PATCH 4/4] ARM: tegra: Set SCU base address dynamically from DT

Rob Herring wrote @ Mon, 17 Dec 2012 15:00:46 +0100: > On 12/17/2012 12:18 AM, Hiroshi Doyu wrote: > > Set Snoop Control Unit(SCU) register base address dynamically from DT. > > > > Signed-off-by: Hiroshi Doyu > > --- > > arch/arm/mach-tegra/platsmp.c | 23 --- > > 1 file

Re: [PATCH 0/4] gpio: introduce descriptor-based interface

On 01/10/2013 07:08 PM, Arnd Bergmann wrote: I've tried to find platforms that don't yet use GPIOLIB and fortunately there are very few left: I found two that provide the generic gpio interfaces when gpiolib is disabled, but use gpiolib otherwise for the same hardware, arch/m68k/include/asm/mcfg

Re: PMU node location

On Mon, Jan 14, 2013 at 09:36:10AM +, Michal Simek wrote: > 2013/1/14 Mark Rutland : > > On Sat, Jan 12, 2013 at 03:54:42PM +, Rob Herring wrote: > >> On 01/10/2013 07:47 AM, Michal Simek wrote: > >> > Hi Rob, Mark, Grant and others, > >> > > >> > I want to check with you the location of AR

Re: [PATCH 02/11] ARM: nomadik: initial devicetree support

On Mon, Jan 14, 2013 at 07:02:06AM +, Linus Walleij wrote: > On Fri, Jan 11, 2013 at 6:57 PM, Mark Rutland wrote: > > On Fri, Jan 11, 2013 at 05:04:11PM +, Grant Likely wrote: > >> On Tue, 8 Jan 2013 09:57:29 +, Mark Rutland > >> wrote: > >> > > >> > Maybe I've misunderstood how this

Re: [PATCH 10/14] PCI: tegra: Move PCIe driver to drivers/pci/host

On Sun, Jan 13, 2013 at 09:58:06AM +, Thierry Reding wrote: > On Sat, Jan 12, 2013 at 09:12:25PM +, Arnd Bergmann wrote: > > On Saturday 12 January 2013, Thierry Reding wrote: > > > > I already hinted at that in one of the other subthreads. Having such a > > > > multiplex would also allow t

Re: [PATCH 2/2] ARM: tegra: Use DT /cpu node to detect number of CPU core

Hi Russell, Russell King - ARM Linux wrote @ Mon, 14 Jan 2013 10:27:20 +0100: > On Mon, Jan 14, 2013 at 09:52:50AM +0200, Hiroshi Doyu wrote: > > + if (!arm_dt_cpu_map_valid()) > > + set_cpu_possible(0, true); > > You don't need to do any of this (and, therefore, I don't think you

Re: PMU node location

2013/1/14 Mark Rutland : > On Sat, Jan 12, 2013 at 03:54:42PM +, Rob Herring wrote: >> On 01/10/2013 07:47 AM, Michal Simek wrote: >> > Hi Rob, Mark, Grant and others, >> > >> > I want to check with you the location of ARM pmu node >> > I see that >> > 1) highbank and dbx5x0 have it in soc node

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

On Sat, Dec 15, 2012 at 01:06:41AM +, Grant Likely wrote: > On Wed, Dec 12, 2012 at 4:37 PM, Andrew Murray wrote: > > DT bindings for PCI host bridges often use the ranges property to describe > > memory and IO ranges - this binding tends to be the same across > > architectures > > yet severa

Re: [PATCH 2/2] ARM: tegra: Use DT /cpu node to detect number of CPU core

On Mon, Jan 14, 2013 at 09:52:50AM +0200, Hiroshi Doyu wrote: > + if (!arm_dt_cpu_map_valid()) > + set_cpu_possible(0, true); You don't need to do any of this (and, therefore, I don't think you even need the first patch.) The generic boot code will set CPU0 as possible, present an

Re: PMU node location

On Sat, Jan 12, 2013 at 03:54:42PM +, Rob Herring wrote: > On 01/10/2013 07:47 AM, Michal Simek wrote: > > Hi Rob, Mark, Grant and others, > > > > I want to check with you the location of ARM pmu node > > I see that > > 1) highbank and dbx5x0 have it in soc node > > > > 2) vexpress and tegra

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

On Thu, Dec 20, 2012 at 08:25:00AM +, Thierry Reding wrote: > On Wed, Dec 12, 2012 at 04:37:50PM +, Andrew Murray wrote: > [...] > > diff --git a/drivers/of/address.c b/drivers/of/address.c > [...] > > + start = of_get_property(node, "ranges", &rlen); > > + if (start == NULL) > > +

$(make uImage) is stupid [Was: Re: Early kernel hang with big DTB appended]

Hello, unrelated to the original problem ... On Fri, Jan 04, 2013 at 11:18:56AM +0100, Tomasz Figa wrote: > We are using uImages built with same parameters as those used in simple > 'make uImage', just with a DTB appended to zImage before running mkimage > on it. note that the parameters used f

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

Hi Doug, On Mon, Jan 14, 2013 at 11:15 AM, Vivek Gautam wrote: > Hi Doug, > > > On Sat, Jan 12, 2013 at 6:20 AM, Doug Anderson wrote: >> Vivek, >> >> On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam >> wrote: > +#define HOST_CTRL0_REFCLKSEL_MASK (0x3) > +#define HOST_CTRL0_R