Re: [PATCH 1/3] iio: core: implement devm_iio_device_alloc/devm_iio_device_free

2013-07-20 Thread Lars-Peter Clausen
return value ib devm_iio_device_alloc in case if devres_alloc failed, remove unused variable rc] Signed-off-by: Oleksandr Kravchenko o.v.kravche...@globallogic.com Tested-by: Oleksandr Kravchenko o.v.kravche...@globallogic.com Very nice, thanks for taking care of this. Reviewed-by: Lars-Peter Clausen

Re: [PATCH v5 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-18 Thread Lars-Peter Clausen
On 07/18/2013 10:36 AM, Oleksandr Kozaruk wrote: Hello Lars, On Wed, Jul 17, 2013 at 9:04 PM, Lars-Peter Clausen l...@metafoo.de wrote: +static int twl6032_calibration(struct twl6030_gpadc_data *gpadc) +{ + int chn, d1 = 0, d2 = 0, temp; + u8 trim_regs[17]; + int ret

Re: [PATCH v5 1/2] ARM: dts: twl: Add GPADC data to device tree

2013-07-17 Thread Lars-Peter Clausen
On 07/17/2013 04:33 PM, Sergei Shtylyov wrote: Hello. On 17-07-2013 15:12, Oleksandr Kozaruk wrote: GPADC is the general purpose ADC present on twl6030. The dt data is interrupt used to trigger end of ADC conversion. Signed-off-by: Oleksandr Kozaruk oleksandr.koza...@ti.com ---

Re: [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-17 Thread Lars-Peter Clausen
On 07/17/2013 03:45 PM, Oleksandr Kozaruk wrote: On Mon, Jul 15, 2013 at 01:33:53PM +0200, Lars-Peter Clausen wrote: On 07/15/2013 01:09 PM, Kozaruk, Oleksandr wrote: [...] + ret = devm_request_threaded_irq(dev, irq, NULL, + twl6030_gpadc_irq_handler, + IRQF_ONESHOT, twl6030_gpadc

Re: [PATCH v5 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-17 Thread Lars-Peter Clausen
On 07/17/2013 01:12 PM, Oleksandr Kozaruk wrote: The GPADC is general purpose ADC found on TWL6030, and TWL6032 PMIC, known also as Phoenix and PhoenixLite. The TWL6030 and TWL6032 have GPADC with 17 and 19 channels respectively. Some channels have current source and are used for measuring

Re: [PATCH RFC v2 2/5] dma: mpc512x: add support for peripheral transfers

2013-07-16 Thread Lars-Peter Clausen
On 07/14/2013 02:01 PM, Gerhard Sittig wrote: From: Alexander Popov a13xp0p0...@gmail.com introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral

Re: [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-15 Thread Lars-Peter Clausen
On 07/15/2013 01:09 PM, Kozaruk, Oleksandr wrote: [...] + ret = devm_request_threaded_irq(dev, irq, NULL, + twl6030_gpadc_irq_handler, + IRQF_ONESHOT, twl6030_gpadc, gpadc); You access memory in the interrupt

Re: [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-15 Thread Lars-Peter Clausen
. - Lars Regards, -grygorii On 07/12/2013 10:56 PM, Lars-Peter Clausen wrote: A couple of comments inline. On 07/12/2013 09:18 AM, Oleksandr Kozaruk wrote: diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index ab0767e6..87d699e 100644 --- a/drivers/iio/adc/Kconfig +++ b

Re: [PATCH] iio: add APDS9300 ambilent light sensor driver

2013-07-15 Thread Lars-Peter Clausen
On 07/15/2013 02:27 PM, Oleksandr Kravchenko wrote: Thank you for review! But I don't completely understand one of your comment: +static int als_probe(struct i2c_client *client, const struct i2c_device_id *id) [...] + if (client-irq) { + ret =

Re: [PATCH] iio: add APDS9300 ambilent light sensor driver

2013-07-15 Thread Lars-Peter Clausen
On 07/15/2013 04:54 PM, Oleksandr Kravchenko wrote: I can't to find devm_iio_device_alloc() in my kernel v3.11-rc1 It doesn't exist yet, but it should be too hard to implement one. - Lars On Mon, Jul 15, 2013 at 3:35 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 07/15/2013 02:27 PM

Re: [PATCH RFC 5/8] dma: mpc512x: use symbolic specifiers for DMA channels

2013-07-14 Thread Lars-Peter Clausen
On 07/14/2013 10:50 AM, Arnd Bergmann wrote: On Saturday 13 July 2013, Gerhard Sittig wrote: [ MPC8308 knowledge required, see below ] On Sat, Jul 13, 2013 at 09:17 +0200, Arnd Bergmann wrote: On Friday 12 July 2013, Gerhard Sittig wrote: +++ b/include/dt-bindings/dma/mpc512x-dma.h @@ -0,0

Re: [PATCH RFC 1/8] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-07-14 Thread Lars-Peter Clausen
On 07/12/2013 05:26 PM, Gerhard Sittig wrote: [...] ] + if (mchan-tcd_nunits) + tcd-nbytes = mchan-tcd_nunits * 4; + else + tcd-nbytes = 64; Just wondering where does the magic 64 come from?

Re: [PATCH RFC 0/8] MPC512x DMA slave s/g support, OF DMA lookup

2013-07-12 Thread Lars-Peter Clausen
On 07/12/2013 05:26 PM, Gerhard Sittig wrote: [...] Lars, there is a checkpatch warning about a line longer than 80 characters in the common xlate part -- I didn't dare to change your submission, and the part included here is verbatim from your patchwork 2331091 (original submission) and

Re: [PATCH] iio: add APDS9300 ambilent light sensor driver

2013-07-12 Thread Lars-Peter Clausen
On 07/10/2013 03:08 PM, Oleksandr Kravchenko wrote: From: Oleksandr Kravchenko o.v.kravche...@globallogic.com This patch adds IIO driver for APDS9300 ambilent light sensor (ALS). s/ambilent/ambient/ http://www.avagotech.com/docs/AV02-1077EN The driver allows to read raw data from ADC

Re: [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-12 Thread Lars-Peter Clausen
A couple of comments inline. On 07/12/2013 09:18 AM, Oleksandr Kozaruk wrote: diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index ab0767e6..87d699e 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -157,4 +157,12 @@ config VIPERBOARD_ADC Say yes

Re: [alsa-devel] [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-08 Thread Lars-Peter Clausen
On 07/08/2013 03:29 PM, Richard Genoud wrote: [...] +/* + * Logic for a wm8731 as connected on a at91sam9x5 based board. + */ +static int at91sam9x5ek_wm8731_init(struct snd_soc_pcm_runtime *rtd) +{ [...] + codec_dai-driver-playback.rates = SNDRV_PCM_RATE_8000 | +

Re: [PATCH 1/1] Added Capella CM3218 Ambient Light Sensor IIO Driver.

2013-07-04 Thread Lars-Peter Clausen
On 07/04/2013 01:31 AM, Kevin Tsai wrote: Maybe write at least a short commit message which states the features of the chip. Signed-off-by: Kevin Tsai kt...@capellamicro.com --- drivers/staging/iio/light/Kconfig | 10 + drivers/staging/iio/light/Makefile |1 +

Re: [PATCHv3 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-07-04 Thread Lars-Peter Clausen
-by: Lars-Peter Clausen l...@metafoo.de One remark though. Multiline comments should be like /* * foo * bar */ not /* foo * bar */ But not need to resend the patch just for this - Lars ___ devicetree-discuss mailing list devicetree-discuss

Re: [PATCH 4/4] iio: lps331ap: Add support for DT

2013-07-02 Thread Lars-Peter Clausen
On 07/02/2013 02:15 PM, Lukasz Czerwinski wrote: From: Jacek Anaszewski j.anaszew...@samsung.com This patch adds DT support for the lps331ap barometer sensor. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [alsa-devel] [PATCH] ASoC: Add PCM1681 codec driver.

2013-07-01 Thread Lars-Peter Clausen
On 06/26/2013 03:05 PM, Marek Belisko wrote: [...] +static int pcm1681_deemph[] = { 44100, 48000, 32000 }; const + +static int pcm1681_set_deemph(struct snd_soc_codec *codec) +{ + struct pcm1681_private *priv = snd_soc_codec_get_drvdata(codec); + int i = 0, val = -1, ret; + +

Re: [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature

2013-06-28 Thread Lars-Peter Clausen
On 06/27/2013 09:26 PM, Alexandre Belloni wrote: Hi, On 27/06/2013 16:27, Guenter Roeck wrote: On Thu, Jun 27, 2013 at 11:17:32AM +0200, Maxime Ripard wrote: On Wed, Jun 26, 2013 at 07:39:27AM -0700, Guenter Roeck wrote: On Wed, Jun 26, 2013 at 10:51:12AM +0200, Alexandre Belloni wrote:

Re: [PATCH 3/4] hwmon: Add a simple driver to read the MXS SoC temperature

2013-06-28 Thread Lars-Peter Clausen
On 06/28/2013 04:50 PM, Alexandre Belloni wrote: On 28/06/2013 16:18, Lars-Peter Clausen wrote: On 06/27/2013 09:26 PM, Alexandre Belloni wrote: They are already registered as IIO_TEMP but only implement read_raw. Also, iio_hwmon_read_val() is using iio_read_channel_processed

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-24 Thread Lars-Peter Clausen
On 06/20/2013 08:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampling rates. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com ---

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-24 Thread Lars-Peter Clausen
On 06/24/2013 12:37 PM, Alexandre Belloni wrote: On 24/06/2013 08:41, Lars-Peter Clausen wrote: On 06/20/2013 08:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampling rates. Signed-off-by: Alexandre Belloni alexandre.bell

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-23 Thread Lars-Peter Clausen
On 06/22/2013 03:28 PM, Alexandre Belloni wrote: On 22/06/2013 15:20, Lars-Peter Clausen wrote: On 06/22/2013 03:07 PM, Alexandre Belloni wrote: On 22/06/2013 14:02, Lars-Peter Clausen wrote: On 06/22/2013 01:55 PM, Jonathan Cameron wrote: On 06/20/2013 07:57 PM, Alexandre Belloni wrote

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Lars-Peter Clausen
On 06/22/2013 01:55 PM, Jonathan Cameron wrote: On 06/20/2013 07:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampling rates. Sorry, somewhat low on time today so only a quick review. 1) Missing userspace ABI

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Lars-Peter Clausen
On 06/22/2013 03:07 PM, Alexandre Belloni wrote: On 22/06/2013 14:02, Lars-Peter Clausen wrote: On 06/22/2013 01:55 PM, Jonathan Cameron wrote: On 06/20/2013 07:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampling rates

[PATCH v2] ASoC: Add ssm2518 support

2013-05-23 Thread Lars-Peter Clausen
This patch adds a ASoC CODEC driver for the SSM2516. The SSM2516 is a stereo Class-D audio amplifier with an I2S interface for audio in and a built-in dynamic range control processor. Signed-off-by: Lars-Peter Clausen l...@metafoo.de --- Changes since v1: * Power off the codec in the I2C

[PATCH] ASoC: Add ssm2518 support

2013-05-22 Thread Lars-Peter Clausen
This patch adds a ASoC CODEC driver for the SSM2516. The SSM2516 is a stereo Class-D audio amplifier with an I2S interface for audio in and a built-in dynamic range control processor. Signed-off-by: Lars-Peter Clausen l...@metafoo.de --- .../devicetree/bindings/sound/ssm2518.txt | 20

Re: [PATCH] ASoC: Add ssm2518 support

2013-05-22 Thread Lars-Peter Clausen
On 05/22/2013 07:57 PM, Mark Brown wrote: On Wed, May 22, 2013 at 07:00:13PM +0200, Lars-Peter Clausen wrote: This patch adds a ASoC CODEC driver for the SSM2516. The SSM2516 is a stereo Class-D audio amplifier with an I2S interface for audio in and a built-in dynamic range control processor

Re: [PATCH 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-04-20 Thread Lars-Peter Clausen
Hi, Some comments on top of what Jonathan said. On 04/18/2013 05:38 PM, Alexandre Belloni wrote: [...] diff --git a/drivers/iio/adc/nau7802.c b/drivers/iio/adc/nau7802.c new file mode 100644 index 000..0148fd8 --- /dev/null +++ b/drivers/iio/adc/nau7802.c @@ -0,0 +1,644 @@ [...]

Re: [alsa-devel] [PATCH v4 02/10] ASoC: imx-pcm-dma: DT support

2013-04-18 Thread Lars-Peter Clausen
On 04/18/2013 02:33 PM, Markus Pargmann wrote: This patch adds the possibility to pass a of_node as platform_data which is used by generic-pcm-dma to request a DMA slave channel. Signed-off-by: Markus Pargmann m...@pengutronix.de --- sound/soc/fsl/imx-pcm-dma.c | 4 +++- 1 file changed, 3

Re: [PATCH RESEND v5 1/2] dma: imx-dma: Add oftree support

2013-04-18 Thread Lars-Peter Clausen
Hi, On 04/18/2013 03:21 PM, Markus Pargmann wrote: [...] +static struct dma_chan *imxdma_xlate(struct of_phandle_args *dma_spec, + struct of_dma *ofdma) +{ + int count = dma_spec-args_count; + struct imxdma_engine *imxdma =

Re: [PATCH v3 00/15] ASoC: fsl-ssi: ac97-slave support

2013-04-16 Thread Lars-Peter Clausen
On 04/16/2013 02:25 AM, Timur Tabi wrote: Lars-Peter Clausen wrote: @Lars: There are 4 new patches at the beginning of the series that fix some problems of your cleanups. I think they were in the changes you posted. If not, could you please add them to your branch? Hi, I had already

Re: [PATCH] dma: of-dma: check OF pointer property before dereferencing it

2013-04-15 Thread Lars-Peter Clausen
On 04/15/2013 10:39 AM, Paolo Pisati wrote: Signed-off-by: Paolo Pisati paolo.pis...@canonical.com That should already be fixed in the DMA tree. See commit 7362f04c28 (DMA: OF: Check properties value before running be32_to_cpup() on it). - Lars --- drivers/dma/of-dma.c |7 +-- 1

Re: [PATCH v3 00/15] ASoC: fsl-ssi: ac97-slave support

2013-04-14 Thread Lars-Peter Clausen
On 04/14/2013 01:42 PM, Markus Pargmann wrote: Hi, This series adds DT support for phycore-ac97. It is now based on the pcm dma cleanups from Lars. Beside ac97 support, the series adds fsl-ssi imx-pcm-fiq and generic DMA binding handling. @Lars: There are 4 new patches at the beginning

Re: [alsa-devel] [PATCH v2 00/11] ASoC: fsl-ssi: ac97-slave support

2013-04-13 Thread Lars-Peter Clausen
On 04/13/2013 03:32 PM, Markus Pargmann wrote: On Sun, Apr 07, 2013 at 10:35:02PM +0200, Lars-Peter Clausen wrote: On 04/07/2013 10:08 PM, Markus Pargmann wrote: Hi, On Sun, Apr 07, 2013 at 09:39:31PM +0200, Lars-Peter Clausen wrote: On 04/07/2013 09:25 PM, Markus Pargmann wrote: Hi

Re: [PATCH 1/2] dmaengine: mpc512x_dma: use generic DMA DT bindings

2013-04-08 Thread Lars-Peter Clausen
On 03/31/2013 06:17 PM, Anatolij Gustschin wrote: Add generic DMA bindings and register the DMA controller to DT DMA helpers. Signed-off-by: Anatolij Gustschin ag...@denx.de --- arch/powerpc/boot/dts/mpc5121.dtsi |5 ++- drivers/dma/mpc512x_dma.c | 63

Re: [alsa-devel] [PATCH v2 00/11] ASoC: fsl-ssi: ac97-slave support

2013-04-07 Thread Lars-Peter Clausen
On 04/07/2013 09:25 PM, Markus Pargmann wrote: Hi, This series adds DT support for phycore-ac97 using the fsl-ssi driver. In version 2 I discarded most of the imx-ssi work and integrated the ac97-slave support in fsl-ssi, including support for imx-pcm-fiq as alternative to dma. There are

Re: [alsa-devel] [PATCH v2 00/11] ASoC: fsl-ssi: ac97-slave support

2013-04-07 Thread Lars-Peter Clausen
On 04/07/2013 10:08 PM, Markus Pargmann wrote: Hi, On Sun, Apr 07, 2013 at 09:39:31PM +0200, Lars-Peter Clausen wrote: On 04/07/2013 09:25 PM, Markus Pargmann wrote: Hi, This series adds DT support for phycore-ac97 using the fsl-ssi driver. In version 2 I discarded most of the imx-ssi

Re: [PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc

2013-03-27 Thread Lars-Peter Clausen
On 03/27/2013 07:35 PM, Naveen Krishna Ch wrote: On 13 March 2013 13:39, Doug Anderson diand...@chromium.org wrote: The exynos ADC won't work without a regulator called vdd and a clock called adc. Document this fact in the device tree bindings. Signed-off-by: Doug Anderson

Re: RFC v2: Zynq Clock Controller

2013-03-25 Thread Lars-Peter Clausen
On 03/25/2013 06:08 PM, Sören Brinkmann wrote: Hi Lars, On Mon, Mar 25, 2013 at 03:46:35PM +0100, Lars-Peter Clausen wrote: Hi, On 03/22/2013 11:41 PM, Sören Brinkmann wrote: Hi Lars, On Thu, Mar 21, 2013 at 07:32:52PM +0100, Lars-Peter Clausen wrote: On 03/21/2013 12:56 AM, Sören

Re: RFC v2: Zynq Clock Controller

2013-03-25 Thread Lars-Peter Clausen
On 03/25/2013 06:59 PM, Sören Brinkmann wrote: Hi, On Mon, Mar 25, 2013 at 06:19:11PM +0100, Lars-Peter Clausen wrote: On 03/25/2013 06:08 PM, Sören Brinkmann wrote: Hi Lars, On Mon, Mar 25, 2013 at 03:46:35PM +0100, Lars-Peter Clausen wrote: Hi, On 03/22/2013 11:41 PM, Sören Brinkmann

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-23 Thread Lars-Peter Clausen
On 03/21/2013 10:32 PM, Sebastian Hesselbarth wrote: + +dev_info(client-dev, registered si5351 i2c client\n); + That's just noise, imagine every driver would print such a line, your bootlog would be scrolling for hours ;) I'd either remove it or make it dev_dbg Actually, I understand

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-21 Thread Lars-Peter Clausen
On 03/18/2013 11:43 AM, Sebastian Hesselbarth wrote: This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators. Currently, the driver supports DT kernels only and VXCO feature of si5351b is not implemented. DT bindings selectively allow to overwrite

Re: RFC v2: Zynq Clock Controller

2013-03-21 Thread Lars-Peter Clausen
On 03/21/2013 12:56 AM, Sören Brinkmann wrote: Hi, I spent some time working on this and incorporating feedback. Here's an updated proposal for a clock controller for Zynq: Required properties: - #clock-cells : Must be 1 - compatible : xlnx,ps7-clkc (this may become 'xlnx,zynq-clkc'

Re: RFC: Zynq Clock Controller

2013-03-08 Thread Lars-Peter Clausen
On 03/08/2013 06:38 PM, Sören Brinkmann wrote: On Fri, Mar 08, 2013 at 08:12:20AM +0100, Lars-Peter Clausen wrote: On 03/08/2013 12:25 AM, Sören Brinkmann wrote: On Thu, Mar 07, 2013 at 11:02:58PM +0100, Lars-Peter Clausen wrote: On 03/07/2013 08:11 PM, Sören Brinkmann wrote: On Thu, Mar 07

Re: RFC: Zynq Clock Controller

2013-03-07 Thread Lars-Peter Clausen
On 03/06/2013 06:27 PM, Sören Brinkmann wrote: Hi Jan, what a small world. Good to hear from you. On Wed, Mar 06, 2013 at 12:51:21PM +0100, Jan Lübbe wrote: Hi Sören, On Tue, 2013-03-05 at 12:04 -0800, Sören Brinkmann wrote: For this reasons, I'd like to propose moving Zynq into the

Re: RFC: Zynq Clock Controller

2013-03-07 Thread Lars-Peter Clausen
On 03/07/2013 08:11 PM, Sören Brinkmann wrote: On Thu, Mar 07, 2013 at 10:36:35AM +0100, Lars-Peter Clausen wrote: On 03/06/2013 06:27 PM, Sören Brinkmann wrote: Hi Jan, what a small world. Good to hear from you. On Wed, Mar 06, 2013 at 12:51:21PM +0100, Jan Lübbe wrote: Hi Sören

Re: RFC: Zynq Clock Controller

2013-03-07 Thread Lars-Peter Clausen
On 03/08/2013 12:25 AM, Sören Brinkmann wrote: On Thu, Mar 07, 2013 at 11:02:58PM +0100, Lars-Peter Clausen wrote: On 03/07/2013 08:11 PM, Sören Brinkmann wrote: On Thu, Mar 07, 2013 at 10:36:35AM +0100, Lars-Peter Clausen wrote: On 03/06/2013 06:27 PM, Sören Brinkmann wrote: Hi Jan, what

Re: [PATCH 1/5 v7][RFC] ASoC: add snd_soc_register_cpu()

2013-03-01 Thread Lars-Peter Clausen
On 02/28/2013 08:14 PM, Stephen Warren wrote: On 02/27/2013 05:42 PM, Kuninori Morimoto wrote: Hi Stephen On 02/25/2013 01:51 AM, Kuninori Morimoto wrote: Current ASoC has register function for platform/codec/dai/card, but doesn't have for cpu. It often produces confusion and fault on

Re: [PATCH v5] iio: Add OF support

2013-02-25 Thread Lars-Peter Clausen
merge window so I will pick it up for start of next cycle and assume silence means everyone else is happy! The latest version looked good to me, you can add my: Reviewed-by: Lars-Peter Clausen l...@metafoo.de ___ devicetree-discuss mailing list devicetree

Re: [alsa-devel] [PATCH 3/4 v6] ASoC: fsi: enable .of_xlate_dai_name on struct snd_soc_dai_driver

2013-02-20 Thread Lars-Peter Clausen
On 02/20/2013 02:04 AM, Kuninori Morimoto wrote: Hi Stephen Hmm. I think that the .of_xlate_dai_name should be something related to the object (e.g. CODEC) that contains the DAIs, rather than the DAIs themselves. The intent is to ask some object (e.g. CODEC) which of its DAIs is

Re: [alsa-devel] [PATCH 4/4 v6] ASoC: simple-card: add Device Tree support

2013-02-20 Thread Lars-Peter Clausen
On 02/20/2013 01:48 AM, Kuninori Morimoto wrote: Hi Lars Thank you for checking patch +- simple-audio,dev : phandle and port for CPU/CODEC +- simple-audio,frame-master: frame master +- simple-audio,bitclock-master : bitclock master

Re: [alsa-devel] [PATCH 1/4 v6] ASoC: add .of_xlate_dai_name callback on struct snd_soc_dai_driver

2013-02-19 Thread Lars-Peter Clausen
On 02/14/2013 10:21 AM, Kuninori Morimoto wrote: [...] +const char *snd_soc_of_get_port_dai_name(struct device_node *of_node, + const char *prop) +{ + struct snd_soc_dai *dai; + struct of_phandle_args args; + const char *name; + int ret;

Re: [alsa-devel] [PATCH 4/4 v6] ASoC: simple-card: add Device Tree support

2013-02-19 Thread Lars-Peter Clausen
On 02/14/2013 10:24 AM, Kuninori Morimoto wrote: Support for loading the simple-card module via devicetree. It requests cpu/codec information, and .of_xlate_dai_name support on each driver for probing. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v5 - v6 -

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Lars-Peter Clausen
On 02/04/2013 06:12 PM, Guenter Roeck wrote: On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
@@ +This binding is a work-in-progress. It is derived from clock bindings, +and based on suggestions from Lars-Peter Clausen [1]. + +Sources of IIO channels can be represented by any node in the device +tree. Those nodes are designated as IIO providers. IIO consumer +nodes use a phandle and IIO

Re: [RFC 10/11] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
-in-progress, and are based on clock bindings and +suggestions from Lars-Peter Clausen [1]. + +Sources of IIO channels can be represented by any node in the device +tree. Those nodes are designated as IIO providers. IIO consumer +nodes use a phandle and IIO specifier pair to connect IIO provider

Re: [RFC 10/11] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 12:47 PM, Lars-Peter Clausen wrote: On 02/03/2013 12:39 PM, Jonathan Cameron wrote: On 02/02/2013 04:10 PM, Guenter Roeck wrote: On Sat, Feb 02, 2013 at 10:29:02AM +, Jonathan Cameron wrote: On 01/31/2013 09:43 PM, Guenter Roeck wrote: Provide bindings, new API access

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 12:52 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59:40

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
bindings, +and based on suggestions from Lars-Peter Clausen [1]. + +Sources of IIO channels can be represented by any node in the device +tree. Those nodes are designated as IIO providers. IIO consumer +nodes use a phandle and IIO specifier pair to connect IIO provider +outputs to IIO inputs

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 05:31 PM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:29:23PM +0100, Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 09:58 PM, Jonathan Cameron wrote: On 02/03/2013 06:55 PM, Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013

Re: [RFC 10/11] iio: Add OF support

2013-02-02 Thread Lars-Peter Clausen
On 02/01/2013 08:42 PM, Guenter Roeck wrote: On Fri, Feb 01, 2013 at 03:59:17PM +0100, Lars-Peter Clausen wrote: On 02/01/2013 03:33 PM, Guenter Roeck wrote: On Fri, Feb 01, 2013 at 12:58:02PM +0100, Lars-Peter Clausen wrote: 013 10:43 PM, Guenter Roeck wrote: Provide bindings, new API access

Re: [RFC 10/11] iio: Add OF support

2013-02-01 Thread Lars-Peter Clausen
@@ +This binding is a work-in-progress, and are based on clock bindings and +suggestions from Lars-Peter Clausen [1]. + +Sources of IIO channels can be represented by any node in the device +tree. Those nodes are designated as IIO providers. IIO consumer +nodes use a phandle and IIO specifier pair

Re: [RFC 10/11] iio: Add OF support

2013-02-01 Thread Lars-Peter Clausen
On 02/01/2013 03:33 PM, Guenter Roeck wrote: On Fri, Feb 01, 2013 at 12:58:02PM +0100, Lars-Peter Clausen wrote: 013 10:43 PM, Guenter Roeck wrote: Provide bindings, new API access functions, and parse OF data during initialization. Hi Guenter, Thanks for taking care of this. I'd prefer

Re: [PATCH v3 4/8] MFD: ti_am335x_tscadc: add device tree binding information

2013-01-19 Thread Lars-Peter Clausen
Hi, On 01/18/2013 11:48 AM, Patil, Rachna wrote: From: Patil, Rachna rac...@ti.com Signed-off-by: Patil, Rachna rac...@ti.com --- .../devicetree/bindings/mfd/ti_am335x_tscadc.txt | 35 1 file changed, 35 insertions(+) create mode 100644

[PATCH resend] spi: Add support for specifying 3-wire mode via device tree

2012-12-06 Thread Lars-Peter Clausen
This patch allows to specify that a SPI device is connected in 3-wire mode via device tree. Signed-off-by: Lars-Peter Clausen l...@metafoo.de Acked-by: Rob Herring rob.herr...@calxeda.com --- Documentation/devicetree/bindings/spi/spi-bus.txt | 2 ++ drivers/spi/spi.c

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-28 Thread Lars-Peter Clausen
On 11/28/2012 09:54 AM, Peter Ujfalusi wrote: Hi Grant, Lars, Thierry, On 11/26/2012 04:46 PM, Grant Likely wrote: You're effectively asking the pwm layer to behave like a gpio (which is completely reasonable). Having a completely separate translation node really doesn't make sense because

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-26 Thread Lars-Peter Clausen
On 11/23/2012 10:44 AM, Peter Ujfalusi wrote: Hi Grant, On 11/23/2012 10:13 AM, Peter Ujfalusi wrote: Hi Grant, On 11/23/2012 08:55 AM, Grant Likely wrote: Ugh. and this is why I wanted the PWM and GPIO subsystems to use the same namespace and binding. grumble, mutter But that's not your

Re: Querry on IIO/ADC DT based consumer device probe

2012-11-09 Thread Lars-Peter Clausen
On 11/08/2012 05:53 PM, Alban Bedel wrote: On Fri, 5 Oct 2012 14:37:01 +0530 Naveen Krishna Ch naveenkrishna...@gmail.com wrote: Hello All, I'm trying to add an ADC driver under IIO/ADC. Machine is DT based so, passing the ADC device as tree node and consumer devices (thermistors) as

Re: [PATCH 7/8] serial: xilinx_uartps: get clock rate info from dts

2012-11-02 Thread Lars-Peter Clausen
On 10/31/2012 08:28 PM, Josh Cartwright wrote: Add support for specifying clock information for the uart clk via the device tree. This eliminates the need to hardcode rates in the device tree. Signed-off-by: Josh Cartwright josh.cartwri...@ni.com --- arch/arm/boot/dts/zynq-7000.dtsi |

Re: [PATCH 5/8] ARM: zynq: add COMMON_CLK support

2012-11-02 Thread Lars-Peter Clausen
On 10/31/2012 07:58 PM, Josh Cartwright wrote: [...] +#define PERIPH_CLK_CTRL_SRC(x) (periph_clk_parent_map[((x)3)4]) +#define PERIPH_CLK_CTRL_DIV(x) (((x)0x3F00)8) A few more spaces wouldn't hurt ;) [...] +static void __init zynq_periph_clk_setup(struct device_node *np) +{ +

Re: [PATCH 5/8] ARM: zynq: add COMMON_CLK support

2012-11-02 Thread Lars-Peter Clausen
On 11/02/2012 02:38 PM, Josh Cartwright wrote: Thanks for the review. On Fri, Nov 02, 2012 at 10:33:44AM +0100, Lars-Peter Clausen wrote: On 10/31/2012 07:58 PM, Josh Cartwright wrote: [...] +#define PERIPH_CLK_CTRL_SRC(x) (periph_clk_parent_map[((x)3)4]) +#define PERIPH_CLK_CTRL_DIV(x

Re: [PATCH] input: pwm-beeper: Add devicetree probing support

2012-09-24 Thread Lars-Peter Clausen
On 09/24/2012 05:56 PM, Dmitry Torokhov wrote: On Mon, Sep 24, 2012 at 07:55:38AM -0500, Rob Herring wrote: On 09/24/2012 02:37 AM, Sascha Hauer wrote: A very simple binding, the only property is the phandle to the PWM. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Acked-by: Rob

Re: [PATCH] input: pwm-beeper: Add devicetree probing support

2012-09-24 Thread Lars-Peter Clausen
On 09/24/2012 08:49 PM, Sascha Hauer wrote: On Mon, Sep 24, 2012 at 06:22:33PM +0200, Lars-Peter Clausen wrote: On 09/24/2012 05:56 PM, Dmitry Torokhov wrote: On Mon, Sep 24, 2012 at 07:55:38AM -0500, Rob Herring wrote: On 09/24/2012 02:37 AM, Sascha Hauer wrote: A very simple binding

[PATCH] spi: Add support for specifing 3-wire mode via device tree

2012-07-13 Thread Lars-Peter Clausen
This patch allows to specify that a SPI device is connected in 3-wire mode via the device tree. Signed-off-by: Lars-Peter Clausen l...@metafoo.de --- Documentation/devicetree/bindings/spi/spi-bus.txt |2 ++ drivers/spi/spi.c |2 ++ 2 files changed, 4

Re: [PATCH] I2C: xiic: Add OF binding support

2012-05-03 Thread Lars-Peter Clausen
On 05/03/2012 01:10 PM, Wolfram Sang wrote: On Wed, Apr 25, 2012 at 03:48:53PM +0200, Lars-Peter Clausen wrote: Signed-off-by: Lars-Peter Clausen l...@metafoo.de Applied to next, thanks. How are your experiences with the driver? Does it still need EXPERIMENTAL? I had some issues under

[PATCH] I2C: xiic: Add OF binding support

2012-04-25 Thread Lars-Peter Clausen
Signed-off-by: Lars-Peter Clausen l...@metafoo.de --- Documentation/devicetree/bindings/i2c/xiic.txt | 22 ++ drivers/i2c/busses/i2c-xiic.c | 23 ++- 2 files changed, 40 insertions(+), 5 deletions(-) create mode 100644 Documentation

Re: [PATCH v3 0/2] i2c/of: Populate multiplexed i2c busses from the device tree.

2012-04-13 Thread Lars-Peter Clausen
On 04/12/2012 11:14 PM, David Daney wrote: From: David Daney david.da...@cavium.com v3: Integrate changes from Lars-Peter Clausen to make better use of the of_*() infrastructure. Get rid of ugly #ifdefs. v2: Update bindings to use reg insutead of cell-index v1: Unchanged from

Re: [PATCH v2 02/10] pwm: Allow chips to support multiple PWMs.

2012-02-16 Thread Lars-Peter Clausen
On 02/06/2012 04:19 PM, Thierry Reding wrote: This commit modifies the PWM core to support multiple PWMs per struct pwm_chip. I think you should mention what motivates this change. It achieves this in a similar way to how gpiolib works, by allowing PWM ranges to be requested dynamically